View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004572CMakeCMakepublic2007-03-12 13:252008-01-10 17:02
ReporterSean McBride 
Assigned ToDavid Cole 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0004572: Tk and Tcl frameworks references with incorrect case
DescriptionLooking at my dashboard machines, I see the following in CMakeCache.txt:

//Path to a file.
TK_INCLUDE_PATH:PATH=/System/Library/Frameworks/Tk.framework/Headers
TK_LIBRARY:FILEPATH=/System/Library/Frameworks/tk.framework
TCL_INCLUDE_PATH:PATH=/System/Library/Frameworks/Tcl.framework/Headers
TCL_LIBRARY:FILEPATH=/System/Library/Frameworks/tcl.framework

Notice the difference in case: Tk vs tk, and tcl vs Tcl.

I believe this would prevent things from working properly on case-sensitive file systems, but by default Macs are formatted with case-insensitive (but case-preserving) file systems.
TagsNo tags attached.
Attached Filespatch file icon CMakeBug4572.patch [^] (474 bytes) 1969-12-31 19:00 [Show Content]

 Relationships
related to 0008563closedBill Hoffman CMake sometimes uses/detects wrong case in file paths 

  Notes
(0006800)
Sean McBride (reporter)
2007-03-15 11:52

 CMake/Tests/BundleTest/CMakeLists.txt

has:

    AND EXISTS /System/Library/Frameworks/tcl.framework)

and

  AND EXISTS /System/Library/Frameworks/tcl.framework)

which should both be "Tcl.framework"

There may be other places that need fixing too. I don't see tk.framework in the source anywhere for example.
(0007908)
Sean McBride (reporter)
2007-06-19 13:45

 OK, to make this even easier, I am attaching a patch!
(0008623)
Alex Neundorf (developer)
2007-08-23 14:19

 You are currently working on that test, right ?
(0008625)
Sean McBride (reporter)
2007-08-23 14:34

 neundorf, I'm not sure if your comments are addressed to me, but if they are, I'm afraid I do not know what you are talking about. :)

The patch I attached is necessary but insufficient. As I recall, I searched the CMake source for and fixed the case of several instances but never found the "tk" part.
(0008630)
David Cole (manager)
2007-08-23 15:10

 No worries, Sean. I'm pretty sure the comments were addressed to me, the new guy he assigned the bug to..... :-)
(0009693)
Sean McBride (reporter)
2007-11-16 12:20

 It seems this is partly fixed, at least the part from my patch. Thanks.
(0010129)
Alex Neundorf (developer)
2008-01-10 17:02

 Seems to be fixed, and the reporter says that too.

Alex

 Issue History
Date Modified Username Field Change
2007-08-23 14:19 Alex Neundorf Note Added: 0008623
2007-08-23 14:19 Alex Neundorf Assigned To Bill Hoffman => David Cole
2007-08-23 14:34 Sean McBride Note Added: 0008625
2007-08-23 15:10 David Cole Note Added: 0008630
2007-11-16 12:20 Sean McBride Note Added: 0009693
2008-01-10 17:02 Alex Neundorf Note Added: 0010129
2008-01-10 17:02 Alex Neundorf Status assigned => closed
2008-01-10 17:02 Alex Neundorf Resolution open => fixed
2009-02-19 17:27 Bill Hoffman Relationship added related to 0008563

Copyright © 2000 - 2018 MantisBT Team