View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015489

CMake

CMakeSetup

public

2015-04-01 16:15

2015-11-02 09:13

Reporter

Bill Newcomb

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Linux

CentOS

OS Version

5.7

Product Version

CMake 3.2.1

Target Version

CMake 3.3

Fixed in Version

CMake 3.3

Summary

0015489: CMake.ELF test fails when sources are read-only

Description

When the cmake sources are all set to read-only (e.g. after importing into perforce), the CMake.ELF test fails because the copy of the binary is also read-only and cannot be modified.

Steps To Reproduce

./bootstrap
make
make test

Additional Information

Assuming one's umask is sane, the following is a patch:

--- /tmp/tmp.10612.25 2015-04-01 13:13:35.000000000 -0700
+++ /a/cmake-bn/cmake-src/3.2.1/Tests/CMakeTests/ELFTest.cmake.in 2015-04-01 13:12:21.000000000 -0700
@@ -11,7 +11,7 @@
file(REMOVE_RECURSE "${out}")
file(MAKE_DIRECTORY "${out}")
foreach(f ${names})
- file(COPY ${in}/${f} DESTINATION ${out})
+ file(COPY ${in}/${f} DESTINATION ${out} NO_SOURCE_PERMISSIONS)
list(APPEND files "${out}/${f}")
endforeach()

Tags

No tags attached.

Attached Files

Relationships

Notes
(0038387) Brad King (manager) 2015-04-01 16:34	Applied, thanks: Tests: Fix CMake.ELF test with read-only source http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a293dcb5 [^]

(0039756) Robert Maynard (manager) 2015-11-02 09:13	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2015-04-01 16:15	Bill Newcomb	New Issue
2015-04-01 16:34	Brad King	Note Added: 0038387
2015-04-01 16:34	Brad King	Assigned To	=> Brad King
2015-04-01 16:34	Brad King	Status	new => resolved
2015-04-01 16:34	Brad King	Resolution	open => fixed
2015-04-01 16:34	Brad King	Fixed in Version	=> CMake 3.3
2015-04-01 16:34	Brad King	Target Version	=> CMake 3.3
2015-11-02 09:13	Robert Maynard	Note Added: 0039756
2015-11-02 09:13	Robert Maynard	Status	resolved => closed