View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015202

CMake

public

2014-10-10 16:59

2015-04-06 09:07

Reporter

Mark Manthei

Assigned To

David Cole

Priority

normal

Severity

block

Reproducibility

always

Status

closed

Resolution

no change required

Platform

Apple Mac

OS X

OS Version

10.7, 10.8, 10.9

Product Version

CMake 3.0.2

Target Version

Fixed in Version

Summary

0015202: BundleUtilities.cmake - function fixup_bundle_item fails with very long path

Description

when fixing up a very long exe inside of a bundle, the code attempts to figure out if the item is embedded in the bundle. The current logic fails because the SUBSTRING search starts at offset 0 and can fail to find the embedded item in the given length.

From debug output of BundleUtilities.cmake:

-- 22/42: fixing up '/Users/autobuild/hudson/workspace/Product-Mac/build/Installed/Really Long App Name.app/Contents/MacOS/embeddeditem
exe_dotapp_dir/='Installed/Really Long App Name.app/'
item_substring='/Users/autobuild/hudson/workspace/R'

Steps To Reproduce

Use long paths.

Additional Information

Patch to fix issue, CMake version 3.0.2 attached

Tags

No tags attached.

Attached Files

BundleUtilities.patch [^] (586 bytes) 2014-10-10 16:59 [Show Content] [Hide Content]

--- BundleUtilities.cmake.orig	2014-10-10 15:52:51.000000000 -0500
+++ BundleUtilities.cmake	2014-10-10 15:55:04.000000000 -0500
@@ -614,7 +614,8 @@
     set(path_too_short 1)
   endif()
   if(NOT path_too_short)
-    string(SUBSTRING "${resolved_embedded_item}" 0 ${exe_dotapp_dir_length} item_substring)
+    string(FIND "${resolved_embedded_item}" "${exe_dotapp_dir}" suboffset ) 
+    string(SUBSTRING "${resolved_embedded_item}" ${suboffset} ${exe_dotapp_dir_length} item_substring)
     if("${exe_dotapp_dir}/" STREQUAL "${item_substring}")
       set(is_embedded 1)
     endif()

Relationships

Notes
(0037019) David Cole (manager) 2014-10-10 17:16	It looks to me like the value of exe_dotapp_dir should be "/Users/autobuild/hudson/workspace/Product-Mac/build/Installed/Really Long App Name.app/" and the fact that it's not is what your problem is... It should be a full absolute path, not a partial/relative path... This patch should be unnecessary. What are your arguments to fixup_bundle? All dirs should be ABSOLUTE full path directories when passed in as args to the function.

(0037020) David Cole (manager) 2014-10-10 17:17	The point of that code is that the path of the already embedded item starts with the the path of the .app directory. So it doesn't make sense to start the scan at anything other than 0.

(0037021) David Cole (manager) 2014-10-10 17:18	patch is incorrect - do not apply...

(0038422) Robert Maynard (manager) 2015-04-06 09:07	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2014-10-10 16:59	Mark Manthei	New Issue
2014-10-10 16:59	Mark Manthei	File Added: BundleUtilities.patch
2014-10-10 17:16	David Cole	Note Added: 0037019
2014-10-10 17:17	David Cole	Note Added: 0037020
2014-10-10 17:18	David Cole	Note Added: 0037021
2014-10-10 17:18	David Cole	Status	new => resolved
2014-10-10 17:18	David Cole	Resolution	open => no change required
2014-10-10 17:18	David Cole	Assigned To	=> David Cole
2015-04-06 09:07	Robert Maynard	Note Added: 0038422
2015-04-06 09:07	Robert Maynard	Status	resolved => closed