View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015082

CMake

CTest

public

2014-08-13 10:31

2016-06-10 14:31

Reporter

ycollet

Assigned To

Kitware Robot

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

CMake 2.8.12.2

Target Version

Fixed in Version

Summary

0015082: DartMeasurement tags must cover the whole line of a log to be taken into account

Description

When performing tests, I printed the following lines into my log:

This is a test <DartMeasurement name="Measure" type="numeric/double">10.0</DartMeasurement> This is a test

Then, when the test results are submitted to cdash, no measurement appears in the dashboard.
For a custom measurement to be taken into account, you must put the tags at the beginning and at the end of the line:

<DartMeasurement name="Measure" type="numeric/double">10.0</DartMeasurement>

Then, when submitted, I can see my custom measurement in the dashboard.

Additional Information

Here is a patch against cmake-2.8.12.2 to allow a measurement to "live" in the middle of a line.

Tags

No tags attached.

Attached Files

dart_measurement.diff [^] (954 bytes) 2014-08-13 10:31 [Show Content] [Hide Content]

diff --git a/Source/CTest/cmCTestTestHandler.cxx b/Source/CTest/cmCTestTestHandler.cxx
index 497774d..c44d630 100644
--- a/Source/CTest/cmCTestTestHandler.cxx
+++ b/Source/CTest/cmCTestTestHandler.cxx
@@ -410,12 +410,12 @@ cmCTestTestHandler::cmCTestTestHandler()
 
   this->LogFile = 0;
 
-  // regex to detect <DartMeasurement>...</DartMeasurement>
+  // regex to detect ...<DartMeasurement>...</DartMeasurement>...
   this->DartStuff.compile(
-    "(<DartMeasurement.*/DartMeasurement[a-zA-Z]*>)");
-  // regex to detect each individual <DartMeasurement>...</DartMeasurement>
+    "(.*<DartMeasurement.*/DartMeasurement[a-zA-Z]*>.*)");
+  // regex to detect each individual ...<DartMeasurement>...</DartMeasurement>...
   this->DartStuff1.compile(
-    "(<DartMeasurement[^<]*</DartMeasurement[a-zA-Z]*>)");
+    "(.*<DartMeasurement[^<]*</DartMeasurement[a-zA-Z]*>.*)");
 }
 
 //----------------------------------------------------------------------

Relationships

Notes
(0036609) Brad King (manager) 2014-08-13 10:48	Thanks. However, allowing content within a line also opens the possibility of multiple measurements on a single line. The ".*" parts of the expression may consume too much and skip some measurements. It may be safer to re-write the extraction code to do explicit parsing rather than using a regex. Also please read http://cmake.org/gitweb?p=cmake.git;a=blob_plain;f=CONTRIBUTING.rst;hb=master [^]

(0042605) Kitware Robot (administrator) 2016-06-10 14:29	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2014-08-13 10:31	ycollet	New Issue
2014-08-13 10:31	ycollet	File Added: dart_measurement.diff
2014-08-13 10:48	Brad King	Note Added: 0036609
2016-06-10 14:29	Kitware Robot	Note Added: 0042605
2016-06-10 14:29	Kitware Robot	Status	new => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:29	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed