View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014880

CMake

public

2014-04-15 10:39

2015-02-18 03:59

Reporter

raspy

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

x86_64

RedHat Enterprise Linux

OS Version

6.4

Product Version

Target Version

Fixed in Version

Summary

0014880: TI ASM rule should not use --asm_file switch

Description

TI assembler is strange enough to have two different dialects: a regular file (with .asm extension) and a linear file (with .sa extension). Both these dialects use different switches: --asm_file or --ap_file.

If one has a linear assembly file in a project and adds ".sa" as a supported assembler extension, the compiler will choke since the file will be provided with --asm_file switch which is invalid. Changing --asm_file into --ap_file also does not resolve problem, since then regular assembly files do not compile.

I suggest to drop language specification from assembly rules and allow compiler to automatically detect language (unless there is some special support for different ASM dialects in CMake). Therefore replace in TI-ASM.cmake:

set(CMAKE_ASM_COMPILE_OBJECT "<CMAKE_ASM_COMPILER> --compile_only --asm_file=<SOURCE> <DEFINES> <FLAGS> --output_file=<OBJECT>")

With:

set(CMAKE_ASM_COMPILE_OBJECT "<CMAKE_ASM_COMPILER> --compile_only <DEFINES> <FLAGS> --output_file=<OBJECT> <SOURCE>")

It would also be great if .sa extension be handled by default, like so:

Replace:

set(CMAKE_ASM_SOURCE_FILE_EXTENSIONS asm;s;abs)

With:

set(CMAKE_ASM_SOURCE_FILE_EXTENSIONS asm;s;abs;sa)

Steps To Reproduce

Try to add and compile any linear assembly file. These are generated for example by tconf for use with DSPBIOS.

Tags

No tags attached.

Attached Files

Relationships

related to

0014876

closed

Kitware Robot

Improve support for TI compiler

Notes
(0035717) Brad King (manager) 2014-04-15 10:41	STOP SUBMITTING SEPARATE ISSUES. USE 0014876.

(0036977) Robert Maynard (manager) 2014-10-06 10:33	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2014-04-15 10:39	raspy	New Issue
2014-04-15 10:40	Brad King	Relationship added	related to 0014876
2014-04-15 10:41	Brad King	Note Added: 0035717
2014-04-15 10:41	Brad King	Status	new => resolved
2014-04-15 10:41	Brad King	Resolution	open => duplicate
2014-10-06 10:33	Robert Maynard	Note Added: 0036977
2014-10-06 10:33	Robert Maynard	Status	resolved => closed