View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014696

CMake

public

2014-01-14 04:52

2014-06-02 08:38

Reporter

Gerry Boland

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

no change required

Platform

x86_64

Ubuntu linux

OS Version

14.01

Product Version

CMake 2.8.12.1

Target Version

Fixed in Version

Summary

0014696: CMake does not add QT_NO_DEBUG definition for RelWithDebInfo build type

Description

In a Qt5 CMake project with code like the following:

cmake_minimum_required(VERSION 2.8.12)
find_package(Qt5Core REQUIRED)
target_link_libraries(${PROJECT_NAME} Qt5::Core)

Running with "cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo" I see that CMake does not define QT_NO_DEBUG.

I interpreted the distinction between the Debug build type from the RelWithDebInfo type as being that while RelWithDebInfo also does not strip symbols from the generated binaries, it does allow developers to disable debug helpers like run-time asserts or expensive printing statements. So for Qt, setting QT_NO_DEBUG for RelWithDebInfo makes sense.

I'd like to know if my interpretation is correct before proceeding with a fix, something like adding
set_property(TARGET ${_target} APPEND PROPERTY COMPILE_DEFINITIONS_RELWITHDEBINFO QT_NO_DEBUG)
to Qt5CoreMacros.cmake around like 246.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0034933) Brad King (manager) 2014-01-14 09:00	The Qt5 CMake files are provided by Qt, not CMake. This will have to be raised over there.

(0036081) Robert Maynard (manager) 2014-06-02 08:38	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2014-01-14 04:52	Gerry Boland	New Issue
2014-01-14 09:00	Brad King	Note Added: 0034933
2014-01-14 09:00	Brad King	Status	new => resolved
2014-01-14 09:00	Brad King	Resolution	open => no change required
2014-06-02 08:38	Robert Maynard	Note Added: 0036081
2014-06-02 08:38	Robert Maynard	Status	resolved => closed