View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014102 | CMake | CMake | public | 2013-04-21 04:06 | 2013-10-07 10:09 | ||||
Reporter | Marco Nolden | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | major | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake 2.8.10.2 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0014102: CHECK_C_COMPILER_FLAG does not work on non-English locales | ||||||||
Description | The regular expressions that are used in CHECK_C_COMPILER_FLAG only work for an English or C locale. On a German localized system e.g. the gcc warning is not recognized if you pass a C++ option like "-fvisibility-inlines-hidden" to gcc. I think there are two options: 1. add some code to switch the locale before the test, like it is done in CMakeExtraGeneratorDetermineCompilerMacrosAndIncludeDirs.cmake 2. try if -Werror or an equivalent is accepted first and then pass it together with the option that should actually be tested | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 52723722+0001-Check-C-CXX-CompilerFlag-Test-using-C-locale-14102.patch [^] (3,438 bytes) 2013-04-22 08:55 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0032916) Brad King (manager) 2013-04-22 08:55 |
Good catch. Please test 52723722+0001-Check-C-CXX-CompilerFlag-Test-using-C-locale-14102.patch |
(0032945) sascha (reporter) 2013-04-26 02:49 |
Hi, I have tested your patch successfully with gcc 4.7 using a German locale. Thanks! |
(0032964) Brad King (manager) 2013-04-30 09:08 |
Thanks for testing. Applied: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=52723722 [^] |
(0034040) Robert Maynard (manager) 2013-10-07 10:09 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-04-21 04:06 | Marco Nolden | New Issue | |
2013-04-22 08:55 | Brad King | File Added: 52723722+0001-Check-C-CXX-CompilerFlag-Test-using-C-locale-14102.patch | |
2013-04-22 08:55 | Brad King | Note Added: 0032916 | |
2013-04-22 08:55 | Brad King | Assigned To | => Brad King |
2013-04-22 08:55 | Brad King | Status | new => assigned |
2013-04-26 02:49 | sascha | Note Added: 0032945 | |
2013-04-30 09:08 | Brad King | Note Added: 0032964 | |
2013-04-30 09:08 | Brad King | Status | assigned => resolved |
2013-04-30 09:08 | Brad King | Resolution | open => fixed |
2013-10-07 10:09 | Robert Maynard | Note Added: 0034040 | |
2013-10-07 10:09 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |