View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013746CMakeModulespublic2012-11-27 06:322013-10-07 10:09
Reporterhades 
Assigned ToRolf Eike Beer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSOS Version
Product VersionCMake 2.8.9 
Target VersionCMake 2.8.11Fixed in Version 
Summary0013746: FindOpenGL module reports OpenGL_FOUND even when no OPENGL_INCLUDE_DIR is set
DescriptionWhen cmake can find a libGL.so, but no gl.h, it still sets OPENGL_FOUND to TRUE, despite that OPENGL_INCLUDE_DIR is set to NOTFOUND and therefore completely unusable.

I believe line 153 should be changed from:

FIND_PACKAGE_HANDLE_STANDARD_ARGS(OpenGL DEFAULT_MSG OPENGL_gl_LIBRARY)

to:

FIND_PACKAGE_HANDLE_STANDARD_ARGS(OpenGL DEFAULT_MSG OPENGL_gl_LIBRARY OPENGL_INCLUDE_DIR)
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0031722)
Brad King (manager)
2012-11-27 08:19

 The line in question was introduced here:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=937e3693 [^]

However, that commit only preserved existing behavior. It looks like the module has *never* considered OPENGL_INCLUDE_DIR to be required for FOUND!
(0031723)
Brad King (manager)
2012-11-27 08:33

 Fixed:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4960e918 [^]
(0031729)
Rolf Eike Beer (developer)
2012-11-27 11:00

 I don't think this will be right. Now you will always get a failure on WIN32 && !CYGWIN, because it there doesn't even try to find the header.

And the whole CYGWIN stuff will probably also never work because the CYGWIN check is inside the WIN32 check, which is only defined if the compat policy is in place IIRC.
(0031730)
Brad King (manager)
2012-11-27 11:14

 Thanks Eike. Reverted for now:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=69f962b1 [^]
(0032856)
Rolf Eike Beer (developer)
2013-04-17 07:10

 Fix pushed to next, please test:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5be35935dceb55923b954ef683aea02af6a92c86 [^]
(0034034)
Robert Maynard (manager)
2013-10-07 10:09

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-11-27 06:32 hades New Issue
2012-11-27 08:19 Brad King Assigned To => Brad King
2012-11-27 08:19 Brad King Status new => assigned
2012-11-27 08:19 Brad King Note Added: 0031722
2012-11-27 08:33 Brad King Note Added: 0031723
2012-11-27 08:33 Brad King Status assigned => resolved
2012-11-27 08:33 Brad King Resolution open => fixed
2012-11-27 08:33 Brad King Fixed in Version => CMake 2.8.11
2012-11-27 08:33 Brad King Target Version => CMake 2.8.11
2012-11-27 11:00 Rolf Eike Beer Note Added: 0031729
2012-11-27 11:00 Rolf Eike Beer Status resolved => feedback
2012-11-27 11:00 Rolf Eike Beer Resolution fixed => reopened
2012-11-27 11:14 Brad King Note Added: 0031730
2012-11-27 11:14 Brad King Assigned To Brad King => Rolf Eike Beer
2012-11-27 11:14 Brad King Status feedback => assigned
2012-11-27 11:14 Brad King Resolution reopened => open
2012-11-27 11:14 Brad King Fixed in Version CMake 2.8.11 =>
2013-04-17 07:10 Rolf Eike Beer Note Added: 0032856
2013-04-17 07:10 Rolf Eike Beer Status assigned => resolved
2013-04-17 07:10 Rolf Eike Beer Resolution open => fixed
2013-10-07 10:09 Robert Maynard Note Added: 0034034
2013-10-07 10:09 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team