View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013728CMakeCMakepublic2012-11-23 04:132012-11-23 04:44
ReporterJussiP 
Assigned ToPeter Kuemmel 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformLinuxOSLinuxOS VersionLinux
Product VersionCMake 2.8.9 
Target VersionFixed in VersionCMake 2.8.11 
Summary0013728: Ninja file generated by CMake is invalid
DescriptionWhen generating a Ninja build system for Scribus, the resulting build.ninja is invalid. The following error is printed when running Ninja:

ninja: error: build.ninja:6397: bad $-escape (literal $ must be written as $$)
  FLAGS = $(CMAKE_CXX_FLAGS) -fPIC -O2 -Wall -fPIC -Iscribus/third_party...
          ^ near here

Steps To ReproduceCheck out Scribus from git:

git clone git://git.scribus.net/scribus.git [^]

Run CMake with the ninja backend. Run Ninja.
Additional InformationThe error is caused by the parentheses surrounding the word CMAKE_CXX_FLAGS. Manually editing the Ninja file and removing the parentheses in all locations they appear fixes the issue and running Ninja will work correctly.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0031680)
Peter Kuemmel (developer)
2012-11-23 04:44
edited on: 2012-11-26 10:20

Your cmake file is buggy:
  SET(CMAKE_CXX_FLAGS "$(CMAKE_CXX_FLAGS) -fPIC")
should be
  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")

(found in 3 files)

scribus/third_party/cairo/CMakeLists.txt: SET(CMAKE_CXX_FLAGS "$(CMAKE_CXX_FLAGS) -fPIC")
scribus/third_party/lib2geom/CMakeLists.txt: SET(CMAKE_CXX_FLAGS "$(CMAKE_CXX_FLAGS) -fPIC")
scribus/third_party/wpg/CMakeLists.txt: SET(CMAKE_CXX_FLAGS "$(CMAKE_CXX_FLAGS) -fPIC")


 Issue History
Date Modified Username Field Change
2012-11-23 04:13 JussiP New Issue
2012-11-23 04:44 Peter Kuemmel Note Added: 0031680
2012-11-23 04:44 Peter Kuemmel Status new => closed
2012-11-23 04:44 Peter Kuemmel Assigned To => Peter Kuemmel
2012-11-23 04:44 Peter Kuemmel Resolution open => no change required
2012-11-23 04:44 Peter Kuemmel Fixed in Version => CMake 2.8.11
2012-11-26 10:20 Bill Hoffman Note Edited: 0031680


Copyright © 2000 - 2018 MantisBT Team