View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013489

CMake

Modules

public

2012-08-24 11:34

2013-01-09 14:05

Reporter

Petr Baloun

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.9

Target Version

Fixed in Version

Summary

0013489: Can't detect QT4 on OS considered as unsupported by QT

Description

Use QT4 on OS version that is not supproted by QT4 - I tried QT 4.7.2 on Windows 8. CMake is not able to detect anything about the QT4.

Steps To Reproduce

Use following code:

include(FindQt4)

Additional Information

FindQt4 calls "qmake -query ..." to detect some information about QT4, the information is expected on qmake's stdout. On unsupported OS, qmake also dumps some warnings to stderr (in my case it's "QT: Untested Windows version 6.2 detected!").

The problem is that FindQt4 mixes both outputs in a single output variable so the stdout information is mixed with the warning which leads to situation that no information is read and no QT4 detected.

The patch attached simply cancels the redirection of qmake's stderr into output variable which has following results:
- QT4 is properly detected
- the warning is seen in the output by the user

Tags

No tags attached.

Attached Files

qt-unsupported-os.patch [^] (795 bytes) 2012-08-24 11:34 [Show Content] [Hide Content]

--- cmake-2.8.9-orig/Modules/FindQt4.cmake	2012-08-09 20:15:19.000000000 +0200
+++ cmake-2.8.9/Modules/FindQt4.cmake	2012-08-24 16:45:48.000000000 +0200
@@ -468,13 +468,13 @@
   MARK_AS_ADVANCED(QT_${basename}_LIBRARY QT_${basename}_LIBRARY_RELEASE QT_${basename}_LIBRARY_DEBUG QT_${basename}_INCLUDE_DIR)
 ENDMACRO (_QT4_ADJUST_LIB_VARS)
 
 function(_QT4_QUERY_QMAKE VAR RESULT)
   execute_process(COMMAND "${QT_QMAKE_EXECUTABLE}" -query ${VAR}
     RESULT_VARIABLE return_code
-    OUTPUT_VARIABLE output ERROR_VARIABLE output
+    OUTPUT_VARIABLE output
     OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_STRIP_TRAILING_WHITESPACE)
   if(NOT return_code)
     file(TO_CMAKE_PATH "${output}" output)
     set(${RESULT} ${output} PARENT_SCOPE)
   endif(NOT return_code)
 endfunction(_QT4_QUERY_QMAKE)

Relationships

has duplicate

0013245

closed

Clinton Stimpson

FindQt4.cmake doesn't work on Windows 8

Notes
(0030757) Stephen Kelly (developer) 2012-08-24 11:41	Similar to http://public.kitware.com/Bug/view.php?id=13245 [^] but that one has no patch.

(0030758) Clinton Stimpson (developer) 2012-08-24 12:03	Thanks for the patch. http://cmake.org/gitweb?p=cmake.git;a=commit;h=caa915 [^]

(0032080) Robert Maynard (manager) 2013-01-09 14:05	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-08-24 11:34	Petr Baloun	New Issue
2012-08-24 11:34	Petr Baloun	File Added: qt-unsupported-os.patch
2012-08-24 11:41	Stephen Kelly	Note Added: 0030757
2012-08-24 12:03	Clinton Stimpson	Note Added: 0030758
2012-08-24 12:03	Clinton Stimpson	Status	new => resolved
2012-08-24 12:03	Clinton Stimpson	Resolution	open => fixed
2012-08-24 12:03	Clinton Stimpson	Assigned To	=> Clinton Stimpson
2012-08-24 12:05	Clinton Stimpson	Relationship added	has duplicate 0013245
2013-01-09 14:05	Robert Maynard	Note Added: 0032080
2013-01-09 14:05	Robert Maynard	Status	resolved => closed