View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013261

CMake

public

2012-05-30 13:43

2012-10-01 13:23

Reporter

Charlie Sharpsteen

Assigned To

David Cole

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Apple

OS X

OS Version

Product Version

CMake 2.8.8

Target Version

CMake 2.8.9

Fixed in Version

CMake 2.8.9

Summary

0013261: Default value of CMAKE_FIND_FRAMEWORK can not be overridden from the command line

Description

`CMAKE_FIND_FRAMEWORK` always has a value of `FIRST` even if a user passes an argument such as `-DCMAKE_FIND_FRAMEWORK=LAST` when configuring a project. This is due to an unguarded default in the platform file `Darwin.cmake` that always overrides user input.

See the following thread on the mailing list for more details:

http://cmake.3232098.n2.nabble.com/Why-does-CMAKE-FIND-FRAMEWORK-always-default-to-FIRST-ignoring-command-line-definitions-tp7521759.html [^]

Patch attached which adds guards to the default in `Darwin.cmake`. No changes in the CMake testsuite were noticed after applying the patch.

Tags

No tags attached.

Attached Files

0001-Add-guards-to-CMAKE_FIND_FRAMEWORK-default.patch [^] (1,025 bytes) 2012-05-30 13:43 [Show Content] [Hide Content]

From b63a07c893d5bc3aa486ac2a65c92b0de39e5ebc Mon Sep 17 00:00:00 2001
From: Charlie Sharpsteen <source@sharpsteen.net>
Date: Wed, 30 May 2012 10:29:26 -0700
Subject: [PATCH] Add guards to CMAKE_FIND_FRAMEWORK default

The default for `CMAKE_FIND_FRAMEWORK`, defined in `Darwin.cmake`, is now
guarded so that it will not override command line arguments passed by users.
---
 Modules/Platform/Darwin.cmake |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Modules/Platform/Darwin.cmake b/Modules/Platform/Darwin.cmake
index f9d37c3..9ce312b 100644
--- a/Modules/Platform/Darwin.cmake
+++ b/Modules/Platform/Darwin.cmake
@@ -230,7 +230,9 @@ SET(CMAKE_CXX_CREATE_MACOSX_FRAMEWORK
 
  
 # default to searching for frameworks first
-SET(CMAKE_FIND_FRAMEWORK FIRST)
+IF(NOT DEFINED CMAKE_FIND_FRAMEWORK)
+  SET(CMAKE_FIND_FRAMEWORK FIRST)
+ENDIF(NOT DEFINED CMAKE_FIND_FRAMEWORK)
 # set up the default search directories for frameworks
 SET(CMAKE_SYSTEM_FRAMEWORK_PATH
   ~/Library/Frameworks
-- 
1.7.10.3

0001-Add-guards-to-CMAKE_FIND_FRAMEWORK-default.patch-2 [^] (1,662 bytes) 2012-05-30 14:16

Relationships

Notes
(0029587) Brad King (manager) 2012-05-30 13:54	I think Darwin-icc.cmake may need this too.

(0029588) Charlie Sharpsteen (reporter) 2012-05-30 14:08	Good catch. Unfortunately, I cannot figure out how to delete my original attachement so that I can upload a corrected patch.

(0029589) Brad King (manager) 2012-05-30 14:10	Re 0013261:0029588: Just add a "-2" to the end of the file name and add a second attachment.

(0029590) Charlie Sharpsteen (reporter) 2012-05-30 14:19	Done. Although it is a bummer that the bugtracker won't let me edit my own bug---it is rare for humans to "get it perfect the first time".

(0029591) David Cole (manager) 2012-05-31 08:28	I modified the patch a little bit to remove the verbose endif() and to do the similar thing for the variable 'CMAKE_FIND_APPBUNDLE' as well... Fix pushed to 'next': http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8b2fb3310b4b8f1d218e479e3f5eafe04e8b8077 [^]

(0031138) David Cole (manager) 2012-10-01 13:23	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-05-30 13:43	Charlie Sharpsteen	New Issue
2012-05-30 13:43	Charlie Sharpsteen	File Added: 0001-Add-guards-to-CMAKE_FIND_FRAMEWORK-default.patch
2012-05-30 13:54	Brad King	Assigned To	=> David Cole
2012-05-30 13:54	Brad King	Status	new => assigned
2012-05-30 13:54	Brad King	Note Added: 0029587
2012-05-30 14:08	Charlie Sharpsteen	Note Added: 0029588
2012-05-30 14:10	Brad King	Note Added: 0029589
2012-05-30 14:16	Charlie Sharpsteen	File Added: 0001-Add-guards-to-CMAKE_FIND_FRAMEWORK-default.patch-2
2012-05-30 14:19	Charlie Sharpsteen	Note Added: 0029590
2012-05-31 08:27	David Cole	Target Version	=> CMake 2.8.9
2012-05-31 08:28	David Cole	Note Added: 0029591
2012-05-31 08:28	David Cole	Status	assigned => resolved
2012-05-31 08:28	David Cole	Fixed in Version	=> CMake 2.8.9
2012-05-31 08:28	David Cole	Resolution	open => fixed
2012-10-01 13:23	David Cole	Note Added: 0031138
2012-10-01 13:23	David Cole	Status	resolved => closed