View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013254

CMake

Modules

public

2012-05-29 15:59

2012-10-01 13:23

Reporter

Kurtis Nusbaum

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Windows

OS Version

Windows 7

Product Version

Target Version

Fixed in Version

Summary

0013254: phonon_ds9 backend plugin not found on windows.

Description

I'm deploying a Qt application which uses phonon on windows. For some reason, the DeployQt4.cmake module wasn't finding the phonon_ds9 backend plugin that is standard with windows installations of Qt4. More specifically (and was I'm almost positive this was what was tripping up DeployQt4), the QT_PHONON_DS9_PLUGIN_RELEASE variable was not set. I went and looked at the FindQt4.cmake file and found this line (it's line 1062 on cmake release 2.8.8):

set( QT_PHONON_BACKEND_PLUGINS phonon_qt7 )

phonon_qt7 is the phonon backend used exclusively on mac. Sure enough, changing the line to

set( QT_PHONON_BACKEND_PLUGINS phonon_ds9 )

resulted in the variable QT_PHONON_DS9_PLUGIN_RELEASE and QT_PHONON_DS9_PLUGIN_DEBUG being set to the correct libraries and DeployQt4 module finding the phonon_ds9 plugin and successfully bundling it with my application. I think this is a bug in FindQt4.cmake

Steps To Reproduce

1. Create an application that uses the phonon backend for Qt.
2. Use DeployQt and pass phonon_ds9 and the plugin argument when calling install_qt4_executable function.

Additional Information

Attached is a patch that does a mediocre job at addressing the issue. It basically, if it detects you're building for an APPLE machine it sets the phonon backend plugin variable to phonon_qt7 and if you're on windows it sets the variable to phonon_ds9. This obviously doesn't take into account all the other possible phonon backend situations. A more rigorous fix would address detecting the presence of other phonon backends.

Tags

No tags attached.

Attached Files

0001-Added-conditional-for-the-phonon-backend-plugin.-If-.patch [^] (1,421 bytes) 2012-05-29 15:59 [Show Content] [Hide Content]

From 8bfe808540fd8ac64126fa576f21a0ed2bece07c Mon Sep 17 00:00:00 2001
From: Kurtis Nusbaum <klnusbaum@gmail.com>
Date: Tue, 29 May 2012 14:49:16 -0500
Subject: [PATCH] Added conditional for the phonon backend plugin. If on
 APPLE, the phonon backend plugin is set to phonon_qt7. If
 on WIN32, the phonon backend plugin is set to phonon_ds9. I
 did not add any for generic UNIXes as they could have a
 whole host of things. A more comprehensive script would
 actually attempt to detect which phonon plugins were
 installed. However, this is a simple fix for now that will
 work for most people.

---
 Modules/FindQt4.cmake |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index f9db5e1..e5149bb 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/FindQt4.cmake
@@ -1059,7 +1059,11 @@ IF (QT_QMAKE_EXECUTABLE AND QTVERSION)
   SET( QT_IMAGEFORMATS_PLUGINS qgif qjpeg qmng qico qsvg qtiff  )
   SET( QT_INPUTMETHODS_PLUGINS qimsw_multi )
   SET( QT_MOUSEDRIVERS_PLUGINS qwstslibmousehandler )
-  SET( QT_PHONON_BACKEND_PLUGINS phonon_qt7 )
+  IF(APPLE)
+    SET( QT_PHONON_BACKEND_PLUGINS phonon_qt7 )
+  ELSEIF(WIN32)
+    SET( QT_PHONON_BACKEND_PLUGINS phonon_ds9 )
+  ENDIF(APPLE)
   SET( QT_SCRIPT_PLUGINS qtscriptdbus )
   SET( QT_SQLDRIVERS_PLUGINS qsqldb2 qsqlibase qsqlite qsqlite2 qsqlmysql qsqloci qsqlodbc qsqlpsql qsqltds )

-- 
1.7.5.4

0001-phonon-backend-tweak.patch [^] (1,416 bytes) 2012-05-29 16:52 [Show Content] [Hide Content]

From 8bfe808540fd8ac64126fa576f21a0ed2bece07c Mon Sep 17 00:00:00 2001
From: Kurtis Nusbaum <klnusbaum@gmail.com>
Date: Tue, 29 May 2012 14:49:16 -0500
Subject: [PATCH] Added conditional for the phonon backend plugin. If on
 APPLE, the phonon backend plugin is set to phonon_qt7. If
 on WIN32, the phonon backend plugin is set to phonon_ds9. I
 did not add any for generic UNIXes as they could have a
 whole host of things. A more comprehensive script would
 actually attempt to detect which phonon plugins were
 installed. However, this is a simple fix for now that will
 work for most people.

---
 Modules/FindQt4.cmake |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index f9db5e1..e5149bb 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/FindQt4.cmake
@@ -1059,7 +1059,11 @@ IF (QT_QMAKE_EXECUTABLE AND QTVERSION)
   SET( QT_IMAGEFORMATS_PLUGINS qgif qjpeg qmng qico qsvg qtiff  )
   SET( QT_INPUTMETHODS_PLUGINS qimsw_multi )
   SET( QT_MOUSEDRIVERS_PLUGINS qwstslibmousehandler )
-  SET( QT_PHONON_BACKEND_PLUGINS phonon_qt7 )
+  IF(APPLE)
+    SET( QT_PHONON_BACKEND_PLUGINS phonon_qt7 )
+  ELSEIF(WIN32)
+    SET( QT_PHONON_BACKEND_PLUGINS phonon_ds9 )
+  ENDIF()
   SET( QT_SCRIPT_PLUGINS qtscriptdbus )
   SET( QT_SQLDRIVERS_PLUGINS qsqldb2 qsqlibase qsqlite qsqlite2 qsqlmysql qsqloci qsqlodbc qsqlpsql qsqltds )

-- 
1.7.5.4

Relationships

Notes
(0029581) David Cole (manager) 2012-05-29 16:07	Clint, does this patch look reasonable, or should there be some additional elseif clauses? Any other suggestions?

(0029582) Clinton Stimpson (developer) 2012-05-29 16:49	Can you tweak that patch to the following? + IF(APPLE) + SET( QT_PHONON_BACKEND_PLUGINS phonon_qt7 ) + ELSEIF(WIN32) + SET( QT_PHONON_BACKEND_PLUGINS phonon_ds9 ) + ENDIF() Its an improvement, and there are multiple possible backends on Linux... so that will take more work to figure out. I didn't see an easy way to detect phonon plugins.

(0029583) Kurtis Nusbaum (reporter) 2012-05-29 16:52	Uploaded the tweaked patch.

(0029584) Clinton Stimpson (developer) 2012-05-29 16:58	http://cmake.org/gitweb?p=cmake.git;a=commit;h=ad7c80 [^]

(0031137) David Cole (manager) 2012-10-01 13:23	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-05-29 15:59	Kurtis Nusbaum	New Issue
2012-05-29 15:59	Kurtis Nusbaum	File Added: 0001-Added-conditional-for-the-phonon-backend-plugin.-If-.patch
2012-05-29 16:06	David Cole	Assigned To	=> Clinton Stimpson
2012-05-29 16:06	David Cole	Status	new => assigned
2012-05-29 16:07	David Cole	Note Added: 0029581
2012-05-29 16:49	Clinton Stimpson	Note Added: 0029582
2012-05-29 16:52	Kurtis Nusbaum	File Added: 0001-phonon-backend-tweak.patch
2012-05-29 16:52	Kurtis Nusbaum	Note Added: 0029583
2012-05-29 16:58	Clinton Stimpson	Note Added: 0029584
2012-05-29 16:58	Clinton Stimpson	Status	assigned => resolved
2012-05-29 16:58	Clinton Stimpson	Resolution	open => fixed
2012-10-01 13:23	David Cole	Note Added: 0031137
2012-10-01 13:23	David Cole	Status	resolved => closed