| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0013018 | CMake | CMake | public | 2012-03-05 19:50 | 2012-04-19 15:52 | ||||
| Reporter | Stephen Kelly | ||||||||
| Assigned To | Alex Neundorf | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | CMake 2.8.8 | Fixed in Version | CMake 2.8.8 | ||||||
| Summary | 0013018: QtAutoMoc does not expand add_definitions arguments consistently | ||||||||
| Description | If the argument to add_definitions() is quoted oddly, CMake handles it correctly, but the automoc feature does not. The line this->GenerateAll = true; is hit to generate all targets again. In the attached file, each invocation of 'make' causes a full rebuild. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |  add_definitions.tar.gz [^] (607 bytes) 2012-03-05 19:50 | ||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0028948) Alex Neundorf (developer) 2012-03-20 17:54 |
Please give the AutomocProperCMakeEscaping-13018 branch on stage a try, this should fix it. I haven't added a test yet. |
|
(0028949) Stephen Kelly (developer) 2012-03-20 18:52 |
I can confirm that this fixes the issue in solid. I reverted https://projects.kde.org/projects/kde/kdelibs/repository/revisions/56fbb4468c5c8ac0bee4490ecefd9b7d6f875aeb/diff/tier1/solid/autotests/CMakeLists.txt [^] to test it. Thanks, |
|
(0028993) Alex Neundorf (developer) 2012-03-28 15:43 |
Merged into master, fix confirmed by reporter. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2012-03-05 19:50 | Stephen Kelly | New Issue | |
| 2012-03-05 19:50 | Stephen Kelly | File Added: add_definitions.tar.gz | |
| 2012-03-06 13:38 | Alex Neundorf | Assigned To | => Alex Neundorf |
| 2012-03-06 13:38 | Alex Neundorf | Status | new => assigned |
| 2012-03-20 17:54 | Alex Neundorf | Note Added: 0028948 | |
| 2012-03-20 18:52 | Stephen Kelly | Note Added: 0028949 | |
| 2012-03-28 15:43 | Alex Neundorf | Note Added: 0028993 | |
| 2012-03-28 15:43 | Alex Neundorf | Status | assigned => closed |
| 2012-03-28 15:43 | Alex Neundorf | Resolution | open => fixed |
| 2012-04-19 15:52 | David Cole | Fixed in Version | => CMake 2.8.8 |
| 2012-04-19 15:52 | David Cole | Target Version | => CMake 2.8.8 |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |