View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0012867 | CMake | Modules | public | 2012-01-09 18:28 | 2012-07-09 06:52 | ||||
Reporter | Patrick Spendrin | ||||||||
Assigned To | Rolf Eike Beer | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | Windows | OS | Windows | OS Version | Windows 7 | ||||
Product Version | CMake 2.8.7 | ||||||||
Target Version | CMake 2.8.8 | Fixed in Version | CMake 2.8.8 | ||||||
Summary | 0012867: bzip2 library not found in debug on windows | ||||||||
Description | bzip2 should also find libraries called bzip2d on windows. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-add-debug-library-name-for-bzip2.patch [^] (738 bytes) 2012-01-09 18:28 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0028224) Rolf Eike Beer (developer) 2012-01-10 08:13 |
I have some further ideas for this module. I'll contact you later with something to test. |
(0028248) Rolf Eike Beer (developer) 2012-01-10 17:39 |
Pushed as topic improve-findbzip2 to stage. Patrick has successfully tested this. Can someone please comment on this? |
(0028249) Rolf Eike Beer (developer) 2012-01-10 17:43 |
I accidentially already merged it to next. Well, let's see what breaks ;) |
(0028256) Rolf Eike Beer (developer) 2012-01-11 03:53 |
Merged into next here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=96ae584f [^] |
(0028258) Rolf Eike Beer (developer) 2012-01-11 04:04 |
This change broke those build machines that do not have a (usable) system bzip2, i.e. that use cmbzip2. The question is how to proceed: put the whole optimized/debug code into IF(MSVC) like e.g. FindOpenSSL does, add some extra code that handles injection of those values (how?), revert this or do something completely different? |
(0028268) David Cole (manager) 2012-01-11 12:08 |
How about "don't do any find operations" if BZIP2_LIBRARIES is already set....? |
(0028269) Rolf Eike Beer (developer) 2012-01-11 12:18 |
Yes, something like that. But I would have to manually put the value in the cache then so it does not get lost? Something like this? IF (BZIP2_LIBRARIES) SET(BZIP2_LIBRARIES "${BZIP2_LIBRARIES}" CACHE FILEPATH "Location of BZip2 libraries") ELSE (BZIP2_LIBRARIES) ... the other code ENDIF () |
(0028274) Rolf Eike Beer (developer) 2012-01-12 02:50 |
Should be finally fixed by: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dc5b85722992a1939c12c8fdf15ac38d300c9879 [^] |
(0029952) David Cole (manager) 2012-07-09 06:52 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-01-09 18:28 | Patrick Spendrin | New Issue | |
2012-01-09 18:28 | Patrick Spendrin | File Added: 0001-add-debug-library-name-for-bzip2.patch | |
2012-01-10 08:13 | Rolf Eike Beer | Note Added: 0028224 | |
2012-01-10 08:13 | Rolf Eike Beer | Assigned To | => Rolf Eike Beer |
2012-01-10 08:13 | Rolf Eike Beer | Status | new => assigned |
2012-01-10 17:39 | Rolf Eike Beer | Note Added: 0028248 | |
2012-01-10 17:43 | Rolf Eike Beer | Note Added: 0028249 | |
2012-01-11 03:53 | Rolf Eike Beer | Note Added: 0028256 | |
2012-01-11 04:04 | Rolf Eike Beer | Note Added: 0028258 | |
2012-01-11 12:08 | David Cole | Note Added: 0028268 | |
2012-01-11 12:18 | Rolf Eike Beer | Note Added: 0028269 | |
2012-01-12 02:50 | Rolf Eike Beer | Note Added: 0028274 | |
2012-01-12 02:50 | Rolf Eike Beer | Status | assigned => resolved |
2012-01-12 02:50 | Rolf Eike Beer | Resolution | open => fixed |
2012-01-12 02:50 | Rolf Eike Beer | Fixed in Version | => CMake 2.8.8 |
2012-01-12 02:50 | Rolf Eike Beer | Target Version | => CMake 2.8.8 |
2012-07-09 06:52 | David Cole | Note Added: 0029952 | |
2012-07-09 06:52 | David Cole | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |