(0028251)
ycollet (reporter)
2012-01-11 02:26

The problem is still present in cmake-2.8.6

(0028259)
Eric NOULARD (developer)
2012-01-11 07:56

Could you attachto the bug tracker the project.nsi file you obtain when packaging with NSIS.

After you did cpack -G NSIS (or build the PACKAGE target in your IDE)

The file project.nsi should be in
<builddir>/_CPack_Packages/<systemdependent name>/NSIS/project.nsi

then may be you can try to modify this file in order to get what you want
and attach the modified file as well.

NB:
Once you modified the file you may rebuild the installer by
calling "makensis project.nsi" from within
<builddir>/_CPack_Packages/<systemdependent name>/NSIS
folder.

YOU MUST not call CPack after modifying the project.nsi file because
CPack would overwrite it.

(0028262)
ycollet (reporter)
2012-01-11 09:19

I just uploaded the original project.nsi file (3.4 Mo).
I will follow your instructions and modify the project.nsi.

(0028271)
Eric NOULARD (developer)
2012-01-11 17:30

I cannot reproduce this problem on my side.
Could you try to build the sample project i've just uploaded and
tell me if the "Runtime" group has the proper "The Runtime Group"
display name.

If it does could you try to downsize your project in order
to reproduce the problem.

If my project exhibit the same issue on your side could
you tell me which version of nsis your are using?

Could you do all this with cmake/cpack 2.8.7?

(0028286)
ycollet (reporter)
2012-01-13 05:16

Your test case works fine for me.
I am trying to see how I can downsiez my problem.

Yc

(0028287)
ycollet (reporter)
2012-01-13 05:54

I found the problem:

I made a typo on the DESCRIPTION parameters.
In your test, I replaced DESCRIPTION by DESCRIPTIONS and I've got the same problem as with my project.

So, now the problem is: cpack doesn't check unknown parameters on the macros.

(0028288)
Eric NOULARD (developer)
2012-01-13 06:27

Ok I see.
Unfortunately,
the non-check of "unknown" parameters is not cpack specific...
I'll see if there is some bug open on the subject and link this one
to it before I close it.

Thank you for taking time to find out.

(0028289)
ycollet (reporter)
2012-01-13 07:54

thanks for your support.

(0030652)
Eric NOULARD (developer)
2012-08-14 14:31

The typo in MACRO name parameters is a problem that is real
but it concerns far more than CPack code.

I won't fix it here.
...and I have no time to work on a general solution.

Notes
(0028251) ycollet (reporter) 2012-01-11 02:26	The problem is still present in cmake-2.8.6

(0028259) Eric NOULARD (developer) 2012-01-11 07:56	Could you attachto the bug tracker the project.nsi file you obtain when packaging with NSIS. After you did cpack -G NSIS (or build the PACKAGE target in your IDE) The file project.nsi should be in <builddir>/_CPack_Packages/<systemdependent name>/NSIS/project.nsi then may be you can try to modify this file in order to get what you want and attach the modified file as well. NB: Once you modified the file you may rebuild the installer by calling "makensis project.nsi" from within <builddir>/_CPack_Packages/<systemdependent name>/NSIS folder. YOU MUST not call CPack after modifying the project.nsi file because CPack would overwrite it.

(0028262) ycollet (reporter) 2012-01-11 09:19	I just uploaded the original project.nsi file (3.4 Mo). I will follow your instructions and modify the project.nsi.

(0028271) Eric NOULARD (developer) 2012-01-11 17:30	I cannot reproduce this problem on my side. Could you try to build the sample project i've just uploaded and tell me if the "Runtime" group has the proper "The Runtime Group" display name. If it does could you try to downsize your project in order to reproduce the problem. If my project exhibit the same issue on your side could you tell me which version of nsis your are using? Could you do all this with cmake/cpack 2.8.7?

(0028286) ycollet (reporter) 2012-01-13 05:16	Your test case works fine for me. I am trying to see how I can downsiez my problem. Yc

(0028287) ycollet (reporter) 2012-01-13 05:54	I found the problem: I made a typo on the DESCRIPTION parameters. In your test, I replaced DESCRIPTION by DESCRIPTIONS and I've got the same problem as with my project. So, now the problem is: cpack doesn't check unknown parameters on the macros.

(0028288) Eric NOULARD (developer) 2012-01-13 06:27	Ok I see. Unfortunately, the non-check of "unknown" parameters is not cpack specific... I'll see if there is some bug open on the subject and link this one to it before I close it. Thank you for taking time to find out.

(0028289) ycollet (reporter) 2012-01-13 07:54	thanks for your support.

(0030652) Eric NOULARD (developer) 2012-08-14 14:31	The typo in MACRO name parameters is a problem that is real but it concerns far more than CPack code. I won't fix it here. ...and I have no time to work on a general solution.

Issue History
Date Modified	Username	Field	Change
2011-07-28 10:06	ycollet	New Issue
2012-01-11 02:26	ycollet	Note Added: 0028251
2012-01-11 07:56	Eric NOULARD	Note Added: 0028259
2012-01-11 09:18	ycollet	File Added: project.zip
2012-01-11 09:19	ycollet	Note Added: 0028262
2012-01-11 17:26	Eric NOULARD	File Added: MyLib-1.0.1-Source.zip
2012-01-11 17:30	Eric NOULARD	Note Added: 0028271
2012-01-11 17:30	Eric NOULARD	Assigned To	=> Eric NOULARD
2012-01-11 17:30	Eric NOULARD	Status	new => assigned
2012-01-13 05:16	ycollet	Note Added: 0028286
2012-01-13 05:54	ycollet	Note Added: 0028287
2012-01-13 06:27	Eric NOULARD	Note Added: 0028288
2012-01-13 07:54	ycollet	Note Added: 0028289
2012-08-14 14:31	Eric NOULARD	Note Added: 0030652
2012-08-14 14:31	Eric NOULARD	Status	assigned => closed
2012-08-14 14:31	Eric NOULARD	Resolution	open => won't fix

Relationships