View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012147

CMake

Modules

public

2011-05-03 04:57

2011-10-03 09:54

Reporter

Bernhard Rosenkraenzer

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

any

OS Version

Product Version

CMake 2.8.4

Target Version

Fixed in Version

Summary

0012147: Absence of uic makes Qt4 detection fail

Description

FindQt4.cmake, line 1091+, does

  IF( QT_LIBRARY_DIR AND QT_INCLUDE_DIR AND QT_MOC_EXECUTABLE AND
      QT_UIC_EXECUTABLE AND QT_RCC_EXECUTABLE AND QT_QTCORE_LIBRARY)
    SET( QT4_FOUND "YES" )
    INCLUDE(FindPackageMessage)
    FIND_PACKAGE_MESSAGE(Qt4 "Found Qt-Version ${QTVERSION} (using ${QT_QMAKE_EXECUTABLE})"
      "[${QT_LIBRARY_DIR}][${QT_INCLUDE_DIR}][${QT_MOC_EXECUTABLE}][${QT_UIC_EXECUTABLE}][${QT_RCC_EXECUTABLE}]")
  ELSE( QT_LIBRARY_DIR AND QT_INCLUDE_DIR AND QT_MOC_EXECUTABLE AND
        QT_UIC_EXECUTABLE AND QT_RCC_EXECUTABLE AND QT_QTCORE_LIBRARY)
    SET( QT4_FOUND "NO")
    SET(QT_QMAKE_EXECUTABLE "${QT_QMAKE_EXECUTABLE}-NOTFOUND" CACHE FILEPATH "Invalid qmake found" FORCE)
    IF( Qt4_FIND_REQUIRED)
      MESSAGE( FATAL_ERROR "Qt libraries, includes, moc, uic or/and rcc NOT found!")
    ENDIF( Qt4_FIND_REQUIRED)
  ENDIF( QT_LIBRARY_DIR AND QT_INCLUDE_DIR AND QT_MOC_EXECUTABLE AND

I think QT_UIC_EXECUTABLE should be removed because UIC is hardly essential (you need it only if you use Qt Designer), and it isn't built if Qt is built with the "-no-gui" configure switch (useful e.g. for headless servers where you still want to use tools that use QtCore, QtXml, QtNetwork and/or QtSql).

I'd argue that a missing uic shouldn't make Qt detection fail at all because there's also plenty of Qt GUI code that doesn't use uic - but it definitely shouldn't fail if QT_DONT_USE_QTGUI is set.

Steps To Reproduce

1. Install Qt with -no-gui
2. Try to compile anything that uses FindQt4.cmake to locate QtCore/QtXml/QtNetwork/QtSql

Tags

No tags attached.

Attached Files

Relationships

Notes
(0026424) Clinton Stimpson (developer) 2011-05-03 10:34	This was already fixed not long ago. And that part of the script doesn't look like that anymore.

(0027503) David Cole (manager) 2011-10-03 09:54	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2011-05-03 04:57	Bernhard Rosenkraenzer	New Issue
2011-05-03 10:34	Clinton Stimpson	Note Added: 0026424
2011-05-03 10:34	Clinton Stimpson	Status	new => resolved
2011-05-03 10:34	Clinton Stimpson	Resolution	open => fixed
2011-05-03 10:34	Clinton Stimpson	Assigned To	=> Clinton Stimpson
2011-10-03 09:54	David Cole	Note Added: 0027503
2011-10-03 09:54	David Cole	Status	resolved => closed