View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012143

CMake

Modules

public

2011-05-02 07:19

2011-06-18 07:40

Reporter

Stuart Henderson

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

amd64

OpenBSD

OS Version

4.9-current

Product Version

CMake 2.8.4

Target Version

CMake 2.8.5

Fixed in Version

CMake 2.8.5

Summary

0012143: use `arch -s' for CMAKE_HOST_SYSTEM_PROCESSOR on OpenBSD

Description

On OpenBSD `uname -p' returns a long descriptive name for the processor e.g.

$ shmux -c "uname -p" mala zephyr sym kaffir
  mala: 7447A (Revision 0x102)
   sym: AMD Opteron(tm) Processor 146
kaffir: i80219 600MHz step A-0 (XScale core)
zephyr: Intel(R) Pentium(R) Dual CPU E2160 @ 1.80GHz

This is used to populate CMAKE_HOST_SYSTEM_PROCESSOR. Programs making use of this variable expect short names of the cpu type e.g. i386. On OpenBSD this is best obtained with `arch -s'.

$ shmux -c "arch -s" mala zephyr sym kaffir
  mala: powerpc
   sym: amd64
zephyr: amd64
kaffir: arm

Tags

No tags attached.

Attached Files

patch-Modules_CMakeDetermineSystem_cmake [^] (1,518 bytes) 2011-05-02 07:19 [Show Content] [Hide Content]

$OpenBSD: patch-Modules_CMakeDetermineSystem_cmake,v 1.1 2011/04/29 16:50:32 sthen Exp $

programs expect CMAKE_HOST_SYSTEM_PROCESSOR to contain a simple,
single-word processor type. "arch -s" provides the closest to
this on OpenBSD.

--- Modules/CMakeDetermineSystem.cmake.orig	Tue Feb 15 17:47:26 2011
+++ Modules/CMakeDetermineSystem.cmake	Fri Apr 29 11:29:23 2011
@@ -51,12 +51,17 @@ IF(CMAKE_HOST_UNIX)
       EXEC_PROGRAM(uname ARGS -m OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
         RETURN_VALUE val)
     ELSE(CMAKE_HOST_SYSTEM_NAME MATCHES "Linux|CYGWIN.*")
-      EXEC_PROGRAM(uname ARGS -p OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
-        RETURN_VALUE val)
-      IF("${val}" GREATER 0)
-        EXEC_PROGRAM(uname ARGS -m OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
+      IF(CMAKE_HOST_SYSTEM_NAME MATCHES "OpenBSD")
+        EXEC_PROGRAM(arch ARGS -s OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
           RETURN_VALUE val)
-      ENDIF("${val}" GREATER 0)
+      ELSE(CMAKE_HOST_SYSTEM_NAME MATCHES "OpenBSD")
+        EXEC_PROGRAM(uname ARGS -p OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
+          RETURN_VALUE val)
+        IF("${val}" GREATER 0)
+          EXEC_PROGRAM(uname ARGS -m OUTPUT_VARIABLE CMAKE_HOST_SYSTEM_PROCESSOR
+            RETURN_VALUE val)
+        ENDIF("${val}" GREATER 0)
+      ENDIF(CMAKE_HOST_SYSTEM_NAME MATCHES "OpenBSD")
     ENDIF(CMAKE_HOST_SYSTEM_NAME MATCHES "Linux|CYGWIN.*")
     # check the return of the last uname -m or -p 
     IF("${val}" GREATER 0)

Relationships

Notes
(0026300) Brad King (manager) 2011-05-02 10:47	Fixed, thanks: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0bfabf96 [^]

Issue History
Date Modified	Username	Field	Change
2011-05-02 07:19	Stuart Henderson	New Issue
2011-05-02 07:19	Stuart Henderson	File Added: patch-Modules_CMakeDetermineSystem_cmake
2011-05-02 10:47	Brad King	Assigned To	=> Brad King
2011-05-02 10:47	Brad King	Status	new => assigned
2011-05-02 10:47	Brad King	Note Added: 0026300
2011-05-02 10:47	Brad King	Status	assigned => closed
2011-05-02 10:47	Brad King	Resolution	open => fixed
2011-06-18 07:40	David Cole	Fixed in Version	=> CMake 2.8.5
2011-06-18 07:40	David Cole	Target Version	=> CMake 2.8.5