View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011927CMakeModulespublic2011-03-04 10:122012-04-02 10:10
ReporterDavid Cole 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformVisual Studio 10OSWindowsOS Version
Product VersionCMake 2.8.4 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0011927: ExternalProject: git clone step always runs when using "Visual Studio 10" generator
DescriptionAs reported on the CMake mailing list, the git clone step always runs again on 2nd and later builds, even though the 1st build was completely successful.

This is really annoying, as it always leads to full rebuilds, because the git clone code blows away the source tree first, and does a fresh clone when it runs...

Note that this only happens with Visual Studio 10, and is not a problem with VS9 and earlier.
Steps To Reproduce# CMakeLists.txt:
# ==========================================================================
cmake_minimum_required(VERSION 2.8.4)
project(SAF-ext)
include(ExternalProject)
EXTERNALPROJECT_ADD(
  SAF-ext
  GIT_REPOSITORY "git://github.com/dlrdave/SmallAndFast.git" [^]
  GIT_TAG "5e98e304a464946dd34cb4c53eb3dd1fd348781b"
  CMAKE_ARGS
    -DSAF_INTENTIONAL_COMPILE_ERROR:BOOL=OFF
  INSTALL_COMMAND ""
  UPDATE_COMMAND ""
  )

# Save these steps to repro as a CMakeLists.txt file
# (1) Run this:
# mkdir b1
# cd b1
# cmake -G "Visual Studio 10" ..
# (2) Open solution file in Visual Studio 10
# (3) Build -- allow to finish all the way
# (4) Build again
#
# Expected:
# 2nd build should build nothing as everything is up to date
#
# Actual:
# 2nd build builds everything again, starting with the mkdir steps,
# and continuing on down through git clone and all the rest...
TagsNo tags attached.
Attached Files

 Relationships
has duplicate 0012407closedDavid Cole CMake doesn't generate .rule files 
has duplicate 0012302closedDavid Cole Unable to use CMAKE_CFG_INTDIR in the OUTPUT of a CUSTOM_COMMAND 

  Notes
(0025669)
David Cole (manager)
2011-03-04 10:16

 Reference thread on the CMake mailing list:
http://www.cmake.org/pipermail/cmake/2011-March/043204.html [^]
(0026738)
Bill Hoffman (manager)
2011-06-07 09:06

 I have a fix for this checked in.

$ ssh git@cmake.org stage cmake merge -b next fix_vs10_custom_command_rulefiles
Fetching upstream next
Merge topic 'fix_vs10_custom_command_rulefiles' into next

9d406cd Fix for bug 0011927, external project git clone step always runs vs10.

Pushing upstream next
To git@cmake.org:cmake.git
(0027219)
David Cole (manager)
2011-08-17 11:34

 The fix:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9d406cd [^]
(0029044)
David Cole (manager)
2012-04-02 10:10

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2011-03-04 10:12 David Cole New Issue
2011-03-04 10:12 David Cole Status new => assigned
2011-03-04 10:12 David Cole Assigned To => David Cole
2011-03-04 10:13 David Cole Steps to Reproduce Updated
2011-03-04 10:14 David Cole Description Updated
2011-03-04 10:16 David Cole Note Added: 0025669
2011-06-07 09:06 Bill Hoffman Note Added: 0026738
2011-06-07 11:30 Bill Hoffman Status assigned => resolved
2011-06-07 11:30 Bill Hoffman Resolution open => fixed
2011-06-17 18:35 David Cole Fixed in Version => CMake 2.8.5
2011-08-17 11:32 David Cole Relationship added has duplicate 0012407
2011-08-17 11:34 David Cole Note Added: 0027219
2011-08-19 14:43 David Cole Relationship added has duplicate 0012302
2012-04-02 10:10 David Cole Note Added: 0029044
2012-04-02 10:10 David Cole Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team