| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0011143 | CMake | CPack | public | 2010-08-18 07:08 | 2011-05-02 14:45 | ||||
| Reporter | Mike McQuaid | ||||||||
| Assigned To | David Cole | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake-2-8 | ||||||||
| Target Version | CMake 2.8.4 | Fixed in Version | CMake 2.8.4 | ||||||
| Summary | 0011143: CPACK_NSIS_MUI_ICON only used when CPACK_NSIS_MUI_UNIICON also set | ||||||||
| Description | CPACK_NSIS_MUI_ICON can only used when CPACK_NSIS_MUI_UNIICON also set as the C++ code seems to require them both to have a value. Surely this could be an || rather than an && here as there's no reason why the user should have to set both to have one change. If this is not intentional, let me know and I'll create a patch. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0023914) Mike McQuaid (reporter) 2010-12-13 07:06 |
4 months later ping. If I shouldn't be bugs on the bug tracker can you suggest the best way of getting these looked at? Thanks! |
|
(0024454) Mike McQuaid (reporter) 2011-01-06 09:07 |
Pull request created at https://github.com/Kitware/CMake/pull/2 [^] |
|
(0024497) David Cole (manager) 2011-01-06 17:02 |
Fixed in this git commit, just pushed to 'next': http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fec32328b17662d44bfa7769e672529c24e1697f [^] Should make it into 2.8.4... Thanks, Mike McQuaid, for the patch / pull request! |
|
(0026336) David Cole (manager) 2011-05-02 14:45 |
Closing resolved issues that have not been updated in more than 3 months. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2010-08-18 07:08 | Mike McQuaid | New Issue | |
| 2010-12-13 07:06 | Mike McQuaid | Note Added: 0023914 | |
| 2010-12-15 11:32 | David Cole | Status | new => assigned |
| 2010-12-15 11:32 | David Cole | Assigned To | => David Cole |
| 2011-01-06 09:07 | Mike McQuaid | Note Added: 0024454 | |
| 2011-01-06 16:56 | David Cole | Target Version | => CMake 2.8.4 |
| 2011-01-06 17:02 | David Cole | Note Added: 0024497 | |
| 2011-01-06 17:02 | David Cole | Status | assigned => resolved |
| 2011-01-06 17:02 | David Cole | Fixed in Version | => CMake 2.8.4 |
| 2011-01-06 17:02 | David Cole | Resolution | open => fixed |
| 2011-05-02 14:45 | David Cole | Note Added: 0026336 | |
| 2011-05-02 14:45 | David Cole | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |