View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011026CMakeCTestpublic2010-07-22 04:562010-11-09 22:57
Reportersimonh 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0011026: CMake 2.8.1 breaks parallel builds during CTest. MAKECOMMAND not respected.
DescriptionAfter reviewing our build times over the past few months, I noticed that the introduction of CMake 2.8.1 from CMake 2.8.0 broke the parallel build stage of our nightly tests.

I see someone else is discussing the problem here:
http://www.cmake.org/pipermail/cmake/2010-July/038186.html [^]

Basically, my CTest script has, amongst others, 
set(CTEST_INITIAL_CACHE "
MAKECOMMAND:STRING=${MAKE_EXECUTABLE} -j4
")


However, the DartConfiguration.tcl file has 
MakeCommand: /usr/bin/gmake -i
TagsNo tags attached.
Attached Files? file icon iron-release.cmake [^] (1,619 bytes) 2010-07-23 05:17
gz file icon ctest_parallel_make.tar.gz [^] (777 bytes) 2010-07-23 05:23
patch file icon cmake_ctest_makecommand.patch [^] (697 bytes) 2010-09-19 21:19 [Show Content]

 Relationships
related to 0002336closedDavid Cole ctest -C option doesn't build proper configuration 

  Notes
(0021469)
Bill Hoffman (manager)
2010-07-22 21:22

 Can you attach a small complete test case?
(0021470)
Emmanuel Christophe (reporter)
2010-07-23 05:18

 Just added a test case (based on ITK) that shows the problem.
(0021471)
Emmanuel Christophe (reporter)
2010-07-23 05:19

 Might be linked to the fix for http://public.kitware.com/Bug/view.php?id=2336 [^]
(according to David Cole)
(0021472)
simonh (reporter)
2010-07-23 05:25

 I've added a whole project that illustrates the issue; unpack the archive and edit ctest_parallel_make/DashboardScript.cmake so that CTEST_SOURCE_DIRECTORY points to the unpacked directory and CTEST_BINARY_DIRECTORY is where the test build should be made.

Then run:
ctest -S /path/to/ctest_parallel_make/DashboardScript.cmake
(0021569)
simonh (reporter)
2010-07-30 04:10

 I keep reading about "new-style" CTest commands, but is there any documentation for them? The scripting HOWTO, http://www.cmake.org/Wiki/CMake_Scripting_Of_CTest [^] , doesn't give any info....
(0022266)
Evgeny Panasyuk (reporter)
2010-09-19 20:42
edited on: 2010-09-19 21:19

 Problem is here:
  BUILD_COMMAND(MAKECOMMAND CONFIGURATION "\${CTEST_CONFIGURATION_TYPE}")
  SET(MAKECOMMAND ${MAKECOMMAND} CACHE STRING "Command to build the project")

Looks like after "BUILD_COMMAND(MAKECOMMAND..", "CACHE" doesn't have big power

patch for fix issue: cmake_ctest_makecommand.patch
(0022286)
Emmanuel Christophe (reporter)
2010-09-20 20:16

 That patch works for me. Thanks!
(0022289)
Brad King (manager)
2010-09-21 08:29

 The regression was introduced here:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0b38bb4c [^]
(0022313)
David Cole (manager)
2010-09-21 22:13

 Fix pushed to 'next' :
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a323bde [^]

This might be in time to get it into the 2.8.3 release... I'll keep you posted.
(0022419)
David Cole (manager)
2010-10-06 13:40

 In CMake 2.8.3-rc2

 Issue History
Date Modified Username Field Change
2010-07-22 04:56 simonh New Issue
2010-07-22 21:22 Bill Hoffman Note Added: 0021469
2010-07-23 05:17 Emmanuel Christophe File Added: iron-release.cmake
2010-07-23 05:18 Emmanuel Christophe Note Added: 0021470
2010-07-23 05:19 Emmanuel Christophe Note Added: 0021471
2010-07-23 05:23 simonh File Added: ctest_parallel_make.tar.gz
2010-07-23 05:25 simonh Note Added: 0021472
2010-07-30 04:10 simonh Note Added: 0021569
2010-09-19 20:42 Evgeny Panasyuk Note Added: 0022266
2010-09-19 21:19 Evgeny Panasyuk File Added: cmake_ctest_makecommand.patch
2010-09-19 21:19 Evgeny Panasyuk Note Edited: 0022266
2010-09-20 20:16 Emmanuel Christophe Note Added: 0022286
2010-09-21 08:18 Bill Hoffman Status new => assigned
2010-09-21 08:18 Bill Hoffman Assigned To => Zach Mullen
2010-09-21 08:29 Brad King Assigned To Zach Mullen => David Cole
2010-09-21 08:29 Brad King Note Added: 0022289
2010-09-21 09:11 David Cole Relationship added related to 0002336
2010-09-21 22:13 David Cole Note Added: 0022313
2010-10-06 13:40 David Cole Note Added: 0022419
2010-10-06 13:40 David Cole Status assigned => resolved
2010-10-06 13:40 David Cole Fixed in Version => CMake 2.8.3
2010-10-06 13:40 David Cole Resolution open => fixed
2010-10-06 13:40 David Cole Target Version => CMake 2.8.3
2010-11-09 22:57 Philip Lowman Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team