View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0010798

CMake

public

2010-06-07 06:37

2011-11-11 10:45

Reporter

Ivan Shynkarenka

Assigned To

Bill Hoffman

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-8

Target Version

CMake 2.8.5

Fixed in Version

CMake 2.8.5

Summary

0010798: VS 2010 generator improperly generates AdditionalIncludeDirectories nodes

Description

Consider we have the following config:

CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
PROJECT(TEST)

ADD_EXECUTABLE(TEST test.cpp)

# This define include directories for ALL targets.
INCLUDE_DIRECTORIES("Subdir1" "Subdir2")

# This define include directories only for TEST targets.
SET_PROPERTY(TARGET TEST APPEND PROPERTY COMPILE_FLAGS "/ISubdir3")

VS 2008 generator behaviour (RIGHT behaviour):
    <Tool AdditionalOptions=" /Zm1000 /ISubdir3"
        AdditionalIncludeDirectories="Subdir1;Subdir2;" />

VS 2010 generator behaviour (WRONG behaviour):
    <ClCompile>
      <AdditionalOptions> /Zm1000 %(AdditionalOptions)</AdditionalOptions>
      <AdditionalIncludeDirectories>Subdir1;Subdir2;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
      <AdditionalIncludeDirectories>Subdir3</AdditionalIncludeDirectories>
    </ClCompile>

You may see VS 2010 creates extra <AdditionalIncludeDirectories> node. As the result all previous nodes are ignored and project will have only one additional include directory - Subdir3.

Tags

No tags attached.

Attached Files

testcase.zip [^] (1,440 bytes) 2010-06-07 06:37

cmake-2.8.2_patch_for_bug_10798.diff [^] (788 bytes) 2010-10-10 14:13 [Show Content] [Hide Content]

diff -r -c cmake-2.8.2.orig/Source/cmVisualStudioGeneratorOptions.cxx cmake-2.8.2/Source/cmVisualStudioGeneratorOptions.cxx
*** cmake-2.8.2.orig/Source/cmVisualStudioGeneratorOptions.cxx	2010-06-28 17:15:59.000000000 +0200
--- cmake-2.8.2/Source/cmVisualStudioGeneratorOptions.cxx	2010-10-01 02:46:57.677851800 +0200
***************
*** 251,257 ****
          {
          fout << "<" << m->first << ">";
          }
!       fout  << m->second << "</" << m->first << ">\n";
        }
      }
    else
--- 251,261 ----
          {
          fout << "<" << m->first << ">";
          }
! 	  fout  << m->second;
! 	  if (m->first == "AdditionalIncludeDirectories") {
! 		fout  << ";%(AdditionalIncludeDirectories)";
! 	  }
! 	  fout  << "</" << m->first << ">\n";
        }
      }
    else

Relationships

Notes
(0022468) Karl Wallner (reporter) 2010-10-10 14:13	Attached a fix for this bug.

(0026907) David Cole (manager) 2011-06-18 08:02	Fixed by this (and parent) git commits: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=27aa446352b882c7bbda269a3770fec8fa24eb57 [^]

(0027774) David Cole (manager) 2011-11-11 10:45	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2010-06-07 06:37	Ivan Shynkarenka	New Issue
2010-06-07 06:37	Ivan Shynkarenka	File Added: testcase.zip
2010-07-13 09:27	Bill Hoffman	Status	new => assigned
2010-07-13 09:27	Bill Hoffman	Assigned To	=> Bill Hoffman
2010-10-10 14:13	Karl Wallner	Note Added: 0022468
2010-10-10 14:13	Karl Wallner	File Added: cmake-2.8.2_patch_for_bug_10798.diff
2011-06-18 08:02	David Cole	Note Added: 0026907
2011-06-18 08:02	David Cole	Status	assigned => resolved
2011-06-18 08:02	David Cole	Fixed in Version	=> CMake 2.8.5
2011-06-18 08:02	David Cole	Resolution	open => fixed
2011-06-18 08:02	David Cole	Target Version	=> CMake 2.8.5
2011-11-11 10:45	David Cole	Note Added: 0027774
2011-11-11 10:45	David Cole	Status	resolved => closed