| View Issue Details [ Jump to Notes ] | [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0010700 | CMake | CMake | public | 2010-05-11 03:37 | 2010-12-15 09:47 |
|
| Reporter | Michael Frommberger | |
| Assigned To | Brad King | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | CMake-2-8 | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0010700: VS6 generator: resource compilation MinSizeRel Bug |
| Description | I'm trying to generate with CMake 2.8.1 on Windows XP a VS6 project which compiles a resource. It works pretty well with Debug, Release and RelWithDebInfo. But with the MinSizeRel profile I got an error from VS6. In the generated dsp file I found the following line:
# ADD RSC REL |
| Additional Information | I think the bug is in cmLocalVisualStudio6Generator.cxx. There are some string replacements. The replacement for the compile definitions for MinSizeRel seems to be incomplete (COMPILE_DEFINITIONS_MINSIZE instead of COMPILE_DEFINITIONS_MINSIZEREL). So the REL remains after the replacement. Here is a diff with the patch to solve this issue. After applying this patch to CMake 2.8.1, resource compilation works for me with all profiles. |
| Tags | No tags attached. |
|
| Attached Files |  MinSizeRel_Compile_Definitions_bug.diff [^] (818 bytes) 2010-05-11 03:37 [Show Content] [Hide Content]diff -ru cmake-2.8.1/Source/cmLocalVisualStudio6Generator.cxx cmake-2.8.1.patched/Source/cmLocalVisualStudio6Generator.cxx
--- cmake-2.8.1/Source/cmLocalVisualStudio6Generator.cxx 2010-03-16 13:10:20.000000000 +0100
+++ cmake-2.8.1.patched/Source/cmLocalVisualStudio6Generator.cxx 2010-05-10 11:21:27.437500000 +0200
@@ -1629,7 +1629,7 @@
flagsRelease.c_str());
cmSystemTools::ReplaceString(line, "CMAKE_CXX_FLAGS", flags.c_str());
- cmSystemTools::ReplaceString(line, "COMPILE_DEFINITIONS_MINSIZE",
+ cmSystemTools::ReplaceString(line, "COMPILE_DEFINITIONS_MINSIZEREL",
minsizeDefines.c_str());
cmSystemTools::ReplaceString(line, "COMPILE_DEFINITIONS_DEBUG",
debugDefines.c_str());
|
|