View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0010532

ITK

public

2010-04-10 21:57

2010-10-21 12:31

Reporter

Steve Robbins

Assigned To

Luis Ibanez

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

ITK-3-16

Target Version

Fixed in Version

ITK-3-20

Summary

0010532: ITK does not build with tcl 8.5

Description

The file Wrapping/CSwig/IO/itkTkImageViewer2D.cxx needs modification for Tcl 8.5. The build stops with the following errors.

[ 86%] Building CXX object Wrapping/CSwig/IO/CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o
cd /home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Wrapping/CSwig/IO && /usr/bin/c++ -DITKIOTcl_EXPORTS -DSWIG_GLOBAL -Wno-deprecated -ftemplate-depth-50 -Wall -Wno-deprecated -msse2 -w -O3 -DNDEBUG -fPIC -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Algorithms -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/BasicFilters -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Common -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/IO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/FEM -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/NeuralNetworks -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/SpatialObject -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/MetaIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/NrrdIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/NrrdIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/DICOMParser -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/DICOMParser -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/expat -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/expat -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/nifti/niftilib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/nifti/znzlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/itkExtHdrs -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/Statistics -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/v3p/netlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/vcl -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/core -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/v3p/netlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/vcl -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/core -I/usr/lib/gdcm-2.0 -I/usr/include/gdcm-2.0 -I/usr/include/python2.5 -I/usr/include/tcl8.5 -I/usr/lib/jvm/default-java/include -o CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o -c /home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx: In member function ‘void itk::TkImageViewer2D::Draw()’:
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: invalid conversion from ‘void*’ to ‘Tcl_Interp*’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: invalid conversion from ‘int’ to ‘void*’
/usr/include/tcl8.5/tkDecls.h:1668: error: too few arguments to function ‘int Tk_PhotoSetSize(Tcl_Interp*, void*, int, int)’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: at this point in file
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:146: error: invalid conversion from ‘void*’ to ‘Tcl_Interp*’
/usr/include/tcl8.5/tkDecls.h:1651: error: too few arguments to function ‘int Tk_PhotoPutBlock(Tcl_Interp*, void*, Tk_PhotoImageBlock*, int, int, int, int, int)’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:146: error: at this point in file
make[3]: *** [Wrapping/CSwig/IO/CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o] Error 1

Tags

No tags attached.

Resolution Date

Sprint

Sprint Status

Attached Files

itkTkImageViewer2D.patch [^] (890 bytes) 2010-04-11 21:26 [Show Content] [Hide Content]

--- insighttoolkit-3.16.0.orig/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx.orig	2010-04-10 21:22:04.000000000 -0500
+++ insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx	2010-04-10 23:13:16.000000000 -0500
@@ -114,7 +114,7 @@
   // Setup the size 
   Tk_PhotoHandle photo =
     Tk_FindPhoto(m_Interpreter, const_cast<char*>(m_ImageName.c_str()));
-  Tk_PhotoSetSize(photo, width, height);
+  Tk_PhotoSetSize(m_Interpreter, photo, width, height);
   
   OStringStream command;
   command << m_CanvasName.c_str() << " configure -scrollregion \"1 1 "
@@ -142,7 +142,7 @@
 #if (TK_MAJOR_VERSION == 8) && (TK_MINOR_VERSION < 4)
   Tk_PhotoPutBlock(photo, &block, 0, 0, size[0], size[1]);
 #else
-  Tk_PhotoPutBlock(photo, &block, 0, 0, size[0], size[1],
+  Tk_PhotoPutBlock(m_Interpreter, photo, &block, 0, 0, size[0], size[1],
                    TK_PHOTO_COMPOSITE_SET);
 #endif
 }

itkTkImageViewer2D_b.patch [^] (1,357 bytes) 2010-04-25 10:14 [Show Content] [Hide Content]

? itkTkImageViewer2D_b.patch
Index: itkTkImageViewer2D.cxx
===================================================================
RCS file: /cvsroot/Insight/Insight/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx,v
retrieving revision 1.2
diff -p -u -r1.2 itkTkImageViewer2D.cxx
--- itkTkImageViewer2D.cxx	10 Sep 2003 14:30:12 -0000	1.2
+++ itkTkImageViewer2D.cxx	25 Apr 2010 14:13:08 -0000
@@ -114,8 +114,14 @@ void TkImageViewer2D::Draw()
   // Setup the size 
   Tk_PhotoHandle photo =
     Tk_FindPhoto(m_Interpreter, const_cast<char*>(m_ImageName.c_str()));
+
+
+#if (TK_MAJOR_VERSION == 8) && (TK_MINOR_VERSION < 5)
   Tk_PhotoSetSize(photo, width, height);
-  
+#else  
+  Tk_PhotoSetSize(m_Interpreter, photo, width, height);
+#endif
+
   OStringStream command;
   command << m_CanvasName.c_str() << " configure -scrollregion \"1 1 "
           << width << " " << height << "\"";
@@ -142,8 +148,13 @@ void TkImageViewer2D::Draw()
 #if (TK_MAJOR_VERSION == 8) && (TK_MINOR_VERSION < 4)
   Tk_PhotoPutBlock(photo, &block, 0, 0, size[0], size[1]);
 #else
+#if (TK_MAJOR_VERSION == 8) && (TK_MINOR_VERSION < 5)
   Tk_PhotoPutBlock(photo, &block, 0, 0, size[0], size[1],
                    TK_PHOTO_COMPOSITE_SET);
+#else
+  Tk_PhotoPutBlock(m_Interpreter, photo, &block, 0, 0, size[0], size[1],
+                    TK_PHOTO_COMPOSITE_SET);
+#endif
 #endif
 }

Relationships

Notes
(0020131) Steve Robbins (developer) 2010-04-11 21:27	I uploaded the patch I'm using to fix this problem (itkTkImageViewer2D.patch). It compiles now, but I have not yet tested.

(0020390) Luis Ibanez (manager) 2010-04-25 10:15	Updated the patch to include conditional #ifdefs so that the changes only apply to Tcl 8.5. New patch file has been attached to this bug report: itkTkImageViewer2D_b.patch

(0020391) Luis Ibanez (manager) 2010-04-25 11:50	patch was committed: http://public.kitware.com/cgi-bin/viewcvs.cgi/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx?root=Insight&r1=1.2&r2=1.3 [^]

Issue History
Date Modified	Username	Field	Change
2010-04-10 21:57	Steve Robbins	New Issue
2010-04-11 21:26	Steve Robbins	File Added: itkTkImageViewer2D.patch
2010-04-11 21:27	Steve Robbins	Note Added: 0020131
2010-04-25 10:13	Luis Ibanez	Status	new => assigned
2010-04-25 10:13	Luis Ibanez	Assigned To	=> Luis Ibanez
2010-04-25 10:14	Luis Ibanez	File Added: itkTkImageViewer2D_b.patch
2010-04-25 10:15	Luis Ibanez	Note Added: 0020390
2010-04-25 11:50	Luis Ibanez	Note Added: 0020391
2010-08-15 23:29	Steve Robbins	Status	assigned => resolved
2010-08-15 23:29	Steve Robbins	Fixed in Version	=> ITK-3-20
2010-08-15 23:29	Steve Robbins	Resolution	open => fixed
2010-10-21 12:31	Gabe Hart	Status	resolved => closed