View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010456ITKpublic2010-03-24 17:542010-10-21 12:31
ReporterRoger Bramon 
Assigned ToBradley Lowekamp 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-3-16 
Target VersionFixed in Version 
Summary0010456: Performance regression in itkImageSeriesReader::GenerateOutputInformation()
DescriptionIn http://www.itk.org/pipermail/insight-users/2010-March/035870.html [^] a discussion about a performance regression in itkImageSeriesReader is started. The problem seems to be in method

void ImageSeriesReader<TOutputImage>
::GenerateOutputInformation(void)

where the line:

for ( int i = 0; i != 2; ++i )

was changed to:

for ( int i = 0; i != numberOfFiles; ++i )

There are some tests in this mailing list thread and also some ideas in order to solve it.

Moreover, there is another performace regression issue when the codification of the DICOM data is Little Endian Implicit, but it will be discussed in another report issue.
TagsNo tags attached.
Resolution Date
Sprint
Sprint Status
Attached Files

 Relationships

  Notes
(0020026)
Bradley Lowekamp (developer)
2010-03-29 08:20

 When support was added to ImageSeriesReader, it was determined that is would be best to update the MetaDataDictionaryArray during UpdateOutputInformation. This requires and additional visit of each file, while on many format this is reasonable efficient, for DICOM processing all of the tags has been shown to be too costly.

The solution is to return the update of the MDDA to the UpdateData methods, but and time stamps and flags to allow for efficient processing when streaming.
(0020027)
Bradley Lowekamp (developer)
2010-03-29 10:59

 Committed patch:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/IO/itkImageSeriesReader.h?root=Insight&r1=1.18&r2=1.19&sortby=date [^]

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/IO/itkImageSeriesReader.txx?root=Insight&r1=1.38&r2=1.39&sortby=date [^]
(0020047)
Bradley Lowekamp (developer)
2010-04-01 08:26

 The patch appears to have fixed the issue

 Issue History
Date Modified Username Field Change
2010-03-24 17:54 Roger Bramon New Issue
2010-03-25 18:37 Luis Ibanez Status new => assigned
2010-03-25 18:37 Luis Ibanez Assigned To => Bradley Lowekamp
2010-03-29 08:20 Bradley Lowekamp Note Added: 0020026
2010-03-29 10:59 Bradley Lowekamp Note Added: 0020027
2010-04-01 08:26 Bradley Lowekamp Note Added: 0020047
2010-04-01 08:26 Bradley Lowekamp Status assigned => resolved
2010-04-01 08:26 Bradley Lowekamp Resolution open => fixed
2010-10-21 12:31 Gabe Hart Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team