View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010443ITKpublic2010-03-19 12:172010-11-15 06:07
ReporterMarius Staring 
Assigned ToLuis Ibanez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in VersionITK-4-A3 
Summary0010443: VectorGradientMagnitudeImageFilter issues
DescriptionThe VectorGradientMagnitudeImageFilter class has protected Get and Set functions, such as:

/** Get/Set the neighborhood radius used for gradient computation */
itkGetConstReferenceMacro( NeighborhoodRadius, RadiusType );
itkSetMacro( NeighborhoodRadius, RadiusType );

Since to my knowledge no class derives from VectorGradientMagnitudeImageFilter, and because it just makes sense, these functions should probably be public.

---------------------------------------------------------------

The 3D tests for this class seem to have two parameters switched, see lines 739 - 753 of Insight\Testing\Code\BasicFilters\CMakeLists.txt:
These lines should probably read

ADD_TEST(itkVectorGradientMagnitudeImageFilterTest2 ${BASIC_FILTERS_TESTS3}
  --compare ${ITK_DATA_ROOT}/Baseline/BasicFilters/VectorGradientMagnitudeImageFilterTest2.png
            ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2.png
  itkVectorGradientMagnitudeImageFilterTest2
            ${ITK_DATA_ROOT}/Input/VHFColor.mhd
            ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2.png
            0 5)

ADD_TEST(itkVectorGradientMagnitudeImageFilterTest2b ${BASIC_FILTERS_TESTS3}
  --compare ${ITK_DATA_ROOT}/Baseline/BasicFilters/VectorGradientMagnitudeImageFilterTest2b.png
            ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2b.png
  itkVectorGradientMagnitudeImageFilterTest2
            ${ITK_DATA_ROOT}/Input/VHFColor.mhd
            ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2b.png
            1 5)

and not ADD_TEST( .... 5 0 ) and ADD_TEST( .... 5 1 )

Because the parameter argv[3] should be 0 or 1 and not the last parameter (see Insight\Testing\Code\BasicFilters\itkVectorGradientMagnitudeImageFilterTest2.cxx).

Solving this will also increase code coverage, since now the function for 3D images EvaluateAtNeighborhood3D() is never called.

TagsNo tags attached.
Resolution Date2010-11-11
Sprint
Sprint Statusbacklog
Attached Files

 Relationships

  Notes
(0022992)
Luis Ibanez (manager)
2010-11-07 01:51

 pushed a fix to Gerrit:
http://review.source.kitware.com/#change,316 [^]
(0023251)
Marius Staring (developer)
2010-11-15 06:07

 merged with git repo:

http://itk.org/gitweb?p=ITK.git;a=commitdiff;h=a62b7db01451091f6a653775e93b8b6061b25b26 [^]

 Issue History
Date Modified Username Field Change
2010-03-19 12:17 Marius Staring New Issue
2010-03-19 12:18 Marius Staring Status new => assigned
2010-03-19 12:18 Marius Staring Assigned To => Luis Ibanez
2010-11-07 01:51 Luis Ibanez Note Added: 0022992
2010-11-15 06:07 Marius Staring Resolution Date => 2010-11-11
2010-11-15 06:07 Marius Staring Sprint Status => backlog
2010-11-15 06:07 Marius Staring Note Added: 0023251
2010-11-15 06:07 Marius Staring Status assigned => closed
2010-11-15 06:07 Marius Staring Resolution open => fixed
2010-11-15 06:07 Marius Staring Fixed in Version => ITK-4-A3

Copyright © 2000 - 2018 MantisBT Team