View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0010263

CMake

public

2010-02-10 02:12

2013-03-13 11:35

Reporter

Philip Lowman

Assigned To

David Cole

Priority

low

Severity

tweak

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-8

Target Version

CMake 2.8.5

Fixed in Version

CMake 2.8.5

Summary

0010263: /GL flag for Visual Studio 7 does not cause "WholeProgramOptimization" to be set in project file (i.e. GUI)

Description

This patch sets WholeProgramOptimization (C/C++->Optimization->WholeProgramOptimization) when /GL is present, setting it to FALSE when /GL- is present (not sure why you would ever need /GL- since the default is off).

Also, not sure if this should be fixed or not, but the reference to LTCG as a compiler flag is an error since it's a linker flag (see also 0006794). It probably could be removed from cmGlobalVisualStudio7Generator.cxx:655. Passing LTCG to the MSVC compiler does generate a warning but I'm not sure what else it does.

Tags

No tags attached.

Attached Files

msvc_gl_flagpatch.diff [^] (939 bytes) 2010-02-10 02:12 [Show Content] [Hide Content]

Index: Source/cmLocalVisualStudio7Generator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmLocalVisualStudio7Generator.cxx,v
retrieving revision 1.260
diff -u -r1.260 cmLocalVisualStudio7Generator.cxx
--- Source/cmLocalVisualStudio7Generator.cxx	24 Dec 2009 16:40:14 -0000	1.260
+++ Source/cmLocalVisualStudio7Generator.cxx	10 Feb 2010 07:08:05 -0000
@@ -446,6 +446,10 @@
   {"SmallerTypeCheck", "RTCc", "smaller type check", "TRUE", 0},
   {"SuppressStartupBanner", "nologo", "SuppressStartupBanner", "TRUE", 0},
   {"WarnAsError", "WX", "Treat warnings as errors", "TRUE", 0},
+  {"WholeProgramOptimization", "GL",
+   "Enables whole program optimization", "TRUE", 0},
+  {"WholeProgramOptimization", "GL-",
+   "Disables whole program optimization", "FALSE", 0},
   {"BrowseInformation", "FR", "Generate browse information", "1", 0},
   {0,0,0,0,0}
 };

Relationships

related to

0014009

closed

Kitware Robot

/LTCG option does not cause LinkTimeCodeGeneration to be set in project file

Notes
(0025198) David Cole (manager) 2011-02-01 13:40	Fix pushed to 'next': http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6cf5772a934f8408dbf0615a0a981239f461a28f [^]

(0026712) David Cole (manager) 2011-06-06 18:25	Closing resolved issues that have not been updated in more than 3 months.

Issue History
Date Modified	Username	Field	Change
2010-02-10 02:12	Philip Lowman	New Issue
2010-02-10 02:12	Philip Lowman	File Added: msvc_gl_flagpatch.diff
2011-01-17 13:01	David Cole	Assigned To	=> David Cole
2011-01-17 13:01	David Cole	Status	new => assigned
2011-02-01 13:40	David Cole	Note Added: 0025198
2011-02-01 13:40	David Cole	Status	assigned => resolved
2011-02-01 13:40	David Cole	Resolution	open => fixed
2011-02-16 11:41	David Cole	Target Version	=> CMake 2.8.5
2011-06-06 18:25	David Cole	Status	resolved => closed
2011-06-06 18:25	David Cole	Note Added: 0026712
2011-06-17 18:08	David Cole	Fixed in Version	=> CMake 2.8.5
2013-03-13 11:35	Brad King	Relationship added	related to 0014009