[vtkusers] About vtkCellLocator::IntersectWithLine method

[Cory Quammen]

Nicolas,

Thanks for your contribution! I've reviewed it and merged it into the
repository.

http://www.vtk.org/gitweb?p=VTK.git;a=log

I'm looking forward to your future contributions!

All the best,
Cory

On Fri, Sep 5, 2014 at 10:08 AM, Nicolas Gallego <nicgallego at gmail.com> wrote:
> Hi Cory and David,
>
> Thank you for the invitation to develop, I did the changes in the source
> code and pushed the topic. I also added you as a reviewer.
>
> I basically took David's explanation and place it in the definition of the
> method vtkCell::IntersectWithLine() since I understood it was somehow
> delegated to that class, I also added the reference in
> vtkAbstractCellLocator to the vtkCell for details.
>
> I hope that helps,
>
> Nicolás Gallego-Ortiz
> Université catholique de Louvain, Belgium
>
>
> 2014-09-04 14:35 GMT+02:00 Cory Quammen <cory.quammen at kitware.com>:
>>
>> Hi Nicolas,
>>
>> While it would be fantastic to be able to review all of VTK and add
>> documentation where ever it is missing, in reality the resources to do
>> that will likely never materialize. However, one of the great things
>> about VTK is that it is open source, and anyone can contribute patches
>> to the source code, including missing documentation.
>>
>> With that in mind, I invite you to become a VTK developer and
>> contribute the missing documentation in a patch. Directions for doing
>> so can be found here:
>>
>> http://www.vtk.org/Wiki/VTK/Git/Develop
>>
>> Feel free to add me as a reviewer to any documentation topics you post.
>>
>> Best regards,
>> Cory
>>
>> On Thu, Sep 4, 2014 at 5:44 AM, Nicolas Gallego <nicgallego at gmail.com>
>> wrote:
>> > Hi David,
>> > Thank you very much, your explanation took me back to the good track.
>> >
>> > It would be nice if next time developers review locators documentations,
>> > make explicit the difference between
>> > double pcoords[3] and double x[3]
>> > the first being in baricentric coordinates apearently and the second in
>> > data
>> > coordinates.
>> >
>> > I will try to extract an example of this exercice a post it on the wiki.
>> >
>> > Nicolás Gallego-Ortiz
>> > Université catholique de Louvain, Belgium
>> >
>> >
>> > 2014-09-03 19:57 GMT+02:00 David Gobbi <david.gobbi at gmail.com>:
>> >
>> >> On Wed, Sep 3, 2014 at 11:55 AM, David Gobbi <david.gobbi at gmail.com>
>> >> wrote:
>> >> >
>> >> > I don't have an answer on hand, but the answer is, yes, they are all
>> >> > outputs.
>> >>
>> >> I meant to say "I don't have an example on hand".
>> >
>> >
>> >
>> > _______________________________________________
>> > Powered by www.kitware.com
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Please keep messages on-topic and check the VTK FAQ at:
>> > http://www.vtk.org/Wiki/VTK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://public.kitware.com/mailman/listinfo/vtkusers
>> >
>
>