[vtkusers] small bug report, extra comma in enum

Sean McBride sean at rogue-research.com
Thu Aug 23 14:27:45 EDT 2012


On Sun, 19 Aug 2012 17:12:05 -0400, Xiaofeng Z said:

>The
> author states that the comma was intentional.  Obviously it's not about
> the time it takes to remove it.  I can see a good reason why the comma 
>is there.  My approach to these kind of thing is typically to end a enum
>with something like, for this 
>case, AlignInvalid=0xFFFF.

Xiaofeng,

VTK does not require C++11 and so this code is not valid C++.  What kind of good reason is more important than conforming to the language specification?

I've created a patch to remove the comma here:
<http://review.source.kitware.com/7159>

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada





More information about the vtkusers mailing list