[vtkusers] Handling "holding down" a key

[Bill Lorensen]

It is too bad you cannot ignore whitespace changes. Gerrit does have
such an option. I assume vtk will move to gerrit for code reviews. itk
is currently using it as an experiment.
http://www.vtk.org/Wiki/ITK/Gerrit

Bill


On Sun, Sep 12, 2010 at 3:27 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> I also agree.  When tabs were removed from VTK, the code was changed
> at the same time as the hooks.
>
> In the meantime, it's too bad github doesn't provide an option for
> ignoring whitespace changes when displaying diffs.
>
>  David
>
>
> On Sun, Sep 12, 2010 at 12:58 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> I agree. We should not have to pay for the sins of others...
>>
>> On Sun, Sep 12, 2010 at 2:29 PM, David Doria <daviddoria+vtk at gmail.com> wrote:
>>> On Sun, Sep 12, 2010 at 2:23 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>> David G,
>>>>
>>>> I don't see style changes. I see comment addition...
>>>
>>> He is referring to removing the trailing spaces (from the discussion
>>> in "New function: vtkMath::ProjectVector" on the devel list). I agree
>>> that it makes finding the actual changes much harder.
>>>
>>> I still think these trailing spaces should be removed from all files
>>> with a script and checked in so that this is not an issue for anyone
>>> going forward. Having commit hooks which the current repo doesn't pass
>>> doesn't make sense to me.
>>>
>>> David
>>>
>>
>