[vtkusers] OpenSolaris build

[Gaëtan Lehmann]

Le 23 juil. 09 à 17:52, Mathieu Malaterre a écrit :

>
>
> 2009/7/21 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>
>> Le 21 juil. 09 à 21:00, Denis Barbier a écrit :
>>
>>> Le 21 juillet 2009 19:30, Gaëtan Lehmann a écrit :
>>> [...]
>>>>
>>>> If I comment the calls to alloca(), everything builds. Of course  
>>>> some
>>>> tests
>>>> are failing - I'd be happy to get some help on that point.
>>>
>>> [...]
>>>
>>> Have a look at the beginning of Hybrid/vtkVRMLImporter.cxx, it  
>>> seems that
>>> in your case, alloca declaration is
>>>  char *alloca ();
>>> and further calls fail when compiling with a C++ compiler.
>>> This function is redeclared lines 828 and below in a slightly  
>>> different
>>> way,
>>> you may try to delete lines 7--28.
>>>
>>
>> Somehow, I've missed the declarations of alloca() at the top of the  
>> file.
>> You pointed me to the right direction. Thank you! :-)
>>
>> alloca.h is available with sun studio - we only have to use it. A  
>> fix is
>> attached to that mail.
>>
>> Can someone commit that patch and the previous one? They are  
>> changing the
>> behavior only on solaris and with sun studio, and they are very  
>> small, so
>> they should be quite safe.
>
> Done.
>
> $ cvs ci -m"COMP: Fix OpenSolaris builds. Thanks to Gaetan Lehmann  
> for patch" Hybrid/vtkVRMLImporter.cxx
> Committer: Mathieu Malaterre <mathieu.malaterre at gmail.com>
> /cvsroot/VTK/VTK/Hybrid/vtkVRMLImporter.cxx,v  <--  Hybrid/ 
> vtkVRMLImporter.cxx
> new revision: 1.74; previous revision: 1.73
>
>

Thanks Mathieu,

Would you agree to also commit the other patch? I've reattached it to  
this mail.

Thanks,

Gaëtan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: common.patch
Type: application/octet-stream
Size: 764 bytes
Desc: not available
URL: <http://www.vtk.org/pipermail/vtkusers/attachments/20090723/aa0b689c/attachment.obj>
-------------- next part --------------


-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.vtk.org/pipermail/vtkusers/attachments/20090723/aa0b689c/attachment.pgp>