<div dir="auto">+1</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 9, 2018, 10:59 AM Jean-Christophe Fillion-Robin <<a href="mailto:jcfr@kitware.com">jcfr@kitware.com</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div dir="ltr"><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">--------------------<br></span></div><div dir="ltr"><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">> > * Building any VTK module either externally or along with the VTK project<br>
> > ? (e.g this will be useful for creating python wheels)<br>
<br></span><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">> I'm not sure the use case is clear to me. How are Python wheels related to remote modules?</span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">As
of today, it is possible to distribute and package part of VTK
independently. this is already done for the VTKOpenVR module. See [1]</span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">[1] <a href="https://github.com/Kitware/VTK/blob/4cb368df22c2db23ed230f743422fcfd78570229/Rendering/OpenVR/CMakeLists.txt#L1-L9" target="_blank" rel="noreferrer">https://github.com/Kitware/VTK/blob/4cb368df22c2db23ed230f743422fcfd78570229/Rendering/OpenVR/CMakeLists.txt#L1-L9</a><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">The comment of David "</span>VTK can be built kit-by-kit instead of all at once, is a logical extension of the multiple package idea<span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"></span>" also capture this idea.<br></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">From
a user perspective, I see remote module as in "VTK module source stored
outside of VTK source tree" exactly the same way as regular module.<br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">Ideally,
a "project" command as well as a "find_package(VTK ... )" with the
expected dependency would be written in every VTK module. The only
exception would be a "VTKCore" module providing the build system
infrastructure.<br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">--------------------</span></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">> I love the ***idea*** of remote modules but sort of hate them in practice. I'm not sure if there is a way to make them work. Maybe someone knows a way.<br></span></span></div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">> Right now a change in VTK is as simple as one commit to one repo. <br></span><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im">This shouldn't change. The key idea here is that the underlying build-system should treat them the same way. The only different is that the source happen to already be available. <br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><div><span class="m_6537650021880218579gmail-m_6515202703864164973gmail-im"><br></span></div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 9, 2018 at 12:05 PM Prabhu Ramachandran <<a href="mailto:prabhu@aero.iitb.ac.in" target="_blank" rel="noreferrer">prabhu@aero.iitb.ac.in</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_6537650021880218579m_-3431511738404790785moz-cite-prefix">On 11/8/18 3:15 PM, David Gobbi wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr">On Thu, Nov 8, 2018 at 12:18 PM Ben Boeckel
<<a href="mailto:ben.boeckel@kitware.com" target="_blank" rel="noreferrer">ben.boeckel@kitware.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> * Building any VTK module either externally or along
with the VTK project<br>
> ? (e.g this will be useful for creating python wheels)<br>
<br>
I'm not sure the use case is clear to me. How are Python
wheels related<br>
to remote modules?<br>
</blockquote>
<div><br>
</div>
<div>Package managers like to be able to subdivide VTK into
multiple packages.</div>
<div>Being able to modularize the build itself, so that VTK
can be built kit-by-kit</div>
<div>instead of all at once, is a logical extension of the
multiple package idea.</div>
<div>If I recall correctly, the CI system for pypi was failing
to build VTK due to</div>
<div>timeouts (I'm not sure what the workaround was, I suspect
that Prabhu</div>
<div>built the wheels manually).</div>
</div>
</div>
</blockquote>
<p>Yes, I built the wheels with the VTKPythonPackage,
(<a class="m_6537650021880218579m_-3431511738404790785moz-txt-link-freetext" href="https://github.com/KitwareMedical/VTKPythonPackage" target="_blank" rel="noreferrer">https://github.com/KitwareMedical/VTKPythonPackage</a>), it is
largely automated but I did build it by hand and uploaded it. <br>
</p>
<p>I am not sure if this is still broken with 8.2 and hope to check
this weekend.<br>
</p>
<p>cheers,</p>
<p>Prabhu<br>
</p>
</div>
</blockquote></div>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="https://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer noreferrer" target="_blank">https://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
</blockquote></div>