<div dir="ltr"><div>Hi, <br></div><div><br></div><div>Here are some suggestions and comment:</div><div><br></div><div>* using "loguru" (or any other logging backend) should be an implementation details specific to the application using the library (e.g of application ParaView, 3D Slicer, VTK examples, VTK tests, and many more).</div><div><br></div><div>* existing logging macros (vtkErrorMacro, vtkDebugMacro, ...) should be kept around along with their existing behavior as well as the vtkOutputWindow</div><div><br></div><div>* new categorical logging macro should be introduced.</div><div><br></div><div> - each message would be associated with a type (info, error, warning), a category (e.g vtk.rendering.opengl2.<wbr>shaderprogram) and a context (line, file, function) <br></div><div> - for sake of performance, context would be available only for Debug (and may be RelWithDebInfo) or only if explicitly enabled<br></div><div> - enable/disable logging at run-time based on rules, ... <br></div><div> - this presentation nicely summarizes the type of features that could be integrated in VTK. See <a href="https://www.kdab.com/wp-content/uploads/stories/slides/Day2/KaiKoehne_Qt%20Logging%20Framework%2016_9_0.pdf" target="_blank">https://www.kdab.com/wp-<wbr>content/uploads/stories/<wbr>slides/Day2/KaiKoehne_Qt%<wbr>20Logging%20Framework%2016_9_<wbr>0.pdf</a></div><div><br></div><div>* since it is not uncommon to have application using both ITK and VTK, would also be nice to discussed with ITK community<br></div><div><br></div><div>Such approach would allow to gradually transition existing VTK module to the new categorical logging and would prevent existing user code from breaking</div><div><br></div><div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 8, 2018 at 4:08 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">We definitely should hide what ever third party spi.</div><div class="m_-191370393084691286HOEnZb"><div class="m_-191370393084691286h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 8, 2018, 11:53 AM Sean McBride <<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 8 Aug 2018 10:47:01 -0400, David Cole via vtk-developers said:<br>
<br>
>As strictly a client of VTK, I would like to express the strong desire<br>
>to NOT get yet-another-logger added to my app just because I link in<br>
>VTK. Please make sure it's "opt-in" only. We have two apps, one<br>
>already uses log4cpp, and one uses g2log, and we just went through a<br>
>large pain trying to turn off logging in one of our other client<br>
>libraries.<br>
<br>
I had a similar thought. I haven't looked at this loguru, but hopefully you can choose where it logs things to. On macOS for example, it would be nice if VTK logging eventually invokes the os_log functions in usr/include/os/log.h.<br>
<br>
Cheers,<br>
<br>
-- <br>
______________________________<wbr>______________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com" rel="noreferrer" target="_blank">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" rel="noreferrer noreferrer" target="_blank">www.rogue-research.com</a> <br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="https://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer noreferrer" target="_blank">https://public.kitware.com/mai<wbr>lman/listinfo/vtk-developers</a><br>
<br>
</blockquote></div>
</div></div><br>______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="https://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">https://public.kitware.com/mai<wbr>lman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div></div>