[vtk-developers] eeloo

[Ken Martin]

Awesome!

On Mon, Sep 10, 2018 at 1:32 PM, Shawn Waldon <shawn.waldon at kitware.com>
wrote:

> Hi Ken,
>
> We reverted the suppressions that were added in July on Friday and Ben has
> a branch [1] that fixes most of the warnings since they were real issues.
>
> Shawn
>
> [1]: https://gitlab.kitware.com/vtk/vtk/merge_requests/4647
>
> On Mon, Sep 10, 2018 at 1:27 PM, Ken Martin <ken.martin at kitware.com>
> wrote:
>
>> So... I am seeing lots of warning suddenly pop up on eeloo. As we clearly
>> want to keep our buildbots green, so that people notice when they introduce
>> new warnings or errors, these need to be either
>>
>> 1) promptly fixed
>>
>> or if no one is opting for (1) then
>>
>> 2) suppressed until such as time that someone can fix them
>>
>> Is anyone doing (1) ? If not then we need to do option (2) or some other
>> creative idea ...
>>
>>
>>
>> On Thu, Sep 6, 2018 at 9:08 AM, Ben Boeckel <ben.boeckel at kitware.com>
>> wrote:
>>
>>> On Tue, Jul 03, 2018 at 12:48:23 -0400, Ken Martin wrote:
>>> > I think that is a crazy warning gcc is producing and we should disable
>>> it.
>>> > Way too many false positives with their approach. Can you change the
>>> > compile flags on eeloo to remove that warning?
>>>
>>> It's not a crazy warning. I saw warnings from the Catalyst builds after
>>> updating `megas`. The one in vtkObjectFactory is a false positive, but
>>> rewriting it to use `std::string` instead of `strncat` just makes the
>>> code easier to read anyways. Errors in pv-forward.c.in were real and
>>> (since it is C), `snprintf` is the better solution there.
>>>
>>> Basically, `strncat` is a function that is really easy to screw up. We
>>> really shouldn't use it in C code and certainly not at all in C++ code.
>>>
>>> --Ben
>>>
>>
>>
>>
>> --
>> Ken Martin PhD
>> Distinguished Engineer
>> Kitware Inc.
>> 101 East Weaver Street
>> <https://maps.google.com/?q=101+East+Weaver+Street+Carrboro,+North+Carolina+%0D%0A27510+USA&entry=gmail&source=g>
>> Carrboro, North Carolina
>> <https://maps.google.com/?q=101+East+Weaver+Street+Carrboro,+North+Carolina+%0D%0A27510+USA&entry=gmail&source=g>
>> 27510 USA
>>
>> This communication, including all attachments, contains confidential and
>> legally privileged information, and it is intended only for the use of the
>> addressee.  Access to this email by anyone else is unauthorized. If you are
>> not the intended recipient, any disclosure, copying, distribution or any
>> action taken in reliance on it is prohibited and may be unlawful. If you
>> received this communication in error please notify us immediately and
>> destroy the original message.  Thank you.
>>
>
>


-- 
Ken Martin PhD
Distinguished Engineer
Kitware Inc.
101 East Weaver Street
Carrboro, North Carolina
27510 USA

This communication, including all attachments, contains confidential and
legally privileged information, and it is intended only for the use of the
addressee.  Access to this email by anyone else is unauthorized. If you are
not the intended recipient, any disclosure, copying, distribution or any
action taken in reliance on it is prohibited and may be unlawful. If you
received this communication in error please notify us immediately and
destroy the original message.  Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://public.kitware.com/pipermail/vtk-developers/attachments/20180910/3cede482/attachment-0001.html>