[vtk-developers] double-conversion error in Windows

[Utkarsh Ayachit]

Andrew,

Strange stuff. Here's what I see
1. with VS2017 15.5.7, I get no such issues. (I don't want to update to
15.7.1 on my test machine yet since it builds the binaries and that often
means other issues).
2. if you look at  double-conversion.h header it's complaining about,
there's no `DC_DISALLOW_IMPLICIT_CONSTRUCTORS`, just
DISALLOW_IMPLICIT_CONSTRUCTORS, not sure where that mangling is  happening.

In any case, can you try the attached patch? Thanks

On Wed, May 9, 2018 at 12:01 AM Andrew Maclean <andrew.amaclean at gmail.com>
wrote:

> I'm just doing an upgrade to 15.7.1, if anything changes I'll let you
know.

> Regards
>     Andrew


> On Wed, May 9, 2018 at 1:48 PM Utkarsh Ayachit <
utkarsh.ayachit at kitware.com> wrote:

>> Roger that. Thanks. I'll give it a try tomorrow and see what's the issue.

>> Utkarsh
>> On Tue, May 8, 2018 at 11:24 PM Andrew Maclean <andrew.amaclean at gmail.com

>> wrote:


>> > Visual Studio Community 2017 Version 15.6.4

>> > On Wed, May 9, 2018 at 1:12 PM Utkarsh Ayachit <
>> utkarsh.ayachit at kitware.com> wrote:

>> >> Which compiler is this with?

>> >> Utkarsh
>> >> On Tue, May 8, 2018 at 9:47 PM Andrew Maclean <
andrew.amaclean at gmail.com>
>> >> wrote:

>> >> > My windows build is showing this error:




...\Development\Kitware\build\VTK-Debug\ThirdParty\doubleconversion\vtkdoubleconversion/double-conversion/double-conversion.h(377):
>> >> error C4430: missing type specifier - int assumed. Note: C++ does not
>> >> support default-int



...\Development\Kitware\build\VTK-Debug\ThirdParty\doubleconversion\vtkdoubleconversion/double-conversion/double-conversion.h(377):
>> >> warning C4183: 'DC_DISALLOW_IMPLICIT_CONSTRUCTORS': missing return
type;
>> >> assumed to be a member function returning 'int'



...\Development\Kitware\build\VTK-Debug\ThirdParty\doubleconversion\vtkdoubleconversion/double-conversion/double-conversion.h(541):
>> >> error C4430: missing type specifier - int assumed. Note: C++ does not
>> >> support default-int



...\Development\Kitware\build\VTK-Debug\ThirdParty\doubleconversion\vtkdoubleconversion/double-conversion/double-conversion.h(541):
>> >> warning C4183: 'DC_DISALLOW_IMPLICIT_CONSTRUCTORS': missing return
type;
>> >> assumed to be a member function returning 'int'

>> >> > I have done a clean and rebuild.

>> >> > Is anyone else seeing this?

>> >> > Regards
>> >> >     Andrew

>> >> > --
>> >> > ___________________________________________
>> >> > Andrew J. P. Maclean

>> >> > ___________________________________________
>> >> > _______________________________________________
>> >> > Powered by www.kitware.com

>> >> > Visit other Kitware open-source projects at
>> >> http://www.kitware.com/opensource/opensource.html

>> >> > Search the list archives at:
>> http://markmail.org/search/?q=vtk-developers

>> >> > Follow this link to subscribe/unsubscribe:
>> >> > https://vtk.org/mailman/listinfo/vtk-developers



>> > --
>> > ___________________________________________
>> > Andrew J. P. Maclean

>> > ___________________________________________



> --
> ___________________________________________
> Andrew J. P. Maclean

> ___________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: double-conversion.patch
Type: text/x-patch
Size: 654 bytes
Desc: not available
URL: <https://vtk.org/pipermail/vtk-developers/attachments/20180510/466a0caf/attachment.bin>