[vtk-developers] Two automatic clang-tidy changes to confirm...
Andrew Maclean
andrew.amaclean at gmail.com
Thu Mar 22 17:25:35 EDT 2018
Sean,
I think that these are very good changes.
"= default" makes the code more compact and readable.
Also by setting a minimum capacity, reserve() may even improve
performance.
Andrew
---------- Forwarded message ----------
> From: Sean McBride <sean at rogue-research.com>
> To: <vtk-developers at vtk.org>
> Cc:
> Bcc:
> Date: Thu, 22 Mar 2018 11:23:33 -0400
> Subject: [vtk-developers] Two automatic clang-tidy changes to confirm...
> Hi all,
>
> I've been playing with clang-tidy and there's two changes I want to
> confirm with everyone:
>
> 1) using "= default" on ctors and dtors:
>
> <https://gitlab.kitware.com/vtk/vtk/merge_requests/4092/diffs?commit_id=
> 84ec1d5757165643b34c2c1e35e84fe963cb8a14>
>
> 2) using reserve() before filling up a vector:
>
> <https://gitlab.kitware.com/vtk/vtk/merge_requests/4092/diffs?commit_id=
> 9266d8817c215f6ee588cfe2102a7152c96af3e7>
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng sean at rogue-research.com
> Rogue Research www.rogue-research.com
> Mac Software Developer Montréal, Québec, Canada
>
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/
> opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> https://vtk.org/mailman/listinfo/vtk-developers
>
>
--
___________________________________________
Andrew J. P. Maclean
___________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://vtk.org/pipermail/vtk-developers/attachments/20180323/8a99ed3b/attachment.html>
More information about the vtk-developers
mailing list