From bill.lorensen at gmail.com Thu Mar 1 10:06:55 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 07:06:55 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files Message-ID: Folks, I'm working on some examples to save/restore camera, polydata, property, etc. in XML files. The files can be saved as binary or ascii. If I save/restore the info in binary, I get the same values for the saved info. But, to no surprise, when I save the same data in ascii, I don't get the same values. This is because the file writing code does not write enough significant digits. In ITK we solved this problem many years ago. ITK uses a reduced version of the Google double-conversion library, https://github.com/google/double-conversion. We added a small class to ITK that uses the library. The class, itkNumberToString, has a simple API. To convert floating and fixed point numbers to ascii without numerical precision erros, For example, to convert a float, #include "itkNumberToString.h: itk::NumberToString convert; float a = 1.0f/3.0f; std::cout << convert(a) << std::endl; I propose a similar approach in VTK. Comments please, Bill From will.schroeder at kitware.com Thu Mar 1 10:36:47 2018 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 1 Mar 2018 10:36:47 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: If it works why mess with success? Where would this class (vtk NumberToString) be placed, in Common/Core (like vtkIndent) or in some IO directory like VTK/IO/Core? On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen wrote: > Folks, > > I'm working on some examples to save/restore camera, polydata, > property, etc. in XML files. The files can be saved as binary or > ascii. If I save/restore the info in binary, I get the same values for > the saved info. But, to no surprise, when I save the same data in > ascii, I don't get the same values. This is because the file writing > code does not write enough significant digits. > > In ITK we solved this problem many years ago. ITK uses a reduced > version of the Google double-conversion library, > https://github.com/google/double-conversion. > > We added a small class to ITK that uses the library. The class, > itkNumberToString, has a simple API. To convert floating and fixed > point numbers to ascii without numerical precision erros, > > For example, to convert a float, > #include "itkNumberToString.h: > itk::NumberToString convert; > float a = 1.0f/3.0f; > std::cout << convert(a) << std::endl; > > I propose a similar approach in VTK. > > Comments please, > > Bill > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From lasso at queensu.ca Thu Mar 1 10:42:10 2018 From: lasso at queensu.ca (Andras Lasso) Date: Thu, 1 Mar 2018 15:42:10 +0000 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: This would be very useful. Lack of precision in decimal strings written by VTK has caused problems several times. We ended up implementing various workarounds, such as using custom XML writer instead of VTK's and set the number of decimals to a large number. Your proposed solution would be much better: it would produce nicer file content, while ensuring that no information is lost. Andras -----Original Message----- From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of Bill Lorensen Sent: Thursday, March 1, 2018 10:07 AM To: VTK Developers Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files Folks, I'm working on some examples to save/restore camera, polydata, property, etc. in XML files. The files can be saved as binary or ascii. If I save/restore the info in binary, I get the same values for the saved info. But, to no surprise, when I save the same data in ascii, I don't get the same values. This is because the file writing code does not write enough significant digits. In ITK we solved this problem many years ago. ITK uses a reduced version of the Google double-conversion library, https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fdouble-conversion&data=02%7C01%7Classo%40queensu.ca%7C0d926d4a58ef424b435208d57f86156d%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636555136211177940&sdata=UnprTyNNEDtcE6ojCBrtz0gC8cHbBF%2FkRJP%2BUh9TDdQ%3D&reserved=0. We added a small class to ITK that uses the library. The class, itkNumberToString, has a simple API. To convert floating and fixed point numbers to ascii without numerical precision erros, For example, to convert a float, #include "itkNumberToString.h: itk::NumberToString convert; float a = 1.0f/3.0f; std::cout << convert(a) << std::endl; I propose a similar approach in VTK. Comments please, Bill _______________________________________________ Powered by https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&data=02%7C01%7Classo%40queensu.ca%7C0d926d4a58ef424b435208d57f86156d%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636555136211177940&sdata=Qlv1B4seLIxmirkXiApA4KMB1KsVj9oDfkxBZcx5%2FZE%3D&reserved=0 Visit other Kitware open-source projects at https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40queensu.ca%7C0d926d4a58ef424b435208d57f86156d%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636555136211177940&sdata=rrA48KPBb5EU8V5IdFuzDdCbIkZ0ff3AbHhuySyLFSs%3D&reserved=0 Search the list archives at: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queensu.ca%7C0d926d4a58ef424b435208d57f86156d%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636555136211177940&sdata=FqIUKRjcwQo8cgmaTCL28ZEvD%2F30ottePni8lBKS7lc%3D&reserved=0 Follow this link to subscribe/unsubscribe: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk.org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40queensu.ca%7C0d926d4a58ef424b435208d57f86156d%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636555136211177940&sdata=%2BJwRkYOZwcN%2FpXut5PaMYGbIMu94i%2FQgjhco%2FJNCEg4%3D&reserved=0 From bill.lorensen at gmail.com Thu Mar 1 10:48:49 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 07:48:49 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: Will, It would go in Common/Core I think. The vtk class would be very small. Bill On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder wrote: > If it works why mess with success? Where would this class > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in some IO > directory like VTK/IO/Core? > > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > wrote: >> >> Folks, >> >> I'm working on some examples to save/restore camera, polydata, >> property, etc. in XML files. The files can be saved as binary or >> ascii. If I save/restore the info in binary, I get the same values for >> the saved info. But, to no surprise, when I save the same data in >> ascii, I don't get the same values. This is because the file writing >> code does not write enough significant digits. >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> version of the Google double-conversion library, >> https://github.com/google/double-conversion. >> >> We added a small class to ITK that uses the library. The class, >> itkNumberToString, has a simple API. To convert floating and fixed >> point numbers to ascii without numerical precision erros, >> >> For example, to convert a float, >> #include "itkNumberToString.h: >> itk::NumberToString convert; >> float a = 1.0f/3.0f; >> std::cout << convert(a) << std::endl; >> >> I propose a similar approach in VTK. >> >> Comments please, >> >> Bill >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 -- Unpaid intern in BillsParadise at noware dot com From berk.geveci at kitware.com Thu Mar 1 10:59:05 2018 From: berk.geveci at kitware.com (Berk Geveci) Date: Thu, 1 Mar 2018 10:59:05 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: Given that this is IO specific, I would vote for IO/Core. No need to pollute Common/Core more than it already is (which is a lot IMO). On Thu, Mar 1, 2018 at 10:36 AM, Will Schroeder wrote: > If it works why mess with success? Where would this class (vtk > NumberToString) be placed, in Common/Core (like vtkIndent) or in some IO > directory like VTK/IO/Core? > > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > wrote: > >> Folks, >> >> I'm working on some examples to save/restore camera, polydata, >> property, etc. in XML files. The files can be saved as binary or >> ascii. If I save/restore the info in binary, I get the same values for >> the saved info. But, to no surprise, when I save the same data in >> ascii, I don't get the same values. This is because the file writing >> code does not write enough significant digits. >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> version of the Google double-conversion library, >> https://github.com/google/double-conversion. >> >> We added a small class to ITK that uses the library. The class, >> itkNumberToString, has a simple API. To convert floating and fixed >> point numbers to ascii without numerical precision erros, >> >> For example, to convert a float, >> #include "itkNumberToString.h: >> itk::NumberToString convert; >> float a = 1.0f/3.0f; >> std::cout << convert(a) << std::endl; >> >> I propose a similar approach in VTK. >> >> Comments please, >> >> Bill >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Mar 1 11:06:41 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 08:06:41 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: IO/Core will work unless we see uses elsewhere. Bill On Thu, Mar 1, 2018 at 7:59 AM, Berk Geveci wrote: > Given that this is IO specific, I would vote for IO/Core. No need to pollute > Common/Core more than it already is (which is a lot IMO). > > On Thu, Mar 1, 2018 at 10:36 AM, Will Schroeder > wrote: >> >> If it works why mess with success? Where would this class >> (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in some IO >> directory like VTK/IO/Core? >> >> On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen >> wrote: >>> >>> Folks, >>> >>> I'm working on some examples to save/restore camera, polydata, >>> property, etc. in XML files. The files can be saved as binary or >>> ascii. If I save/restore the info in binary, I get the same values for >>> the saved info. But, to no surprise, when I save the same data in >>> ascii, I don't get the same values. This is because the file writing >>> code does not write enough significant digits. >>> >>> In ITK we solved this problem many years ago. ITK uses a reduced >>> version of the Google double-conversion library, >>> https://github.com/google/double-conversion. >>> >>> We added a small class to ITK that uses the library. The class, >>> itkNumberToString, has a simple API. To convert floating and fixed >>> point numbers to ascii without numerical precision erros, >>> >>> For example, to convert a float, >>> #include "itkNumberToString.h: >>> itk::NumberToString convert; >>> float a = 1.0f/3.0f; >>> std::cout << convert(a) << std::endl; >>> >>> I propose a similar approach in VTK. >>> >>> Comments please, >>> >>> Bill >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtk-developers >>> >> >> >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> > -- Unpaid intern in BillsParadise at noware dot com From david.gobbi at gmail.com Thu Mar 1 11:32:49 2018 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 1 Mar 2018 09:32:49 -0700 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: I agree that floats should be printed so that conversion is lossless. Python's console output does this and I find it incredibly useful. Not sure if we need to add a new third-party library for this, though, especially one that duplicates so much of C++'s built-in machinery. Isn't it just a matter of printing enough digits? That's basically what I do in my own code (plus checks for isnan(x) and isinf(x), and a check of the size of fabs(x) for whether to force scientific notation.) - David On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen wrote: > Will, > > It would go in Common/Core I think. The vtk class would be very small. > > Bill > > On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder > wrote: > > If it works why mess with success? Where would this class > > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in > some IO > > directory like VTK/IO/Core? > > > > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > > wrote: > >> > >> Folks, > >> > >> I'm working on some examples to save/restore camera, polydata, > >> property, etc. in XML files. The files can be saved as binary or > >> ascii. If I save/restore the info in binary, I get the same values for > >> the saved info. But, to no surprise, when I save the same data in > >> ascii, I don't get the same values. This is because the file writing > >> code does not write enough significant digits. > >> > >> In ITK we solved this problem many years ago. ITK uses a reduced > >> version of the Google double-conversion library, > >> https://github.com/google/double-conversion. > >> > >> We added a small class to ITK that uses the library. The class, > >> itkNumberToString, has a simple API. To convert floating and fixed > >> point numbers to ascii without numerical precision erros, > >> > >> For example, to convert a float, > >> #include "itkNumberToString.h: > >> itk::NumberToString convert; > >> float a = 1.0f/3.0f; > >> std::cout << convert(a) << std::endl; > >> > >> I propose a similar approach in VTK. > >> > >> Comments please, > >> > >> Bill > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Mar 1 11:34:49 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 08:34:49 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: The library is very small. On Mar 1, 2018 8:33 AM, "David Gobbi" wrote: > I agree that floats should be printed so that conversion is lossless. > Python's console output does this and I find it incredibly useful. > > Not sure if we need to add a new third-party library for this, though, > especially one that duplicates so much of C++'s built-in machinery. > Isn't it just a matter of printing enough digits? That's basically what > I do in my own code (plus checks for isnan(x) and isinf(x), and a > check of the size of fabs(x) for whether to force scientific notation.) > > - David > > > On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen > wrote: > >> Will, >> >> It would go in Common/Core I think. The vtk class would be very small. >> >> Bill >> >> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >> wrote: >> > If it works why mess with success? Where would this class >> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in >> some IO >> > directory like VTK/IO/Core? >> > >> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > > >> > wrote: >> >> >> >> Folks, >> >> >> >> I'm working on some examples to save/restore camera, polydata, >> >> property, etc. in XML files. The files can be saved as binary or >> >> ascii. If I save/restore the info in binary, I get the same values for >> >> the saved info. But, to no surprise, when I save the same data in >> >> ascii, I don't get the same values. This is because the file writing >> >> code does not write enough significant digits. >> >> >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> >> version of the Google double-conversion library, >> >> https://github.com/google/double-conversion. >> >> >> >> We added a small class to ITK that uses the library. The class, >> >> itkNumberToString, has a simple API. To convert floating and fixed >> >> point numbers to ascii without numerical precision erros, >> >> >> >> For example, to convert a float, >> >> #include "itkNumberToString.h: >> >> itk::NumberToString convert; >> >> float a = 1.0f/3.0f; >> >> std::cout << convert(a) << std::endl; >> >> >> >> I propose a similar approach in VTK. >> >> >> >> Comments please, >> >> >> >> Bill >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Thu Mar 1 11:51:13 2018 From: sean at rogue-research.com (Sean McBride) Date: Thu, 1 Mar 2018 11:51:13 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: <20180301165113.826275313@mail.rogue-research.com> On Thu, 1 Mar 2018 09:32:49 -0700, David Gobbi said: >I agree that floats should be printed so that conversion is lossless. >Python's console output does this and I find it incredibly useful. > >Not sure if we need to add a new third-party library for this, though, >especially one that duplicates so much of C++'s built-in machinery. >Isn't it just a matter of printing enough digits? Yes, a nice article on the subject: Sean From bill.lorensen at gmail.com Thu Mar 1 12:06:13 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 09:06:13 -0800 Subject: [vtk-developers] Adding a third-party library Message-ID: I want to add a thirdparty library to VTK. I'm following the instructiions here: https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md I think I need permission to push to: https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md Bill -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Thu Mar 1 12:08:43 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 09:08:43 -0800 Subject: [vtk-developers] Adding a third-party library to VTK Message-ID: I'm following the instructions here: https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md I think I need permission to push to: https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md Bill -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Thu Mar 1 12:14:01 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 09:14:01 -0800 Subject: [vtk-developers] Adding a third party library to VTK Message-ID: I am trying to add a third party library following: https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md I need permission to push to https://gitlab.kitware.com/third-party Bill -- Unpaid intern in BillsParadise at noware dot com From ben.boeckel at kitware.com Thu Mar 1 13:29:39 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 1 Mar 2018 13:29:39 -0500 Subject: [vtk-developers] Adding a third party library to VTK In-Reply-To: References: Message-ID: <20180301182939.GA8173@megas.kitware.com> On Thu, Mar 01, 2018 at 09:14:01 -0800, Bill Lorensen wrote: > I am trying to add a third party library following: > https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md > > I need permission to push to > https://gitlab.kitware.com/third-party The instructions should mention this repo: https://gitlab.kitware.com/third-party/repo-requests specifically: https://gitlab.kitware.com/third-party/repo-requests/issues/new --Ben From utkarsh.ayachit at kitware.com Thu Mar 1 15:21:05 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 1 Mar 2018 15:21:05 -0500 Subject: [vtk-developers] Thoughts on changelog maintenance? In-Reply-To: <20171107191035.GA11652@rotor.kitware.com> References: <20171107191035.GA11652@rotor.kitware.com> Message-ID: Resurrecting this old thread, I'd like to voice my support for this. We've been using this mechanism for ParaView for the coming release, it was very easy to put together release notes than in the past. Utkarsh On Tue, Nov 7, 2017 at 2:10 PM, Ben Boeckel wrote: > Hi all, > > With 8.1.0 recently starting its RC cycle and the changelog request > emails being sent, what would thoughts be on having changelogs be part > of merge requests directly starting with the 9.0 development cycle? > > There are two general ways of doing this: > > - a single file that gets updated by each MR. > - a directory of files, one per changelog entry. > > The first is probably not fit for VTK due to the volume of changes that > it receives and it would be a never-ending cause of conflicts. The > latter would be either markdown or restructured text files. VTK seems to > have more `.md` files than others right now, so that would probably work > out better. How about putting them in `Documentation/release/dev`? > > The robot can warn (or enforce, but, IMO, that shouldn't be done) about > missing changelogs on a topic level. Would that be something that we > should enable? > > --Ben > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > From bill.lorensen at gmail.com Thu Mar 1 16:53:44 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 13:53:44 -0800 Subject: [vtk-developers] Adding a third party library to VTK In-Reply-To: <20180301182939.GA8173@megas.kitware.com> References: <20180301182939.GA8173@megas.kitware.com> Message-ID: When I run update.sh I get the error: error: pathspec 'for/vtk-old' did not match any file(s) known to git. On Thu, Mar 1, 2018 at 10:29 AM, Ben Boeckel wrote: > On Thu, Mar 01, 2018 at 09:14:01 -0800, Bill Lorensen wrote: >> I am trying to add a third party library following: >> https://gitlab.kitware.com/vtk/vtk/blob/master/ThirdParty/UPDATING.md >> >> I need permission to push to >> https://gitlab.kitware.com/third-party > > The instructions should mention this repo: > > https://gitlab.kitware.com/third-party/repo-requests > > specifically: > > https://gitlab.kitware.com/third-party/repo-requests/issues/new > > --Ben -- Unpaid intern in BillsParadise at noware dot com From nztoddler at yahoo.com Thu Mar 1 17:05:24 2018 From: nztoddler at yahoo.com (Todd) Date: Fri, 02 Mar 2018 11:05:24 +1300 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: Message-ID: <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Thu Mar 1 17:16:48 2018 From: nztoddler at yahoo.com (Todd) Date: Fri, 02 Mar 2018 11:16:48 +1300 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> Message-ID: <379f5ae6-7859-4dce-96ff-80090239c3ca@email.android.com> An HTML attachment was scrubbed... URL: From lasso at queensu.ca Thu Mar 1 17:19:51 2018 From: lasso at queensu.ca (Andras Lasso) Date: Thu, 1 Mar 2018 22:19:51 +0000 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> References: , <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> Message-ID: <529da48f-7943-421a-8e25-8e1c91dea534@queensu.ca> Base64 encoding is often not feasible or desirable. Usually you don't have the option to change a standard file format (metaimage, nrrd image file headers, ASCII STL files, CSV files, etc.). Andras ________________________________ From: Todd via vtk-developers Sent: Thursday, March 1, 2018 5:05 PM To: David Gobbi; vtk-developers at vtk.org Subject: Re: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files Can this not be simply achieved by base64 encoding the value as bytes and saving as a string? Isn't a float always 10 bytes? It is more verbose, but there would be no loss of precision. It looks like VTK already has base64 utilities, so another library would not be needed. On 2 Mar 2018 5:32 a.m., David Gobbi wrote: I agree that floats should be printed so that conversion is lossless. Python's console output does this and I find it incredibly useful. Not sure if we need to add a new third-party library for this, though, especially one that duplicates so much of C++'s built-in machinery. Isn't it just a matter of printing enough digits? That's basically what I do in my own code (plus checks for isnan(x) and isinf(x), and a check of the size of fabs(x) for whether to force scientific notation.) - David On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen > wrote: Will, It would go in Common/Core I think. The vtk class would be very small. Bill On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder > wrote: > If it works why mess with success? Where would this class > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in some IO > directory like VTK/IO/Core? > > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > > wrote: >> >> Folks, >> >> I'm working on some examples to save/restore camera, polydata, >> property, etc. in XML files. The files can be saved as binary or >> ascii. If I save/restore the info in binary, I get the same values for >> the saved info. But, to no surprise, when I save the same data in >> ascii, I don't get the same values. This is because the file writing >> code does not write enough significant digits. >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> version of the Google double-conversion library, >> https://github.com/google/double-conversion. >> >> We added a small class to ITK that uses the library. The class, >> itkNumberToString, has a simple API. To convert floating and fixed >> point numbers to ascii without numerical precision erros, >> >> For example, to convert a float, >> #include "itkNumberToString.h: >> itk::NumberToString convert; >> float a = 1.0f/3.0f; >> std::cout << convert(a) << std::endl; >> >> I propose a similar approach in VTK. >> >> Comments please, >> >> Bill -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Thu Mar 1 17:28:27 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 1 Mar 2018 17:28:27 -0500 Subject: [vtk-developers] Adding a third party library to VTK In-Reply-To: References: <20180301182939.GA8173@megas.kitware.com> Message-ID: <20180301222827.GA22812@rotor.kitware.com> On Thu, Mar 01, 2018 at 13:53:44 -0800, Bill Lorensen wrote: > When I run update.sh I get the error: > > error: pathspec 'for/vtk-old' did not match any file(s) known to git. That's controlled by the `tag=` variable in `update.sh`. Sorry, I forgot, you should update the third-party repo to use `for/vtk-old` as the branch name[1] (I'll make the `for/vtk` when I update the new module system's import of the project). --Ben [1]git push kitware for/vtk:refs/heads/for/vtk-old From ben.boeckel at kitware.com Thu Mar 1 17:30:00 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 1 Mar 2018 17:30:00 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> References: <7e8f6843-7f1d-4257-bc5a-2e18fc14caf8@email.android.com> Message-ID: <20180301223000.GB22812@rotor.kitware.com> On Fri, Mar 02, 2018 at 11:05:24 +1300, Todd via vtk-developers wrote: > Can this not be simply achieved by base64 encoding the value as bytes and > saving as a string? Isn't a float always 10 bytes? > > It is more verbose, but there would be no loss of precision. It looks like VTK > already has base64 utilities, so another library would not be needed. There is also the hexfloat format, but that has endian-ness issues, same as any other binary-in-ascii output. It is also likely to make files backwards-incompatible (older releases don't know how to read a hexfloat or base64-encoded float). --Ben From nztoddler at yahoo.com Thu Mar 1 17:30:39 2018 From: nztoddler at yahoo.com (Todd) Date: Fri, 02 Mar 2018 11:30:39 +1300 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <529da48f-7943-421a-8e25-8e1c91dea534@queensu.ca> Message-ID: An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Thu Mar 1 17:46:51 2018 From: nztoddler at yahoo.com (Todd) Date: Fri, 02 Mar 2018 11:46:51 +1300 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <20180301223000.GB22812@rotor.kitware.com> Message-ID: An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Mar 1 17:55:30 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 1 Mar 2018 14:55:30 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: <529da48f-7943-421a-8e25-8e1c91dea534@queensu.ca> Message-ID: Sometimes it us good to see the ascii values. On Mar 1, 2018 2:31 PM, "Todd via vtk-developers" wrote: Hi Andras I wasn't suggesting base64 encoding the whole file. Just the double/float values. On 2 Mar 2018 11:19 a.m., Andras Lasso wrote: Base64 encoding is often not feasible or desirable. Usually you don't have the option to change a standard file format (metaimage, nrrd image file headers, ASCII STL files, CSV files, etc.). Andras ------------------------------ *From:* Todd via vtk-developers *Sent:* Thursday, March 1, 2018 5:05 PM *To:* David Gobbi; vtk-developers at vtk.org *Subject:* Re: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files Can this not be simply achieved by base64 encoding the value as bytes and saving as a string? Isn't a float always 10 bytes? It is more verbose, but there would be no loss of precision. It looks like VTK already has base64 utilities, so another library would not be needed. On 2 Mar 2018 5:32 a.m., David Gobbi wrote: I agree that floats should be printed so that conversion is lossless. Python's console output does this and I find it incredibly useful. Not sure if we need to add a new third-party library for this, though, especially one that duplicates so much of C++'s built-in machinery. Isn't it just a matter of printing enough digits? That's basically what I do in my own code (plus checks for isnan(x) and isinf(x), and a check of the size of fabs(x) for whether to force scientific notation.) - David On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen wrote: Will, It would go in Common/Core I think. The vtk class would be very small. Bill On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder wrote: > If it works why mess with success? Where would this class > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in some IO > directory like VTK/IO/Core? > > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > wrote: >> >> Folks, >> >> I'm working on some examples to save/restore camera, polydata, >> property, etc. in XML files. The files can be saved as binary or >> ascii. If I save/restore the info in binary, I get the same values for >> the saved info. But, to no surprise, when I save the same data in >> ascii, I don't get the same values. This is because the file writing >> code does not write enough significant digits. >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> version of the Google double-conversion library, >> https://github.com/google/double-conversion . >> >> We added a small class to ITK that uses the library. The class, >> itkNumberToString, has a simple API. To convert floating and fixed >> point numbers to ascii without numerical precision erros, >> >> For example, to convert a float, >> #include "itkNumberToString.h: >> itk::NumberToString convert; >> float a = 1.0f/3.0f; >> std::cout << convert(a) << std::endl; >> >> I propose a similar approach in VTK. >> >> Comments please, >> >> Bill _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/ opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: https://vtk.org/mailman/listinfo/vtk-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Thu Mar 1 17:56:08 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 1 Mar 2018 17:56:08 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: <20180301223000.GB22812@rotor.kitware.com> Message-ID: <20180301225608.GA32463@megas.kitware.com> On Fri, Mar 02, 2018 at 11:46:51 +1300, Todd wrote: > I think the trick would be to choose either big or small endianess and always > save the values that way; then handle the conversion depending on the system. How does that allow for these new files to be written by VTK 8.0? --Ben From ben.boeckel at kitware.com Thu Mar 1 17:56:59 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 1 Mar 2018 17:56:59 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: <529da48f-7943-421a-8e25-8e1c91dea534@queensu.ca> Message-ID: <20180301225659.GB32463@megas.kitware.com> On Fri, Mar 02, 2018 at 11:30:39 +1300, Todd via vtk-developers wrote: > I wasn't suggesting base64 encoding the whole file. Just the double/float > values. That doesn't matter, it still changes the file format. --Ben From nztoddler at yahoo.com Thu Mar 1 18:05:58 2018 From: nztoddler at yahoo.com (Todd) Date: Fri, 02 Mar 2018 12:05:58 +1300 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: <20180301225659.GB32463@megas.kitware.com> Message-ID: An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri Mar 2 12:14:09 2018 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 2 Mar 2018 12:14:09 -0500 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: <20180301225659.GB32463@megas.kitware.com> Message-ID: There is a difference between what Bill is suggesting and using some sort of encoding. What Bill is suggesting will still result in human readable as well as generic parser parseable files. I had to look at the double-precision documentation to figure that out.... So Bill's suggestion should not prevent previous versions of the reader from reading new files and wouldn't require updating the format version as far as I understand. Best, -berk On Thu, Mar 1, 2018 at 6:05 PM, Todd via vtk-developers < vtk-developers at vtk.org> wrote: > Hi Ben > > On 2 Mar 2018 11:56 a.m., Ben Boeckel wrote: > > On Fri, Mar 02, 2018 at 11:30:39 +1300, Todd via vtk-developers wrote: > > I wasn't suggesting base64 encoding the whole file. Just the > double/float > > values. > > That doesn't matter, it still changes the file format. > > Yes. It changes the file format. So does Bill's proposal to use itk > NumberToString(). > > I guess the change would need to be limited to some VTK readers/writers > with an optional constructor parameter to utilise the new format. > > > --Ben > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Mar 2 14:56:13 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 2 Mar 2018 11:56:13 -0800 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: <20180301225659.GB32463@megas.kitware.com> Message-ID: +1 On Fri, Mar 2, 2018 at 9:14 AM, Berk Geveci wrote: > There is a difference between what Bill is suggesting and using some sort of > encoding. What Bill is suggesting will still result in human readable as > well as generic parser parseable files. I had to look at the > double-precision documentation to figure that out.... So Bill's suggestion > should not prevent previous versions of the reader from reading new files > and wouldn't require updating the format version as far as I understand. > > Best, > -berk > > > On Thu, Mar 1, 2018 at 6:05 PM, Todd via vtk-developers > wrote: >> >> Hi Ben >> >> On 2 Mar 2018 11:56 a.m., Ben Boeckel wrote: >> >> On Fri, Mar 02, 2018 at 11:30:39 +1300, Todd via vtk-developers wrote: >> > I wasn't suggesting base64 encoding the whole file. Just the >> > double/float >> > values. >> >> That doesn't matter, it still changes the file format. >> >> Yes. It changes the file format. So does Bill's proposal to use itk >> NumberToString(). >> >> I guess the change would need to be limited to some VTK readers/writers >> with an optional constructor parameter to utilise the new format. >> >> >> --Ben >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Fri Mar 2 23:54:07 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 2 Mar 2018 20:54:07 -0800 Subject: [vtk-developers] ThirdParty surprise Message-ID: I spent quite a while trying to figure out why my ThirdParty module's library was being built but not linked to by a module that used it. It turns out, third party module names cannot contain any uppercase characters. Surprise! Bill From bill.lorensen at gmail.com Sat Mar 3 11:28:25 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 3 Mar 2018 08:28:25 -0800 Subject: [vtk-developers] Progress on ascii representation of floats and doubles Message-ID: Folks, I'm making progress on using google's double-conversion library. An interesting result... On my Mac, For floats, a stream precision of 9 is needed for an exact conversion. For doubles, 17 is needed. The XML writers use a precision of 11 which is sufficient for floats but not doubles. I'll be submitting a WIP patch soon. Bill -- Unpaid intern in BillsParadise at noware dot com From ken.martin at kitware.com Mon Mar 5 08:54:11 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 5 Mar 2018 08:54:11 -0500 Subject: [vtk-developers] Wiki test failing In-Reply-To: <20180228184552.GA22661@megas.kitware.com> References: <20180228184552.GA22661@megas.kitware.com> Message-ID: If I understood that correctly, it seems the PCA based stuff is not deterministic in some cases now, so we need another valid image for that test. Bill is there any chance you could just add a second valid image for UtilitiesPCADemo with the following image? https://open.cdash.org/testDetails.php?test=631992789&build=5279900 On Wed, Feb 28, 2018 at 1:45 PM, Ben Boeckel wrote: > On Wed, Feb 28, 2018 at 12:54:39 -0500, Ken Martin wrote: > > I've noticed that the Wiki examples Utilities-PCADemo test has been > failing > > for some time on mun. Ring a bell with anyone? > > It only affects static (and maybe Windows) builds. Some information is > available on the MR which made the static builder work: > > https://gitlab.kitware.com/vtk/vtk/merge_requests/3900 > > David, if you don't have the time, we should probably just skip the test > on that machine. > > --Ben > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Mon Mar 5 09:11:19 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 5 Mar 2018 09:11:19 -0500 Subject: [vtk-developers] Wiki test failing In-Reply-To: References: <20180228184552.GA22661@megas.kitware.com> Message-ID: <20180305141119.GB28134@megas.kitware.com> On Mon, Mar 05, 2018 at 08:54:11 -0500, Ken Martin wrote: > If I understood that correctly, it seems the PCA based stuff is not > deterministic in some cases now, so we need another valid image for that > test. > > Bill is there any chance you could just add a second valid image for > UtilitiesPCADemo with the following image? > > https://open.cdash.org/testDetails.php?test=631992789&build=5279900 I'm pretty sure that's not a valid image though. I think the test may have been making assumptions about order or sign of results and isn't actually handling the results correctly. --Ben From bill.lorensen at gmail.com Mon Mar 5 09:31:27 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 5 Mar 2018 09:31:27 -0500 Subject: [vtk-developers] Wiki test failing In-Reply-To: References: <20180228184552.GA22661@megas.kitware.com> Message-ID: Yes, I'll add a second image. On Mar 5, 2018 5:54 AM, "Ken Martin" wrote: > If I understood that correctly, it seems the PCA based stuff is not > deterministic in some cases now, so we need another valid image for that > test. > > Bill is there any chance you could just add a second valid image for > UtilitiesPCADemo with the following image? > > https://open.cdash.org/testDetails.php?test=631992789&build=5279900 > > > On Wed, Feb 28, 2018 at 1:45 PM, Ben Boeckel > wrote: > >> On Wed, Feb 28, 2018 at 12:54:39 -0500, Ken Martin wrote: >> > I've noticed that the Wiki examples Utilities-PCADemo test has been >> failing >> > for some time on mun. Ring a bell with anyone? >> >> It only affects static (and maybe Windows) builds. Some information is >> available on the MR which made the static builder work: >> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/3900 >> >> David, if you don't have the time, we should probably just skip the test >> on that machine. >> >> --Ben >> > > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Mar 5 09:34:05 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 5 Mar 2018 09:34:05 -0500 Subject: [vtk-developers] Wiki test failing In-Reply-To: References: <20180228184552.GA22661@megas.kitware.com> Message-ID: Or remove the example if you think it is bad. I have no clue :-) I just see the red block on ctest and get freaked out :-) On Mon, Mar 5, 2018 at 9:31 AM, Bill Lorensen wrote: > Yes, I'll add a second image. > > On Mar 5, 2018 5:54 AM, "Ken Martin" wrote: > >> If I understood that correctly, it seems the PCA based stuff is not >> deterministic in some cases now, so we need another valid image for that >> test. >> >> Bill is there any chance you could just add a second valid image for >> UtilitiesPCADemo with the following image? >> >> https://open.cdash.org/testDetails.php?test=631992789&build=5279900 >> >> >> On Wed, Feb 28, 2018 at 1:45 PM, Ben Boeckel >> wrote: >> >>> On Wed, Feb 28, 2018 at 12:54:39 -0500, Ken Martin wrote: >>> > I've noticed that the Wiki examples Utilities-PCADemo test has been >>> failing >>> > for some time on mun. Ring a bell with anyone? >>> >>> It only affects static (and maybe Windows) builds. Some information is >>> available on the MR which made the static builder work: >>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/3900 >>> >>> David, if you don't have the time, we should probably just skip the test >>> on that machine. >>> >>> --Ben >>> >> >> >> >> -- >> Ken Martin PhD >> Distinguished Engineer >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> >> -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Mon Mar 5 10:04:29 2018 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 5 Mar 2018 10:04:29 -0500 Subject: [vtk-developers] ThirdParty surprise In-Reply-To: References: Message-ID: <20180305150429.GB31005@rotor> On Fri, Mar 02, 2018 at 20:54:07 -0800, Bill Lorensen wrote: > I spent quite a while trying to figure out why my ThirdParty module's > library was being built but not linked to by a module that used it. > > It turns out, third party module names cannot contain any uppercase > characters. > > Surprise! There's the `vtkVPIC` module?but it seems that it is doing module logic manually :( . --Ben From bill.lorensen at gmail.com Mon Mar 5 11:24:20 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 5 Mar 2018 08:24:20 -0800 Subject: [vtk-developers] [vtkusers] Error reading asci data. Possible mismatch of datasize with declaration In-Reply-To: References: Message-ID: Tensor data should have 9 entries per point. Your data has 3 entries per point On Mon, Mar 5, 2018 at 6:59 AM, Amine Aboufirass wrote: > Hello, > > > > I am trying to read a vtk unstructured grid file with tensor data in > paraview. I cannot for the life of me figure out why I am getting the > following error message: > > > > Error reading asci data. Possible mismatch of datasize with declaration. > > > > The problem is that I have actually counted up the points and the tensors > inside this file. It is apparent that it contains 1560 points and 4680 > corresponding tensor entries. I have attached the file above so that the > problem can be reproduced. > > > > Why am I getting the above error and how can I fix it? > > > > Thanks, > > > > Amine > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the VTK FAQ at: > http://www.vtk.org/Wiki/VTK_FAQ > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtkusers > -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Mon Mar 5 11:48:02 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 5 Mar 2018 08:48:02 -0800 Subject: [vtk-developers] [vtkusers] Error reading asci data. Possible mismatch of datasize with declaration In-Reply-To: References: Message-ID: Sorry, you have 6 entries per point. Tses are symetric tensors. Declare the type as TENSORS6 rather than TENSORS. Bill On Mon, Mar 5, 2018 at 8:24 AM, Bill Lorensen wrote: > Tensor data should have 9 entries per point. Your data has 3 entries per point > > > On Mon, Mar 5, 2018 at 6:59 AM, Amine Aboufirass > wrote: >> Hello, >> >> >> >> I am trying to read a vtk unstructured grid file with tensor data in >> paraview. I cannot for the life of me figure out why I am getting the >> following error message: >> >> >> >> Error reading asci data. Possible mismatch of datasize with declaration. >> >> >> >> The problem is that I have actually counted up the points and the tensors >> inside this file. It is apparent that it contains 1560 points and 4680 >> corresponding tensor entries. I have attached the file above so that the >> problem can be reproduced. >> >> >> >> Why am I getting the above error and how can I fix it? >> >> >> >> Thanks, >> >> >> >> Amine >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the VTK FAQ at: >> http://www.vtk.org/Wiki/VTK_FAQ >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtkusers >> > > > > -- > Unpaid intern in BillsParadise at noware dot com -- Unpaid intern in BillsParadise at noware dot com -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon Mar 5 11:49:56 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 5 Mar 2018 08:49:56 -0800 Subject: [vtk-developers] [vtkusers] Error reading asci data. Possible mismatch of datasize with declaration In-Reply-To: References: Message-ID: The error message says there is a mismatch in the number declared and the number present. On Mar 5, 2018 8:48 AM, "Bill Lorensen" wrote: > Sorry, you have 6 entries per point. Tses are symetric tensors. Declare > the type as TENSORS6 rather than TENSORS. > > Bill > > > On Mon, Mar 5, 2018 at 8:24 AM, Bill Lorensen > wrote: > > Tensor data should have 9 entries per point. Your data has 3 entries per > point > > > > > > On Mon, Mar 5, 2018 at 6:59 AM, Amine Aboufirass > > wrote: > >> Hello, > >> > >> > >> > >> I am trying to read a vtk unstructured grid file with tensor data in > >> paraview. I cannot for the life of me figure out why I am getting the > >> following error message: > >> > >> > >> > >> Error reading asci data. Possible mismatch of datasize with declaration. > >> > >> > >> > >> The problem is that I have actually counted up the points and the > tensors > >> inside this file. It is apparent that it contains 1560 points and 4680 > >> corresponding tensor entries. I have attached the file above so that the > >> problem can be reproduced. > >> > >> > >> > >> Why am I getting the above error and how can I fix it? > >> > >> > >> > >> Thanks, > >> > >> > >> > >> Amine > >> > >> > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Please keep messages on-topic and check the VTK FAQ at: > >> http://www.vtk.org/Wiki/VTK_FAQ > >> > >> Search the list archives at: http://markmail.org/search/?q=vtkusers > >> > >> Follow this link to subscribe/unsubscribe: > >> https://vtk.org/mailman/listinfo/vtkusers > >> > > > > > > > > -- > > Unpaid intern in BillsParadise at noware dot com > > > > -- > Unpaid intern in BillsParadise at noware dot com > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon Mar 5 11:56:17 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 5 Mar 2018 08:56:17 -0800 Subject: [vtk-developers] [vtkusers] Error reading asci data. Possible mismatch of datasize with declaration In-Reply-To: References: Message-ID: Ignore I previous responses. I miscalcuated. From jonathan.borduas at caboma.com Mon Mar 5 11:56:25 2018 From: jonathan.borduas at caboma.com (Jonathan Borduas) Date: Mon, 5 Mar 2018 16:56:25 +0000 Subject: [vtk-developers] Massive lag in a Pileline. Too complex pipeline ? Message-ID: Hi all, VTK pipelines are great, they allow to dynamically create a flow of algorithms. However, we recently encountered a massive lag in our pipeline related to the pipeline mechanisms (as opposed to the algorithms' calculation time). We are using a derivative of ParaView with homemade filters. We profiled our application in such a way that the profiling session started when all of the algorithms present in the pipeline had already been executed once and were up to date. The profiler pointed out two methods that were called a very significant amount of times while no updates were required on any of the algorithms of the pipeline. Those methods were: 1) vtkInformation::GetAsObjectBase(...) 2) vtkDemandDrivenPipeline::ComputePipelineMTime(...) This lag doesn't appear when only filters at the beginning of the pipeline are shown, but as we go down in the pipeline and show the outputs of filters, the lag become unbearable: We think this lag is caused by the number of inputs our filters have combined with the length and complexity of the pipeline. In the following, I will explain our line of thought and propose a way to solve our pipeline scalability problem. Demand Driven Pipelines for Representation: Our understanding is that a representation pipeline usually involves that the multiplicity of outputs is greater than the multiplicity of inputs. The pipeline fans out. This mean that the Update() process is rather fast and scalable. [cid:image001.jpg at 01D3B474.DFE725B0] In the previous picture, if filter 3 needs an Update(), only filter 0,1 and 3 will have a RequestData(). Demand Driven Pipeline for Modeling: However, in our case, we use VTK as a visualisation library as well as a mesh processing tool. To process mesh, you often need multiple inputs (boolean operations, points projections on a mesh...): the multiplicity of inputs is equivalent to the multiplicity of outputs. [cid:image002.jpg at 01D3B474.DFE725B0] If filter 8 needs an Update(), all filters Upstream will require to Update() except (6,3,1) With high input multiplicity, the Update() process, even with a distributed executive pipeline, will impact performance, creating a significant overhead. Demand Driven Pipeline with Event Driven Subsets: Here we suggest an improvement over the DemandDrivenPipeline by introducing Event Driven (push) subsets: [cid:image003.jpg at 01D3B474.DFE725B0] If Filter 8 needs an Update(), the signal will be passed to the subset and then to Filter0. Filter 2,4,5 and 7 are force to calculate in a Event-driven fashion. The overhead of the representation pipeline Update() when you have a high input multiplicity could be reduced with the creation of subsets of a pipeline. The subsets should be handled as Event Triggered Pipelines (Push Pipelines). A push subset could be considered like a filter that contains a small part of the pipeline and where all outputs execute a RequestData() using a Push Pipeline. We are aware of the vtkThreadedStreamingPipeline that had PUSH/PULL capability, however it is now legacy. Also, we do not require the threaded/scheduler capability of this pipeline model. An extended version of the vtkDemandDrivenPipeline with a Event Driven (pull) pipeline that would apply to a subset would be ideal. Please share your thoughts on creating such a pipeline. Please keep in mind that this suggestion has the goal to keep the pipeline's dynamism, we are aware that we could package the subset into a single filter. Thank you, Jonathan Borduas -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.jpg Type: image/jpeg Size: 5915 bytes Desc: image001.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image002.jpg Type: image/jpeg Size: 10479 bytes Desc: image002.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image003.jpg Type: image/jpeg Size: 14261 bytes Desc: image003.jpg URL: From will.schroeder at kitware.com Mon Mar 5 12:04:00 2018 From: will.schroeder at kitware.com (Will Schroeder) Date: Mon, 5 Mar 2018 12:04:00 -0500 Subject: [vtk-developers] Massive lag in a Pileline. Too complex pipeline ? In-Reply-To: References: Message-ID: Just a quick response off of the top of my head: vtkMapper::Static (i.e, SetStaticOn()) prevents the mapper from propagating updates down the pipeline. I have seen pipelines hacked as follows: executing them once, and then perform a local shallow copy of the resulting data into data object(s) (e.g., polydata) which is disconnected from the pipeline hence the updates are fast. I suspect there are more elegant ways but maybe this will get the conversation going... On Mon, Mar 5, 2018 at 11:56 AM, Jonathan Borduas < jonathan.borduas at caboma.com> wrote: > > > Hi all, > > > > VTK pipelines are great, they allow to dynamically create a flow of > algorithms. However, we recently encountered a massive lag in our pipeline > related to the pipeline mechanisms (as opposed to the algorithms? > calculation time). We are using a derivative of ParaView with homemade > filters. > > > > We profiled our application in such a way that the profiling session > started when all of the algorithms present in the pipeline had already been > executed once and were up to date. The profiler pointed out two methods > that were called a very significant amount of times while no updates > were required on any of the algorithms of the pipeline. Those methods were: > > > > 1) vtkInformation::GetAsObjectBase(...) > > 2) vtkDemandDrivenPipeline::ComputePipelineMTime(...) > > > > This lag doesn?t appear when only filters at the beginning of the pipeline > are shown, but as we go down in the pipeline and show the outputs of > filters, the lag become unbearable: > > > > We think this lag is caused by the number of inputs our filters have > combined with the length and complexity of the pipeline. In the following, > I will explain our line of thought and propose a way to solve our pipeline > scalability problem. > > > > *Demand Driven Pipelines for Representation:* > > Our understanding is that a representation pipeline usually involves that > the multiplicity of outputs* is greater than* the multiplicity of inputs. > The pipeline fans out. This mean that the Update() process is rather fast > and scalable. > > > > > In the previous picture, if filter 3 needs an Update(), only filter 0,1 > and 3 will have a RequestData(). > > > > *Demand Driven Pipeline for Modeling:* > > However, in our case, we use VTK as a visualisation library as well as a > mesh processing tool. To process mesh, you often need multiple inputs > (boolean operations, points projections on a mesh?): the multiplicity of > inputs is *equivalent *to the multiplicity of outputs. > > If filter 8 needs an Update(), all filters Upstream will require to > Update() except (6,3,1) > > With high input multiplicity, the Update() process, even with a > distributed executive pipeline, will impact performance, creating a > significant overhead. > > > > *Demand Driven Pipeline with Event Driven Subsets:* > > Here we suggest an improvement over the DemandDrivenPipeline by > introducing Event Driven (push) subsets: > > > > > If Filter 8 needs an Update(), the signal will be passed to the subset and > then to Filter0. Filter 2,4,5 and 7 are force to calculate in a > Event-driven fashion. > > > > The overhead of the representation pipeline Update() when you have a high > input multiplicity could be reduced with the creation of subsets of a > pipeline. The subsets should be handled as Event Triggered Pipelines (Push > Pipelines). > > A push subset could be considered like a filter that contains a small part > of the pipeline and where all outputs execute a RequestData() using a Push > Pipeline. > > > > We are aware of the vtkThreadedStreamingPipeline that had PUSH/PULL > capability, however it is now legacy. Also, we do not require the > threaded/scheduler capability of this pipeline model. An extended version > of the vtkDemandDrivenPipeline with a Event Driven (pull) pipeline that > would apply to a subset would be ideal. > > > > Please share your thoughts on creating such a pipeline. Please keep in > mind that this suggestion has the goal to keep the pipeline?s dynamism, we > are aware that we could package the subset into a single filter. > > Thank you, > > Jonathan Borduas > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.jpg Type: image/jpeg Size: 5915 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image003.jpg Type: image/jpeg Size: 14261 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image002.jpg Type: image/jpeg Size: 10479 bytes Desc: not available URL: From amine.aboufirass at gmail.com Mon Mar 5 12:10:21 2018 From: amine.aboufirass at gmail.com (Amine Aboufirass) Date: Mon, 5 Mar 2018 18:10:21 +0100 Subject: [vtk-developers] [vtkusers] Error reading asci data. Possible mismatch of datasize with declaration In-Reply-To: References: Message-ID: There are 9 tensor components. It is a true tensor On Mon, Mar 5, 2018 at 5:56 PM, Bill Lorensen wrote: > Ignore I previous responses. I miscalcuated. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Mar 5 12:56:23 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 5 Mar 2018 12:56:23 -0500 Subject: [vtk-developers] Massive lag in a Pileline. Too complex pipeline ? In-Reply-To: References: Message-ID: For VTK there is no need to disconnect. In fact mapper->StaticOn() is faster than disconnecting once you have rendered once I believe. Also if you know your data is opaque setting ForceOpaqueOn() helps as well. With just those two settings on VTK master I can get 10000 actors rendering at a rate of 11 fps on a laptop. For VTK I really do believe some of the core information object pipeline stuff needs to be reworked. Simple calls like GetInputObject take a huge % of time and create multiple objects on the heap per call etc. ParaView is a different beast as it has GUI etc. On Mon, Mar 5, 2018 at 12:04 PM, Will Schroeder wrote: > Just a quick response off of the top of my head: > > vtkMapper::Static (i.e, SetStaticOn()) prevents the mapper from > propagating updates down the pipeline. > > I have seen pipelines hacked as follows: executing them once, and then > perform a local shallow copy of the resulting data into data object(s) > (e.g., polydata) which is disconnected from the pipeline hence the updates > are fast. > > I suspect there are more elegant ways but maybe this will get the > conversation going... > > > > On Mon, Mar 5, 2018 at 11:56 AM, Jonathan Borduas < > jonathan.borduas at caboma.com> wrote: > >> >> >> Hi all, >> >> >> >> VTK pipelines are great, they allow to dynamically create a flow of >> algorithms. However, we recently encountered a massive lag in our pipeline >> related to the pipeline mechanisms (as opposed to the algorithms? >> calculation time). We are using a derivative of ParaView with homemade >> filters. >> >> >> >> We profiled our application in such a way that the profiling session >> started when all of the algorithms present in the pipeline had already been >> executed once and were up to date. The profiler pointed out two methods >> that were called a very significant amount of times while no updates >> were required on any of the algorithms of the pipeline. Those methods were: >> >> >> >> 1) vtkInformation::GetAsObjectBase(...) >> >> 2) vtkDemandDrivenPipeline::ComputePipelineMTime(...) >> >> >> >> This lag doesn?t appear when only filters at the beginning of the >> pipeline are shown, but as we go down in the pipeline and show the outputs >> of filters, the lag become unbearable: >> >> >> >> We think this lag is caused by the number of inputs our filters have >> combined with the length and complexity of the pipeline. In the following, >> I will explain our line of thought and propose a way to solve our pipeline >> scalability problem. >> >> >> >> *Demand Driven Pipelines for Representation:* >> >> Our understanding is that a representation pipeline usually involves that >> the multiplicity of outputs* is greater than* the multiplicity of >> inputs. The pipeline fans out. This mean that the Update() process is >> rather fast and scalable. >> >> >> >> >> In the previous picture, if filter 3 needs an Update(), only filter 0,1 >> and 3 will have a RequestData(). >> >> >> >> *Demand Driven Pipeline for Modeling:* >> >> However, in our case, we use VTK as a visualisation library as well as a >> mesh processing tool. To process mesh, you often need multiple inputs >> (boolean operations, points projections on a mesh?): the multiplicity of >> inputs is *equivalent *to the multiplicity of outputs. >> >> If filter 8 needs an Update(), all filters Upstream will require to >> Update() except (6,3,1) >> >> With high input multiplicity, the Update() process, even with a >> distributed executive pipeline, will impact performance, creating a >> significant overhead. >> >> >> >> *Demand Driven Pipeline with Event Driven Subsets:* >> >> Here we suggest an improvement over the DemandDrivenPipeline by >> introducing Event Driven (push) subsets: >> >> >> >> >> If Filter 8 needs an Update(), the signal will be passed to the subset >> and then to Filter0. Filter 2,4,5 and 7 are force to calculate in a >> Event-driven fashion. >> >> >> >> The overhead of the representation pipeline Update() when you have a high >> input multiplicity could be reduced with the creation of subsets of a >> pipeline. The subsets should be handled as Event Triggered Pipelines (Push >> Pipelines). >> >> A push subset could be considered like a filter that contains a small >> part of the pipeline and where all outputs execute a RequestData() using a >> Push Pipeline. >> >> >> >> We are aware of the vtkThreadedStreamingPipeline that had PUSH/PULL >> capability, however it is now legacy. Also, we do not require the >> threaded/scheduler capability of this pipeline model. An extended version >> of the vtkDemandDrivenPipeline with a Event Driven (pull) pipeline that >> would apply to a subset would be ideal. >> >> >> >> Please share your thoughts on creating such a pipeline. Please keep in >> mind that this suggestion has the goal to keep the pipeline?s dynamism, we >> are aware that we could package the subset into a single filter. >> >> Thank you, >> >> Jonathan Borduas >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> >> > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.jpg Type: image/jpeg Size: 5915 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image003.jpg Type: image/jpeg Size: 14261 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image002.jpg Type: image/jpeg Size: 10479 bytes Desc: not available URL: From jonathan.borduas at caboma.com Mon Mar 5 14:56:05 2018 From: jonathan.borduas at caboma.com (Jonathan Borduas) Date: Mon, 5 Mar 2018 19:56:05 +0000 Subject: [vtk-developers] Massive lag in a Pileline. Too complex pipeline ? In-Reply-To: References: Message-ID: Hi all, Thank you greatly for your responses. Well I do agree ParaView is a different beast, but I have seen no problem in scaling with the number of actors (except maybe when loading a StateFile). I?m will take a look at mapper->StaticOn(), but I?m afraid the problem will now be of determining when a mapper should be static and when it should be dynamic. A more automated principle would be welcome. Jonathan Borduas From: Ken Martin [mailto:ken.martin at kitware.com] Sent: March 5, 2018 12:56 PM To: Will Schroeder Cc: Jonathan Borduas ; vtk-developers at vtk.org Subject: Re: [vtk-developers] Massive lag in a Pileline. Too complex pipeline ? For VTK there is no need to disconnect. In fact mapper->StaticOn() is faster than disconnecting once you have rendered once I believe. Also if you know your data is opaque setting ForceOpaqueOn() helps as well. With just those two settings on VTK master I can get 10000 actors rendering at a rate of 11 fps on a laptop. For VTK I really do believe some of the core information object pipeline stuff needs to be reworked. Simple calls like GetInputObject take a huge % of time and create multiple objects on the heap per call etc. ParaView is a different beast as it has GUI etc. On Mon, Mar 5, 2018 at 12:04 PM, Will Schroeder > wrote: Just a quick response off of the top of my head: vtkMapper::Static (i.e, SetStaticOn()) prevents the mapper from propagating updates down the pipeline. I have seen pipelines hacked as follows: executing them once, and then perform a local shallow copy of the resulting data into data object(s) (e.g., polydata) which is disconnected from the pipeline hence the updates are fast. I suspect there are more elegant ways but maybe this will get the conversation going... On Mon, Mar 5, 2018 at 11:56 AM, Jonathan Borduas > wrote: Hi all, VTK pipelines are great, they allow to dynamically create a flow of algorithms. However, we recently encountered a massive lag in our pipeline related to the pipeline mechanisms (as opposed to the algorithms? calculation time). We are using a derivative of ParaView with homemade filters. We profiled our application in such a way that the profiling session started when all of the algorithms present in the pipeline had already been executed once and were up to date. The profiler pointed out two methods that were called a very significant amount of times while no updates were required on any of the algorithms of the pipeline. Those methods were: 1) vtkInformation::GetAsObjectBase(...) 2) vtkDemandDrivenPipeline::ComputePipelineMTime(...) This lag doesn?t appear when only filters at the beginning of the pipeline are shown, but as we go down in the pipeline and show the outputs of filters, the lag become unbearable: We think this lag is caused by the number of inputs our filters have combined with the length and complexity of the pipeline. In the following, I will explain our line of thought and propose a way to solve our pipeline scalability problem. Demand Driven Pipelines for Representation: Our understanding is that a representation pipeline usually involves that the multiplicity of outputs is greater than the multiplicity of inputs. The pipeline fans out. This mean that the Update() process is rather fast and scalable. [cid:image001.jpg at 01D3B489.338F1290] In the previous picture, if filter 3 needs an Update(), only filter 0,1 and 3 will have a RequestData(). Demand Driven Pipeline for Modeling: However, in our case, we use VTK as a visualisation library as well as a mesh processing tool. To process mesh, you often need multiple inputs (boolean operations, points projections on a mesh?): the multiplicity of inputs is equivalent to the multiplicity of outputs. [cid:image002.jpg at 01D3B489.338F1290] If filter 8 needs an Update(), all filters Upstream will require to Update() except (6,3,1) With high input multiplicity, the Update() process, even with a distributed executive pipeline, will impact performance, creating a significant overhead. Demand Driven Pipeline with Event Driven Subsets: Here we suggest an improvement over the DemandDrivenPipeline by introducing Event Driven (push) subsets: [cid:image003.jpg at 01D3B489.338F1290] If Filter 8 needs an Update(), the signal will be passed to the subset and then to Filter0. Filter 2,4,5 and 7 are force to calculate in a Event-driven fashion. The overhead of the representation pipeline Update() when you have a high input multiplicity could be reduced with the creation of subsets of a pipeline. The subsets should be handled as Event Triggered Pipelines (Push Pipelines). A push subset could be considered like a filter that contains a small part of the pipeline and where all outputs execute a RequestData() using a Push Pipeline. We are aware of the vtkThreadedStreamingPipeline that had PUSH/PULL capability, however it is now legacy. Also, we do not require the threaded/scheduler capability of this pipeline model. An extended version of the vtkDemandDrivenPipeline with a Event Driven (pull) pipeline that would apply to a subset would be ideal. Please share your thoughts on creating such a pipeline. Please keep in mind that this suggestion has the goal to keep the pipeline?s dynamism, we are aware that we could package the subset into a single filter. Thank you, Jonathan Borduas _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: https://vtk.org/mailman/listinfo/vtk-developers -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: https://vtk.org/mailman/listinfo/vtk-developers -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.jpg Type: image/jpeg Size: 5915 bytes Desc: image001.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image002.jpg Type: image/jpeg Size: 10479 bytes Desc: image002.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image003.jpg Type: image/jpeg Size: 14261 bytes Desc: image003.jpg URL: From amine.aboufirass at gmail.com Tue Mar 6 07:29:02 2018 From: amine.aboufirass at gmail.com (Amine Aboufirass) Date: Tue, 6 Mar 2018 13:29:02 +0100 Subject: [vtk-developers] Rendering and saving unstructured grid mesh to image file Message-ID: Dear all, I have an unstructured grid cell data file which I would like to render and then save to a png image. I made use of available examples to generate a python code which I have attached below. The file I am using this with is also attached. The rendering seems to work but I am not sure why it cannot send the render window content to an image. It keeps giving me the following error: ?!: libpng warning: Image width is zero in IHDR ?!: libpng warning: Image height is zero in IHDR I'm not sure what is causing this, I followed the documentation to the best of my ability but still can't figure it out. Could anyone please help? Thanks Amine -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- from vtk import * # The source file file_name = 'MeshData.vtk'#"MeshData.vtk" # Read the source file. reader = vtkUnstructuredGridReader() reader.SetFileName(file_name) reader.Update() # Needed because of GetScalarRange output = reader.GetOutput() #scalar_range = output.GetScalarRange() # Create the mapper that corresponds the objects of the vtk file # into graphics elements mapper = vtkDataSetMapper() mapper.SetInputData(output) #mapper.SetScalarRange(scalar_range) # Create the Actor actor = vtkActor() actor.GetProperty().SetRepresentationToWireframe() actor.SetMapper(mapper) # Create the Renderer renderer = vtkRenderer() renderer.AddActor(actor) renderer.SetBackground(1, 1, 1) # Set background to white # Create the RendererWindow renderer_window = vtkRenderWindow() renderer_window.AddRenderer(renderer) #Image https://www.vtk.org/Wiki/VTK/Examples/Python/Screenshot w2if = vtk.vtkWindowToImageFilter() w2if.SetInput(renderer_window) w2if.Update() writer = vtk.vtkPNGWriter() writer.SetFileName("screenshot.png") writer.SetInputData(w2if.GetOutput()) writer.Write() # Create the RendererWindowInteractor and display the vtk_file #interactor = vtkRenderWindowInteractor() #interactor.SetRenderWindow(renderer_window) #interactor.Initialize() #interactor.Start() # -------------- next part -------------- A non-text attachment was scrubbed... Name: MeshData.vtk Type: application/octet-stream Size: 566142 bytes Desc: not available URL: From bill.lorensen at gmail.com Wed Mar 7 20:25:01 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 7 Mar 2018 17:25:01 -0800 Subject: [vtk-developers] Gitlab not running tests Message-ID: Gitlab is not performing Do: test. Stopped about 16 hours ago. Bill From bill.lorensen at gmail.com Wed Mar 7 22:24:52 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 7 Mar 2018 22:24:52 -0500 Subject: [vtk-developers] Gitlab not running tests In-Reply-To: References: Message-ID: looks like things are working again... On Wed, Mar 7, 2018 at 8:25 PM, Bill Lorensen wrote: > Gitlab is not performing Do: test. > > Stopped about 16 hours ago. > > Bill -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Thu Mar 8 14:23:25 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 8 Mar 2018 11:23:25 -0800 Subject: [vtk-developers] Command summary for gitlab testing Message-ID: Folks, Is there a summary of the command for gitlab testing. Do: test and others. I'd like to just run windows tests if possible. Or a specific machine/configuration I'm having problems with. Thanks, Bill From ken.martin at kitware.com Thu Mar 8 14:30:21 2018 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 8 Mar 2018 14:30:21 -0500 Subject: [vtk-developers] Command summary for gitlab testing In-Reply-To: References: Message-ID: Do: help and Do: test --help On Thu, Mar 8, 2018 at 2:23 PM, Bill Lorensen wrote: > Folks, > > Is there a summary of the command for gitlab testing. > > Do: test > > and others. > > I'd like to just run windows tests if possible. > > Or a specific machine/configuration I'm having problems with. > > Thanks, > > Bill > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Fri Mar 9 17:50:31 2018 From: sean at rogue-research.com (Sean McBride) Date: Fri, 9 Mar 2018 17:50:31 -0500 Subject: [vtk-developers] Changes to my cppcheck dashboards Message-ID: <20180309225031.144356034@mail.rogue-research.com> Hi all, This MR: changes how I suppress some cppcheck warnings. Previously the below warnings were suppressed everywhere, now they are only suppressed in the files that already have such warnings. This means any new files, and currently warning-free files, will now be checked for these warnings: - uninitMemberVar: uninitialized member variables - cstyleCast: C-style casts - unreadVariable: never reading a value written to a variable - noCopyConstructor: class without copy ctor that contains a pointer to allocated memory - useInitializationList: variable assigned in ctor body instead of initialization list - copyCtorAndEqOperator: when a class has copy ctor but lacks operator= If this gets to be noisy or otherwise undesirable, we can adjust... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From behollis at soe.ucsc.edu Sun Mar 11 20:32:10 2018 From: behollis at soe.ucsc.edu (Brad Eric hollister) Date: Sun, 11 Mar 2018 17:32:10 -0700 Subject: [vtk-developers] Decorator Pattern in VTK Message-ID: Hi, I?m preparing a short talk on the decorator pattern for classroom instruction. I?d like to use an example from VTK. Are there any such examples in the codebase? Regards, Brad Sent from my iPad -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Sun Mar 11 22:49:45 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sun, 11 Mar 2018 19:49:45 -0700 Subject: [vtk-developers] Decorator Pattern in VTK In-Reply-To: References: Message-ID: If I recall correctly, ITK has decorators. https://itk.org/Doxygen/html/classitk_1_1DataObjectDecorator.html On Mar 11, 2018 5:32 PM, "Brad Eric hollister" wrote: > Hi, > > I?m preparing a short talk on the decorator pattern for classroom > instruction. > > I?d like to use an example from VTK. Are there any such examples in the > codebase? > > Regards, > Brad > > Sent from my iPad > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Tue Mar 13 10:35:17 2018 From: sean at rogue-research.com (Sean McBride) Date: Tue, 13 Mar 2018 10:35:17 -0400 Subject: [vtk-developers] Changes to my cppcheck dashboards In-Reply-To: <20180309225031.144356034@mail.rogue-research.com> References: <20180309225031.144356034@mail.rogue-research.com> Message-ID: <20180313143517.847914308@mail.rogue-research.com> On Fri, 9 Mar 2018 17:50:31 -0500, Sean McBride said: >changes how I suppress some cppcheck warnings. Previously the below >warnings were suppressed everywhere, now they are only suppressed in the >files that already have such warnings. This means any new files, and >currently warning-free files, will now be checked for these warnings: > >- uninitMemberVar: uninitialized member variables >- cstyleCast: C-style casts >- unreadVariable: never reading a value written to a variable >- noCopyConstructor: class without copy ctor that contains a pointer to >allocated memory >- useInitializationList: variable assigned in ctor body instead of >initialization list >- copyCtorAndEqOperator: when a class has copy ctor but lacks operator= > >If this gets to be noisy or otherwise undesirable, we can adjust... So today for example: The (new?) file vtkAMReXParticlesReader.cxx has warnings about uninitialized ivars. I seem to recall VTK having a policy of initing ivars, is that the case? I couldn't actually find it in the coding style doc. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From ken.martin at kitware.com Thu Mar 15 10:32:03 2018 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 15 Mar 2018 10:32:03 -0400 Subject: [vtk-developers] Handling System that lack OpenGL 3.2 (on windows) Message-ID: With some help (thanks!) I have added some support for dynamically testing for OpenGL 3.2 support and then selecting Mesa software rendering when needed. It is part of this commit https://gitlab.kitware.com/vtk/vtk/commit/29607014a2dea0931ff30c0b584b25f760233245 The basic approach is as follows 1) Build VTK with the advanced cmake option VTK_USE_OPENGL_DELAYED_LOAD turned on. 2) Include vtkTestOpenGLVersion.h in your application and call HandleOpenGL32Issues before you do any rendering or anything that would cause opengl to be used. Ideally do this right at the beginning of your program. 3) Make sure you include vtkTestOpenGLVersion.exe with your application and pass the fullpath to it as the first argument to HandleOpenGL32Issues 4) Make sure you include the Mesa libraries with your application. Typically this means opengl32.dll swrAVX.dll swrAVX2.dll and graw.dll. Pass the path to these libraries as the second argument to HandleOpenGL32Issues Hope this proves useful for those that need to support remote desktop or older computers etc. Thanks! Ken -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Tue Mar 20 05:22:02 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Tue, 20 Mar 2018 10:22:02 +0100 Subject: [vtk-developers] Removed VTK class still present in the online doc Message-ID: Hello one can access https://www.vtk.org/doc/nightly/html/classvtkQImageToImageSource.html which is the vtkQImageToImageSource class documentation. This class does not exist anymore. This is not the only one. Should I open an issue on VTK gitlab ? Best regards, Mathieu Westphal -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Tue Mar 20 05:26:14 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Tue, 20 Mar 2018 10:26:14 +0100 Subject: [vtk-developers] Removed VTK class still present in the online doc In-Reply-To: References: Message-ID: Please ignore this mail, sorry for the noise. Mathieu Westphal On Tue, Mar 20, 2018 at 10:22 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > Hello > > one can access https://www.vtk.org/doc/nightly/html/ > classvtkQImageToImageSource.html > which is the vtkQImageToImageSource class documentation. > > This class does not exist anymore. This is not the only one. > > Should I open an issue on VTK gitlab ? > > Best regards, > > Mathieu Westphal > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Tue Mar 20 13:31:02 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 20 Mar 2018 10:31:02 -0700 Subject: [vtk-developers] ANN: VTKExamples adds Shader example Message-ID: We are excited to announce that we have added several examples that show how to use vtkShaders to generate exciting images. Each of the new examples modifies the existing vtkOpenGLPolyData pipeline. We hope that these examples will stimulate interest and usage of this advanced capability. The new examples are here: https://lorensen.github.io/VTKExamples/site/Cxx/#shaders As always we ask you to contribute to the grassroots effort to make VTK more understandable and exciting. See: https://lorensen.github.io/VTKExamples/site/Instructions/ForDevelopers/ Andrew Maclean and I will be happy to get you started. Stay tuned, we will be adding more examples in the next weeks. -- Unpaid intern in BillsParadise at noware dot com From dave.demarle at kitware.com Wed Mar 21 14:45:56 2018 From: dave.demarle at kitware.com (David E DeMarle) Date: Wed, 21 Mar 2018 14:45:56 -0400 Subject: [vtk-developers] gitlab down for 30 mins to an hour Message-ID: Passing along a note from kitware sysadmin about downtime for a critical security patch. It should be back up before you know it. thanks for the patience David E DeMarle Kitware, Inc. Principal Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 -------------- next part -------------- An HTML attachment was scrubbed... URL: From isaiah.norton at gmail.com Wed Mar 21 17:08:16 2018 From: isaiah.norton at gmail.com (Isaiah Norton) Date: Wed, 21 Mar 2018 17:08:16 -0400 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: +1. I needed this recently in Slicer, and ended up using ITK's version because we link it anyway. > Not sure if we need to add a new third-party library for this, though, > especially one that duplicates so much of C++'s built-in machinery. > Grisu3 (double-conversion) appears to be ~13x faster than the C++ stream functions (and 6x faster than sprintf): https://github.com/miloyip/dtoa-benchmark Those numbers are on VS2013/Windows, but that code is easy to build locally. The sprintf vs double-conversion conclusion holds on 2015 macbook with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. [usual benchmark NaCl disclaimer here] On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi wrote: > I agree that floats should be printed so that conversion is lossless. > Python's console output does this and I find it incredibly useful. > > Not sure if we need to add a new third-party library for this, though, > especially one that duplicates so much of C++'s built-in machinery. > Isn't it just a matter of printing enough digits? That's basically what > I do in my own code (plus checks for isnan(x) and isinf(x), and a > check of the size of fabs(x) for whether to force scientific notation.) > > - David > > > On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen > wrote: > >> Will, >> >> It would go in Common/Core I think. The vtk class would be very small. >> >> Bill >> >> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >> wrote: >> > If it works why mess with success? Where would this class >> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in >> some IO >> > directory like VTK/IO/Core? >> > >> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen > > >> > wrote: >> >> >> >> Folks, >> >> >> >> I'm working on some examples to save/restore camera, polydata, >> >> property, etc. in XML files. The files can be saved as binary or >> >> ascii. If I save/restore the info in binary, I get the same values for >> >> the saved info. But, to no surprise, when I save the same data in >> >> ascii, I don't get the same values. This is because the file writing >> >> code does not write enough significant digits. >> >> >> >> In ITK we solved this problem many years ago. ITK uses a reduced >> >> version of the Google double-conversion library, >> >> https://github.com/google/double-conversion. >> >> >> >> We added a small class to ITK that uses the library. The class, >> >> itkNumberToString, has a simple API. To convert floating and fixed >> >> point numbers to ascii without numerical precision erros, >> >> >> >> For example, to convert a float, >> >> #include "itkNumberToString.h: >> >> itk::NumberToString convert; >> >> float a = 1.0f/3.0f; >> >> std::cout << convert(a) << std::endl; >> >> >> >> I propose a similar approach in VTK. >> >> >> >> Comments please, >> >> >> >> Bill >> > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Wed Mar 21 20:10:11 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 21 Mar 2018 17:10:11 -0700 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: I'm still working in the MR. It works great but I'm having cmake issues on Windows. Adding a new third party library is tricky. On Mar 21, 2018 2:08 PM, "Isaiah Norton" wrote: > +1. I needed this recently in Slicer, and ended up using ITK's version > because we link it anyway. > > >> Not sure if we need to add a new third-party library for this, though, >> especially one that duplicates so much of C++'s built-in machinery. >> > > Grisu3 (double-conversion) appears to be ~13x faster than the C++ stream > functions (and 6x faster than sprintf): > > https://github.com/miloyip/dtoa-benchmark > > Those numbers are on VS2013/Windows, but that code is easy to build > locally. The sprintf vs double-conversion conclusion holds on 2015 macbook > with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. > > [usual benchmark NaCl disclaimer here] > > On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi > wrote: > >> I agree that floats should be printed so that conversion is lossless. >> Python's console output does this and I find it incredibly useful. >> >> Not sure if we need to add a new third-party library for this, though, >> especially one that duplicates so much of C++'s built-in machinery. >> Isn't it just a matter of printing enough digits? That's basically what >> I do in my own code (plus checks for isnan(x) and isinf(x), and a >> check of the size of fabs(x) for whether to force scientific notation.) >> >> - David >> >> >> On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen >> wrote: >> >>> Will, >>> >>> It would go in Common/Core I think. The vtk class would be very small. >>> >>> Bill >>> >>> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >>> wrote: >>> > If it works why mess with success? Where would this class >>> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in >>> some IO >>> > directory like VTK/IO/Core? >>> > >>> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen < >>> bill.lorensen at gmail.com> >>> > wrote: >>> >> >>> >> Folks, >>> >> >>> >> I'm working on some examples to save/restore camera, polydata, >>> >> property, etc. in XML files. The files can be saved as binary or >>> >> ascii. If I save/restore the info in binary, I get the same values for >>> >> the saved info. But, to no surprise, when I save the same data in >>> >> ascii, I don't get the same values. This is because the file writing >>> >> code does not write enough significant digits. >>> >> >>> >> In ITK we solved this problem many years ago. ITK uses a reduced >>> >> version of the Google double-conversion library, >>> >> https://github.com/google/double-conversion. >>> >> >>> >> We added a small class to ITK that uses the library. The class, >>> >> itkNumberToString, has a simple API. To convert floating and fixed >>> >> point numbers to ascii without numerical precision erros, >>> >> >>> >> For example, to convert a float, >>> >> #include "itkNumberToString.h: >>> >> itk::NumberToString convert; >>> >> float a = 1.0f/3.0f; >>> >> std::cout << convert(a) << std::endl; >>> >> >>> >> I propose a similar approach in VTK. >>> >> >>> >> Comments please, >>> >> >>> >> Bill >>> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Thu Mar 22 11:23:33 2018 From: sean at rogue-research.com (Sean McBride) Date: Thu, 22 Mar 2018 11:23:33 -0400 Subject: [vtk-developers] Two automatic clang-tidy changes to confirm... Message-ID: <20180322152333.73856852@mail.rogue-research.com> Hi all, I've been playing with clang-tidy and there's two changes I want to confirm with everyone: 1) using "= default" on ctors and dtors: 2) using reserve() before filling up a vector: Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.gobbi at gmail.com Thu Mar 22 12:05:58 2018 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 22 Mar 2018 10:05:58 -0600 Subject: [vtk-developers] Doxygen macro Message-ID: Hi All, I notice that a few headers check the macro DOXYGEN_SHOULD_SKIP_THIS, but we don't predefine this macro in VTK's doxygen.in file. It's used (currently with no effect) in the following files: vtkSMPTools.h vtkCachingInterpolatedVelocityField.h vtkModifiedBSPTree.h - David -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Thu Mar 22 12:09:35 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 22 Mar 2018 12:09:35 -0400 Subject: [vtk-developers] Doxygen macro In-Reply-To: References: Message-ID: David, That's how it should be if the intent is to skip generating doxygen code for those parts, isn't it? Utkarsh [1] https://stackoverflow.com/questions/1619577/how-can-doxygen-exclude-a-c-class On Thu, Mar 22, 2018 at 12:05 PM, David Gobbi wrote: > Hi All, > > I notice that a few headers check the macro DOXYGEN_SHOULD_SKIP_THIS, but we > don't predefine this macro in VTK's doxygen.in file. It's used (currently > with no effect) in the following files: > > vtkSMPTools.h > vtkCachingInterpolatedVelocityField.h > vtkModifiedBSPTree.h > > - David > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > From utkarsh.ayachit at kitware.com Thu Mar 22 12:11:42 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 22 Mar 2018 12:11:42 -0400 Subject: [vtk-developers] Doxygen macro In-Reply-To: References: Message-ID: Should have looked at the code; it's not being used the way I thought it was (using a @cond). Please ignore my email :). On Thu, Mar 22, 2018 at 12:09 PM, Utkarsh Ayachit wrote: > David, > > That's how it should be if the intent is to skip generating doxygen > code for those parts, isn't it? > > Utkarsh > > [1] https://stackoverflow.com/questions/1619577/how-can-doxygen-exclude-a-c-class > > > > On Thu, Mar 22, 2018 at 12:05 PM, David Gobbi wrote: >> Hi All, >> >> I notice that a few headers check the macro DOXYGEN_SHOULD_SKIP_THIS, but we >> don't predefine this macro in VTK's doxygen.in file. It's used (currently >> with no effect) in the following files: >> >> vtkSMPTools.h >> vtkCachingInterpolatedVelocityField.h >> vtkModifiedBSPTree.h >> >> - David >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> From david.gobbi at gmail.com Thu Mar 22 12:32:25 2018 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 22 Mar 2018 10:32:25 -0600 Subject: [vtk-developers] Doxygen macro In-Reply-To: References: Message-ID: Some of the uses of DOXYGEN_SHOULD_SKIP_THIS in VTK should probably be using @cond instead. But it seems that DOXYGEN_SHOULD_SKIP_THIS was meant for larger blocks than @cond is typically used for (i.e. it's a bigger hammer than @cond). On Thu, Mar 22, 2018 at 10:11 AM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > Should have looked at the code; it's not being used the way I thought > it was (using a @cond). Please ignore my email :). > > > > On Thu, Mar 22, 2018 at 12:09 PM, Utkarsh Ayachit > wrote: > > David, > > > > That's how it should be if the intent is to skip generating doxygen > > code for those parts, isn't it? > > > > Utkarsh > > > > [1] https://stackoverflow.com/questions/1619577/how-can- > doxygen-exclude-a-c-class > > > > > > > > On Thu, Mar 22, 2018 at 12:05 PM, David Gobbi > wrote: > >> Hi All, > >> > >> I notice that a few headers check the macro DOXYGEN_SHOULD_SKIP_THIS, > but we > >> don't predefine this macro in VTK's doxygen.in file. It's used > (currently > >> with no effect) in the following files: > >> > >> vtkSMPTools.h > >> vtkCachingInterpolatedVelocityField.h > >> vtkModifiedBSPTree.h > >> > >> - David > >> > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: http://markmail.org/search/?q= > vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> https://vtk.org/mailman/listinfo/vtk-developers > >> > >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Thu Mar 22 12:37:43 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 22 Mar 2018 12:37:43 -0400 Subject: [vtk-developers] Doxygen macro In-Reply-To: References: Message-ID: Indeed. Looks like DOXYGEN_SHOULD_SKIP_THIS should indeed be defined in the doxyfile [1]. [1] https://www.stack.nl/~dimitri/doxygen/manual/faq.html#faq_code On Thu, Mar 22, 2018 at 12:32 PM, David Gobbi wrote: > Some of the uses of DOXYGEN_SHOULD_SKIP_THIS in VTK should probably be using > @cond instead. But it seems that DOXYGEN_SHOULD_SKIP_THIS was meant for > larger blocks than @cond is typically used for (i.e. it's a bigger hammer > than @cond). > > > > On Thu, Mar 22, 2018 at 10:11 AM, Utkarsh Ayachit > wrote: >> >> Should have looked at the code; it's not being used the way I thought >> it was (using a @cond). Please ignore my email :). >> >> >> >> On Thu, Mar 22, 2018 at 12:09 PM, Utkarsh Ayachit >> wrote: >> > David, >> > >> > That's how it should be if the intent is to skip generating doxygen >> > code for those parts, isn't it? >> > >> > Utkarsh >> > >> > [1] >> > https://stackoverflow.com/questions/1619577/how-can-doxygen-exclude-a-c-class >> > >> > >> > >> > On Thu, Mar 22, 2018 at 12:05 PM, David Gobbi >> > wrote: >> >> Hi All, >> >> >> >> I notice that a few headers check the macro DOXYGEN_SHOULD_SKIP_THIS, >> >> but we >> >> don't predefine this macro in VTK's doxygen.in file. It's used >> >> (currently >> >> with no effect) in the following files: >> >> >> >> vtkSMPTools.h >> >> vtkCachingInterpolatedVelocityField.h >> >> vtkModifiedBSPTree.h >> >> >> >> - David >> >> >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> https://vtk.org/mailman/listinfo/vtk-developers >> >> >> >> > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > From shawn.waldon at kitware.com Thu Mar 22 16:34:26 2018 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Thu, 22 Mar 2018 16:34:26 -0400 Subject: [vtk-developers] kwrobot unresponsiveness and 'topic is missing checks' errors Message-ID: Hi all, The Gitlab update yesterday caused the robot to no longer get events from gitlab. This is why the robot was nonresponsive from yesterday afternoon until this morning when it was fixed. If your topic was updated during that time, the robot never ran the automatic checks since it didn't get the notification about the update. Before you can merge a topic in this state you need to manually tell the robot to run the checks (Do: check). Shawn -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Thu Mar 22 17:25:35 2018 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 23 Mar 2018 08:25:35 +1100 Subject: [vtk-developers] Two automatic clang-tidy changes to confirm... Message-ID: Sean, I think that these are very good changes. "= default" makes the code more compact and readable. Also by setting a minimum capacity, reserve() may even improve performance. Andrew ---------- Forwarded message ---------- > From: Sean McBride > To: > Cc: > Bcc: > Date: Thu, 22 Mar 2018 11:23:33 -0400 > Subject: [vtk-developers] Two automatic clang-tidy changes to confirm... > Hi all, > > I've been playing with clang-tidy and there's two changes I want to > confirm with everyone: > > 1) using "= default" on ctors and dtors: > > 84ec1d5757165643b34c2c1e35e84fe963cb8a14> > > 2) using reserve() before filling up a vector: > > 9266d8817c215f6ee588cfe2102a7152c96af3e7> > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From kyle.edwards at kitware.com Fri Mar 23 13:29:29 2018 From: kyle.edwards at kitware.com (Kyle Edwards) Date: Fri, 23 Mar 2018 13:29:29 -0400 Subject: [vtk-developers] Trey builds are failing Message-ID: <9e84a542-cc2a-9fa0-fba9-e656205d5ad7@kitware.com> Trey is failing with lots of git submodule update timeout errors. Who's in charge of trey while Ben is away? Kyle From utkarsh.ayachit at kitware.com Fri Mar 23 13:33:24 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Fri, 23 Mar 2018 13:33:24 -0400 Subject: [vtk-developers] Trey builds are failing In-Reply-To: <9e84a542-cc2a-9fa0-fba9-e656205d5ad7@kitware.com> References: <9e84a542-cc2a-9fa0-fba9-e656205d5ad7@kitware.com> Message-ID: Kyle, Looks like trey is having some issues doing git checkouts. I'll clean the source directories and reboot and let's see if that resolves the issue. On Fri, Mar 23, 2018 at 1:29 PM, Kyle Edwards wrote: > Trey is failing with lots of git submodule update timeout errors. Who's in > charge of trey while Ben is away? > > Kyle > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > From shawn.waldon at kitware.com Fri Mar 23 13:33:10 2018 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Fri, 23 Mar 2018 13:33:10 -0400 Subject: [vtk-developers] Trey builds are failing In-Reply-To: <9e84a542-cc2a-9fa0-fba9-e656205d5ad7@kitware.com> References: <9e84a542-cc2a-9fa0-fba9-e656205d5ad7@kitware.com> Message-ID: Hi Kyle, I'm taking over Ben's dashboards while he is away. I'll take a look at it. Shawn On Fri, Mar 23, 2018 at 1:29 PM, Kyle Edwards wrote: > Trey is failing with lots of git submodule update timeout errors. Who's in > charge of trey while Ben is away? > > Kyle > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensou > rce/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon Mar 26 09:07:17 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 26 Mar 2018 06:07:17 -0700 Subject: [vtk-developers] Gitlab test on only one macine Message-ID: Is there a magic RE that will let me build/test an MR on a particular build machine.I'm trying to debug an issue on a specific build machine. Bill From kyle.edwards at kitware.com Mon Mar 26 09:09:08 2018 From: kyle.edwards at kitware.com (Kyle Edwards) Date: Mon, 26 Mar 2018 09:09:08 -0400 Subject: [vtk-developers] Gitlab test on only one macine In-Reply-To: References: Message-ID: <8c4db10e-f277-ed54-8722-0dd10a584f74@kitware.com> I just did this with Trey the other day, the command I used was "Do: test -i trey" On 03/26/2018 09:07 AM, Bill Lorensen wrote: > Is there a magic RE that will let me build/test an MR on a particular > build machine.I'm trying to debug an issue on a specific build > machine. > > Bill > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > From shawn.waldon at kitware.com Mon Mar 26 09:20:08 2018 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Mon, 26 Mar 2018 09:20:08 -0400 Subject: [vtk-developers] Gitlab test on only one macine In-Reply-To: <8c4db10e-f277-ed54-8722-0dd10a584f74@kitware.com> References: <8c4db10e-f277-ed54-8722-0dd10a584f74@kitware.com> Message-ID: Kyle has the right syntax. For future reference: to get a full list of the options on Do: test, you can run "Do: test --help". Shawn On Mon, Mar 26, 2018 at 9:09 AM, Kyle Edwards wrote: > I just did this with Trey the other day, the command I used was "Do: test > -i trey" > > > > On 03/26/2018 09:07 AM, Bill Lorensen wrote: > >> Is there a magic RE that will let me build/test an MR on a particular >> build machine.I'm trying to debug an issue on a specific build >> machine. >> >> Bill >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensou > rce/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Mon Mar 26 11:50:32 2018 From: david.gobbi at gmail.com (David Gobbi) Date: Mon, 26 Mar 2018 09:50:32 -0600 Subject: [vtk-developers] Doxygen macro In-Reply-To: References: Message-ID: Just to close the loop on this: We merged a patch that predefines DOXYGEN_SHOULD_SKIP_THIS for doxygen. We also modified the doxyfile so that doxygen sees the true vtkDataArray hierarchy. Old doxygen: https://www.vtk.org/doc/release/7.1/html/ classvtkFloatArray.html New doxygen: https://www.vtk.org/doc/nightly/html/classvtkFloatArray.html - David On Thu, Mar 22, 2018 at 10:37 AM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > Indeed. Looks like DOXYGEN_SHOULD_SKIP_THIS should indeed be defined > in the doxyfile [1]. > > [1] https://www.stack.nl/~dimitri/doxygen/manual/faq.html#faq_code -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Tue Mar 27 10:57:13 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 27 Mar 2018 07:57:13 -0700 Subject: [vtk-developers] [vtkusers] Any plan to update the books? In-Reply-To: References: Message-ID: I think an online source would be very useful and doable. There are several components to the book: 1) The text (easy to convert to another format) 2) Non-vtk generated figures (I think Kitware has these in some form). 3) vtk-generated figures (almost all already exist in https://lorensen.github.io/VTKExamples/site/VTKBookFigures/) 4) Equations (need to find a reasonable converter) 5) Cross-references (might be a manual operation) 6) Index (use search technology?) 7) Remove all references to tcl. 8) Update the text to reflect modern VTK. 9) Other stuff (TBD). There are tools to convert pdf text to markdown. For example, http://pdf2md.morethan.io/ converted the entire VTK Book pdf to markdown. There are lots of decisions to make, but given the current toolsets available on the internet, an organized group effort could do it once an approach is chosen. Choosing an approach will be the most challenging part of the effort. There are tools to convert pdf to markdown. These tools could handle the "text" portion of the book. I've tried http://pdf2md.morethan.io/ and it converted the entire text of the vtk book into a simple markdown format. I can also share my experience in moving the VTK Wiki Examples to github and markdown. Auto-generation of enhanced markdown was a key. For example, the VTKExamples hyperlinks every text occurrence of a vtk class to the doxygen. VTK generated figures could be auto inserted. Just my 2 cents, Bill On Mon, Mar 26, 2018 at 7:56 AM, Berk Geveci wrote: > Just a quick update on this guys. We would love to provide editable versions > of both books. The challenge is that they are in old Framemaker format and > we have not had the time to focus on finding a way to generate some form of > editable content from them. I don't believe exporting to another format from > Framemaker is a good option. So we have contemplating scraping the PDF for > content and generating all new images (which Bill Lorensen did to a great > extent). Will Schroeder has been contemplating doing a new version that is > interactive on the Web also. If there are folks out there with concrete > ideas on how to move forward, we would be happy to have everyone engaged in > finding a way forward. > > I have some ideas of my own: > > * Combine contents to create one book that is a hybrid textbook / user's > guide, more focused on teaching visualization as covered by VTK > * Generate a separate guide with lots of examples that can be translated to > various languages that VTK supports leveraging content from the book as well > as VTK examples online. This could be an online thing. > > Best, > -berk > > > On Mon, Mar 26, 2018 at 10:49 AM, Andras Lasso wrote: >> >> Yes, the VTK textbook is great and still up-to-date, except specific >> source code examples. If it was made available in editable form then I?m >> sure there would be volunteers to update the examples (convert Tcl to Python >> and update according to VTK API), and maybe describe some notable core >> changes (pipeline changes, etc). >> >> >> >> I have never found the VTK User?s Guide particularly suitable for a >> printed book format. At user guide level online resources (examples, API >> documentation, etc.) are easier to use, because you can search better, they >> are hyperlinked, you can copy-paste, etc. Online materials are also easier >> to keep up-to-date. >> >> >> >> Andras >> >> >> >> From: vtkusers On Behalf Of David E DeMarle >> Sent: Monday, March 26, 2018 10:39 AM >> To: Jesse Kinross-Smith >> Cc: vtkusers at vtk.org >> Subject: Re: [vtkusers] Any plan to update the books? >> >> >> >> We don't have any near term plans for an update. >> >> >> >> The books certainly do need a refresh, including a math reformat for the >> free online versions, however just about of the techniques described in them >> are still valid. >> >> >> >> Most of the code is still valid, with the important exception of a few >> places in need of version 5->6 changes. For those refer to >> https://www.vtk.org/Wiki/VTK/VTK_6_Migration_Guide >> >> >> >> >> David E DeMarle >> Kitware, Inc. >> Principal Engineer >> 21 Corporate Drive >> Clifton Park, NY 12065-8662 >> Phone: 518-881-4909 >> >> >> >> On Mon, Mar 26, 2018 at 3:42 AM, Jesse Kinross-Smith >> wrote: >> >> Are there any plans to update these books at all? >> >> I?d love to get some books to help me learn the ins and outs of VTK for >> the office, but anything over 5 years old in this industry is usually pretty >> obsolete I?ve found. >> >> >> >> Visualization Toolkit: An Object-Oriented Approach to 3D Graphics, 4th >> Edition - December 1, 2006 >> >> >> https://www.amazon.com/Visualization-Toolkit-Object-Oriented-Approach-Graphics/dp/193093419X >> >> >> >> VTK User's Guide Paperback ? 11th Ed. March 18, 2010 >> >> https://www.amazon.com/VTK-Users-Guide-Kitware/dp/1930934238 >> >> >> >> Jesse >> >> -- >> >> Jesse Kinross-Smith >> >> Senior Software Engineer - BSW >> >> Bentley Systems, Fremantle >> >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the VTK FAQ at: >> http://www.vtk.org/Wiki/VTK_FAQ >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtkusers >> >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the VTK FAQ at: >> http://www.vtk.org/Wiki/VTK_FAQ >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtkusers >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the VTK FAQ at: > http://www.vtk.org/Wiki/VTK_FAQ > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtkusers > -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Tue Mar 27 13:13:02 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 27 Mar 2018 10:13:02 -0700 Subject: [vtk-developers] [vtkusers] Any plan to update the books? In-Reply-To: References: Message-ID: I found a tool, pandoc, that converts pdf to a number of file formats including markdown and docx. It can also extract figures. I've extracted all of the VTK book figures and I'm checking out how well it did on the drawn figures. Bill On Tue, Mar 27, 2018 at 7:57 AM, Bill Lorensen wrote: > I think an online source would be very useful and doable. > > There are several components to the book: > 1) The text (easy to convert to another format) > 2) Non-vtk generated figures (I think Kitware has these in some form). > 3) vtk-generated figures (almost all already exist in > https://lorensen.github.io/VTKExamples/site/VTKBookFigures/) > 4) Equations (need to find a reasonable converter) > 5) Cross-references (might be a manual operation) > 6) Index (use search technology?) > 7) Remove all references to tcl. > 8) Update the text to reflect modern VTK. > 9) Other stuff (TBD). > > There are tools to convert pdf text to markdown. For example, > http://pdf2md.morethan.io/ converted the entire VTK Book pdf to > markdown. > > There are lots of decisions to make, but given the current toolsets > available on the internet, an organized group effort could do it once > an approach is chosen. > > Choosing an approach will be the most challenging part of the effort. > > There are tools to convert pdf to markdown. These tools could handle > the "text" portion of the book. I've tried > http://pdf2md.morethan.io/ > and it converted the entire text of the vtk book into a simple markdown format. > > I can also share my experience in moving the VTK Wiki Examples to > github and markdown. Auto-generation of enhanced markdown was a key. > For example, the VTKExamples hyperlinks every text occurrence of a vtk > class to the doxygen. VTK generated figures could be auto inserted. > > Just my 2 cents, > > Bill > > On Mon, Mar 26, 2018 at 7:56 AM, Berk Geveci wrote: >> Just a quick update on this guys. We would love to provide editable versions >> of both books. The challenge is that they are in old Framemaker format and >> we have not had the time to focus on finding a way to generate some form of >> editable content from them. I don't believe exporting to another format from >> Framemaker is a good option. So we have contemplating scraping the PDF for >> content and generating all new images (which Bill Lorensen did to a great >> extent). Will Schroeder has been contemplating doing a new version that is >> interactive on the Web also. If there are folks out there with concrete >> ideas on how to move forward, we would be happy to have everyone engaged in >> finding a way forward. >> >> I have some ideas of my own: >> >> * Combine contents to create one book that is a hybrid textbook / user's >> guide, more focused on teaching visualization as covered by VTK >> * Generate a separate guide with lots of examples that can be translated to >> various languages that VTK supports leveraging content from the book as well >> as VTK examples online. This could be an online thing. >> >> Best, >> -berk >> >> >> On Mon, Mar 26, 2018 at 10:49 AM, Andras Lasso wrote: >>> >>> Yes, the VTK textbook is great and still up-to-date, except specific >>> source code examples. If it was made available in editable form then I?m >>> sure there would be volunteers to update the examples (convert Tcl to Python >>> and update according to VTK API), and maybe describe some notable core >>> changes (pipeline changes, etc). >>> >>> >>> >>> I have never found the VTK User?s Guide particularly suitable for a >>> printed book format. At user guide level online resources (examples, API >>> documentation, etc.) are easier to use, because you can search better, they >>> are hyperlinked, you can copy-paste, etc. Online materials are also easier >>> to keep up-to-date. >>> >>> >>> >>> Andras >>> >>> >>> >>> From: vtkusers On Behalf Of David E DeMarle >>> Sent: Monday, March 26, 2018 10:39 AM >>> To: Jesse Kinross-Smith >>> Cc: vtkusers at vtk.org >>> Subject: Re: [vtkusers] Any plan to update the books? >>> >>> >>> >>> We don't have any near term plans for an update. >>> >>> >>> >>> The books certainly do need a refresh, including a math reformat for the >>> free online versions, however just about of the techniques described in them >>> are still valid. >>> >>> >>> >>> Most of the code is still valid, with the important exception of a few >>> places in need of version 5->6 changes. For those refer to >>> https://www.vtk.org/Wiki/VTK/VTK_6_Migration_Guide >>> >>> >>> >>> >>> David E DeMarle >>> Kitware, Inc. >>> Principal Engineer >>> 21 Corporate Drive >>> Clifton Park, NY 12065-8662 >>> Phone: 518-881-4909 >>> >>> >>> >>> On Mon, Mar 26, 2018 at 3:42 AM, Jesse Kinross-Smith >>> wrote: >>> >>> Are there any plans to update these books at all? >>> >>> I?d love to get some books to help me learn the ins and outs of VTK for >>> the office, but anything over 5 years old in this industry is usually pretty >>> obsolete I?ve found. >>> >>> >>> >>> Visualization Toolkit: An Object-Oriented Approach to 3D Graphics, 4th >>> Edition - December 1, 2006 >>> >>> >>> https://www.amazon.com/Visualization-Toolkit-Object-Oriented-Approach-Graphics/dp/193093419X >>> >>> >>> >>> VTK User's Guide Paperback ? 11th Ed. March 18, 2010 >>> >>> https://www.amazon.com/VTK-Users-Guide-Kitware/dp/1930934238 >>> >>> >>> >>> Jesse >>> >>> -- >>> >>> Jesse Kinross-Smith >>> >>> Senior Software Engineer - BSW >>> >>> Bentley Systems, Fremantle >>> >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the VTK FAQ at: >>> http://www.vtk.org/Wiki/VTK_FAQ >>> >>> Search the list archives at: http://markmail.org/search/?q=vtkusers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtkusers >>> >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the VTK FAQ at: >>> http://www.vtk.org/Wiki/VTK_FAQ >>> >>> Search the list archives at: http://markmail.org/search/?q=vtkusers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtkusers >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Please keep messages on-topic and check the VTK FAQ at: >> http://www.vtk.org/Wiki/VTK_FAQ >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtkusers >> > > > > -- > Unpaid intern in BillsParadise at noware dot com -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Wed Mar 28 14:05:01 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 28 Mar 2018 11:05:01 -0700 Subject: [vtk-developers] [vtkusers] Any plan to update the books? In-Reply-To: References: Message-ID: I have a strawman for Chapter 6. I'll publish it as soon s I add the figures (which we already have). The figures are regression tested every night. Equations are not addressed yet. Andrew Maclean knows how to handle these I believe. Bill On Wed, Mar 28, 2018 at 9:42 AM, Berk Geveci wrote: > Wow this is great! > > On Tue, Mar 27, 2018 at 1:13 PM, Bill Lorensen > wrote: >> >> I found a tool, pandoc, that converts pdf to a number of file formats >> including markdown and docx. It can also extract figures. I've >> extracted all of the VTK book figures and I'm checking out how well it >> did on the drawn figures. >> >> Bill >> >> >> On Tue, Mar 27, 2018 at 7:57 AM, Bill Lorensen >> wrote: >> > I think an online source would be very useful and doable. >> > >> > There are several components to the book: >> > 1) The text (easy to convert to another format) >> > 2) Non-vtk generated figures (I think Kitware has these in some form). >> > 3) vtk-generated figures (almost all already exist in >> > https://lorensen.github.io/VTKExamples/site/VTKBookFigures/) >> > 4) Equations (need to find a reasonable converter) >> > 5) Cross-references (might be a manual operation) >> > 6) Index (use search technology?) >> > 7) Remove all references to tcl. >> > 8) Update the text to reflect modern VTK. >> > 9) Other stuff (TBD). >> > >> > There are tools to convert pdf text to markdown. For example, >> > http://pdf2md.morethan.io/ converted the entire VTK Book pdf to >> > markdown. >> > >> > There are lots of decisions to make, but given the current toolsets >> > available on the internet, an organized group effort could do it once >> > an approach is chosen. >> > >> > Choosing an approach will be the most challenging part of the effort. >> > >> > There are tools to convert pdf to markdown. These tools could handle >> > the "text" portion of the book. I've tried >> > http://pdf2md.morethan.io/ >> > and it converted the entire text of the vtk book into a simple markdown >> > format. >> > >> > I can also share my experience in moving the VTK Wiki Examples to >> > github and markdown. Auto-generation of enhanced markdown was a key. >> > For example, the VTKExamples hyperlinks every text occurrence of a vtk >> > class to the doxygen. VTK generated figures could be auto inserted. >> > >> > Just my 2 cents, >> > >> > Bill >> > >> > On Mon, Mar 26, 2018 at 7:56 AM, Berk Geveci >> > wrote: >> >> Just a quick update on this guys. We would love to provide editable >> >> versions >> >> of both books. The challenge is that they are in old Framemaker format >> >> and >> >> we have not had the time to focus on finding a way to generate some >> >> form of >> >> editable content from them. I don't believe exporting to another format >> >> from >> >> Framemaker is a good option. So we have contemplating scraping the PDF >> >> for >> >> content and generating all new images (which Bill Lorensen did to a >> >> great >> >> extent). Will Schroeder has been contemplating doing a new version that >> >> is >> >> interactive on the Web also. If there are folks out there with concrete >> >> ideas on how to move forward, we would be happy to have everyone >> >> engaged in >> >> finding a way forward. >> >> >> >> I have some ideas of my own: >> >> >> >> * Combine contents to create one book that is a hybrid textbook / >> >> user's >> >> guide, more focused on teaching visualization as covered by VTK >> >> * Generate a separate guide with lots of examples that can be >> >> translated to >> >> various languages that VTK supports leveraging content from the book as >> >> well >> >> as VTK examples online. This could be an online thing. >> >> >> >> Best, >> >> -berk >> >> >> >> >> >> On Mon, Mar 26, 2018 at 10:49 AM, Andras Lasso >> >> wrote: >> >>> >> >>> Yes, the VTK textbook is great and still up-to-date, except specific >> >>> source code examples. If it was made available in editable form then >> >>> I?m >> >>> sure there would be volunteers to update the examples (convert Tcl to >> >>> Python >> >>> and update according to VTK API), and maybe describe some notable core >> >>> changes (pipeline changes, etc). >> >>> >> >>> >> >>> >> >>> I have never found the VTK User?s Guide particularly suitable for a >> >>> printed book format. At user guide level online resources (examples, >> >>> API >> >>> documentation, etc.) are easier to use, because you can search better, >> >>> they >> >>> are hyperlinked, you can copy-paste, etc. Online materials are also >> >>> easier >> >>> to keep up-to-date. >> >>> >> >>> >> >>> >> >>> Andras >> >>> >> >>> >> >>> >> >>> From: vtkusers On Behalf Of David E DeMarle >> >>> Sent: Monday, March 26, 2018 10:39 AM >> >>> To: Jesse Kinross-Smith >> >>> Cc: vtkusers at vtk.org >> >>> Subject: Re: [vtkusers] Any plan to update the books? >> >>> >> >>> >> >>> >> >>> We don't have any near term plans for an update. >> >>> >> >>> >> >>> >> >>> The books certainly do need a refresh, including a math reformat for >> >>> the >> >>> free online versions, however just about of the techniques described >> >>> in them >> >>> are still valid. >> >>> >> >>> >> >>> >> >>> Most of the code is still valid, with the important exception of a few >> >>> places in need of version 5->6 changes. For those refer to >> >>> https://www.vtk.org/Wiki/VTK/VTK_6_Migration_Guide >> >>> >> >>> >> >>> >> >>> >> >>> David E DeMarle >> >>> Kitware, Inc. >> >>> Principal Engineer >> >>> 21 Corporate Drive >> >>> Clifton Park, NY 12065-8662 >> >>> Phone: 518-881-4909 >> >>> >> >>> >> >>> >> >>> On Mon, Mar 26, 2018 at 3:42 AM, Jesse Kinross-Smith >> >>> wrote: >> >>> >> >>> Are there any plans to update these books at all? >> >>> >> >>> I?d love to get some books to help me learn the ins and outs of VTK >> >>> for >> >>> the office, but anything over 5 years old in this industry is usually >> >>> pretty >> >>> obsolete I?ve found. >> >>> >> >>> >> >>> >> >>> Visualization Toolkit: An Object-Oriented Approach to 3D Graphics, 4th >> >>> Edition - December 1, 2006 >> >>> >> >>> >> >>> >> >>> https://www.amazon.com/Visualization-Toolkit-Object-Oriented-Approach-Graphics/dp/193093419X >> >>> >> >>> >> >>> >> >>> VTK User's Guide Paperback ? 11th Ed. March 18, 2010 >> >>> >> >>> https://www.amazon.com/VTK-Users-Guide-Kitware/dp/1930934238 >> >>> >> >>> >> >>> >> >>> Jesse >> >>> >> >>> -- >> >>> >> >>> Jesse Kinross-Smith >> >>> >> >>> Senior Software Engineer - BSW >> >>> >> >>> Bentley Systems, Fremantle >> >>> >> >>> >> >>> >> >>> >> >>> _______________________________________________ >> >>> Powered by www.kitware.com >> >>> >> >>> Visit other Kitware open-source projects at >> >>> http://www.kitware.com/opensource/opensource.html >> >>> >> >>> Please keep messages on-topic and check the VTK FAQ at: >> >>> http://www.vtk.org/Wiki/VTK_FAQ >> >>> >> >>> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >>> >> >>> Follow this link to subscribe/unsubscribe: >> >>> https://vtk.org/mailman/listinfo/vtkusers >> >>> >> >>> >> >>> >> >>> >> >>> _______________________________________________ >> >>> Powered by www.kitware.com >> >>> >> >>> Visit other Kitware open-source projects at >> >>> http://www.kitware.com/opensource/opensource.html >> >>> >> >>> Please keep messages on-topic and check the VTK FAQ at: >> >>> http://www.vtk.org/Wiki/VTK_FAQ >> >>> >> >>> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >>> >> >>> Follow this link to subscribe/unsubscribe: >> >>> https://vtk.org/mailman/listinfo/vtkusers >> >>> >> >> >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Please keep messages on-topic and check the VTK FAQ at: >> >> http://www.vtk.org/Wiki/VTK_FAQ >> >> >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> https://vtk.org/mailman/listinfo/vtkusers >> >> >> > >> > >> > >> > -- >> > Unpaid intern in BillsParadise at noware dot com >> >> >> >> -- >> Unpaid intern in BillsParadise at noware dot com > > -- Unpaid intern in BillsParadise at noware dot com From utkarsh.ayachit at kitware.com Wed Mar 28 20:19:31 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Wed, 28 Mar 2018 20:19:31 -0400 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: Funny coincidence, I just got bit but this double-string precision problem in a ParaView issue [1]. Looks forward to having this library in VTK so we can use it. Bill, if you need help with the 3rd party stuff, just holler. Utkarsh [1] https://gitlab.kitware.com/paraview/paraview/issues/18083 On Wed, Mar 21, 2018 at 8:10 PM, Bill Lorensen wrote: > I'm still working in the MR. It works great but I'm having cmake issues on > Windows. Adding a new third party library is tricky. > > On Mar 21, 2018 2:08 PM, "Isaiah Norton" wrote: >> >> +1. I needed this recently in Slicer, and ended up using ITK's version >> because we link it anyway. >> >>> >>> Not sure if we need to add a new third-party library for this, though, >>> especially one that duplicates so much of C++'s built-in machinery. >> >> >> Grisu3 (double-conversion) appears to be ~13x faster than the C++ stream >> functions (and 6x faster than sprintf): >> >> https://github.com/miloyip/dtoa-benchmark >> >> Those numbers are on VS2013/Windows, but that code is easy to build >> locally. The sprintf vs double-conversion conclusion holds on 2015 macbook >> with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. >> >> [usual benchmark NaCl disclaimer here] >> >> On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi >> wrote: >>> >>> I agree that floats should be printed so that conversion is lossless. >>> Python's console output does this and I find it incredibly useful. >>> >>> Not sure if we need to add a new third-party library for this, though, >>> especially one that duplicates so much of C++'s built-in machinery. >>> Isn't it just a matter of printing enough digits? That's basically what >>> I do in my own code (plus checks for isnan(x) and isinf(x), and a >>> check of the size of fabs(x) for whether to force scientific notation.) >>> >>> - David >>> >>> >>> On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen >>> wrote: >>>> >>>> Will, >>>> >>>> It would go in Common/Core I think. The vtk class would be very small. >>>> >>>> Bill >>>> >>>> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >>>> wrote: >>>> > If it works why mess with success? Where would this class >>>> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in >>>> > some IO >>>> > directory like VTK/IO/Core? >>>> > >>>> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen >>>> > >>>> > wrote: >>>> >> >>>> >> Folks, >>>> >> >>>> >> I'm working on some examples to save/restore camera, polydata, >>>> >> property, etc. in XML files. The files can be saved as binary or >>>> >> ascii. If I save/restore the info in binary, I get the same values >>>> >> for >>>> >> the saved info. But, to no surprise, when I save the same data in >>>> >> ascii, I don't get the same values. This is because the file writing >>>> >> code does not write enough significant digits. >>>> >> >>>> >> In ITK we solved this problem many years ago. ITK uses a reduced >>>> >> version of the Google double-conversion library, >>>> >> https://github.com/google/double-conversion. >>>> >> >>>> >> We added a small class to ITK that uses the library. The class, >>>> >> itkNumberToString, has a simple API. To convert floating and fixed >>>> >> point numbers to ascii without numerical precision erros, >>>> >> >>>> >> For example, to convert a float, >>>> >> #include "itkNumberToString.h: >>>> >> itk::NumberToString convert; >>>> >> float a = 1.0f/3.0f; >>>> >> std::cout << convert(a) << std::endl; >>>> >> >>>> >> I propose a similar approach in VTK. >>>> >> >>>> >> Comments please, >>>> >> >>>> >> Bill >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtk-developers >>> >>> >> > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > From bill.lorensen at gmail.com Wed Mar 28 20:54:34 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 28 Mar 2018 17:54:34 -0700 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: I'm having problems on a Windows platform. I'll be asking for help. The ThirdParty stuff is tricky since not all ThirdParty packages follow the recommended way. Bill On Wed, Mar 28, 2018 at 5:19 PM, Utkarsh Ayachit wrote: > Funny coincidence, I just got bit but this double-string precision > problem in a ParaView issue [1]. Looks forward to having this library > in VTK so we can use it. Bill, if you need help with the 3rd party > stuff, just holler. > > Utkarsh > > > [1] https://gitlab.kitware.com/paraview/paraview/issues/18083 > > On Wed, Mar 21, 2018 at 8:10 PM, Bill Lorensen wrote: >> I'm still working in the MR. It works great but I'm having cmake issues on >> Windows. Adding a new third party library is tricky. >> >> On Mar 21, 2018 2:08 PM, "Isaiah Norton" wrote: >>> >>> +1. I needed this recently in Slicer, and ended up using ITK's version >>> because we link it anyway. >>> >>>> >>>> Not sure if we need to add a new third-party library for this, though, >>>> especially one that duplicates so much of C++'s built-in machinery. >>> >>> >>> Grisu3 (double-conversion) appears to be ~13x faster than the C++ stream >>> functions (and 6x faster than sprintf): >>> >>> https://github.com/miloyip/dtoa-benchmark >>> >>> Those numbers are on VS2013/Windows, but that code is easy to build >>> locally. The sprintf vs double-conversion conclusion holds on 2015 macbook >>> with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. >>> >>> [usual benchmark NaCl disclaimer here] >>> >>> On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi >>> wrote: >>>> >>>> I agree that floats should be printed so that conversion is lossless. >>>> Python's console output does this and I find it incredibly useful. >>>> >>>> Not sure if we need to add a new third-party library for this, though, >>>> especially one that duplicates so much of C++'s built-in machinery. >>>> Isn't it just a matter of printing enough digits? That's basically what >>>> I do in my own code (plus checks for isnan(x) and isinf(x), and a >>>> check of the size of fabs(x) for whether to force scientific notation.) >>>> >>>> - David >>>> >>>> >>>> On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen >>>> wrote: >>>>> >>>>> Will, >>>>> >>>>> It would go in Common/Core I think. The vtk class would be very small. >>>>> >>>>> Bill >>>>> >>>>> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >>>>> wrote: >>>>> > If it works why mess with success? Where would this class >>>>> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) or in >>>>> > some IO >>>>> > directory like VTK/IO/Core? >>>>> > >>>>> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen >>>>> > >>>>> > wrote: >>>>> >> >>>>> >> Folks, >>>>> >> >>>>> >> I'm working on some examples to save/restore camera, polydata, >>>>> >> property, etc. in XML files. The files can be saved as binary or >>>>> >> ascii. If I save/restore the info in binary, I get the same values >>>>> >> for >>>>> >> the saved info. But, to no surprise, when I save the same data in >>>>> >> ascii, I don't get the same values. This is because the file writing >>>>> >> code does not write enough significant digits. >>>>> >> >>>>> >> In ITK we solved this problem many years ago. ITK uses a reduced >>>>> >> version of the Google double-conversion library, >>>>> >> https://github.com/google/double-conversion. >>>>> >> >>>>> >> We added a small class to ITK that uses the library. The class, >>>>> >> itkNumberToString, has a simple API. To convert floating and fixed >>>>> >> point numbers to ascii without numerical precision erros, >>>>> >> >>>>> >> For example, to convert a float, >>>>> >> #include "itkNumberToString.h: >>>>> >> itk::NumberToString convert; >>>>> >> float a = 1.0f/3.0f; >>>>> >> std::cout << convert(a) << std::endl; >>>>> >> >>>>> >> I propose a similar approach in VTK. >>>>> >> >>>>> >> Comments please, >>>>> >> >>>>> >> Bill >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://vtk.org/mailman/listinfo/vtk-developers >>>> >>>> >>> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> -- Unpaid intern in BillsParadise at noware dot com From lasso at queensu.ca Wed Mar 28 23:36:50 2018 From: lasso at queensu.ca (Andras Lasso) Date: Thu, 29 Mar 2018 03:36:50 +0000 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: ITK already uses DoubleConversion library. Could VTK include it the same way? Andras -----Original Message----- From: vtk-developers On Behalf Of Bill Lorensen Sent: Wednesday, March 28, 2018 8:55 PM To: Utkarsh Ayachit Cc: VTK Developers ; Will Schroeder ; David Gobbi Subject: Re: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files I'm having problems on a Windows platform. I'll be asking for help. The ThirdParty stuff is tricky since not all ThirdParty packages follow the recommended way. Bill On Wed, Mar 28, 2018 at 5:19 PM, Utkarsh Ayachit wrote: > Funny coincidence, I just got bit but this double-string precision > problem in a ParaView issue [1]. Looks forward to having this library > in VTK so we can use it. Bill, if you need help with the 3rd party > stuff, just holler. > > Utkarsh > > > [1] > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla > b.kitware.com%2Fparaview%2Fparaview%2Fissues%2F18083&data=02%7C01%7Cla > sso%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d5 > 82c4efb2838b925c%7C1%7C0%7C636578816799629721&sdata=%2F1yBI%2B25wC1xr7 > Z2agKh1IslyksB6y1k0GUKpfp8PtQ%3D&reserved=0 > > On Wed, Mar 21, 2018 at 8:10 PM, Bill Lorensen wrote: >> I'm still working in the MR. It works great but I'm having cmake >> issues on Windows. Adding a new third party library is tricky. >> >> On Mar 21, 2018 2:08 PM, "Isaiah Norton" wrote: >>> >>> +1. I needed this recently in Slicer, and ended up using ITK's >>> +version >>> because we link it anyway. >>> >>>> >>>> Not sure if we need to add a new third-party library for this, >>>> though, especially one that duplicates so much of C++'s built-in machinery. >>> >>> >>> Grisu3 (double-conversion) appears to be ~13x faster than the C++ >>> stream functions (and 6x faster than sprintf): >>> >>> >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >>> hub.com%2Fmiloyip%2Fdtoa-benchmark&data=02%7C01%7Classo%40queensu.ca >>> %7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b92 >>> 5c%7C1%7C0%7C636578816799629721&sdata=XjioME1t%2F1TwLSUObFB5GGG9d%2B >>> S8f4%2ByVls1%2B5oB1q4%3D&reserved=0 >>> >>> Those numbers are on VS2013/Windows, but that code is easy to build >>> locally. The sprintf vs double-conversion conclusion holds on 2015 >>> macbook with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. >>> >>> [usual benchmark NaCl disclaimer here] >>> >>> On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi >>> wrote: >>>> >>>> I agree that floats should be printed so that conversion is lossless. >>>> Python's console output does this and I find it incredibly useful. >>>> >>>> Not sure if we need to add a new third-party library for this, >>>> though, especially one that duplicates so much of C++'s built-in machinery. >>>> Isn't it just a matter of printing enough digits? That's basically >>>> what I do in my own code (plus checks for isnan(x) and isinf(x), >>>> and a check of the size of fabs(x) for whether to force scientific >>>> notation.) >>>> >>>> - David >>>> >>>> >>>> On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen >>>> >>>> wrote: >>>>> >>>>> Will, >>>>> >>>>> It would go in Common/Core I think. The vtk class would be very small. >>>>> >>>>> Bill >>>>> >>>>> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >>>>> wrote: >>>>> > If it works why mess with success? Where would this class >>>>> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) >>>>> > or in some IO directory like VTK/IO/Core? >>>>> > >>>>> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen >>>>> > >>>>> > wrote: >>>>> >> >>>>> >> Folks, >>>>> >> >>>>> >> I'm working on some examples to save/restore camera, polydata, >>>>> >> property, etc. in XML files. The files can be saved as binary >>>>> >> or ascii. If I save/restore the info in binary, I get the same >>>>> >> values for the saved info. But, to no surprise, when I save the >>>>> >> same data in ascii, I don't get the same values. This is >>>>> >> because the file writing code does not write enough significant >>>>> >> digits. >>>>> >> >>>>> >> In ITK we solved this problem many years ago. ITK uses a >>>>> >> reduced version of the Google double-conversion library, >>>>> >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fdouble-conversion&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799629721&sdata=Iaj1ntftOmg4TsPj7U3eaMXoYfiNmT0yqRlQxZvpMC8%3D&reserved=0. >>>>> >> >>>>> >> We added a small class to ITK that uses the library. The class, >>>>> >> itkNumberToString, has a simple API. To convert floating and >>>>> >> fixed point numbers to ascii without numerical precision erros, >>>>> >> >>>>> >> For example, to convert a float, #include "itkNumberToString.h: >>>>> >> itk::NumberToString convert; float a = 1.0f/3.0f; >>>>> >> std::cout << convert(a) << std::endl; >>>>> >> >>>>> >> I propose a similar approach in VTK. >>>>> >> >>>>> >> Comments please, >>>>> >> >>>>> >> Bill >>>> >>>> >>>> _______________________________________________ >>>> Powered by >>>> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com& >>>> data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5e >>>> c%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799629721&s >>>> data=PSctDI%2BN60sIjEpXkZjufI%2BkcclVZKoI2T2bzBAoj9w%3D&reserved=0 >>>> >>>> Visit other Kitware open-source projects at >>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww >>>> .kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40 >>>> queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c >>>> 4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUol >>>> wTdGnnWJvFjnk8Xo%2FscXkXSnQ%3D&reserved=0 >>>> >>>> Search the list archives at: >>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmar >>>> kmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40q >>>> ueensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4 >>>> efb2838b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFI >>>> f5kGUo6%2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvt >>>> k.org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40 >>>> queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c >>>> 4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0 >>>> nT8PNtbFF%2BUG9R9kpeMLYvb4I%3D&reserved=0 >>>> >>>> >>> >> >> _______________________________________________ >> Powered by >> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&da >> ta=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7C >> d61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=s >> 4hn6gw5SNnQrTmqnud8rld8Hh8KAGzfLH7qJYGPaRw%3D&reserved=0 >> >> Visit other Kitware open-source projects at >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.k >> itware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40quee >> nsu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb28 >> 38b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUolwTdGnnWJ >> vFjnk8Xo%2FscXkXSnQ%3D&reserved=0 >> >> Search the list archives at: >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkm >> ail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queen >> su.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb283 >> 8b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFIf5kGUo6% >> 2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 >> >> Follow this link to subscribe/unsubscribe: >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk. >> org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40quee >> nsu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb28 >> 38b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0nT8PNtbF >> F%2BUG9R9kpeMLYvb4I%3D&reserved=0 >> >> -- Unpaid intern in BillsParadise at noware dot com _______________________________________________ Powered by https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=s4hn6gw5SNnQrTmqnud8rld8Hh8KAGzfLH7qJYGPaRw%3D&reserved=0 Visit other Kitware open-source projects at https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUolwTdGnnWJvFjnk8Xo%2FscXkXSnQ%3D&reserved=0 Search the list archives at: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFIf5kGUo6%2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 Follow this link to subscribe/unsubscribe: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk.org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0nT8PNtbFF%2BUG9R9kpeMLYvb4I%3D&reserved=0 From bill.lorensen at gmail.com Thu Mar 29 01:58:55 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 28 Mar 2018 22:58:55 -0700 Subject: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files In-Reply-To: References: Message-ID: VTK's ThirdParty api is different than ITK's . I almost have it building except when Kits are enabled on windows with shared libs. I'll ask for help tomorrow. I did use a similar ITK API for the VTK class On Wed, Mar 28, 2018 at 8:36 PM, Andras Lasso wrote: > ITK already uses DoubleConversion library. Could VTK include it the same way? > > Andras > > -----Original Message----- > From: vtk-developers On Behalf Of Bill Lorensen > Sent: Wednesday, March 28, 2018 8:55 PM > To: Utkarsh Ayachit > Cc: VTK Developers ; Will Schroeder ; David Gobbi > Subject: Re: [vtk-developers] Call for Comments: Ascii representation of floats and doubles in files > > I'm having problems on a Windows platform. I'll be asking for help. > > The ThirdParty stuff is tricky since not all ThirdParty packages follow the recommended way. > > Bill > > On Wed, Mar 28, 2018 at 5:19 PM, Utkarsh Ayachit wrote: >> Funny coincidence, I just got bit but this double-string precision >> problem in a ParaView issue [1]. Looks forward to having this library >> in VTK so we can use it. Bill, if you need help with the 3rd party >> stuff, just holler. >> >> Utkarsh >> >> >> [1] >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla >> b.kitware.com%2Fparaview%2Fparaview%2Fissues%2F18083&data=02%7C01%7Cla >> sso%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d5 >> 82c4efb2838b925c%7C1%7C0%7C636578816799629721&sdata=%2F1yBI%2B25wC1xr7 >> Z2agKh1IslyksB6y1k0GUKpfp8PtQ%3D&reserved=0 >> >> On Wed, Mar 21, 2018 at 8:10 PM, Bill Lorensen wrote: >>> I'm still working in the MR. It works great but I'm having cmake >>> issues on Windows. Adding a new third party library is tricky. >>> >>> On Mar 21, 2018 2:08 PM, "Isaiah Norton" wrote: >>>> >>>> +1. I needed this recently in Slicer, and ended up using ITK's >>>> +version >>>> because we link it anyway. >>>> >>>>> >>>>> Not sure if we need to add a new third-party library for this, >>>>> though, especially one that duplicates so much of C++'s built-in machinery. >>>> >>>> >>>> Grisu3 (double-conversion) appears to be ~13x faster than the C++ >>>> stream functions (and 6x faster than sprintf): >>>> >>>> >>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >>>> hub.com%2Fmiloyip%2Fdtoa-benchmark&data=02%7C01%7Classo%40queensu.ca >>>> %7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b92 >>>> 5c%7C1%7C0%7C636578816799629721&sdata=XjioME1t%2F1TwLSUObFB5GGG9d%2B >>>> S8f4%2ByVls1%2B5oB1q4%3D&reserved=0 >>>> >>>> Those numbers are on VS2013/Windows, but that code is easy to build >>>> locally. The sprintf vs double-conversion conclusion holds on 2015 >>>> macbook with 10.12 SDK. The C++ stream functionality is somewhat closer to sprintf. >>>> >>>> [usual benchmark NaCl disclaimer here] >>>> >>>> On Thu, Mar 1, 2018 at 11:32 AM, David Gobbi >>>> wrote: >>>>> >>>>> I agree that floats should be printed so that conversion is lossless. >>>>> Python's console output does this and I find it incredibly useful. >>>>> >>>>> Not sure if we need to add a new third-party library for this, >>>>> though, especially one that duplicates so much of C++'s built-in machinery. >>>>> Isn't it just a matter of printing enough digits? That's basically >>>>> what I do in my own code (plus checks for isnan(x) and isinf(x), >>>>> and a check of the size of fabs(x) for whether to force scientific >>>>> notation.) >>>>> >>>>> - David >>>>> >>>>> >>>>> On Thu, Mar 1, 2018 at 8:48 AM, Bill Lorensen >>>>> >>>>> wrote: >>>>>> >>>>>> Will, >>>>>> >>>>>> It would go in Common/Core I think. The vtk class would be very small. >>>>>> >>>>>> Bill >>>>>> >>>>>> On Thu, Mar 1, 2018 at 7:36 AM, Will Schroeder >>>>>> wrote: >>>>>> > If it works why mess with success? Where would this class >>>>>> > (vtkNumberToString) be placed, in Common/Core (like vtkIndent) >>>>>> > or in some IO directory like VTK/IO/Core? >>>>>> > >>>>>> > On Thu, Mar 1, 2018 at 10:06 AM, Bill Lorensen >>>>>> > >>>>>> > wrote: >>>>>> >> >>>>>> >> Folks, >>>>>> >> >>>>>> >> I'm working on some examples to save/restore camera, polydata, >>>>>> >> property, etc. in XML files. The files can be saved as binary >>>>>> >> or ascii. If I save/restore the info in binary, I get the same >>>>>> >> values for the saved info. But, to no surprise, when I save the >>>>>> >> same data in ascii, I don't get the same values. This is >>>>>> >> because the file writing code does not write enough significant >>>>>> >> digits. >>>>>> >> >>>>>> >> In ITK we solved this problem many years ago. ITK uses a >>>>>> >> reduced version of the Google double-conversion library, >>>>>> >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fdouble-conversion&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799629721&sdata=Iaj1ntftOmg4TsPj7U3eaMXoYfiNmT0yqRlQxZvpMC8%3D&reserved=0. >>>>>> >> >>>>>> >> We added a small class to ITK that uses the library. The class, >>>>>> >> itkNumberToString, has a simple API. To convert floating and >>>>>> >> fixed point numbers to ascii without numerical precision erros, >>>>>> >> >>>>>> >> For example, to convert a float, #include "itkNumberToString.h: >>>>>> >> itk::NumberToString convert; float a = 1.0f/3.0f; >>>>>> >> std::cout << convert(a) << std::endl; >>>>>> >> >>>>>> >> I propose a similar approach in VTK. >>>>>> >> >>>>>> >> Comments please, >>>>>> >> >>>>>> >> Bill >>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by >>>>> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com& >>>>> data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5e >>>>> c%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799629721&s >>>>> data=PSctDI%2BN60sIjEpXkZjufI%2BkcclVZKoI2T2bzBAoj9w%3D&reserved=0 >>>>> >>>>> Visit other Kitware open-source projects at >>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww >>>>> .kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40 >>>>> queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c >>>>> 4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUol >>>>> wTdGnnWJvFjnk8Xo%2FscXkXSnQ%3D&reserved=0 >>>>> >>>>> Search the list archives at: >>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmar >>>>> kmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40q >>>>> ueensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4 >>>>> efb2838b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFI >>>>> f5kGUo6%2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvt >>>>> k.org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40 >>>>> queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c >>>>> 4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0 >>>>> nT8PNtbFF%2BUG9R9kpeMLYvb4I%3D&reserved=0 >>>>> >>>>> >>>> >>> >>> _______________________________________________ >>> Powered by >>> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&da >>> ta=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7C >>> d61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=s >>> 4hn6gw5SNnQrTmqnud8rld8Hh8KAGzfLH7qJYGPaRw%3D&reserved=0 >>> >>> Visit other Kitware open-source projects at >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.k >>> itware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40quee >>> nsu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb28 >>> 38b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUolwTdGnnWJ >>> vFjnk8Xo%2FscXkXSnQ%3D&reserved=0 >>> >>> Search the list archives at: >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkm >>> ail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queen >>> su.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb283 >>> 8b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFIf5kGUo6% >>> 2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 >>> >>> Follow this link to subscribe/unsubscribe: >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk. >>> org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40quee >>> nsu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb28 >>> 38b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0nT8PNtbF >>> F%2BUG9R9kpeMLYvb4I%3D&reserved=0 >>> >>> > > > > -- > Unpaid intern in BillsParadise at noware dot com _______________________________________________ > Powered by https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=s4hn6gw5SNnQrTmqnud8rld8Hh8KAGzfLH7qJYGPaRw%3D&reserved=0 > > Visit other Kitware open-source projects at https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=puooqmxO4eh7NCSUolwTdGnnWJvFjnk8Xo%2FscXkXSnQ%3D&reserved=0 > > Search the list archives at: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=QQnylc0vj5YP7A%2BFIf5kGUo6%2BBAXlpxGxyFsAb0WvAg%3D&reserved=0 > > Follow this link to subscribe/unsubscribe: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk.org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40queensu.ca%7Cab25aee0e0ae47e090b608d5950fa5ec%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636578816799639730&sdata=FmBgc4o0HsL7Nqb5u0nT8PNtbFF%2BUG9R9kpeMLYvb4I%3D&reserved=0 > -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Thu Mar 29 15:22:31 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 29 Mar 2018 12:22:31 -0700 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman Message-ID: Folks, Following my "bull in the china shop" approach to design by committee, I have converted Chapter 6 of the VTK Textbook to markdown and the mkdocs flavor. See: https://lorensen.github.io/VTKExamples/site/VTKBook/Chapter6/ This approach is meant to be a Strawman. Here is what I did: 1) I used pandoc to convert the VTK Textbook PDF to .txt and .md files. The conversion of the main text was excellent. Figures, tables, and equations not so good. 2) I cleaned up much of the cruft manually with emacs. 3) I added links to all of the VTKBookFigures (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). Andrew and I had created these a while ago. The figures contain links to the C++ and Python code that generated the figures. 4) The chapter passes through the normal ScrapeRepo and SyncSiteWithRepo scripts that are used to maintain the static website. As part of this process, I insert doxygen links to any vtk class mentioned in the document. I still have a small issue with this process. Once I figured out an approach to handle figures, it took about 8 hours of manual labor to convert the chapter. What needs to be done on the Chapter 6 Strawman? 1) Add the math. 2) Add the non-vtk generated figures. 3) More cleanup. Other than 1 and 2, I will continue on cleanup. There are several future issues. Converting the text to markdown does not require a brain surgeon. But, editing the content to modern VTK will require more effort. Also, there are lots of old concepts. Andrew and I have already converted< all of the .tcl scripts to C++ and Python. They exist as examples on this page (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). But subjects like the web should probably be replaced with the javascript stuff that is going on at Kitware. Also, there are concepts that are not addressed in the current VTK Textbook including shaders, color management, etc. Please provide feedback/suggestions. I don't have much skin in this game. If the approach looks wrong I'll gladly remove the current strawman and reconcentrate my efforts on making the VTKExamples better. Bill From lasso at queensu.ca Thu Mar 29 15:34:03 2018 From: lasso at queensu.ca (Andras Lasso) Date: Thu, 29 Mar 2018 19:34:03 +0000 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Thank you Bill, this is looks awesome! It is nicely readable - even on portrait screen orientation (e-readers, phones), searchable, hyperlinkable section titles. One nice improvement would be to make figure reference (e.g., Figure6-39) hyperlinked to the figure, so that if I click on it then the page scrolls there. Would be nice to make biblio references (e.g., [Wyszecki82]) hyperlinked, too, but only if it's easy to do. Andras -----Original Message----- From: Bill Lorensen Sent: Thursday, March 29, 2018 3:23 PM To: VTK Developers ; VTK Users Cc: Will ; Ken ; Berk Geveci ; Andras Lasso ; Andrew Maclean Subject: Request for Feedback: VTK Textbook Strawman Folks, Following my "bull in the china shop" approach to design by committee, I have converted Chapter 6 of the VTK Textbook to markdown and the mkdocs flavor. See: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Florensen.github.io%2FVTKExamples%2Fsite%2FVTKBook%2FChapter6%2F&data=02%7C01%7Classo%40queensu.ca%7Cd69312dd725d4229c7a608d595aa6c11%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636579481544635694&sdata=PctmleYfeo8Xkda2fsRZJlcybPoe7DgT5E2LtG%2FNnIY%3D&reserved=0 This approach is meant to be a Strawman. Here is what I did: 1) I used pandoc to convert the VTK Textbook PDF to .txt and .md files. The conversion of the main text was excellent. Figures, tables, and equations not so good. 2) I cleaned up much of the cruft manually with emacs. 3) I added links to all of the VTKBookFigures (https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Florensen.github.io%2FVTKExamples%2Fsite%2FVTKBookFigures%2F&data=02%7C01%7Classo%40queensu.ca%7Cd69312dd725d4229c7a608d595aa6c11%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636579481544635694&sdata=y2MzDqU%2FIuambSesKZRlGMneBsTtc3JiOVQo5jN1Un0%3D&reserved=0). Andrew and I had created these a while ago. The figures contain links to the C++ and Python code that generated the figures. 4) The chapter passes through the normal ScrapeRepo and SyncSiteWithRepo scripts that are used to maintain the static website. As part of this process, I insert doxygen links to any vtk class mentioned in the document. I still have a small issue with this process. Once I figured out an approach to handle figures, it took about 8 hours of manual labor to convert the chapter. What needs to be done on the Chapter 6 Strawman? 1) Add the math. 2) Add the non-vtk generated figures. 3) More cleanup. Other than 1 and 2, I will continue on cleanup. There are several future issues. Converting the text to markdown does not require a brain surgeon. But, editing the content to modern VTK will require more effort. Also, there are lots of old concepts. Andrew and I have already converted< all of the .tcl scripts to C++ and Python. They exist as examples on this page (https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Florensen.github.io%2FVTKExamples%2Fsite%2FVTKBookFigures%2F&data=02%7C01%7Classo%40queensu.ca%7Cd69312dd725d4229c7a608d595aa6c11%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636579481544635694&sdata=y2MzDqU%2FIuambSesKZRlGMneBsTtc3JiOVQo5jN1Un0%3D&reserved=0). But subjects like the web should probably be replaced with the javascript stuff that is going on at Kitware. Also, there are concepts that are not addressed in the current VTK Textbook including shaders, color management, etc. Please provide feedback/suggestions. I don't have much skin in this game. If the approach looks wrong I'll gladly remove the current strawman and reconcentrate my efforts on making the VTKExamples better. Bill From bill.lorensen at gmail.com Thu Mar 29 15:45:53 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 29 Mar 2018 12:45:53 -0700 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Andras, I think I could automate link between figure references and the figures. I'll take a look. On Thu, Mar 29, 2018, 12:34 PM Andras Lasso wrote: > Thank you Bill, this is looks awesome! It is nicely readable - even on > portrait screen orientation (e-readers, phones), searchable, hyperlinkable > section titles. > > One nice improvement would be to make figure reference (e.g., Figure6-39) > hyperlinked to the figure, so that if I click on it then the page scrolls > there. > > Would be nice to make biblio references (e.g., [Wyszecki82]) hyperlinked, > too, but only if it's easy to do. > > Andras > > -----Original Message----- > From: Bill Lorensen > Sent: Thursday, March 29, 2018 3:23 PM > To: VTK Developers ; VTK Users > Cc: Will ; Ken ; Berk > Geveci ; Andras Lasso ; Andrew > Maclean > Subject: Request for Feedback: VTK Textbook Strawman > > Folks, > > Following my "bull in the china shop" approach to design by committee, I > have converted Chapter 6 of the VTK Textbook to markdown and the mkdocs > flavor. > > See: https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Florensen.github.io%2FVTKExamples%2Fsite% > 2FVTKBook%2FChapter6%2F&data=02%7C01%7Classo%40queensu.ca% > 7Cd69312dd725d4229c7a608d595aa6c11%7Cd61ecb3b38b142d582c4efb2838b > 925c%7C1%7C0%7C636579481544635694&sdata=PctmleYfeo8Xkda2fsRZJlcybPoe7D > gT5E2LtG%2FNnIY%3D&reserved=0 > > This approach is meant to be a Strawman. > > Here is what I did: > > 1) I used pandoc to convert the VTK Textbook PDF to .txt and .md files. > The conversion of the main text was excellent. Figures, tables, and > equations not so good. > > 2) I cleaned up much of the cruft manually with emacs. > > 3) I added links to all of the VTKBookFigures (https://na01.safelinks. > protection.outlook.com/?url=https%3A%2F%2Florensen.github. > io%2FVTKExamples%2Fsite%2FVTKBookFigures%2F&data=02% > 7C01%7Classo%40queensu.ca%7Cd69312dd725d4229c7a608d595aa6c11% > 7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636579481544635694&sdata= > y2MzDqU%2FIuambSesKZRlGMneBsTtc3JiOVQo5jN1Un0%3D&reserved=0). Andrew and > I had created these a while ago. The figures contain links to the > C++ and Python code that generated the figures. > > 4) The chapter passes through the normal ScrapeRepo and SyncSiteWithRepo > scripts that are used to maintain the static website. > As part of this process, I insert doxygen links to any vtk class mentioned > in the document. I still have a small issue with this process. > > Once I figured out an approach to handle figures, it took about 8 hours of > manual labor to convert the chapter. > > What needs to be done on the Chapter 6 Strawman? > > 1) Add the math. > > 2) Add the non-vtk generated figures. > > 3) More cleanup. > > Other than 1 and 2, I will continue on cleanup. > > There are several future issues. > > Converting the text to markdown does not require a brain surgeon. But, > editing the content to modern VTK will require more effort. Also, there are > lots of old concepts. Andrew and I have already converted< all of the .tcl > scripts to C++ and Python. They exist as examples on this page ( > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Florensen.github.io%2FVTKExamples%2Fsite% > 2FVTKBookFigures%2F&data=02%7C01%7Classo%40queensu.ca% > 7Cd69312dd725d4229c7a608d595aa6c11%7Cd61ecb3b38b142d582c4efb2838b > 925c%7C1%7C0%7C636579481544635694&sdata=y2MzDqU% > 2FIuambSesKZRlGMneBsTtc3JiOVQo5jN1Un0%3D&reserved=0). > But subjects like the web should probably be replaced with the javascript > stuff that is going on at Kitware. > > Also, there are concepts that are not addressed in the current VTK > Textbook including shaders, color management, etc. > > Please provide feedback/suggestions. I don't have much skin in this game. > If the approach looks wrong I'll gladly remove the current strawman and > reconcentrate my efforts on making the VTKExamples better. > > > Bill > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Thu Mar 29 16:11:31 2018 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 29 Mar 2018 14:11:31 -0600 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: If you don't yet have a way to extract figures from the text, the "poppler" package has a "pdfimages" tool for this: pdfimages -j book.pdf /outdir/prefix With the "-j" flag, all jpegs in the pdf are dumped as prefix-xxxx.jpg, and all other figures as prefix-xxxx.pbm. - David On Thu, Mar 29, 2018 at 1:45 PM, Bill Lorensen wrote: > Andras, > > I think I could automate link between figure references and the figures. > I'll take a look. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Mar 29 16:33:09 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 29 Mar 2018 13:33:09 -0700 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: pandoc extracts them. The problem is the pdf was created from framemaker output and the drawn figures are not made up of one thing. On Thu, Mar 29, 2018 at 1:11 PM, David Gobbi wrote: > If you don't yet have a way to extract figures from the text, the "poppler" > package has a "pdfimages" tool for this: > > pdfimages -j book.pdf /outdir/prefix > > With the "-j" flag, all jpegs in the pdf are dumped as prefix-xxxx.jpg, and > all other figures as prefix-xxxx.pbm. > > - David > > > > On Thu, Mar 29, 2018 at 1:45 PM, Bill Lorensen > wrote: >> >> Andras, >> >> I think I could automate link between figure references and the figures. >> I'll take a look. -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Thu Mar 29 16:34:27 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 29 Mar 2018 13:34:27 -0700 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Turns out I can auto-generate links to figures during the scraping process. I'll try tonight. Bill On Thu, Mar 29, 2018 at 1:33 PM, Bill Lorensen wrote: > pandoc extracts them. The problem is the pdf was created from > framemaker output and the drawn figures are not made up of one thing. > > On Thu, Mar 29, 2018 at 1:11 PM, David Gobbi wrote: >> If you don't yet have a way to extract figures from the text, the "poppler" >> package has a "pdfimages" tool for this: >> >> pdfimages -j book.pdf /outdir/prefix >> >> With the "-j" flag, all jpegs in the pdf are dumped as prefix-xxxx.jpg, and >> all other figures as prefix-xxxx.pbm. >> >> - David >> >> >> >> On Thu, Mar 29, 2018 at 1:45 PM, Bill Lorensen >> wrote: >>> >>> Andras, >>> >>> I think I could automate link between figure references and the figures. >>> I'll take a look. > > > > -- > Unpaid intern in BillsParadise at noware dot com -- Unpaid intern in BillsParadise at noware dot com From andrew.amaclean at gmail.com Thu Mar 29 19:02:41 2018 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Thu, 29 Mar 2018 23:02:41 +0000 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: I'll look at the equations in the next week or so. Looks pretty good so far. I guess the key thing is that it should be easy to update so the book can be modernised. Andrew Maclean On 30 Mar 2018 07:34, "Bill Lorensen" wrote: Turns out I can auto-generate links to figures during the scraping process. I'll try tonight. Bill On Thu, Mar 29, 2018 at 1:33 PM, Bill Lorensen wrote: > pandoc extracts them. The problem is the pdf was created from > framemaker output and the drawn figures are not made up of one thing. > > On Thu, Mar 29, 2018 at 1:11 PM, David Gobbi wrote: >> If you don't yet have a way to extract figures from the text, the "poppler" >> package has a "pdfimages" tool for this: >> >> pdfimages -j book.pdf /outdir/prefix >> >> With the "-j" flag, all jpegs in the pdf are dumped as prefix-xxxx.jpg, and >> all other figures as prefix-xxxx.pbm. >> >> - David >> >> >> >> On Thu, Mar 29, 2018 at 1:45 PM, Bill Lorensen >> wrote: >>> >>> Andras, >>> >>> I think I could automate link between figure references and the figures. >>> I'll take a look. > > > > -- > Unpaid intern in BillsParadise at noware dot com -- Unpaid intern in BillsParadise at noware dot com -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Thu Mar 29 20:59:48 2018 From: nztoddler at yahoo.com (Todd Martin) Date: Fri, 30 Mar 2018 00:59:48 +0000 (UTC) Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: <1155151590.1098355.1522371588064@mail.yahoo.com> This looks great Bill! On Friday, March 30, 2018, 12:02:58 PM GMT+13, Andrew Maclean wrote: I'll look at the equations in the next week or so.Looks pretty good so far.I guess the key thing is that it should be easy to update so the book can be modernised. Andrew Maclean On 30 Mar 2018 07:34, "Bill Lorensen" wrote: Turns out I can auto-generate links to figures during the scraping process. I'll try tonight. Bill On Thu, Mar 29, 2018 at 1:33 PM, Bill Lorensen wrote: > pandoc extracts them. The problem is the pdf was created from > framemaker output and the drawn figures are not made up of one thing. > > On Thu, Mar 29, 2018 at 1:11 PM, David Gobbi wrote: >> If you don't yet have a way to extract figures from the text, the "poppler" >> package has a "pdfimages" tool for this: >> >>? pdfimages -j book.pdf /outdir/prefix >> >> With the "-j" flag, all jpegs in the pdf are dumped as prefix-xxxx.jpg, and >> all other figures as prefix-xxxx.pbm. >> >>? - David >> >> >> >> On Thu, Mar 29, 2018 at 1:45 PM, Bill Lorensen >> wrote: >>> >>> Andras, >>> >>> I think I could automate link between figure references and the figures. >>> I'll take a look. > > > > -- > Unpaid intern in BillsParadise at noware dot com -- Unpaid intern in BillsParadise at noware dot com _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: https://vtk.org/mailman/listinfo/vtk-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Fri Mar 30 06:43:18 2018 From: will.schroeder at kitware.com (Will Schroeder) Date: Fri, 30 Mar 2018 06:43:18 -0400 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: This is a really great work, thanks Bill! It would be great to get the book out there so the community can fix, improve and extend it. To ask a dumb question. and I don't have skin this game either, is markdown the best way to go? Is a LaTeX book better? From what I understand here are tools that convert framemaker to LaTeX etc. I suspect that with LaTeX you'd end up with a better quality result, including things like indexing, cross referencing, etc. And are there other options we should consider? Best, Will On Thu, Mar 29, 2018 at 3:22 PM, Bill Lorensen wrote: > Folks, > > Following my "bull in the china shop" approach to design by committee, > I have converted Chapter 6 of the VTK Textbook to markdown and the > mkdocs flavor. > > See: https://lorensen.github.io/VTKExamples/site/VTKBook/Chapter6/ > > This approach is meant to be a Strawman. > > Here is what I did: > > 1) I used pandoc to convert the VTK Textbook PDF to .txt and .md > files. The conversion of the main text was excellent. Figures, tables, > and equations not so good. > > 2) I cleaned up much of the cruft manually with emacs. > > 3) I added links to all of the VTKBookFigures > (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). Andrew > and I had created these a while ago. The figures contain links to the > C++ and Python code that generated the figures. > > 4) The chapter passes through the normal ScrapeRepo and > SyncSiteWithRepo scripts that are used to maintain the static website. > As part of this process, I insert doxygen links to any vtk class > mentioned in the document. I still have a small issue with this > process. > > Once I figured out an approach to handle figures, it took about 8 > hours of manual labor to convert the chapter. > > What needs to be done on the Chapter 6 Strawman? > > 1) Add the math. > > 2) Add the non-vtk generated figures. > > 3) More cleanup. > > Other than 1 and 2, I will continue on cleanup. > > There are several future issues. > > Converting the text to markdown does not require a brain surgeon. But, > editing the content to modern VTK will require more effort. Also, > there are lots of old concepts. Andrew and I have already converted< > all of the .tcl scripts to C++ and Python. They exist as examples on > this page (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). > But subjects like the web should probably be replaced with the > javascript stuff that is going on at Kitware. > > Also, there are concepts that are not addressed in the current VTK > Textbook including shaders, color management, etc. > > Please provide feedback/suggestions. I don't have much skin in this > game. If the approach looks wrong I'll gladly remove the current > strawman and reconcentrate my efforts on making the VTKExamples > better. > > > Bill > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Fri Mar 30 08:04:37 2018 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 30 Mar 2018 12:04:37 +0000 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: I would seriously consider LaTeX for the reasons mentioned. Additionally, it is really well suited for rendering equations. Andrew Maclean On Fri, 30 Mar. 2018, 21:43 Will Schroeder, wrote: > This is a really great work, thanks Bill! It would be great to get the > book out there so the community can fix, improve and extend it. > > To ask a dumb question. and I don't have skin this game either, is > markdown the best way to go? Is a LaTeX book better? From what I understand > here are tools that convert framemaker to LaTeX etc. I suspect that with > LaTeX you'd end up with a better quality result, including things like > indexing, cross referencing, etc. And are there other options we should > consider? > > Best, > Will > > > > > > On Thu, Mar 29, 2018 at 3:22 PM, Bill Lorensen > wrote: > >> Folks, >> >> Following my "bull in the china shop" approach to design by committee, >> I have converted Chapter 6 of the VTK Textbook to markdown and the >> mkdocs flavor. >> >> See: https://lorensen.github.io/VTKExamples/site/VTKBook/Chapter6/ >> >> This approach is meant to be a Strawman. >> >> Here is what I did: >> >> 1) I used pandoc to convert the VTK Textbook PDF to .txt and .md >> files. The conversion of the main text was excellent. Figures, tables, >> and equations not so good. >> >> 2) I cleaned up much of the cruft manually with emacs. >> >> 3) I added links to all of the VTKBookFigures >> (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). Andrew >> and I had created these a while ago. The figures contain links to the >> C++ and Python code that generated the figures. >> >> 4) The chapter passes through the normal ScrapeRepo and >> SyncSiteWithRepo scripts that are used to maintain the static website. >> As part of this process, I insert doxygen links to any vtk class >> mentioned in the document. I still have a small issue with this >> process. >> >> Once I figured out an approach to handle figures, it took about 8 >> hours of manual labor to convert the chapter. >> >> What needs to be done on the Chapter 6 Strawman? >> >> 1) Add the math. >> >> 2) Add the non-vtk generated figures. >> >> 3) More cleanup. >> >> Other than 1 and 2, I will continue on cleanup. >> >> There are several future issues. >> >> Converting the text to markdown does not require a brain surgeon. But, >> editing the content to modern VTK will require more effort. Also, >> there are lots of old concepts. Andrew and I have already converted< >> all of the .tcl scripts to C++ and Python. They exist as examples on >> this page (https://lorensen.github.io/VTKExamples/site/VTKBookFigures/). >> But subjects like the web should probably be replaced with the >> javascript stuff that is going on at Kitware. >> >> Also, there are concepts that are not addressed in the current VTK >> Textbook including shaders, color management, etc. >> >> Please provide feedback/suggestions. I don't have much skin in this >> game. If the approach looks wrong I'll gladly remove the current >> strawman and reconcentrate my efforts on making the VTKExamples >> better. >> >> >> Bill >> > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthew.brett at gmail.com Fri Mar 30 08:29:40 2018 From: matthew.brett at gmail.com (Matthew Brett) Date: Fri, 30 Mar 2018 13:29:40 +0100 Subject: [vtk-developers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Hi, On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean wrote: > I would seriously consider LaTeX for the reasons mentioned. Additionally, it > is really well suited for rendering equations. I don't know much about mkdocs, but I believe you can configure it to render LaTeX equations: https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 Cheers, Matthew From bill.lorensen at gmail.com Fri Mar 30 09:09:30 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 13:09:30 +0000 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Will, I guess I did not envision a traditional book. This is a web site that is alive. It will present well on all platforms including mobile. Things like indexes aren't really needed. That said if folks want latex so be it. Not me. I can fill my time with other stuff. In the meantime, I'll do some more experiments. Bill On Fri, Mar 30, 2018, 5:30 AM Matthew Brett wrote: > Hi, > > On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean > wrote: > > I would seriously consider LaTeX for the reasons mentioned. > Additionally, it > > is really well suited for rendering equations. > > I don't know much about mkdocs, but I believe you can configure it to > render LaTeX equations: > > https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 > > Cheers, > > Matthew > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the VTK FAQ at: > http://www.vtk.org/Wiki/VTK_FAQ > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtkusers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri Mar 30 09:34:16 2018 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 30 Mar 2018 09:34:16 -0400 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Wouldn't a tool like pandoc allow us to maintain some sort of markdown that can be converted to both something online and LaTeX at the same time? It would be great to support both as we would be interested in support a print-on-demand kind of book on Amazon. There are still people out there that like printed books (like me :-) ). On Fri, Mar 30, 2018 at 9:09 AM, Bill Lorensen wrote: > Will, I guess I did not envision a traditional book. This is a web site > that is alive. It will present well on all platforms including mobile. > Things like indexes aren't really needed. > > That said if folks want latex so be it. Not me. I can fill my time with > other stuff. > > In the meantime, I'll do some more experiments. > > Bill > > On Fri, Mar 30, 2018, 5:30 AM Matthew Brett > wrote: > >> Hi, >> >> On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean >> wrote: >> > I would seriously consider LaTeX for the reasons mentioned. >> Additionally, it >> > is really well suited for rendering equations. >> >> I don't know much about mkdocs, but I believe you can configure it to >> render LaTeX equations: >> >> https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 >> >> Cheers, >> >> Matthew >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at http://www.kitware.com/ >> opensource/opensource.html >> >> Please keep messages on-topic and check the VTK FAQ at: >> http://www.vtk.org/Wiki/VTK_FAQ >> >> Search the list archives at: http://markmail.org/search/?q=vtkusers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtkusers >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri Mar 30 09:34:55 2018 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 30 Mar 2018 09:34:55 -0400 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Btw, I meant to say that this is fantastic and I am super thrilled. I am also kicking myself for not suggesting this to Bill earlier! On Fri, Mar 30, 2018 at 9:34 AM, Berk Geveci wrote: > Wouldn't a tool like pandoc allow us to maintain some sort of markdown > that can be converted to both something online and LaTeX at the same time? > It would be great to support both as we would be interested in support a > print-on-demand kind of book on Amazon. There are still people out there > that like printed books (like me :-) ). > > On Fri, Mar 30, 2018 at 9:09 AM, Bill Lorensen > wrote: > >> Will, I guess I did not envision a traditional book. This is a web site >> that is alive. It will present well on all platforms including mobile. >> Things like indexes aren't really needed. >> >> That said if folks want latex so be it. Not me. I can fill my time with >> other stuff. >> >> In the meantime, I'll do some more experiments. >> >> Bill >> >> On Fri, Mar 30, 2018, 5:30 AM Matthew Brett >> wrote: >> >>> Hi, >>> >>> On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean >>> wrote: >>> > I would seriously consider LaTeX for the reasons mentioned. >>> Additionally, it >>> > is really well suited for rendering equations. >>> >>> I don't know much about mkdocs, but I believe you can configure it to >>> render LaTeX equations: >>> >>> https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 >>> >>> Cheers, >>> >>> Matthew >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the VTK FAQ at: >>> http://www.vtk.org/Wiki/VTK_FAQ >>> >>> Search the list archives at: http://markmail.org/search/?q=vtkusers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtkusers >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Mar 30 09:58:00 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 06:58:00 -0700 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: pandoc is not perfect, but I did use it to convert the book's pdf to markdown doc, docx and txt. On Fri, Mar 30, 2018 at 6:34 AM, Berk Geveci wrote: > Btw, I meant to say that this is fantastic and I am super thrilled. I am > also kicking myself for not suggesting this to Bill earlier! > > On Fri, Mar 30, 2018 at 9:34 AM, Berk Geveci > wrote: >> >> Wouldn't a tool like pandoc allow us to maintain some sort of markdown >> that can be converted to both something online and LaTeX at the same time? >> It would be great to support both as we would be interested in support a >> print-on-demand kind of book on Amazon. There are still people out there >> that like printed books (like me :-) ). >> >> On Fri, Mar 30, 2018 at 9:09 AM, Bill Lorensen >> wrote: >>> >>> Will, I guess I did not envision a traditional book. This is a web site >>> that is alive. It will present well on all platforms including mobile. >>> Things like indexes aren't really needed. >>> >>> That said if folks want latex so be it. Not me. I can fill my time with >>> other stuff. >>> >>> In the meantime, I'll do some more experiments. >>> >>> Bill >>> >>> On Fri, Mar 30, 2018, 5:30 AM Matthew Brett >>> wrote: >>>> >>>> Hi, >>>> >>>> On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean >>>> wrote: >>>> > I would seriously consider LaTeX for the reasons mentioned. >>>> > Additionally, it >>>> > is really well suited for rendering equations. >>>> >>>> I don't know much about mkdocs, but I believe you can configure it to >>>> render LaTeX equations: >>>> >>>> https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 >>>> >>>> Cheers, >>>> >>>> Matthew >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Please keep messages on-topic and check the VTK FAQ at: >>>> http://www.vtk.org/Wiki/VTK_FAQ >>>> >>>> Search the list archives at: http://markmail.org/search/?q=vtkusers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://vtk.org/mailman/listinfo/vtkusers >> >> > -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Fri Mar 30 10:00:26 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 07:00:26 -0700 Subject: [vtk-developers] Links to Figures Message-ID: Now auto-generated links to figures are here: https://lorensen.github.io/VTKExamples/site/VTKBook/Chapter6/ If a figure exists in the chapter, references in the text will link to the figure. Bill -- Unpaid intern in BillsParadise at noware dot com From lasso at queensu.ca Fri Mar 30 11:26:03 2018 From: lasso at queensu.ca (Andras Lasso) Date: Fri, 30 Mar 2018 15:26:03 +0000 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Despite all its limitations, Markdown is becoming one of the most widely used standard in technical writing. You can get books authored in Markdown published as hardcopy, see for example http://docs.atlas.oreilly.com/writing_in_markdown.html. If we can live without sophisticated typesetting then we could save a lot of time and be ?compatible? with many more potential authors and online publishing services by using Markdown instead of Latex. ITK software guide is written in Latex, we could ask ITK folks about how happy they are with it. Andras From: vtk-developers On Behalf Of Berk Geveci Sent: Friday, March 30, 2018 9:34 AM To: Bill Lorensen Cc: VTK Developers ; VTK Users ; Andrew Maclean ; Will Schroeder Subject: Re: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman Wouldn't a tool like pandoc allow us to maintain some sort of markdown that can be converted to both something online and LaTeX at the same time? It would be great to support both as we would be interested in support a print-on-demand kind of book on Amazon. There are still people out there that like printed books (like me :-) ). On Fri, Mar 30, 2018 at 9:09 AM, Bill Lorensen > wrote: Will, I guess I did not envision a traditional book. This is a web site that is alive. It will present well on all platforms including mobile. Things like indexes aren't really needed. That said if folks want latex so be it. Not me. I can fill my time with other stuff. In the meantime, I'll do some more experiments. Bill On Fri, Mar 30, 2018, 5:30 AM Matthew Brett > wrote: Hi, On Fri, Mar 30, 2018 at 1:04 PM, Andrew Maclean > wrote: > I would seriously consider LaTeX for the reasons mentioned. Additionally, it > is really well suited for rendering equations. I don't know much about mkdocs, but I believe you can configure it to render LaTeX equations: https://github.com/mkdocs/mkdocs/issues/253#issuecomment-196486412 Cheers, Matthew _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the VTK FAQ at: http://www.vtk.org/Wiki/VTK_FAQ Search the list archives at: http://markmail.org/search/?q=vtkusers Follow this link to subscribe/unsubscribe: https://vtk.org/mailman/listinfo/vtkusers -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthew.brett at gmail.com Fri Mar 30 12:07:57 2018 From: matthew.brett at gmail.com (Matthew Brett) Date: Fri, 30 Mar 2018 17:07:57 +0100 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Hi, On Fri, Mar 30, 2018 at 4:26 PM, Andras Lasso wrote: > Despite all its limitations, Markdown is becoming one of the most widely > used standard in technical writing. You can get books authored in Markdown > published as hardcopy, see for example > http://docs.atlas.oreilly.com/writing_in_markdown.html. > > > > If we can live without sophisticated typesetting then we could save a lot of > time and be ?compatible? with many more potential authors and online > publishing services by using Markdown instead of Latex. You probably saw the warning on the O'Reilly Markdown page: """ Markdown is best for simple content. It does not support many standard technical book elements, including parts, admonitions, sidebars, and cross references. """ Some of that might be called "typsetting" but maybe not parts or cross-references. Matthew From bill.lorensen at gmail.com Fri Mar 30 12:15:04 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 16:15:04 +0000 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: Mkdocs does contain admonitions. Also I process the markdown and create the cross references automatically. On Fri, Mar 30, 2018, 9:08 AM Matthew Brett wrote: > Hi, > > On Fri, Mar 30, 2018 at 4:26 PM, Andras Lasso wrote: > > Despite all its limitations, Markdown is becoming one of the most widely > > used standard in technical writing. You can get books authored in > Markdown > > published as hardcopy, see for example > > http://docs.atlas.oreilly.com/writing_in_markdown.html. > > > > > > > > If we can live without sophisticated typesetting then we could save a > lot of > > time and be ?compatible? with many more potential authors and online > > publishing services by using Markdown instead of Latex. > > You probably saw the warning on the O'Reilly Markdown page: > > """ > Markdown is best for simple content. It does not support many standard > technical book elements, including parts, admonitions, sidebars, and > cross references. > """ > > Some of that might be called "typsetting" but maybe not parts or > cross-references. > > Matthew > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.thompson at kitware.com Fri Mar 30 12:55:16 2018 From: david.thompson at kitware.com (David Thompson) Date: Fri, 30 Mar 2018 12:55:16 -0400 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: > pandoc is not perfect, but I did use it to convert the book's pdf to > markdown doc, docx and txt. I believe pandoc also deals with restructured text (rst), which is similar to markdown. It is what https://readthedocs.org/ uses (via the python Sphinx tool). We use it for some other projects at Kitware (SMTK and CMB) and it works well. Unlike markdown, it is extensible (you can write python code to inject HTML/JS/LaTeX etc. into the output). It also has some hooks to include portions of external files. We use this to directly include source code (that gets tested!) into the documentation. I am working toward using image tests as part of the documentation. Of course, it's not perfect (there's no guarantee all the documentation makes sense anymore if you change the source). I also want to use it to inject interactive vtk-js content into the online version of the docs (and a screenshot into the offline version), which is possible via an extension if not directly. David From bill.lorensen at gmail.com Fri Mar 30 13:21:26 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 17:21:26 +0000 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: We also do the testing every night. Since I already have the infrastructure in place I hope to keep using mkdocs with the material look and feel. On Fri, Mar 30, 2018, 9:55 AM David Thompson wrote: > > pandoc is not perfect, but I did use it to convert the book's pdf to > > markdown doc, docx and txt. > > I believe pandoc also deals with restructured text (rst), which is similar > to markdown. It is what https://readthedocs.org/ uses (via the python > Sphinx tool). We use it for some other projects at Kitware (SMTK and CMB) > and it works well. Unlike markdown, it is extensible (you can write python > code to inject HTML/JS/LaTeX etc. into the output). > > It also has some hooks to include portions of external files. We use this > to directly include source code (that gets tested!) into the documentation. > I am working toward using image tests as part of the documentation. Of > course, it's not perfect (there's no guarantee all the documentation makes > sense anymore if you change the source). I also want to use it to inject > interactive vtk-js content into the online version of the docs (and a > screenshot into the offline version), which is possible via an extension if > not directly. > > David -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Mar 30 13:24:50 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2018 17:24:50 +0000 Subject: [vtk-developers] [vtkusers] Request for Feedback: VTK Textbook Strawman In-Reply-To: References: Message-ID: I also process the markdown and insert code, images, doxygen links to all mentions of vtk classes. So I guess markdown is extensible with my own python code. On Fri, Mar 30, 2018, 10:21 AM Bill Lorensen wrote: > We also do the testing every night. Since I already have the > infrastructure in place I hope to keep using mkdocs with the material look > and feel. > > On Fri, Mar 30, 2018, 9:55 AM David Thompson > wrote: > >> > pandoc is not perfect, but I did use it to convert the book's pdf to >> > markdown doc, docx and txt. >> >> I believe pandoc also deals with restructured text (rst), which is >> similar to markdown. It is what https://readthedocs.org/ uses (via the >> python Sphinx tool). We use it for some other projects at Kitware (SMTK and >> CMB) and it works well. Unlike markdown, it is extensible (you can write >> python code to inject HTML/JS/LaTeX etc. into the output). >> >> It also has some hooks to include portions of external files. We use this >> to directly include source code (that gets tested!) into the documentation. >> I am working toward using image tests as part of the documentation. Of >> course, it's not perfect (there's no guarantee all the documentation makes >> sense anymore if you change the source). I also want to use it to inject >> interactive vtk-js content into the online version of the docs (and a >> screenshot into the offline version), which is possible via an extension if >> not directly. >> >> David > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From biagas2 at llnl.gov Fri Mar 30 16:18:41 2018 From: biagas2 at llnl.gov (Kathleen S. Biagas) Date: Fri, 30 Mar 2018 13:18:41 -0700 Subject: [vtk-developers] problem with multiple offscreen render windows Message-ID: <1522441121.3780.17.camel@beetlehunter> Hello, I used the Offscreen Renderer example from here: https://lorensen.github.io/VTKExamples/site/Cxx/Utilities/OffScreenRendering/ But I modified it for use with VTK-8 by removing the Factory logic that sets up Mesa classes. This works great. However, when I duplicate all the code (probably more than is strictly necessary) to create a second render window, then it segv's in a call to XQueryExtension during vtkXOpenGLRenderWindow::PopContext. If I comment out the logic that turns on OffScreen Rendering, then it doesn't crash. I compiled VTK-8.1 with gcc 6.2, qt 5.10.1, python 2.7.14, and system GL. This *should* work, shouldn't it? I've attached the OffScreenRendering source code I used, as well as output from a call to 'ReportCapabilities' on the vtkRenderWindow. Kathleen -------------- next part -------------- A non-text attachment was scrubbed... Name: OffScreenRendering.cxx Type: text/x-c++src Size: 2957 bytes Desc: not available URL: -------------- next part -------------- server glx vendor string: NVIDIA Corporation server glx version string: 1.4 server glx extensions: GLX_EXT_visual_info GLX_EXT_visual_rating GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGI_video_sync GLX_SGI_swap_control GLX_EXT_swap_control GLX_EXT_swap_control_tear GLX_EXT_texture_from_pixmap GLX_EXT_buffer_age GLX_ARB_create_context GLX_ARB_create_context_profile GLX_EXT_create_context_es_profile GLX_EXT_create_context_es2_profile GLX_ARB_create_context_robustness GLX_NV_delay_before_swap GLX_EXT_stereo_tree GLX_ARB_context_flush_control GLX_ARB_multisample GLX_NV_float_buffer GLX_ARB_fbconfig_float GLX_EXT_framebuffer_sRGB GLX_NV_multisample_coverage GLX_NV_copy_image client glx vendor string: NVIDIA Corporation client glx version string: 1.4 glx extensions: GLX_EXT_visual_info GLX_EXT_visual_rating GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGI_video_sync GLX_SGI_swap_control GLX_EXT_swap_control GLX_EXT_swap_control_tear GLX_EXT_texture_from_pixmap GLX_EXT_buffer_age GLX_ARB_create_context GLX_ARB_create_context_profile GLX_EXT_create_context_es_profile GLX_EXT_create_context_es2_profile GLX_ARB_create_context_robustness GLX_NV_delay_before_swap GLX_EXT_stereo_tree GLX_ARB_context_flush_control GLX_ARB_multisample GLX_NV_float_buffer GLX_ARB_fbconfig_float GLX_EXT_framebuffer_sRGB GLX_NV_multisample_coverage GLX_NV_copy_image GLX_ARB_get_proc_address OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GT 520/PCIe/SSE2 OpenGL version string: 4.5.0 NVIDIA 349.16 OpenGL extensions: GL_AMD_multi_draw_indirect GL_ARB_arrays_of_arrays GL_ARB_base_instance GL_ARB_blend_func_extended GL_ARB_buffer_storage GL_ARB_clear_buffer_object GL_ARB_clear_texture GL_ARB_clip_control GL_ARB_color_buffer_float GL_ARB_compressed_texture_pixel_storage GL_ARB_conservative_depth GL_ARB_compute_shader GL_ARB_compute_variable_group_size GL_ARB_conditional_render_inverted GL_ARB_copy_buffer GL_ARB_copy_image GL_ARB_cull_distance GL_ARB_debug_output GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_derivative_control GL_ARB_direct_state_access GL_ARB_draw_buffers GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_enhanced_layouts GL_ARB_ES2_compatibility GL_ARB_ES3_compatibility GL_ARB_ES3_1_compatibility GL_ARB_explicit_attrib_location GL_ARB_explicit_uniform_location GL_ARB_fragment_coord_conventions GL_ARB_fragment_layer_viewport GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_framebuffer_no_attachments GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_geometry_shader4 GL_ARB_get_program_binary GL_ARB_get_texture_sub_image GL_ARB_gpu_shader5 GL_ARB_gpu_shader_fp64 GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_imaging GL_ARB_indirect_parameters GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_internalformat_query2 GL_NV_internalformat_sample_query GL_ARB_invalidate_subdata GL_ARB_map_buffer_alignment GL_ARB_map_buffer_range GL_ARB_multi_bind GL_ARB_multi_draw_indirect GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_occlusion_query2 GL_ARB_pipeline_statistics_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_program_interface_query GL_ARB_provoking_vertex GL_ARB_robust_buffer_access_behavior GL_ARB_robustness GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_separate_shader_objects GL_ARB_shader_atomic_counters GL_ARB_shader_bit_encoding GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_shader_image_load_store GL_ARB_shader_image_size GL_ARB_shader_objects GL_ARB_shader_precision GL_ARB_query_buffer_object GL_ARB_shader_storage_buffer_object GL_ARB_shader_subroutine GL_ARB_shader_texture_image_samples GL_ARB_shader_texture_lod GL_ARB_shading_language_100 GL_ARB_shading_language_420pack GL_ARB_shading_language_include GL_ARB_shading_language_packing GL_ARB_shadow GL_ARB_sparse_buffer GL_ARB_sparse_texture GL_ARB_stencil_texturing GL_ARB_sync GL_ARB_tessellation_shader GL_ARB_texture_barrier GL_ARB_texture_border_clamp GL_ARB_texture_buffer_object GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_buffer_range GL_ARB_texture_compression GL_ARB_texture_compression_bptc GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_cube_map_array GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_float GL_ARB_texture_gather GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_mirrored_repeat GL_ARB_texture_multisample GL_ARB_texture_non_power_of_two GL_ARB_texture_query_levels GL_ARB_texture_query_lod GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_texture_rgb10_a2ui GL_ARB_texture_stencil8 GL_ARB_texture_storage GL_ARB_texture_storage_multisample GL_ARB_texture_swizzle GL_ARB_texture_view GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_transform_feedback_instanced GL_ARB_transform_feedback_overflow_query GL_ARB_transpose_matrix GL_ARB_uniform_buffer_object GL_ARB_vertex_array_bgra GL_ARB_vertex_array_object GL_ARB_vertex_attrib_64bit GL_ARB_vertex_attrib_binding GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_vertex_type_10f_11f_11f_rev GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_ARB_window_pos GL_ATI_draw_buffers GL_ATI_texture_float GL_ATI_texture_mirror_once GL_S3_s3tc GL_EXT_texture_env_add GL_EXT_abgr GL_EXT_bgra GL_EXT_bindable_uniform GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_compiled_vertex_array GL_EXT_Cg_shader GL_EXT_depth_bounds_test GL_EXT_direct_state_access GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXTX_framebuffer_mixed_formats GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_object GL_EXT_framebuffer_sRGB GL_EXT_geometry_shader4 GL_EXT_gpu_program_parameters GL_EXT_gpu_shader4 GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_packed_pixels GL_EXT_pixel_buffer_object GL_EXT_point_parameters GL_EXT_polygon_offset_clamp GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_shader_objects GL_EXT_separate_specular_color GL_EXT_shader_image_load_store GL_EXT_shader_integer_mix GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_texture3D GL_EXT_texture_array GL_EXT_texture_buffer_object GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_latc GL_EXT_texture_compression_rgtc GL_EXT_texture_compression_s3tc GL_EXT_texture_cube_map GL_EXT_texture_edge_clamp GL_EXT_texture_env_combine GL_EXT_texture_env_dot3 GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod GL_EXT_texture_lod_bias GL_EXT_texture_mirror_clamp GL_EXT_texture_object GL_EXT_texture_shared_exponent GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_texture_storage GL_EXT_texture_swizzle GL_EXT_timer_query GL_EXT_transform_feedback2 GL_EXT_vertex_array GL_EXT_vertex_array_bgra GL_EXT_vertex_attrib_64bit GL_EXT_x11_sync_object GL_EXT_import_sync_object GL_IBM_rasterpos_clip GL_IBM_texture_mirrored_repeat GL_KHR_context_flush_control GL_KHR_debug GL_KHR_robust_buffer_access_behavior GL_KHR_robustness GL_KTX_buffer_region GL_NV_bindless_multi_draw_indirect GL_NV_bindless_multi_draw_indirect_count GL_NV_blend_equation_advanced GL_NV_blend_square GL_NV_command_list GL_NV_compute_program5 GL_NV_conditional_render GL_NV_copy_depth_to_color GL_NV_copy_image GL_NV_depth_buffer_float GL_NV_depth_clamp GL_NV_draw_texture GL_NV_ES1_1_compatibility GL_NV_ES3_1_compatibility GL_NV_explicit_multisample GL_NV_fence GL_NV_float_buffer GL_NV_fog_distance GL_NV_fragment_program GL_NV_fragment_program_option GL_NV_fragment_program2 GL_NV_framebuffer_multisample_coverage GL_NV_geometry_shader4 GL_NV_gpu_program4 GL_NV_gpu_program4_1 GL_NV_gpu_program5 GL_NV_gpu_program5_mem_extended GL_NV_gpu_program_fp64 GL_NV_gpu_shader5 GL_NV_half_float GL_NV_light_max_exponent GL_NV_multisample_coverage GL_NV_multisample_filter_hint GL_NV_occlusion_query GL_NV_packed_depth_stencil GL_NV_parameter_buffer_object GL_NV_parameter_buffer_object2 GL_NV_path_rendering GL_NV_pixel_data_range GL_NV_point_sprite GL_NV_primitive_restart GL_NV_register_combiners GL_NV_register_combiners2 GL_NV_shader_atomic_counters GL_NV_shader_atomic_float GL_NV_shader_buffer_load GL_NV_shader_storage_buffer_object GL_NV_texgen_reflection GL_NV_texture_barrier GL_NV_texture_compression_vtc GL_NV_texture_env_combine4 GL_NV_texture_multisample GL_NV_texture_rectangle GL_NV_texture_shader GL_NV_texture_shader2 GL_NV_texture_shader3 GL_NV_transform_feedback GL_NV_transform_feedback2 GL_NV_uniform_buffer_unified_memory GL_NV_vdpau_interop GL_NV_vertex_array_range GL_NV_vertex_array_range2 GL_NV_vertex_attrib_integer_64bit GL_NV_vertex_buffer_unified_memory GL_NV_vertex_program GL_NV_vertex_program1_1 GL_NV_vertex_program2 GL_NV_vertex_program2_option GL_NV_vertex_program3 GL_NVX_conditional_render GL_NVX_gpu_memory_info GL_NV_shader_thread_group GL_KHR_blend_equation_advanced GL_SGIS_generate_mipmap GL_SGIS_texture_lod GL_SGIX_depth_texture GL_SGIX_shadow GL_SUN_slice_accum X Extensions: Generic Event Extension, SHAPE, MIT-SHM, XInputExtension, XTEST, BIG-REQUESTS, SYNC, XKEYBOARD, XC-MISC, SECURITY, XFIXES, RENDER, RANDR, XINERAMA, Composite, DAMAGE, MIT-SCREEN-SAVER, DOUBLE-BUFFER, RECORD, DPMS, Present, X-Resource, XVideo, XFree86-VidModeExtension, XFree86-DGA, DRI2, GLX, NV-GLX, NV-CONTROL, XINERAMA From francois.budin at kitware.com Fri Mar 30 16:44:58 2018 From: francois.budin at kitware.com (Francois Budin) Date: Fri, 30 Mar 2018 16:44:58 -0400 Subject: [vtk-developers] problem with multiple offscreen render windows In-Reply-To: <1522441121.3780.17.camel@beetlehunter> References: <1522441121.3780.17.camel@beetlehunter> Message-ID: Hello Kathleen, Could you try with the latest VTK (master branch)? I encountered a bug that sounds very similar to what you are describing and a patch has been integrated in VTK recently: https://gitlab.kitware.com/vtk/vtk/commit/a7988f5c530d6db31d6d9a774049c5247a9ac80c Hope this helps, Francois On Fri, Mar 30, 2018 at 4:18 PM, Kathleen S. Biagas wrote: > Hello, > > I used the Offscreen Renderer example from here: > https://lorensen.github.io/VTKExamples/site/Cxx/ > Utilities/OffScreenRendering/ > > But I modified it for use with VTK-8 by removing the Factory logic that > sets up Mesa classes. > > This works great. > > However, when I duplicate all the code (probably more than is strictly > necessary) to create a second render window, then it segv's in a call to > XQueryExtension during vtkXOpenGLRenderWindow::PopContext. > > If I comment out the logic that turns on OffScreen Rendering, then it > doesn't crash. > > I compiled VTK-8.1 with gcc 6.2, qt 5.10.1, python 2.7.14, and system > GL. > > This *should* work, shouldn't it? > > I've attached the OffScreenRendering source code I used, as well as > output from a call to 'ReportCapabilities' on the vtkRenderWindow. > > Kathleen > > > > > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From biagas2 at llnl.gov Fri Mar 30 17:35:11 2018 From: biagas2 at llnl.gov (Kathleen S. Biagas) Date: Fri, 30 Mar 2018 14:35:11 -0700 Subject: [vtk-developers] problem with multiple offscreen render windows In-Reply-To: References: <1522441121.3780.17.camel@beetlehunter> Message-ID: <1522445711.3780.19.camel@beetlehunter> Thanks, I tried that, and it worked, thanks so much! Kathleen On Fri, 2018-03-30 at 16:44 -0400, Francois Budin wrote: > Hello Kathleen, > > > Could you try with the latest VTK (master branch)? I encountered a bug > that sounds very similar to what you are describing and a patch has > been integrated in VTK recently: > https://gitlab.kitware.com/vtk/vtk/commit/a7988f5c530d6db31d6d9a774049c5247a9ac80c > > > Hope this helps, > > > Francois > > > On Fri, Mar 30, 2018 at 4:18 PM, Kathleen S. Biagas > wrote: > Hello, > > I used the Offscreen Renderer example from here: > https://lorensen.github.io/VTKExamples/site/Cxx/Utilities/OffScreenRendering/ > > But I modified it for use with VTK-8 by removing the Factory > logic that > sets up Mesa classes. > > This works great. > > However, when I duplicate all the code (probably more than is > strictly > necessary) to create a second render window, then it segv's in > a call to > XQueryExtension during vtkXOpenGLRenderWindow::PopContext. > > If I comment out the logic that turns on OffScreen Rendering, > then it > doesn't crash. > > I compiled VTK-8.1 with gcc 6.2, qt 5.10.1, python 2.7.14, and > system > GL. > > This *should* work, shouldn't it? > > I've attached the OffScreenRendering source code I used, as > well as > output from a call to 'ReportCapabilities' on the > vtkRenderWindow. > > Kathleen > > > > > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > >