[vtk-developers] Two quick dashboard issues

[Utkarsh Ayachit]

Fixed vtkMomentsTensor, and vtkTransformFeedback.

https://gitlab.kitware.com/vtk/vtk/merge_requests/3820

On Mon, Jan 22, 2018 at 12:01 PM, Sean McBride <sean at rogue-research.com> wrote:
> Hi all,
>
> There are also a number of cppcheck warnings that seem to have been ignored for some time now:
>
> <https://open.cdash.org/viewBuildError.php?type=1&buildid=5229459>
>
> They are:
>
> Common/ExecutionModel/vtkAlgorithm.h:665: portability: Returning an integer in a function with pointer return type is not portable.
>
> Filters/MomentInvariants/vtkMomentsHelper.cxx:549: style: Statements following return, break, continue, goto or throw will never be executed.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:181: performance: Function parameter 'parentInfo' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:195: performance: Function parameter 'parentInfo' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:208: performance: Function parameter 'productInfo1' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:219: performance: Function parameter 'parentInfo' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:466: performance: Function parameter 'indices' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:476: performance: Function parameter 'indices' should be passed by reference.
>
> Filters/MomentInvariants/vtkMomentsTensor.h:489: performance: Function parameter 'data' should be passed by reference.
>
> IO/Geometry/vtkSTLReader.cxx:351: performance: Function parameter 'expected' should be passed by reference.
>
> IO/Geometry/vtkSTLReader.cxx:357: performance: Function parameter 'expected' should be passed by reference.
>
> IO/Geometry/vtkSTLReader.cxx:357: performance: Function parameter 'found' should be passed by reference.
>
> IO/Geometry/vtkSTLReader.cxx:437: warning: Ineffective call of function 'empty()'. Did you intend to call 'clear()' instead?
>
> Rendering/OpenGL2/vtkTransformFeedback.cxx:231: style: Unused variable: tbo
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> https://vtk.org/mailman/listinfo/vtk-developers
>