[vtk-developers] Texture issues causing vtkImageResliceMapper to fail

[David Gobbi]

Hi Ken,

Calling Modified() on the TCoords array in vtkOpenGLImageSliceMapper fixes
the issue.  I'll push an MR.

Thanks,
  - David

On Tue, Sep 5, 2017 at 8:13 PM, David Gobbi <david.gobbi at gmail.com> wrote:

> Yeah, I've been looking over that commit (my own git bisect gave me the
> same answer a couple hours ago).  Definitely looks like it could be
> timestamp-related.
>
>  - David
>
> On Tue, Sep 5, 2017 at 7:42 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>
>> Ken was right. git bisect picked the winner
>>
>> 59373905501ae983e1587d6b118fcbcccd548c1c is the first bad commit
>> commit 59373905501ae983e1587d6b118fcbcccd548c1c
>> Author: Ken Martin <ken.martin at kitware.com>
>> Date:   Tue Aug 22 17:07:43 2017 -0400
>>
>>     a number of cleanups to the VBO code
>>
>>     added a lot of documentation, removed a couple methods
>>     that were no longer needed. Improved the handling of
>>     data arrays so that they are more often cached.
>>
>> On Tue, Sep 5, 2017 at 9:18 PM, Ken Martin <ken.martin at kitware.com>
>> wrote:
>> > My guess is something is calling Set(..) on a texture or point array
>> and not
>> > marking it modified.  There was a change I made recently that will cause
>> > those cases to not update the VBO.
>> >
>> > On Tue, Sep 5, 2017 at 7:00 PM, David Gobbi <david.gobbi at gmail.com>
>> wrote:
>> >>
>> >> I'm doing a bisect right now.  Builds take forever, though.
>> >>
>> >> On Tue, Sep 5, 2017 at 4:58 PM, Bill Lorensen <bill.lorensen at gmail.com
>> >
>> >> wrote:
>> >>>
>> >>> David,
>> >>>
>> >>> git bisect is great for identifying the culprit.
>> >>>
>> >>> On Tue, Sep 5, 2017 at 6:37 PM David Gobbi <david.gobbi at gmail.com>
>> wrote:
>> >>>>
>> >>>> Something has changed in VTK in the past couple weeks relating to
>> >>>> textures that is causing vtkImageResliceMapper to fail.   The
>> problem can be
>> >>>> seen in Examples/ImageProcessing/Python/ImageInteractorReslice.py:
>> if the
>> >>>> window is resized to make the window taller or wider, then the
>> texture
>> >>>> appears to be stretched in the wrong direction.  It's almost as if
>> somewhere
>> >>>> in the code the "x" texture coords are being read as "y" and
>> vice-versa.
>> >>>>
>> >>>> Can anyone point me to a place to look?
>> >>>>
>> >>>> Thanks,
>> >>>>  - David
>> >>>> _______________________________________________
>> >>>> Powered by www.kitware.com
>> >>>>
>> >>>> Visit other Kitware open-source projects at
>> >>>> http://www.kitware.com/opensource/opensource.html
>> >>>>
>> >>>> Search the list archives at:
>> >>>> http://markmail.org/search/?q=vtk-developers
>> >>>>
>> >>>> Follow this link to subscribe/unsubscribe:
>> >>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>> >>>>
>> >>> --
>> >>> Unpaid intern in BillsBasement at noware dot com
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> Powered by www.kitware.com
>> >>
>> >> Visit other Kitware open-source projects at
>> >> http://www.kitware.com/opensource/opensource.html
>> >>
>> >> Search the list archives at: http://markmail.org/search/?q=
>> vtk-developers
>> >>
>> >> Follow this link to subscribe/unsubscribe:
>> >> http://public.kitware.com/mailman/listinfo/vtk-developers
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Ken Martin PhD
>> > Distinguished Engineer
>> > Kitware Inc.
>> > 28 Corporate Drive
>> > Clifton Park NY 12065
>> >
>> > This communication, including all attachments, contains confidential and
>> > legally privileged information, and it is intended only for the use of
>> the
>> > addressee.  Access to this email by anyone else is unauthorized. If you
>> are
>> > not the intended recipient, any disclosure, copying, distribution or any
>> > action taken in reliance on it is prohibited and may be unlawful. If you
>> > received this communication in error please notify us immediately and
>> > destroy the original message.  Thank you.
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170905/c6dc525f/attachment-0001.html>