[vtk-developers] proposal - drop +1/+2/+3 in favor of simply +1

Jon Haitz Legarreta jhlegarreta at vicomtech.org
Wed Oct 4 12:07:46 EDT 2017


Concerning Berk's suggestion, and if I understood well, if +1 is
sufficient for merging, IMHO then we'll hardly see +2 and +3, unless
somebody explicitly asks for an exotic build (i.e. not regular
buildbots). And in that case, one of the two would be enough (i.e.
tested in local exotic build, and it works).

JON HAITZ

--



On 4 October 2017 at 18:01, Ken Martin <ken.martin at kitware.com> wrote:
> Or use colors like TSA. This topic is threat level Orange ;-)
>
> On Wed, Oct 4, 2017 at 11:51 AM, Berk Geveci <berk.geveci at kitware.com>
> wrote:
>>
>> We could keep +2 and +3 but make +1 sufficient for merging... Just saying.
>>
>> On Tue, Oct 3, 2017 at 5:24 PM, Sean McBride <sean at rogue-research.com>
>> wrote:
>>>
>>> I rather like that distinction, i.e. the difference between merely "looks
>>> fine" vs "looks fine, I tried it, I know this code, I authoritatively
>>> approve".
>>>
>>> But I'm not super bothered about it all...
>>>
>>> Sean
>>>
>>>
>>> On Tue, 3 Oct 2017 23:17:34 +0200, Jon Haitz Legarreta said:
>>>
>>> >Although I use Mathieu's convention, I'd be OK if we switched to +1/-1
>>> > only.
>>> >
>>> >JON HAITZ
>>> >
>>> >--
>>> >
>>> >
>>> >
>>> >On 3 October 2017 at 16:34, Mathieu Westphal
>>> ><mathieu.westphal at kitware.com> wrote:
>>> >> Hi
>>> >>
>>> >> My scale was shifted by +1 actually.
>>> >> What i'm using is the following :
>>> >>
>>> >>   +1 or (:+1:) means "I consider the changed ready for integration"
>>> >>   +2 means "I consider the changed ready for integration and have
>>> >> locally
>>> >> tested it and verified it works."
>>> >>
>>> >> I'm happy with anything, but I always apreciate when a reviewer go
>>> >> ahead and
>>> >> try out the feature during the review.
>>> >>
>>> >> Mathieu Westphal
>>> >>
>>> >> On Tue, Oct 3, 2017 at 4:29 PM, David E DeMarle
>>> >> <dave.demarle at kitware.com>
>>> >> wrote:
>>> >>>
>>> >>> Our current rule is:
>>> >>>
>>> >>> https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/
>>> >develop.md#leading-line
>>> >>>
>>> >>> +1 has alway been problematic.
>>> >>> I've never seen a +3 comment in the wild.
>>> >>>
>>> >>> What say we simplify to just +1 or -1 with words for everything else
>>> >>> we
>>> >>> need to say?
>>> >>>
>>> >>> Any +1's out there for this suggestion?
>>> >>> --
>>> >>> David E DeMarle
>>> >>> Kitware, Inc.
>>> >>> Principal Engineer
>>> >>> 21 Corporate Drive
>>> >>> Clifton Park, NY 12065-8662
>>> >>> Phone: 518-881-4909
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>
>
>
>
> --
> Ken Martin PhD
> Distinguished Engineer
> Kitware Inc.
> 28 Corporate Drive
> Clifton Park NY 12065
>
> This communication, including all attachments, contains confidential and
> legally privileged information, and it is intended only for the use of the
> addressee.  Access to this email by anyone else is unauthorized. If you are
> not the intended recipient, any disclosure, copying, distribution or any
> action taken in reliance on it is prohibited and may be unlawful. If you
> received this communication in error please notify us immediately and
> destroy the original message.  Thank you.
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>


More information about the vtk-developers mailing list