[vtk-developers] help with cppcheck duplInheritedMember warnings

[Marcus D. Hanwell]

Hi Jon,

The charts related changed look good to me, just added +2 for that piece
for both. Thanks for fixing these up, it looks like there are some
dashboard issues hopefully they can be cleared up (look unrelated to the
charts changes to me).

Marcus

On Tue, May 9, 2017 at 5:21 PM, Jon Haitz Legarreta <
jhlegarreta at vicomtech.org> wrote:

> Hi Marcus,
> thanks !
>
> The issues with vtk::PlotSurface were addressed here:
> https://gitlab.kitware.com/vtk/vtk/merge_requests/2787
>
> Still pending some approval/review/suggestion, since the build errors seem
> unrelated to me.
>
> The last bunch of warnings (including that one belonging to the
> vtk::vtkScatterPlotMatrix class) is addressed here:
> https://gitlab.kitware.com/vtk/vtk/merge_requests/2799
>
> I've got to review the errors in this last still. That's why I did not add
> any reviewers yet. But if they look immediate to you, suggestions are
> welcome.
>
> JON HAITZ
>
> --
>
>
> On 9 May 2017 at 20:34, Marcus D. Hanwell <marcus.hanwell at kitware.com>
> wrote:
>
>> On Fri, May 5, 2017 at 10:09 AM, Sean McBride <sean at rogue-research.com>
>> wrote:
>> >
>> > On Wed, 3 May 2017 09:25:09 -0600, David Gobbi said:
>> >
>> > >I don't think suppressing them is a good idea, redefined member
>> variables
>> > >are strongly indicative of real bugs.
>> >
>> > Thanks David & Jon!  We are down to 10 now:
>> >
>> > Charts/Core/vtkPlot3D.h:152: warning: The class 'vtkPlotSurface'
>> defines member variable with name 'Colors' also defined in its parent class
>> 'vtkPlot3D'.
>> >
>> > Charts/Core/vtkChartMatrix.h:155: warning: The class
>> 'vtkScatterPlotMatrix' defines member variable with name 'Private' also
>> defined in its parent class 'vtkChartMatrix'.
>> >
>> I missed your original email, I haven't always had time to monitor the
>> mailing list. Are both of these still open? I can take a look if so,
>> they should be pretty simple and I likely wrote them, if there are
>> others in charts I can take a look too.
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170510/b4cc6ebb/attachment.html>