[vtk-developers] ready to branch for 8.0.0?

[Robert Maynard]

Given these issues, and known performance problems with
std::min/std::max I think it would be valuable to provide a single
header that wraps all these functions and provides fast versions where
needed. Personally I see no reason to not place these into a vtk
namespace.

On Thu, Mar 23, 2017 at 10:07 AM, Hahn, Steven E. <hahnse at ornl.gov> wrote:
> I've encountered a few complications with recent versions of MSVC and clang with integral value types.  With std::isnan and std::isinf Visual Studio 2017 generates an error message. With std::isinf<int> clang generates code that is 3-4 times slower than one would naively expect for a type that doesn’t contain infinity. I worked around both issues with tag dispatch, but don’t think we want that code copied and pasted throughout the VTK codebase.
>
> Steven
> ________________________________________
> From: Sean McBride <sean at rogue-research.com>
> Sent: Wednesday, March 22, 2017 5:01 PM
> To: Hahn, Steven E.; David Gobbi
> Cc: vtkdev
> Subject: Re: [vtk-developers] ready to branch for 8.0.0?
>
> On Tue, 21 Mar 2017 15:41:00 +0000, Hahn, Steven E. said:
>
>>The former. I’d like to move these functions (and workarounds for
>>certain data types and compilers) into a header where they can be
>>reused. Would it make sense to either template the existing function in
>>vtkMath or put the templated functions in a different header file?
>
> Maybe our new minimum compiler requirements would finally allow us to just use std::isnan, std::isfinite, and std::isinf.
>
> Cheers,
>
> Sean
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>