[vtk-developers] ready to branch for 8.0.0?

[Hahn, Steven E.]

The former. I’d like to move these functions (and workarounds for certain data types and compilers) into a header where they can be reused. Would it make sense to either template the existing function in vtkMath or put the templated functions in a different header file?

From: David Gobbi <david.gobbi at gmail.com>
Date: Tuesday, March 21, 2017 at 11:04 AM
To: "Hahn, Steven E." <hahnse at ornl.gov>
Cc: vtkdev <vtk-developers at vtk.org>
Subject: Re: [vtk-developers] ready to branch for 8.0.0?

Typo: I meant to write "want the VTK codebase to stop using them".

On Tue, Mar 21, 2017 at 9:03 AM, David Gobbi <david.gobbi at gmail.com<mailto:david.gobbi at gmail.com>> wrote:
Not clear what you mean here.  Do you want to template the IsInf, IsNan, and IsFinite methods in vtkMath, or do you want to VTK codebase to stop using them?


On Tue, Mar 21, 2017 at 8:31 AM, Hahn, Steven E. <hahnse at ornl.gov<mailto:hahnse at ornl.gov>> wrote:
There are templated min, max, isinf, and isnan functions scattered around the VTK codebase. Is this a good time to replace the (slower?) functions in vtkMath.h that require a conversion to double?

Steven

min, max
https://gitlab.kitware.com/vtk/vtk/blob/3c479cfe4ab201f74642ef0973ae65ebb96dcab2/Common/Core/vtkDataArrayPrivate.txx#L58

isinf
https://gitlab.kitware.com/vtk/vtk/blob/3c479cfe4ab201f74642ef0973ae65ebb96dcab2/Common/Core/vtkDataArrayPrivate.txx#L98

isnan
https://gitlab.kitware.com/vtk/vtk/blob/3c479cfe4ab201f74642ef0973ae65ebb96dcab2/Common/Core/vtkGenericDataArrayLookupHelper.h#L56


On 3/21/17, 9:24 AM, "vtk-developers on behalf of Cory Quammen" <vtk-developers-bounces at vtk.org<mailto:vtk-developers-bounces at vtk.org> on behalf of cory.quammen at kitware.com<mailto:cory.quammen at kitware.com>> wrote:

    Dave,

    VTK 8.0.0 seems like a good target for some of the bigger API change
    merge requests that have been put off for a while Examples include:

    https://gitlab.kitware.com/vtk/vtk/merge_requests/1455
    https://gitlab.kitware.com/vtk/vtk/merge_requests/917

    If we are aspiring toward using semantic versioning [1], now would be
    the time to make such API changes. And document them nicely as well,
    of course.

    Thanks,
    Cory

    [1] http://semver.org/

    On Mon, Mar 20, 2017 at 5:39 PM, David E DeMarle
    <dave.demarle at kitware.com<mailto:dave.demarle at kitware.com>> wrote:
    > Hi,
    >
    > Does anyone have work in progress that should delay the branch point for
    > 8.0.0?
    >
    > If so, please add the 8.0.0 milestone on any relevant merge requests
    > and @mention ben.beockel, demarle, and chuck.atkins so they can be more
    > easily tracked.
    >
    > We are hoping to get 8.0.0 started by April 3, 2017.
    >
    > Thanks,
    >
    > The VTK Maintenance Team
    >
    > David E DeMarle
    > Kitware, Inc.
    > R&D Engineer
    > 21 Corporate Drive
    > Clifton Park, NY 12065-8662
    > Phone: 518-881-4909<tel:(518)%20881-4909>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170321/a6554cc4/attachment-0001.html>