[vtk-developers] vtkNew in examples (or auto?)

[Elvis Stansvik]

2017-06-22 18:57 GMT+02:00 Elvis Stansvik <elvis.stansvik at orexplore.com>:
> Hi all,
>
> How about a refactor of the examples to use vtkNew instead of
> vtkSmartPointer (where it makes sense)?
>
> E.g.
>
>   vtkNew<vtkActor> actor;
>   actor->SetMapper(mapper);
>
>   vtkNew<vtkRenderer> renderer;
>   renderer->AddActor(actor);

Well, missing some .Get() here, but you see what I mean.

Elvis

>
> instead of
>
>   vtkSmartPointer<vtkActor> actor =
>     vtkSmartPointer<vtkActor>::New();
>   actor->SetMapper(mapper);
>
>   vtkSmartPointer<vtkRenderer> renderer =
>     vtkSmartPointer<vtkRenderer>::New();
>   renderer->AddActor(actor);
>
> I think it would help with the readability of the examples. Or are
> there other reasons for the prevalent use of vtkSmartPointer?
>
> Another option would be to use auto, e.g.
>
>   auto actor = vtkSmartPointer<vtkActor>::New();
>
> Also, would anyone mind if I did a little naming cleanup, mostly
> things like "renwin" -> "window" and "iren" -> "interactor"? Those
> abbreviations are not that bad, but I think it's better in examples to
> spell out the variables in proper English.
>
> If there are no objections, I could try to prepare an MR when time
> permits. If so, vtkNew, or auto?
>
> Elvis