[vtk-developers] 0, NULL -> nullptr

Cory Quammen cory.quammen at kitware.com
Tue Jul 25 14:28:32 EDT 2017


+1 for doing it all at once. A sequence of changes that touch a lot of
files slows down testing builds for projects that closely track VTK
master.

On Tue, Jul 25, 2017 at 2:08 PM, Ken Martin <ken.martin at kitware.com> wrote:
>
> Here is a topic for updating VTK/Common to use nullptr based on fixes from
> clang-tidy
>
> https://gitlab.kitware.com/vtk/vtk/merge_requests/3055
>
> I just did common as I figured that would impact fewer people. My plan is to
> do other directories in chunks over time but I can go whole hog and do it
> all at once if you all think that is better.  The change is from Rob's
> script ala...
>
> #!/bin/bash
>
> # The vtk build must have CMAKE_EXPORT_COMPILE_COMMANDS=ON
>
> path=$(pwd)
> build_path="/home/ken/Documents/vtk/vtkbin"
> clang_tidy="/usr/bin/clang-tidy"
> args="-checks=-*,modernize-use-nullptr --header-filter=$path -p $build_path
> -fix"
> for file in $1/*.cxx; do
>   $clang_tidy $args $file
> done
>
>
>
> --
> Ken Martin PhD
> Distinguished Engineer
> Kitware Inc.
> 28 Corporate Drive
> Clifton Park NY 12065
>
> This communication, including all attachments, contains confidential and
> legally privileged information, and it is intended only for the use of the
> addressee.  Access to this email by anyone else is unauthorized. If you are
> not the intended recipient, any disclosure, copying, distribution or any
> action taken in reliance on it is prohibited and may be unlawful. If you
> received this communication in error please notify us immediately and
> destroy the original message.  Thank you.
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>



-- 
Cory Quammen
Staff R&D Engineer
Kitware, Inc.


More information about the vtk-developers mailing list