[vtk-developers] A few nightly warnings and test failures introduced last Thursday

[Shawn Waldon]

Thanks for pointing those out David.  I thought I'd gotten all those when I
compiled with VTK_LEGACY_REMOVE, but it missed deprecated functions called
from other deprecated functions.  That is what is happening there.  The
vtkArrayCalculator::SetAttributeModeToXXX() functions are calling
vtkArrayCalculator::SetAttributeMode(), which I deprecated in favor of
vtkArrayCalculator::SetAttributeType() which has its own variants
(vtkArrayCalculator::SetAttributeTypeToXXX().  How do we handle deprecated
functions called from deprecated functions?

Shawn

For the curious: the difference is that the old deprecated functions use
custom constants declared in vtkArrayCalculator.h and the new functions
take vtkDataObject::AttributeTypes constants (plus one custom constant for
"default" (-1))  This let me refactor the calculator to use the
vtkDataObject::GetAttributes()/GetNumberOfElements() API instead of
down-casting each data type to get its data/data length.

On Mon, Jul 17, 2017 at 11:17 AM, David Cole <DLRdave at aol.com> wrote:

> These Windows/VS2013 warnings are also related to vtkArrayCalculator:
>
> https://open.cdash.org/viewBuildError.php?type=1&buildid=4980673
>
>
> On Mon, Jul 17, 2017 at 10:33 AM, Shawn Waldon <shawn.waldon at kitware.com>
> wrote:
> > I've already merged a branch that fixes the inconsistent override
> warnings
> > in vtkArrayCalculator.h after Cory pointed them out to me this morning.
> My
> > branch changed vtkArrayCalculator to be a subclass of
> > vtkPassInputTypeAlgorithm so that it can be applied to vtkTables and
> > vtkGraphs (for molecules).  So I don't think it is related to the other
> > failures.
> >
> > Shawn
> >
> > On Mon, Jul 17, 2017 at 10:25 AM, Ken Martin <ken.martin at kitware.com>
> wrote:
> >>
> >>
> >> If you have committed to VTK between Thursday and now please take a
> look.
> >> The expected nightlies have a some warnings and test failures introduced
> >> since last Thursday.
> >>
> >> https://open.cdash.org/index.php?project=VTK
> >>
> >>
> >> --
> >> Ken Martin PhD
> >> Distinguished Engineer
> >> Kitware Inc.
> >> 28 Corporate Drive
> >> Clifton Park NY 12065
> >>
> >> This communication, including all attachments, contains confidential and
> >> legally privileged information, and it is intended only for the use of
> the
> >> addressee.  Access to this email by anyone else is unauthorized. If you
> are
> >> not the intended recipient, any disclosure, copying, distribution or any
> >> action taken in reliance on it is prohibited and may be unlawful. If you
> >> received this communication in error please notify us immediately and
> >> destroy the original message.  Thank you.
> >>
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Search the list archives at: http://markmail.org/search/?q=
> vtk-developers
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://public.kitware.com/mailman/listinfo/vtk-developers
> >>
> >>
> >
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Search the list archives at: http://markmail.org/search/?q=
> vtk-developers
> >
> > Follow this link to subscribe/unsubscribe:
> > http://public.kitware.com/mailman/listinfo/vtk-developers
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170717/a24f6bac/attachment-0001.html>