From amine.aboufirass at gmail.com Fri Dec 1 10:45:27 2017 From: amine.aboufirass at gmail.com (Amine Aboufirass) Date: Fri, 1 Dec 2017 16:45:27 +0100 Subject: [vtk-developers] ExtractByLocation Message-ID: Hello, I am trying to figure out how to select the closest neighboring points to a list of coordinates using the vtk library. I have a simple point data set in the Unstructured Grid Format. The dataset contains one attribute named the 'point_id' which is just enumerating the points starting from 1 instead of 0. The raw text from the ASCII file is attached in testScalar.vtk below. I have also written a script in python which I thought would function as follows: INPUT: 1. List of tuples containing world coordinates [(X1,Y1,Z1),(X2,Y2,Z2)] 2. name of attribute to extract as a string. in this case "point_id" OUTPUT: 1. List of floating point values of the attribute for the selected points This does work to a certain degree, for instance when I do : ExtractByLocation('testScalar.vtk', [(5.999,0,0)], 'point_id') I do indeed get back the following: array([ 2.], dtype=float32) So point_id 2 is the closest point to the coordinates I have specified. However, as soon as I get a bit too far from one of the points, the function starts returning an empty list. For instance: ExtractByLocation('testScalar.vtk', [(5.888,0,0)], 'point_id') Returns array([], dtype=float32) I found out that the cut off point is 5.89-5.90. If I plugin 5.9 I get the point, if I plugin 5.89 I get back an empty list. According to the object reference ( https://www.vtk.org/doc/nightly/html/classvtkSelectionNode.html#aa7b54148c40adf4f5019b8ad3e160535a97d8505c922b2a25c5d2755607d3cbb6 ) LOCATIONS is supposed to select the points near the supplied world coordinates. Is there an option or something that selects the nearest point PERIOD? i.e using a simple distance formula? I would like to never get back an empty list but always get back a list of the closest point to the supplied coordinates. Kind Regards, Amine -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- import vtk from vtk.util.numpy_support import vtk_to_numpy import os def ExtractByLocation(FileName, Locations, DataType): #where Locations MUST be a list of XYZ tuples, e.g [(0,0.2,0.0),(0,0.4,0.0),(0,0.5,0.0),(0,0.6,0.0)] reader = vtk.vtkUnstructuredGridReader() reader.SetFileName(FileName) if 'Scalar' in FileName: reader.SetScalarsName(DataType) elif 'Tensor' in FileName: reader.SetTensorsName(DataType) elif 'Vector' in FileName: reader.SetVectorsName(DataType) reader.Update() SelectionList = vtk.vtkDoubleArray() SelectionList.SetNumberOfComponents(3) #dimension of the components for Location in Locations: SelectionList.InsertNextTuple(Location) SelectionNode = vtk.vtkSelectionNode() SelectionNode.SetFieldType(vtk.vtkSelectionNode.POINT) SelectionNode.SetContentType(vtk.vtkSelectionNode.LOCATIONS) SelectionNode.SetSelectionList(SelectionList) Selection = vtk.vtkSelection() Selection.AddNode(SelectionNode) ExtractSelection = vtk.vtkExtractSelection() ExtractSelection.SetInputConnection(0, reader.GetOutputPort()) ExtractSelection.SetInputData(1,Selection) ExtractSelection.Update() Selected = vtk.vtkUnstructuredGrid() Selected.ShallowCopy(ExtractSelection.GetOutput()) PointData = Selected.GetPointData() if 'Scalar' in FileName: Data = vtk_to_numpy(PointData.GetScalars()) elif 'Tensor' in FileName: Data = vtk_to_numpy(PointData.GetTensors()) elif 'Vector' in FileName: Data = vtk_to_numpy(PointData.GetVectors()) return Data -------------- next part -------------- A non-text attachment was scrubbed... Name: testScalar.vtk Type: application/octet-stream Size: 231 bytes Desc: not available URL: From bill.lorensen at gmail.com Fri Dec 1 13:57:31 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 1 Dec 2017 13:57:31 -0500 Subject: [vtk-developers] Does Kitware have a git-lfs server? Message-ID: I'm trying to use git lfs to host datasets for the VTKExamples. github limits the amount of storage and bandwidth for freeloaders like me. Does kitware have a git lfs server that I can use? From ben.boeckel at kitware.com Fri Dec 1 14:52:44 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Fri, 1 Dec 2017 14:52:44 -0500 Subject: [vtk-developers] Does Kitware have a git-lfs server? In-Reply-To: References: Message-ID: <20171201195244.GA3064@megas.kitware.com> On Fri, Dec 01, 2017 at 13:57:31 -0500, Bill Lorensen wrote: > I'm trying to use git lfs to host datasets for the VTKExamples. > > github limits the amount of storage and bandwidth for freeloaders like me. > > Does kitware have a git lfs server that I can use? gitlab.kitware.com supports LFS. I don't know LFS enough to know if you can tell it to look there for a github repo though. --Ben From bill.lorensen at gmail.com Sun Dec 3 11:46:46 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sun, 3 Dec 2017 11:46:46 -0500 Subject: [vtk-developers] Does Kitware have a git-lfs server? In-Reply-To: <20171201195244.GA3064@megas.kitware.com> References: <20171201195244.GA3064@megas.kitware.com> Message-ID: I was able to use gitlab.kitware.com to host the LFS files for repositories on github. Pretty cool... Bill On Fri, Dec 1, 2017 at 2:52 PM, Ben Boeckel wrote: > On Fri, Dec 01, 2017 at 13:57:31 -0500, Bill Lorensen wrote: >> I'm trying to use git lfs to host datasets for the VTKExamples. >> >> github limits the amount of storage and bandwidth for freeloaders like me. >> >> Does kitware have a git lfs server that I can use? > > gitlab.kitware.com supports LFS. I don't know LFS enough to know if you > can tell it to look there for a github repo though. > > --Ben -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Sun Dec 3 13:40:54 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sun, 3 Dec 2017 13:40:54 -0500 Subject: [vtk-developers] Fast cloning of VTKExamples Message-ID: Folks, I've been working on reducing the time and storage for cloning the VTKExamples. I will experiment with a way to use the clone depth for remote modules. Here are some results comparing time to clone and amount of storage used. time git clone git at github.com:lorensen/VTKExamples.git XXX real 4m28.974s user 5m18.285s sys 0m29.902s (du -f -s XXX) 1113420 XXX time git clone --depth=1 git at github.com:lorensen/VTKExamples.git XXX real 0m50.060s user 0m7.288s sys 0m7.051s (cd XXX; du -f -s .) 654736 XXX Bill -- Unpaid intern in BillsBasement at noware dot com From elvis.stansvik at orexplore.com Mon Dec 4 02:34:06 2017 From: elvis.stansvik at orexplore.com (Elvis Stansvik) Date: Mon, 4 Dec 2017 08:34:06 +0100 Subject: [vtk-developers] Fast cloning of VTKExamples In-Reply-To: References: Message-ID: Den 3 dec. 2017 7:40 em skrev "Bill Lorensen" : Folks, I've been working on reducing the time and storage for cloning the VTKExamples. I will experiment with a way to use the clone depth for remote modules. Here are some results comparing time to clone and amount of storage used. time git clone git at github.com:lorensen/VTKExamples.git XXX real 4m28.974s user 5m18.285s sys 0m29.902s (du -f -s XXX) 1113420 XXX time git clone --depth=1 git at github.com:lorensen/VTKExamples.git XXX real 0m50.060s user 0m7.288s sys 0m7.051s (cd XXX; du -f -s .) 654736 XXX Very nice! I've been thinking of keeping a clone around and use `git grep` instead of the web UI, and now I have even less excuses not to :) Elvis Bill -- Unpaid intern in BillsBasement at noware dot com _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/ opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From ahmedbenltaief29 at gmail.com Mon Dec 4 05:34:30 2017 From: ahmedbenltaief29 at gmail.com (Ahmed Ben Ltaief) Date: Mon, 4 Dec 2017 11:34:30 +0100 Subject: [vtk-developers] No makefile found Message-ID: Dear all, I'm trying the exemple of vtkDICOMSeries available here: https://lorensen.github.io/VTKExamples/site/Cxx/IO/ReadDICOMSeries/ I added in the cmakeLists SET (VTK_DIR D:/VTK-8.0.0/bin) to run cmake .. -- Building for: Visual Studio 15 2017 -- Selecting Windows SDK version 10.0.16299.0 to target Windows 6.3.9600. -- The C compiler identification is MSVC 19.11.25547.0 -- The CXX compiler identification is MSVC 19.11.25547.0 -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.11.25503/bin/Hostx86/x86/cl.exe -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.11.25503/bin/Hostx86/x86/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.11.25503/bin/Hostx86/x86/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.11.25503/bin/Hostx86/x86/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Configuring done -- Generating done -- Build files have been written to: C:/ReadDICOMSeries2/ReadDICOMSeries/build I think there is no problem in this step. But when i use the commande make: make: *** No targets specified and no makefile found. Stop. I don't know why the makeFile don't exist in the build directory. I use cygwin to run the commands and i installed the build-essential. Can you help me to fixe it. Thanks. Garanti sans virus. www.avast.com <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Mon Dec 4 09:29:34 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 4 Dec 2017 09:29:34 -0500 Subject: [vtk-developers] Does Kitware have a git-lfs server? In-Reply-To: References: <20171201195244.GA3064@megas.kitware.com> Message-ID: <20171204142934.GB32596@megas> On Sun, Dec 03, 2017 at 11:46:46 -0500, Bill Lorensen wrote: > I was able to use gitlab.kitware.com to host the LFS files for > repositories on github. Nifty. How is that done? --Ben From bill.lorensen at gmail.com Mon Dec 4 09:38:47 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 4 Dec 2017 09:38:47 -0500 Subject: [vtk-developers] Does Kitware have a git-lfs server? In-Reply-To: <20171204142934.GB32596@megas> References: <20171201195244.GA3064@megas.kitware.com> <20171204142934.GB32596@megas> Message-ID: I set up a repo on gitlab.kitware.com called VTKExamplesLFS. Then, in my github hosted VTKExamples git config -f .lfsconfig remote.origin.lfsurl https://gitlab.kitware.com/lorensen/VTKExamplesLFS.git/info/lfs git add .ifconfig git lfs fetch origin --all git lfs push origin master --all This moved all of my lfs files from github to gitlab.kitware.com. The VTKExamplesLFS repo shows up as empty, but the files are stored there somewhere. I'll eventually writeup something on my experiences with git lfs. On Mon, Dec 4, 2017 at 9:29 AM, Ben Boeckel wrote: > On Sun, Dec 03, 2017 at 11:46:46 -0500, Bill Lorensen wrote: >> I was able to use gitlab.kitware.com to host the LFS files for >> repositories on github. > > Nifty. How is that done? > > --Ben -- Unpaid intern in BillsBasement at noware dot com From ben.boeckel at kitware.com Mon Dec 4 09:47:32 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 4 Dec 2017 09:47:32 -0500 Subject: [vtk-developers] No makefile found In-Reply-To: References: Message-ID: <20171204144732.GC32596@megas> On Mon, Dec 04, 2017 at 11:34:30 +0100, Ahmed Ben Ltaief wrote: > -- Building for: Visual Studio 15 2017 > I don't know why the makeFile don't exist in the build directory. > I use cygwin to run the commands and i installed the build-essential. Can > you help me to fixe it. You're using a Windows CMake. Cygwin requires a Cygwin-built CMake. --Ben From ahmedbenltaief29 at gmail.com Mon Dec 4 11:09:37 2017 From: ahmedbenltaief29 at gmail.com (Ahmed Ben Ltaief) Date: Mon, 4 Dec 2017 17:09:37 +0100 Subject: [vtk-developers] No makefile found In-Reply-To: <20171204144732.GC32596@megas> References: <20171204144732.GC32596@megas> Message-ID: Thank you ben for you response. I added CMake on cygwin, but now when i run cmake .. CMake Error: Error in cmake code at /cygdrive/c/ReadDICOM2/ReadDICOM/CMakeLists.txt:6: Parse error. Expected a newline, got identifier with text "find_package". -- Configuring incomplete, errors occurred! Despite that VAR_DIR modified in cmakelists: cmake_minimum_required(VERSION 2.8) PROJECT(ReadDICOM) SET (VTK_DIR D:/VTK-8.0.0/bin) find_package(VTK REQUIRED) include(${VTK_USE_FILE}) add_executable(ReadDICOM MACOSX_BUNDLE ReadDICOM.cxx ) target_link_libraries(ReadDICOM ${VTK_LIBRARIES}) Garanti sans virus. www.avast.com <#m_-9183446350155148664_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2017-12-04 15:47 GMT+01:00 Ben Boeckel : > On Mon, Dec 04, 2017 at 11:34:30 +0100, Ahmed Ben Ltaief wrote: > > -- Building for: Visual Studio 15 2017 > > > > I don't know why the makeFile don't exist in the build directory. > > I use cygwin to run the commands and i installed the build-essential. Can > > you help me to fixe it. > > You're using a Windows CMake. Cygwin requires a Cygwin-built CMake. > > --Ben > 2017-12-04 15:47 GMT+01:00 Ben Boeckel : > On Mon, Dec 04, 2017 at 11:34:30 +0100, Ahmed Ben Ltaief wrote: > > -- Building for: Visual Studio 15 2017 > > > > I don't know why the makeFile don't exist in the build directory. > > I use cygwin to run the commands and i installed the build-essential. Can > > you help me to fixe it. > > You're using a Windows CMake. Cygwin requires a Cygwin-built CMake. > > --Ben > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ahmedbenltaief29 at gmail.com Mon Dec 4 12:43:10 2017 From: ahmedbenltaief29 at gmail.com (Ahmed Ben Ltaief) Date: Mon, 4 Dec 2017 18:43:10 +0100 Subject: [vtk-developers] No makefile found In-Reply-To: References: <20171204144732.GC32596@megas> Message-ID: Hello Ben, I left cygwin, i change the VTK_DIR like always, and i run cmake .. with windows cmake, it works. And then when i run make the same problem occur, no makefile generated: make: *** No targets specified and no makefile found. Stop. It's really wreid. 2017-12-04 17:09 GMT+01:00 Ahmed Ben Ltaief : > Thank you ben for you response. > > I added CMake on cygwin, but now when i run cmake .. > > CMake Error: Error in cmake code at > /cygdrive/c/ReadDICOM2/ReadDICOM/CMakeLists.txt:6: > Parse error. Expected a newline, got identifier with text "find_package". > -- Configuring incomplete, errors occurred! > > > Despite that VAR_DIR modified in cmakelists: > > cmake_minimum_required(VERSION 2.8) > > PROJECT(ReadDICOM) > > SET (VTK_DIR D:/VTK-8.0.0/bin) find_package(VTK REQUIRED) > include(${VTK_USE_FILE}) > > add_executable(ReadDICOM MACOSX_BUNDLE ReadDICOM.cxx ) > > target_link_libraries(ReadDICOM ${VTK_LIBRARIES}) > > > > Garanti > sans virus. www.avast.com > > <#m_-8852953459366276914_m_-9183446350155148664_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > 2017-12-04 15:47 GMT+01:00 Ben Boeckel : > >> On Mon, Dec 04, 2017 at 11:34:30 +0100, Ahmed Ben Ltaief wrote: >> > -- Building for: Visual Studio 15 2017 >> >> >> > I don't know why the makeFile don't exist in the build directory. >> > I use cygwin to run the commands and i installed the build-essential. >> Can >> > you help me to fixe it. >> >> You're using a Windows CMake. Cygwin requires a Cygwin-built CMake. >> >> --Ben >> > > > 2017-12-04 15:47 GMT+01:00 Ben Boeckel : > >> On Mon, Dec 04, 2017 at 11:34:30 +0100, Ahmed Ben Ltaief wrote: >> > -- Building for: Visual Studio 15 2017 >> >> >> > I don't know why the makeFile don't exist in the build directory. >> > I use cygwin to run the commands and i installed the build-essential. >> Can >> > you help me to fixe it. >> >> You're using a Windows CMake. Cygwin requires a Cygwin-built CMake. >> >> --Ben >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Mon Dec 4 12:56:17 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 4 Dec 2017 12:56:17 -0500 Subject: [vtk-developers] No makefile found In-Reply-To: References: <20171204144732.GC32596@megas> Message-ID: <20171204175546.GA17057@rotor.kitware.com> On Mon, Dec 04, 2017 at 17:09:37 +0100, Ahmed Ben Ltaief wrote: > SET (VTK_DIR D:/VTK-8.0.0/bin) find_package(VTK REQUIRED) These need to be two different lines. --Ben From andrew.amaclean at gmail.com Tue Dec 5 16:33:37 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 6 Dec 2017 08:33:37 +1100 Subject: [vtk-developers] GitLab Message-ID: There seems to be a problem. I am just getting a web page with Forbidden on it. -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.thompson at kitware.com Tue Dec 5 16:42:47 2017 From: david.thompson at kitware.com (David Thompson) Date: Tue, 5 Dec 2017 16:42:47 -0500 Subject: [vtk-developers] GitLab In-Reply-To: References: Message-ID: <547DC170-6058-47AE-91F4-41354D7004A8@kitware.com> > There seems to be a problem. I am just getting a web page with Forbidden on it. I've notified our admins, but gitlab is working over here (NC Kitware office, which is remote to NY HQ). David From ben.boeckel at kitware.com Tue Dec 5 16:51:53 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Tue, 5 Dec 2017 16:51:53 -0500 Subject: [vtk-developers] GitLab In-Reply-To: References: Message-ID: <20171205215153.GA27088@megas.kitware.com> On Wed, Dec 06, 2017 at 08:33:37 +1100, Andrew Maclean wrote: > There seems to be a problem. I am just getting a web page with Forbidden on > it. I got it yesterday too. It seems that the span detection has gotten touchier :/ . --Ben From dave.demarle at kitware.com Tue Dec 5 17:00:32 2017 From: dave.demarle at kitware.com (David E DeMarle) Date: Tue, 5 Dec 2017 17:00:32 -0500 Subject: [vtk-developers] announce: vtk 8.1.0.rc2 is ready to try Message-ID: Hi folks, VTK 8.1.0.rc2 is up on the downloads site and tagged in git. Please give it a try and report any problems that you find to us via the gitlab issue tracker with an "8.1" milestone tag. Developers, use the same tag to let us know of any fixes that you want integrated to the release branch in time for 8.1.0 final in a few weeks time. If nothing major comes up, this will be retagged as 8.1.0 final. We expect the next release, VTK 9.0.0, to be out in a few short months. The biggest reason for rc2 is that in it we have deprecated Tcl. The entire set of changes over rc1 are as follows. $ git shortlog v8.1.0.rc1..v8.1.0.rc2 Ben Boeckel (2): tcl: deprecate for 8.1 Merge topic 'deprecate-tcl' into release David E. DeMarle (2): Merge branch 'upstream-tiff' into release Merge topic 'bump-tiff' into release Forrest Li (2): Remove legacy classes from ParallelGeometry Remove vtkPUnstructuredGridGhostDataGenerator from docs Julien Finet (2): Fix crash in transforms when doing DeepCopy after Identity Merge topic 'fix-transform-identity' into release Ken Martin (1): Merge topic 'remove_deprecated_from_filters' into release Sankhesh Jhaveri (4): Provide access to the shader program in UpdateShaderEvent callback Added test that demonstrates ability to set shader uniforms from python Invoke UpdateShaderEvent from volume mapper Merge topic 'expose_shader_api_release' into release Sean McBride (2): Fixed, again, a slightly incorrect assert Merge topic 'release-lut-assert' into release Tiff Upstream (1): tiff 2017-12-05 (818c6fed) David E DeMarle Kitware, Inc. Principal Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Tue Dec 5 17:13:11 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 6 Dec 2017 09:13:11 +1100 Subject: [vtk-developers] GitLab In-Reply-To: <20171205215153.GA27088@megas.kitware.com> References: <20171205215153.GA27088@megas.kitware.com> Message-ID: Ok no worries. Thanks for letting me know! On Wed, Dec 6, 2017 at 8:51 AM, Ben Boeckel wrote: > On Wed, Dec 06, 2017 at 08:33:37 +1100, Andrew Maclean wrote: > > There seems to be a problem. I am just getting a web page with Forbidden > on > > it. > > I got it yesterday too. It seems that the span detection has gotten > touchier :/ . > > --Ben > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Tue Dec 5 17:27:25 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 6 Dec 2017 09:27:25 +1100 Subject: [vtk-developers] TCL Gone Message-ID: I see that TCL has gone from the master. I remember when I first started using VTK (in 2000!!!!) for laser imaging, I was so impressed that I could use TCL for rapid prototyping. For me what was really amazing was the wrapping process for TCL. Remember this was pre CMake. We only had Visual Studio 6 in those days. Then in later years I helped with the conversion of the tests to Python which was a big job. I hope someone in Kitware can write up a little bit of history about TCL. Regards Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From josp.jorge at gmail.com Tue Dec 5 18:39:00 2017 From: josp.jorge at gmail.com (Jorge Perez) Date: Wed, 6 Dec 2017 00:39:00 +0100 Subject: [vtk-developers] TCL Gone In-Reply-To: References: Message-ID: It is really a shame to see VTK pushing TCL out the ship! Do you know if there could be way to wrap TCL after VTK has been built? best regards, Jorge 2017-12-05 23:27 GMT+01:00 Andrew Maclean : > I see that TCL has gone from the master. > > I remember when I first started using VTK (in 2000!!!!) for laser imaging, > I was so impressed that I could use TCL for rapid prototyping. For me what > was really amazing was the wrapping process for TCL. Remember this was pre > CMake. > > We only had Visual Studio 6 in those days. > > Then in later years I helped with the conversion of the tests to Python > which was a big job. > > I hope someone in Kitware can write up a little bit of history about TCL. > > > Regards > Andrew > > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Tue Dec 5 18:44:36 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 5 Dec 2017 18:44:36 -0500 Subject: [vtk-developers] TCL Gone In-Reply-To: References: Message-ID: Our first wrapped language. Wrapped by Ken. Loved by all. Goodbye old friend. On Tue, Dec 5, 2017 at 6:39 PM, Jorge Perez wrote: > It is really a shame to see VTK pushing TCL out the ship! > > Do you know if there could be way to wrap TCL after VTK has been built? > > best regards, > > Jorge > > 2017-12-05 23:27 GMT+01:00 Andrew Maclean : >> >> I see that TCL has gone from the master. >> >> I remember when I first started using VTK (in 2000!!!!) for laser imaging, >> I was so impressed that I could use TCL for rapid prototyping. For me what >> was really amazing was the wrapping process for TCL. Remember this was pre >> CMake. >> >> We only had Visual Studio 6 in those days. >> >> Then in later years I helped with the conversion of the tests to Python >> which was a big job. >> >> I hope someone in Kitware can write up a little bit of history about TCL. >> >> >> Regards >> Andrew >> >> >> >> -- >> ___________________________________________ >> Andrew J. P. Maclean >> >> ___________________________________________ >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From andrew.amaclean at gmail.com Tue Dec 5 19:49:12 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 6 Dec 2017 11:49:12 +1100 Subject: [vtk-developers] TCL Gone In-Reply-To: References: Message-ID: Thanks Bill, that's the sort of history we need to at least presrve somewhere! On Wed, Dec 6, 2017 at 10:44 AM, Bill Lorensen wrote: > Our first wrapped language. > Wrapped by Ken. > Loved by all. > Goodbye old friend. > > > On Tue, Dec 5, 2017 at 6:39 PM, Jorge Perez wrote: > > It is really a shame to see VTK pushing TCL out the ship! > > > > Do you know if there could be way to wrap TCL after VTK has been built? > > > > best regards, > > > > Jorge > > > > 2017-12-05 23:27 GMT+01:00 Andrew Maclean : > >> > >> I see that TCL has gone from the master. > >> > >> I remember when I first started using VTK (in 2000!!!!) for laser > imaging, > >> I was so impressed that I could use TCL for rapid prototyping. For me > what > >> was really amazing was the wrapping process for TCL. Remember this was > pre > >> CMake. > >> > >> We only had Visual Studio 6 in those days. > >> > >> Then in later years I helped with the conversion of the tests to Python > >> which was a big job. > >> > >> I hope someone in Kitware can write up a little bit of history about > TCL. > >> > >> > >> Regards > >> Andrew > >> > >> > >> > >> -- > >> ___________________________________________ > >> Andrew J. P. Maclean > >> > >> ___________________________________________ > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: http://markmail.org/search/?q= > vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> > >> > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: http://markmail.org/search/?q= > vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > Unpaid intern in BillsBasement at noware dot com > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From heiland at iu.edu Tue Dec 5 19:58:42 2017 From: heiland at iu.edu (Heiland, Randy) Date: Wed, 6 Dec 2017 00:58:42 +0000 Subject: [vtk-developers] TCL Gone In-Reply-To: References: Message-ID: Good bye. Good riddance:-) > On Dec 5, 2017, at 7:50 PM, Andrew Maclean wrote: > > Thanks Bill, that's the sort of history we need to at least presrve somewhere! > >> On Wed, Dec 6, 2017 at 10:44 AM, Bill Lorensen wrote: >> Our first wrapped language. >> Wrapped by Ken. >> Loved by all. >> Goodbye old friend. >> >> >> On Tue, Dec 5, 2017 at 6:39 PM, Jorge Perez wrote: >> > It is really a shame to see VTK pushing TCL out the ship! >> > >> > Do you know if there could be way to wrap TCL after VTK has been built? >> > >> > best regards, >> > >> > Jorge >> > >> > 2017-12-05 23:27 GMT+01:00 Andrew Maclean : >> >> >> >> I see that TCL has gone from the master. >> >> >> >> I remember when I first started using VTK (in 2000!!!!) for laser imaging, >> >> I was so impressed that I could use TCL for rapid prototyping. For me what >> >> was really amazing was the wrapping process for TCL. Remember this was pre >> >> CMake. >> >> >> >> We only had Visual Studio 6 in those days. >> >> >> >> Then in later years I helped with the conversion of the tests to Python >> >> which was a big job. >> >> >> >> I hope someone in Kitware can write up a little bit of history about TCL. >> >> >> >> >> >> Regards >> >> Andrew >> >> >> >> >> >> >> >> -- >> >> ___________________________________________ >> >> Andrew J. P. Maclean >> >> >> >> ___________________________________________ >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 4035 bytes Desc: not available URL: From irocks0922 at gmail.com Tue Dec 5 21:08:59 2017 From: irocks0922 at gmail.com (eclipse) Date: Wed, 6 Dec 2017 11:08:59 +0900 Subject: [vtk-developers] vtkfollower performance problem Message-ID: Sorry for cross posting. I uploaded same post StackOverflow, vtk user mailing lis, vtk git issues but nobody made an answer for this. please forgive me. I am trying to add vtkfollower to vtkrenderer for indicating the chosen point. textured vtkfollower is represented correctly, but in the renderer, if I look closer (camera comes closer to polydata) it's getting really slow(frame drop) and the boundary of image turned into black. I did not set the edge line or something might be related. then, if I move camera far from model its rendering performance is going back to normal. here is the code. why is this situation happening? Did I something in a wrong way? `m_SourceFromQrc = vtkSmartPointer::New(); m_SourceFromQrc->SetQImage(&m_qimageFromQrc); m_SourceFromQrc->Update(); m_spVTKTexture = vtkSmartPointer::New(); m_spVTKTexture->SetInputConnection(m_SourceFromQrc->GetOutputPort()); m_spVTKTexture->Update(); m_spVTKPlane = vtkSmartPointer::New(); m_spVTKPlane->SetNormal(0.0, 0.0, 1.0); m_spVTKTextureMappedPlane = vtkSmartPointer::New(); m_spVTKTextureMappedPlane->SetInputConnection(m_spVTKPlane->GetOutputPort()); m_planeDataMapper = vtkSmartPointer::New(); m_planeDataMapper->SetInputConnection(m_spVTKTextureMappedPlane->GetOutputPort()); double followerOriginPoint[3] = { 0.0 }; followerOriginPoint[1] = -1 / 2.0; m_follower = vtkSmartPointer< vtkFollower>::New(); m_follower->SetOrigin(followerOriginPoint); m_follower->SetPosition( pos[0] - followerOriginPoint[0], pos[1] - followerOriginPoint[1], pos[2] - followerOriginPoint[2]); m_follower->SetScale(6); m_follower->SetMapper(m_planeDataMapper); m_follower->SetTexture(m_spVTKTexture); m_follower->SetCamera(getRenderer(m_rendererType)->GetActiveCamera()); m_follower->VisibilityOn(); m_follower->ForceOpaqueOff(); getRenderer(m_rendererType)->AddActor(m_follower);` If I change this code m_follower->SetTexture(m_spVTKTexture); into m_follower->GetProperty()->SetTexture(m_spVTKTexture);, Then, follower rendered properly without performance loss. but ForceOpaqueOff()does not work. I am using VTK 7.0. And the renderer is vtkrenderer. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ahmedbenltaief29 at gmail.com Wed Dec 6 05:46:38 2017 From: ahmedbenltaief29 at gmail.com (Ahmed Ben Ltaief) Date: Wed, 6 Dec 2017 11:46:38 +0100 Subject: [vtk-developers] No makefile found In-Reply-To: <20171204175546.GA17057@rotor.kitware.com> References: <20171204144732.GC32596@megas> <20171204175546.GA17057@rotor.kitware.com> Message-ID: Thank you Ben. 2017-12-04 18:56 GMT+01:00 Ben Boeckel : > On Mon, Dec 04, 2017 at 17:09:37 +0100, Ahmed Ben Ltaief wrote: > > SET (VTK_DIR D:/VTK-8.0.0/bin) find_package(VTK REQUIRED) > > These need to be two different lines. > > --Ben > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Wed Dec 6 10:28:03 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Wed, 6 Dec 2017 10:28:03 -0500 Subject: [vtk-developers] TCL Gone In-Reply-To: References: Message-ID: <20171206152803.GB8072@megas.kitware.com> On Wed, Dec 06, 2017 at 00:39:00 +0100, Jorge Perez wrote: > Do you know if there could be way to wrap TCL after VTK has been built? Yes, there is work underway to improve the module system used in VTK and wrapping VTK from outside should be much easier (including ActiViz). --Ben From amine.aboufirass at gmail.com Fri Dec 8 02:43:12 2017 From: amine.aboufirass at gmail.com (Amine Aboufirass) Date: Fri, 8 Dec 2017 08:43:12 +0100 Subject: [vtk-developers] Getting 0 response for all my questions Message-ID: Hello, In the last month or so, I have sent over 4 detailed messages with legitimate queries on vtk functionality to the vtk users mailing list, the vtk developers mailing list and also the kitware support line. The kitware support always either 1) refer me back to the mailing lists or 2) propose paid support. I am getting no support from the users/developers mailing list. Some of the questions I hve been sending include the following: - subject: ExtractByLocation (sent on 01-Dec-2017) - subject: write unstructured grid vtk file to query-able database format (sent in 11-Nov-2017) - subject: trying to extract points by location (sent in 11-Nov-2017) - subject: Extracting selection from UnstructuredGridDataset using python (sent in 16-Nov-2017) I believe my questions are appropriate for the mailing list and I do not understand why they are not getting any response. I have also checked the mailing list options to make sure I am not blocking responses and I don't think I am. Is vtk an open source tool? or does one need to be part of some special community to receive support for basic functionality which comes with the free package? Thanks for your consideration and look forward to hearing from you. Regards, Amine -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Fri Dec 8 03:30:14 2017 From: nztoddler at yahoo.com (Todd) Date: Fri, 08 Dec 2017 21:30:14 +1300 Subject: [vtk-developers] Getting 0 response for all my questions In-Reply-To: Message-ID: <0855cf13-11a4-427d-82df-943f20db3a86@email.android.com> An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Fri Dec 8 09:50:02 2017 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 8 Dec 2017 09:50:02 -0500 Subject: [vtk-developers] vtkfollower performance problem In-Reply-To: References: Message-ID: ForceOpaqueOff is an odd call to make in that spot. If you want to force the actor to be opaque use ForceOpaqueOn() if you want to force it to be Transparent use ForceTransparentOn() Maybe you want to be using ForceTransparentOn() ? On Tue, Dec 5, 2017 at 9:08 PM, eclipse wrote: > > Sorry for cross posting. > > I uploaded same post StackOverflow, vtk user mailing lis, vtk git issues > but nobody made an answer for this. > > please forgive me. > > > I am trying to add vtkfollower to vtkrenderer for indicating the chosen > point. > > textured vtkfollower is represented correctly, but in the renderer, if I > look closer (camera comes closer to polydata) it's getting really > slow(frame drop) and the boundary of image turned into black. I did not set > the edge line or something might be related. > > then, if I move camera far from model its rendering performance is going > back to normal. > > here is the code. > > why is this situation happening? Did I something in a wrong way? > > `m_SourceFromQrc = vtkSmartPointer::New(); > > m_SourceFromQrc->SetQImage(&m_qimageFromQrc); m_SourceFromQrc->Update(); m_spVTKTexture = vtkSmartPointer::New(); m_spVTKTexture->SetInputConnection(m_SourceFromQrc->GetOutputPort()); m_spVTKTexture->Update(); m_spVTKPlane = vtkSmartPointer::New(); m_spVTKPlane->SetNormal(0.0, 0.0, 1.0); m_spVTKTextureMappedPlane = vtkSmartPointer::New(); m_spVTKTextureMappedPlane->SetInputConnection(m_spVTKPlane->GetOutputPort()); m_planeDataMapper = vtkSmartPointer::New(); m_planeDataMapper->SetInputConnection(m_spVTKTextureMappedPlane->GetOutputPort()); double followerOriginPoint[3] = { 0.0 }; followerOriginPoint[1] = -1 / 2.0; m_follower = vtkSmartPointer< vtkFollower>::New(); m_follower->SetOrigin(followerOriginPoint); m_follower->SetPosition( pos[0] - followerOriginPoint[0], pos[1] - followerOriginPoint[1], pos[2] - followerOriginPoint[2]); m_follower->SetScale(6); m_follower->SetMapper(m_planeDataMapper); m_follower->SetTexture(m_spVTKTexture); m_follower->SetCamera(getRenderer(m_rendererType)->GetActiveCamera()); m_follower->VisibilityOn(); m_follower->ForceOpaqueOff(); getRenderer(m_rendererType)->AddActor(m_follower);` > > If I change this code m_follower->SetTexture(m_spVTKTexture); > > into m_follower->GetProperty()->SetTexture(m_spVTKTexture);, > > Then, follower rendered properly without performance loss. but > ForceOpaqueOff()does not work. > > I am using VTK 7.0. > > And the renderer is vtkrenderer. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From irocks0922 at gmail.com Fri Dec 8 10:15:23 2017 From: irocks0922 at gmail.com (eclipse) Date: Sat, 9 Dec 2017 00:15:23 +0900 Subject: [vtk-developers] vtkfollower performance problem In-Reply-To: References: Message-ID: First of all, Thanks for Reply. I want to make vtkfollower come to front regardless of any other polydata. Whether or not I move camera position, vtkollower should be rendered. camera - vtkfolllower - actor of other polydatas. 2017-12-08 23:50 GMT+09:00 Ken Martin : > ForceOpaqueOff is an odd call to make in that spot. If you want to force > the actor to be opaque use ForceOpaqueOn() if you want to force it to be > Transparent use ForceTransparentOn() Maybe you want to be using > ForceTransparentOn() ? > > On Tue, Dec 5, 2017 at 9:08 PM, eclipse wrote: > >> >> Sorry for cross posting. >> >> I uploaded same post StackOverflow, vtk user mailing lis, vtk git issues >> but nobody made an answer for this. >> >> please forgive me. >> >> >> I am trying to add vtkfollower to vtkrenderer for indicating the chosen >> point. >> >> textured vtkfollower is represented correctly, but in the renderer, if I >> look closer (camera comes closer to polydata) it's getting really >> slow(frame drop) and the boundary of image turned into black. I did not set >> the edge line or something might be related. >> >> then, if I move camera far from model its rendering performance is going >> back to normal. >> >> here is the code. >> >> why is this situation happening? Did I something in a wrong way? >> >> `m_SourceFromQrc = vtkSmartPointer::New(); >> >> m_SourceFromQrc->SetQImage(&m_qimageFromQrc); m_SourceFromQrc->Update(); m_spVTKTexture = vtkSmartPointer::New(); m_spVTKTexture->SetInputConnection(m_SourceFromQrc->GetOutputPort()); m_spVTKTexture->Update(); m_spVTKPlane = vtkSmartPointer::New(); m_spVTKPlane->SetNormal(0.0, 0.0, 1.0); m_spVTKTextureMappedPlane = vtkSmartPointer::New(); m_spVTKTextureMappedPlane->SetInputConnection(m_spVTKPlane->GetOutputPort()); m_planeDataMapper = vtkSmartPointer::New(); m_planeDataMapper->SetInputConnection(m_spVTKTextureMappedPlane->GetOutputPort()); double followerOriginPoint[3] = { 0.0 }; followerOriginPoint[1] = -1 / 2.0; m_follower = vtkSmartPointer< vtkFollower>::New(); m_follower->SetOrigin(followerOriginPoint); m_follower->SetPosition( pos[0] - followerOriginPoint[0], pos[1] - followerOriginPoint[1], pos[2] - followerOriginPoint[2]); m_follower->SetScale(6); m_follower->SetMapper(m_planeDataMapper); m_follower->SetTexture(m_spVTKTexture); m_follower->SetCamera(getRenderer(m_rendererType)->GetActiveCamera()); m_follower->VisibilityOn(); m_follower->ForceOpaqueOff(); getRenderer(m_rendererType)->AddActor(m_follower);` >> >> If I change this code m_follower->SetTexture(m_spVTKTexture); >> >> into m_follower->GetProperty()->SetTexture(m_spVTKTexture);, >> >> Then, follower rendered properly without performance loss. but >> ForceOpaqueOff()does not work. >> >> I am using VTK 7.0. >> >> And the renderer is vtkrenderer. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 28 Corporate Drive > > Clifton Park NY 12065 > > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Fri Dec 8 10:31:21 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 Dec 2017 10:31:21 -0500 Subject: [vtk-developers] Failure of wiki examples on merge request build (both Windows) Message-ID: Hi, I am working on debugging an issue with the axes in the charts, and hit an odd failure: https://open.cdash.org/viewBuildError.php?buildid=5172371 C:\dashboards\buildbot\fc38cb64\source\Remote\WikiExamples\src\Cxx\IO\DumpXMLFile.cxx(82): error C2065: 'vtkXMLHyperOctreeReader': undeclared identifier .... It looks like there are currently just two Windows builds, and both of them failed in the same way. Are all of the build hosts building wiki examples, or just Windows? Do they build whatever happens to be master in the remote modules, or are they using the GIT_TAG defined in the remote? I have submitted another request for a build, maybe this is a current failure in the examples only affecting Windows, but then I wonder how it ended up getting missed before merging. I can rebase the branch if I just happened to be unlucky too. Thanks, Marcus -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Dec 8 10:55:08 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 8 Dec 2017 10:55:08 -0500 Subject: [vtk-developers] Failure of wiki examples on merge request build (both Windows) In-Reply-To: References: Message-ID: I fixed it this morning. Do a pull. Let me know if you have other issues. Changes to VTK's api are a pain in the ass. On Fri, Dec 8, 2017 at 10:31 AM, Marcus D. Hanwell wrote: > Hi, > > I am working on debugging an issue with the axes in the charts, and hit an > odd failure: > > https://open.cdash.org/viewBuildError.php?buildid=5172371 > C:\dashboards\buildbot\fc38cb64\source\Remote\WikiExamples\src\Cxx\IO\DumpXMLFile.cxx(82): > error C2065: 'vtkXMLHyperOctreeReader': undeclared identifier > .... > > It looks like there are currently just two Windows builds, and both of them > failed in the same way. Are all of the build hosts building wiki examples, > or just Windows? Do they build whatever happens to be master in the remote > modules, or are they using the GIT_TAG defined in the remote? > > I have submitted another request for a build, maybe this is a current > failure in the examples only affecting Windows, but then I wonder how it > ended up getting missed before merging. I can rebase the branch if I just > happened to be unlucky too. > > Thanks, > > Marcus > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From marcus.hanwell at kitware.com Fri Dec 8 11:11:36 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 Dec 2017 11:11:36 -0500 Subject: [vtk-developers] Failure of wiki examples on merge request build (both Windows) In-Reply-To: References: Message-ID: On Fri, Dec 8, 2017 at 10:55 AM, Bill Lorensen wrote: > I fixed it this morning. Do a pull. Let me know if you have other issues. > > Changes to VTK's api are a pain in the ass. > > I will rebase the branch then, I was more trying to understand the interaction here - I guess it does use the tag in the VTK repo akin to it being a submodule, and I was just unlucky. Thanks Bill. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Fri Dec 8 12:49:32 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 Dec 2017 12:49:32 -0500 Subject: [vtk-developers] Image based axis test passing despite failure (Windows bug with label precision) Message-ID: I had been meaning to look into this for a while, we have an issue on Windows with chart axes displaying way too many decimal places using scientific notation and set precision. I have confirmed on the dashboard that this does in fact happen with the TestAxes test: https://open.cdash.org/testDetails.php?test=607700533&build=5173639 I made the axis next to it invisible, so it begs the question of why this was passing on Windows as I only see one baseline, and it looks correct. Perhaps the test image is too crowded, and the fuzzing for the image let it through unnoticed all this time? This is using the standard library calls to generate the labels, so guessing this is a bug/feature in the Windows STL, I will dig into this but wanted to point this passing failure out in case anyone had ideas on how it might be prevented in the future. I noticed because we use this in Tomviz, and on Windows users complained about us using 10 decimal places, asking for a more reasonable number :-) -------------- next part -------------- An HTML attachment was scrubbed... URL: From jeff.baumes at kitware.com Fri Dec 8 12:58:28 2017 From: jeff.baumes at kitware.com (Jeff Baumes) Date: Fri, 08 Dec 2017 17:58:28 +0000 Subject: [vtk-developers] Image based axis test passing despite failure (Windows bug with label precision) In-Reply-To: References: Message-ID: Don't know about the image non-failure, but I've seen these settings interfere with how numbers are formatted across Windows applications (e.g. I think these settings affect how CSVs are exported from Excel for example): https://superuser.com/questions/969078/how-can-i-change-number-format-in-my-pc-windows-8 On Fri, Dec 8, 2017 at 12:49 PM Marcus D. Hanwell < marcus.hanwell at kitware.com> wrote: > I had been meaning to look into this for a while, we have an issue on > Windows with chart axes displaying way too many decimal places using > scientific notation and set precision. I have confirmed on the dashboard > that this does in fact happen with the TestAxes test: > > https://open.cdash.org/testDetails.php?test=607700533&build=5173639 > > I made the axis next to it invisible, so it begs the question of why this > was passing on Windows as I only see one baseline, and it looks correct. > Perhaps the test image is too crowded, and the fuzzing for the image let it > through unnoticed all this time? > > This is using the standard library calls to generate the labels, so > guessing this is a bug/feature in the Windows STL, I will dig into this but > wanted to point this passing failure out in case anyone had ideas on how it > might be prevented in the future. > > I noticed because we use this in Tomviz, and on Windows users complained > about us using 10 decimal places, asking for a more reasonable number :-) > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Fri Dec 8 13:08:49 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 Dec 2017 13:08:49 -0500 Subject: [vtk-developers] Image based axis test passing despite failure (Windows bug with label precision) In-Reply-To: References: Message-ID: I think we already clobber a lot of it by setting the numeric locale to C, and there is code in the axes that is careful to avoid localized number strings: void vtkAxis::GenerateLabelFormat(int notation, double n) { std::ostringstream ostr; ostr.imbue(std::locale::classic()); switch(notation) { case 1: ostr << n; ostr.precision(this->Precision); ostr.setf(std::ios::scientific, std::ios::floatfield); this->TickLabels->InsertNextValue(ostr.str()); break; ... I can try tweaking some of this now I have a failing test at least. I thought the image regression would have been sensitive enough to catch it. On Fri, Dec 8, 2017 at 12:58 PM, Jeff Baumes wrote: > Don't know about the image non-failure, but I've seen these settings > interfere with how numbers are formatted across Windows applications (e.g. > I think these settings affect how CSVs are exported from Excel for example): > > https://superuser.com/questions/969078/how-can-i- > change-number-format-in-my-pc-windows-8 > > On Fri, Dec 8, 2017 at 12:49 PM Marcus D. Hanwell < > marcus.hanwell at kitware.com> wrote: > >> I had been meaning to look into this for a while, we have an issue on >> Windows with chart axes displaying way too many decimal places using >> scientific notation and set precision. I have confirmed on the dashboard >> that this does in fact happen with the TestAxes test: >> >> https://open.cdash.org/testDetails.php?test=607700533&build=5173639 >> >> I made the axis next to it invisible, so it begs the question of why this >> was passing on Windows as I only see one baseline, and it looks correct. >> Perhaps the test image is too crowded, and the fuzzing for the image let it >> through unnoticed all this time? >> >> This is using the standard library calls to generate the labels, so >> guessing this is a bug/feature in the Windows STL, I will dig into this but >> wanted to point this passing failure out in case anyone had ideas on how it >> might be prevented in the future. >> >> I noticed because we use this in Tomviz, and on Windows users complained >> about us using 10 decimal places, asking for a more reasonable number :-) >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at http://www.kitware.com/ >> opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Fri Dec 8 14:05:01 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 Dec 2017 14:05:01 -0500 Subject: [vtk-developers] Image based axis test passing despite failure (Windows bug with label precision) In-Reply-To: References: Message-ID: So, I built the simplest Visual Studio project, and it would appear that there is a bug in their STL implementation for ostringstream, setting precision to a non-zero value works as expected, but if you attempt to use scientific notation with a precision of 0 it uses 6! It works as expected with fixed notation. The pragmatic solution for Tomviz is to use 1 decimal place I think in this case. I am not sure how much value there is in adding custom code, this seems to be a bug across a number of Visual Studio versions. A simple Google didn't turn up any useful workarounds, maybe my Google skills are failing me today. On Fri, Dec 8, 2017 at 1:08 PM, Marcus D. Hanwell < marcus.hanwell at kitware.com> wrote: > I think we already clobber a lot of it by setting the numeric locale to C, > and there is code in the axes that is careful to avoid localized number > strings: > > void vtkAxis::GenerateLabelFormat(int notation, double n) > { > std::ostringstream ostr; > ostr.imbue(std::locale::classic()); > > switch(notation) > { > case 1: > ostr << n; > ostr.precision(this->Precision); > ostr.setf(std::ios::scientific, std::ios::floatfield); > this->TickLabels->InsertNextValue(ostr.str()); > break; > ... > > I can try tweaking some of this now I have a failing test at least. I > thought the image regression would have been sensitive enough to catch it. > > On Fri, Dec 8, 2017 at 12:58 PM, Jeff Baumes > wrote: > >> Don't know about the image non-failure, but I've seen these settings >> interfere with how numbers are formatted across Windows applications (e.g. >> I think these settings affect how CSVs are exported from Excel for example): >> >> https://superuser.com/questions/969078/how-can-i-change- >> number-format-in-my-pc-windows-8 >> >> On Fri, Dec 8, 2017 at 12:49 PM Marcus D. Hanwell < >> marcus.hanwell at kitware.com> wrote: >> >>> I had been meaning to look into this for a while, we have an issue on >>> Windows with chart axes displaying way too many decimal places using >>> scientific notation and set precision. I have confirmed on the dashboard >>> that this does in fact happen with the TestAxes test: >>> >>> https://open.cdash.org/testDetails.php?test=607700533&build=5173639 >>> >>> I made the axis next to it invisible, so it begs the question of why >>> this was passing on Windows as I only see one baseline, and it looks >>> correct. Perhaps the test image is too crowded, and the fuzzing for the >>> image let it through unnoticed all this time? >>> >>> This is using the standard library calls to generate the labels, so >>> guessing this is a bug/feature in the Windows STL, I will dig into this but >>> wanted to point this passing failure out in case anyone had ideas on how it >>> might be prevented in the future. >>> >>> I noticed because we use this in Tomviz, and on Windows users complained >>> about us using 10 decimal places, asking for a more reasonable number :-) >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q= >>> vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sankhesh.jhaveri at kitware.com Mon Dec 11 11:00:17 2017 From: sankhesh.jhaveri at kitware.com (Sankhesh Jhaveri) Date: Mon, 11 Dec 2017 16:00:17 +0000 Subject: [vtk-developers] [vtkusers] ExtractByLocation In-Reply-To: References: Message-ID: Hello Amine, Take a look at point locators in VTK. Here is an example of the KdTreePointLocator: https://lorensen.github.io/VTKExamples/site/Cxx/DataStructures/KdTreePointLocator/ClosestNPoints/ For your particular use case, you might want to look at vtkKdTreePointLocator::FindPointsWithinRadius Hope this helps. Best, Sankhesh ? On Sat, Dec 9, 2017 at 5:49 AM kenichiro yoshimi wrote: > Hello Amine, > > The searching range for location selection of points is limited by > EPSILON key. You can set a bigger value to expand the searching range > as below. > SelectionNode.GetProperties().Set(SelectionNode.EPSILON(), 1000) > > Thanks > > 2017-12-02 0:45 GMT+09:00 Amine Aboufirass : > > Hello, > > > > I am trying to figure out how to select the closest neighboring points > to a > > list of coordinates using the vtk library. I have a simple point data > set in > > the Unstructured Grid Format. The dataset contains one attribute named > the > > 'point_id' which is just enumerating the points starting from 1 instead > of > > 0. The raw text from the ASCII file is attached in testScalar.vtk below. > > > > I have also written a script in python which I thought would function as > > follows: > > > > INPUT: > > > > List of tuples containing world coordinates [(X1,Y1,Z1),(X2,Y2,Z2)] > > name of attribute to extract as a string. in this case "point_id" > > > > OUTPUT: > > > > List of floating point values of the attribute for the selected points > > > > This does work to a certain degree, for instance when I do : > > > > ExtractByLocation('testScalar.vtk', [(5.999,0,0)], 'point_id') > > > > I do indeed get back the following: > > > > array([ 2.], dtype=float32) > > > > So point_id 2 is the closest point to the coordinates I have specified. > > However, as soon as I get a bit too far from one of the points, the > function > > starts returning an empty list. For instance: > > > > ExtractByLocation('testScalar.vtk', [(5.888,0,0)], 'point_id') > > > > Returns > > array([], dtype=float32) > > > > I found out that the cut off point is 5.89-5.90. If I plugin 5.9 I get > the > > point, if I plugin 5.89 I get back an empty list. > > > > According to the object reference > > ( > https://www.vtk.org/doc/nightly/html/classvtkSelectionNode.html#aa7b54148c40adf4f5019b8ad3e160535a97d8505c922b2a25c5d2755607d3cbb6 > ) > > LOCATIONS is supposed to select the points near the supplied world > > coordinates. Is there an option or something that selects the nearest > point > > PERIOD? i.e using a simple distance formula? I would like to never get > back > > an empty list but always get back a list of the closest point to the > > supplied coordinates. > > > > Kind Regards, > > > > Amine > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Please keep messages on-topic and check the VTK FAQ at: > > http://www.vtk.org/Wiki/VTK_FAQ > > > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtkusers > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the VTK FAQ at: > http://www.vtk.org/Wiki/VTK_FAQ > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtkusers > -- Sankhesh Jhaveri *Sr. Research & Development Engineer* | Kitware | (518) 881-4417 ? -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Mon Dec 11 13:00:37 2017 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Mon, 11 Dec 2017 13:00:37 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: <20170919142943.GA28183@megas.kitware.com> References: <20170919142943.GA28183@megas.kitware.com> Message-ID: I went the route of simpler implementation that better handles all forms of importing vtk including `import vtk` and `from vtk import *` etc. while still providing me with a package that doesn't import all the modules. The implementation is here: https://gitlab.kitware.com/vtk/vtk/merge_requests/3674 In summary: * a new `vtkmodules` package replaces the old `vtk` package which has an empty __init__.py file, thus doesn't import anything by default. * `vtkmodules.all` module imports all vtk modules * vtk.py is a new module that acts as a trampoline, forwarding to the `vtkmodules` package but also imports everything from the all module. I'd like to move forward with this change, if there are no objections. It's 100% backwards compatible. Utkarsh From tim.thirion at kitware.com Mon Dec 11 14:24:22 2017 From: tim.thirion at kitware.com (Tim Thirion) Date: Mon, 11 Dec 2017 11:24:22 -0800 Subject: [vtk-developers] vtkWindowToImageFilter Message-ID: Hi all, I have a customer that is using vtkWindowToImageFilter [1] to capture framebuffer data. However, it seems it's also capturing the decorations of the window as well--the title bar, etc., which is not desirable. Is there a way to ensure it only captures the GL context? This is a Linux deployment. TT https://www.vtk.org/doc/nightly/html/classvtkWindowToImageFilter.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Mon Dec 11 15:46:29 2017 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Mon, 11 Dec 2017 15:46:29 -0500 Subject: [vtk-developers] vtkWindowToImageFilter In-Reply-To: References: Message-ID: That's odd. vtkWindowToImageFilter is indeed not intended to capture the decorations. Make sure you're capturing from the right buffer (https://blog.kitware.com/be-careful-what-you-grab/). Utkarsh On Mon, Dec 11, 2017 at 2:24 PM, Tim Thirion wrote: > Hi all, > > I have a customer that is using vtkWindowToImageFilter [1] to capture > framebuffer data. However, it seems it's also capturing the decorations of > the window as well--the title bar, etc., which is not desirable. Is there a > way to ensure it only captures the GL context? This is a Linux deployment. > > TT > > https://www.vtk.org/doc/nightly/html/classvtkWindowToImageFilter.html > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From andrew.amaclean at gmail.com Tue Dec 12 05:05:10 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Tue, 12 Dec 2017 21:05:10 +1100 Subject: [vtk-developers] Standard human anatomical position In-Reply-To: References: Message-ID: I have created a little example to show the various anatomical planes and relate them to coordinate systems using vtkOrientationMarkerWidget. I would like to put a human body in the standard anatomical position i.e. standing up straight with the body at rest into this view. Does anyone know of a freely available model I can use that is compliant with VTK licensing? Thanks in advance, Andrew Maclean -------------- next part -------------- An HTML attachment was scrubbed... URL: From lasso at queensu.ca Tue Dec 12 08:40:39 2017 From: lasso at queensu.ca (Andras Lasso) Date: Tue, 12 Dec 2017 13:40:39 +0000 Subject: [vtk-developers] [vtkusers] Standard human anatomical position In-Reply-To: References: Message-ID: You can grab this one from 3D Slicer (all resource files that we put into Slicer can be used without even attribution): https://www.dropbox.com/s/5ftwq3egtun19um/SlicerHumanOrientationMarker.png?dl=0 https://github.com/Slicer/Slicer/blob/master/Base/Logic/Resources/OrientationMarkers/Human.vtp The model is shaped colored to make it easy to distinguish directions (left/right, up/down, front/back), even when shown in a small size. Color information is stored embedded as scalar data, so you don?t need to load it separately from a texture file. Andras From: vtkusers [mailto:vtkusers-bounces at vtk.org] On Behalf Of Andrew Maclean Sent: Tuesday, December 12, 2017 5:05 AM To: VTK Developers ; vtk Subject: [vtkusers] Standard human anatomical position I have created a little example to show the various anatomical planes and relate them to coordinate systems using vtkOrientationMarkerWidget. I would like to put a human body in the standard anatomical position i.e. standing up straight with the body at rest into this view. Does anyone know of a freely available model I can use that is compliant with VTK licensing? Thanks in advance, Andrew Maclean -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Tue Dec 12 09:08:48 2017 From: will.schroeder at kitware.com (Will Schroeder) Date: Tue, 12 Dec 2017 09:08:48 -0500 Subject: [vtk-developers] Parsing and reading json files Message-ID: Background: I am working with a research team performing biological simulation (UConn fungal simulation ). Their simulation code (NetLogo ) has been instrumented to output JSON files for the purposes of visualization. Advice needed: We need to read their data so I intend to write a VTK reader to parse these JSON files. It appears that "VTK/ThirdParty/jsoncpp" is the way to go, please correct me if I am wrong and/or offer an alternate approach. Best, W -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From lasso at queensu.ca Tue Dec 12 09:20:22 2017 From: lasso at queensu.ca (Andras Lasso) Date: Tue, 12 Dec 2017 14:20:22 +0000 Subject: [vtk-developers] Parsing and reading json files In-Reply-To: References: Message-ID: Jsoncpp works and it?s already added in VTK, so it is a convenient choice. However, we?ve found that if you work with large documents then it is unbearably slow (not just parsing, but accessing data in memory). For large files, I would recommend RapidJSON instead. Some advantages of RapidJSON: - Magnitudes faster, also, its API facilitates writing efficient application code (although this API is also a bit more complex than jsoncpp) - CMake-ified - Header-only (no need to install DLLs, ...) - More conform to json standard - Library is much smaller (31k vs 243k) Some more background: https://github.com/Slicer/Slicer/pull/646 Andras From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of Will Schroeder Sent: Tuesday, December 12, 2017 9:09 AM To: vtk-developers Subject: [vtk-developers] Parsing and reading json files Background: I am working with a research team performing biological simulation (UConn fungal simulation). Their simulation code (NetLogo) has been instrumented to output JSON files for the purposes of visualization. Advice needed: We need to read their data so I intend to write a VTK reader to parse these JSON files. It appears that "VTK/ThirdParty/jsoncpp" is the way to go, please correct me if I am wrong and/or offer an alternate approach. Best, W -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.malaterre at gmail.com Tue Dec 12 09:48:58 2017 From: mathieu.malaterre at gmail.com (Mathieu Malaterre) Date: Tue, 12 Dec 2017 15:48:58 +0100 Subject: [vtk-developers] Parsing and reading json files In-Reply-To: References: Message-ID: Just one reminder for RapidJson and long string: https://github.com/Tencent/rapidjson/issues/996 On Tue, Dec 12, 2017 at 3:20 PM, Andras Lasso wrote: > Jsoncpp works and it?s already added in VTK, so it is a convenient choice. > However, we?ve found that if you work with large documents then it is > unbearably slow (not just parsing, but accessing data in memory). For large > files, I would recommend RapidJSON instead. > > > > Some advantages of RapidJSON: > > > > - Magnitudes faster, also, its API facilitates writing efficient > application code (although this API is also a bit more complex than jsoncpp) > > - CMake-ified > > - Header-only (no need to install DLLs, ...) > > - More conform to json standard > > - Library is much smaller (31k vs 243k) > > > > Some more background: > > https://github.com/Slicer/Slicer/pull/646 > > > > Andras > > > > From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of > Will Schroeder > Sent: Tuesday, December 12, 2017 9:09 AM > To: vtk-developers > Subject: [vtk-developers] Parsing and reading json files > > > > Background: > > I am working with a research team performing biological simulation (UConn > fungal simulation). Their simulation code (NetLogo) has been instrumented to > output JSON files for the purposes of visualization. > > > > Advice needed: > > We need to read their data so I intend to write a VTK reader to parse these > JSON files. It appears that "VTK/ThirdParty/jsoncpp" is the way to go, > please correct me if I am wrong and/or offer an alternate approach. > > > > Best, > W > > > > > > > -- > > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Mathieu From alexis.girault at kitware.com Tue Dec 12 12:10:39 2017 From: alexis.girault at kitware.com (Alexis Girault) Date: Tue, 12 Dec 2017 12:10:39 -0500 Subject: [vtk-developers] vtk header listing compiled modules Message-ID: Hi all, We're currently working on improving the vtk ios viewer. The vtk app is currently configured with XCode, and we link against a vtk.framework that is cross-compiled for iOS through CMake. We want the app to offer a way to attempt to load the files that are only supported by the vtk.framework that was built, so we need a way to know which modules were built from the Xcode Project (example: OBJ, STL, PLY might or might not make it). Is there a header file we could include that is configured during vtk's build process to define the modules that should be part of the build? Thanks! Alexis -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Tue Dec 12 13:27:40 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Tue, 12 Dec 2017 13:27:40 -0500 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: References: Message-ID: <20171212182740.GA17186@megas.kitware.com> On Tue, Dec 12, 2017 at 12:10:39 -0500, Alexis Girault wrote: > Is there a header file we could include that is configured during vtk's > build process to define the modules that should be part of the build? No, one could generate such a header based on the `VTK_ALL_MODULES` CMake list though. --Ben From ben.boeckel at kitware.com Tue Dec 12 13:28:02 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Tue, 12 Dec 2017 13:28:02 -0500 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: <20171212182740.GA17186@megas.kitware.com> References: <20171212182740.GA17186@megas.kitware.com> Message-ID: <20171212182802.GB17186@megas.kitware.com> On Tue, Dec 12, 2017 at 13:27:40 -0500, Ben Boeckel wrote: > No, one could generate such a header based on the `VTK_ALL_MODULES` > CMake list though. Sorry, it is `VTK_MODULES_ALL`. --Ben From david.gobbi at gmail.com Tue Dec 12 13:35:38 2017 From: david.gobbi at gmail.com (David Gobbi) Date: Tue, 12 Dec 2017 11:35:38 -0700 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: <20171212182802.GB17186@megas.kitware.com> References: <20171212182740.GA17186@megas.kitware.com> <20171212182802.GB17186@megas.kitware.com> Message-ID: If VTK is already built, it might be best to use the VTK_MODULES_ENABLED from VTKConfig.cmake. - David On Tue, Dec 12, 2017 at 11:28 AM, Ben Boeckel wrote: > On Tue, Dec 12, 2017 at 13:27:40 -0500, Ben Boeckel wrote: > > No, one could generate such a header based on the `VTK_ALL_MODULES` > > CMake list though. > > Sorry, it is `VTK_MODULES_ALL`. > > --Ben > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From prabhu at aero.iitb.ac.in Tue Dec 12 15:06:15 2017 From: prabhu at aero.iitb.ac.in (Prabhu Ramachandran) Date: Tue, 12 Dec 2017 15:06:15 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> Message-ID: <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> On 12/11/17 1:00 PM, Utkarsh Ayachit wrote: > The implementation is here: > https://gitlab.kitware.com/vtk/vtk/merge_requests/3674 > > In summary: > * a new `vtkmodules` package replaces the old `vtk` package which has > an empty __init__.py file, thus doesn't import anything by default. > * `vtkmodules.all` module imports all vtk modules Would `vtkm` be a shorter name rather than `vtkmodules`? cheers, Prabhu -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Tue Dec 12 15:18:09 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Tue, 12 Dec 2017 15:18:09 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> Message-ID: <20171212201809.GA20736@megas.kitware.com> On Tue, Dec 12, 2017 at 15:06:15 -0500, Prabhu Ramachandran wrote: > Would `vtkm` be a shorter name rather than `vtkmodules`? `vtkm` is a different project already (though I don't know of its status with Python wrapping outside of the VTK filters which use it). --Ben From andrew.amaclean at gmail.com Tue Dec 12 15:25:19 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 13 Dec 2017 07:25:19 +1100 Subject: [vtk-developers] [vtkusers] Standard human anatomical position In-Reply-To: References: Message-ID: Thankyou very much! It looks to be exactly what I need. On Wed, Dec 13, 2017 at 12:40 AM, Andras Lasso wrote: > You can grab this one from 3D Slicer (all resource files that we put into > Slicer can be used without even attribution): > > > > https://www.dropbox.com/s/5ftwq3egtun19um/SlicerHumanOrientationMarker. > png?dl=0 > > > > https://github.com/Slicer/Slicer/blob/master/Base/Logic/ > Resources/OrientationMarkers/Human.vtp > > > > The model is shaped colored to make it easy to distinguish directions > (left/right, up/down, front/back), even when shown in a small size. Color > information is stored embedded as scalar data, so you don?t need to load it > separately from a texture file. > > > > Andras > > > > *From:* vtkusers [mailto:vtkusers-bounces at vtk.org] *On Behalf Of *Andrew > Maclean > *Sent:* Tuesday, December 12, 2017 5:05 AM > *To:* VTK Developers ; vtk > *Subject:* [vtkusers] Standard human anatomical position > > > > I have created a little example to show the various anatomical planes and > relate them to coordinate systems using vtkOrientationMarkerWidget. I would > like to put a human body in the standard anatomical position i.e. standing > up straight with the body at rest into this view. > > > > Does anyone know of a freely available model I can use that is compliant > with VTK licensing? > > > > > Thanks in advance, > > Andrew Maclean > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Tue Dec 12 16:55:58 2017 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Tue, 12 Dec 2017 16:55:58 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: <20171212201809.GA20736@megas.kitware.com> References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> Message-ID: On Tue, Dec 12, 2017 at 3:18 PM, Ben Boeckel wrote: > On Tue, Dec 12, 2017 at 15:06:15 -0500, Prabhu Ramachandran wrote: >> Would `vtkm` be a shorter name rather than `vtkmodules`? > > `vtkm` is a different project already (though I don't know of its status > with Python wrapping outside of the VTK filters which use it). Yea, alas `vtkm` won't be a good option. From marcus.hanwell at kitware.com Wed Dec 13 12:41:18 2017 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Wed, 13 Dec 2017 12:41:18 -0500 Subject: [vtk-developers] Image based axis test passing despite failure (Windows bug with label precision) In-Reply-To: References: Message-ID: Not making any promises on when (or if) I can get to this, but I opened https://gitlab.kitware.com/vtk/vtk/issues/17201 to track the issues I brought up (the bug, and the non-failure of a test that looks like it should fail). Hopefully the search engines connect the pieces in the future should anyone hit a similar issue. On Fri, Dec 8, 2017 at 2:05 PM, Marcus D. Hanwell < marcus.hanwell at kitware.com> wrote: > So, I built the simplest Visual Studio project, and it would appear that > there is a bug in their STL implementation for ostringstream, setting > precision to a non-zero value works as expected, but if you attempt to use > scientific notation with a precision of 0 it uses 6! It works as expected > with fixed notation. > > The pragmatic solution for Tomviz is to use 1 decimal place I think in > this case. I am not sure how much value there is in adding custom code, > this seems to be a bug across a number of Visual Studio versions. A simple > Google didn't turn up any useful workarounds, maybe my Google skills are > failing me today. > > > On Fri, Dec 8, 2017 at 1:08 PM, Marcus D. Hanwell < > marcus.hanwell at kitware.com> wrote: > >> I think we already clobber a lot of it by setting the numeric locale to >> C, and there is code in the axes that is careful to avoid localized number >> strings: >> >> void vtkAxis::GenerateLabelFormat(int notation, double n) >> { >> std::ostringstream ostr; >> ostr.imbue(std::locale::classic()); >> >> switch(notation) >> { >> case 1: >> ostr << n; >> ostr.precision(this->Precision); >> ostr.setf(std::ios::scientific, std::ios::floatfield); >> this->TickLabels->InsertNextValue(ostr.str()); >> break; >> ... >> >> I can try tweaking some of this now I have a failing test at least. I >> thought the image regression would have been sensitive enough to catch it. >> >> On Fri, Dec 8, 2017 at 12:58 PM, Jeff Baumes >> wrote: >> >>> Don't know about the image non-failure, but I've seen these settings >>> interfere with how numbers are formatted across Windows applications (e.g. >>> I think these settings affect how CSVs are exported from Excel for example): >>> >>> https://superuser.com/questions/969078/how-can-i-change-numb >>> er-format-in-my-pc-windows-8 >>> >>> On Fri, Dec 8, 2017 at 12:49 PM Marcus D. Hanwell < >>> marcus.hanwell at kitware.com> wrote: >>> >>>> I had been meaning to look into this for a while, we have an issue on >>>> Windows with chart axes displaying way too many decimal places using >>>> scientific notation and set precision. I have confirmed on the dashboard >>>> that this does in fact happen with the TestAxes test: >>>> >>>> https://open.cdash.org/testDetails.php?test=607700533&build=5173639 >>>> >>>> I made the axis next to it invisible, so it begs the question of why >>>> this was passing on Windows as I only see one baseline, and it looks >>>> correct. Perhaps the test image is too crowded, and the fuzzing for the >>>> image let it through unnoticed all this time? >>>> >>>> This is using the standard library calls to generate the labels, so >>>> guessing this is a bug/feature in the Windows STL, I will dig into this but >>>> wanted to point this passing failure out in case anyone had ideas on how it >>>> might be prevented in the future. >>>> >>>> I noticed because we use this in Tomviz, and on Windows users >>>> complained about us using 10 decimal places, asking for a more reasonable >>>> number :-) >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: http://markmail.org/search/?q= >>>> vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dave.demarle at kitware.com Wed Dec 13 16:39:53 2017 From: dave.demarle at kitware.com (David E DeMarle) Date: Wed, 13 Dec 2017 16:39:53 -0500 Subject: [vtk-developers] announce: vtk 8.1.0.rc3 is ready to try Message-ID: Hi folks, VTK 8.1.0.rc3 is up on the downloads site and tagged in git. Please give it a try and report any problems that you find to us via the gitlab issue tracker with an "8.1" milestone tag. Developers, use the same tag to let us know of any fixes that you want integrated to the release branch in time for 8.1.0 final in about a week. If nothing major comes up, this will be retagged as 8.1.0 final. We expect the next release, VTK 9.0.0, to be out in a few short months. The reason for rc3 is that we decided to deprecate vtkHyperOctree. It has long been superseded by vtkHyperTreeGrid, which is being actively maintained and updated, unlike its predecessor. thanks David E DeMarle Kitware, Inc. Principal Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Thu Dec 14 08:55:12 2017 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 14 Dec 2017 08:55:12 -0500 Subject: [vtk-developers] kens_macbook Message-ID: FYI the failures on kens_macbook were due to being in the middle of a High Sierra/XCode upgrade. Hopefully back to normal tomorrow morning. -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From alexis.girault at kitware.com Thu Dec 14 09:24:40 2017 From: alexis.girault at kitware.com (Alexis Girault) Date: Thu, 14 Dec 2017 09:24:40 -0500 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: References: <20171212182740.GA17186@megas.kitware.com> <20171212182802.GB17186@megas.kitware.com> Message-ID: Thanks Ben, David. Since we're in XCode and not using CMake at that point, I don't think we can grab anything from VTKConfig.cmake easily. I'll look into generating a header, I assume I should try to use VTK_MODULES_ENABLED and not VTK_MODULES_ALL ? Alexis Girault R&D Engineer in Medical Computing Kitware, Inc. http://www.kitware.com (919) 969-6990 x325 On Tue, Dec 12, 2017 at 1:35 PM, David Gobbi wrote: > If VTK is already built, it might be best to use the VTK_MODULES_ENABLED > from VTKConfig.cmake. > > - David > > On Tue, Dec 12, 2017 at 11:28 AM, Ben Boeckel > wrote: > >> On Tue, Dec 12, 2017 at 13:27:40 -0500, Ben Boeckel wrote: >> > No, one could generate such a header based on the `VTK_ALL_MODULES` >> > CMake list though. >> >> Sorry, it is `VTK_MODULES_ALL`. >> >> --Ben >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Thu Dec 14 09:45:47 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 14 Dec 2017 09:45:47 -0500 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: References: <20171212182740.GA17186@megas.kitware.com> <20171212182802.GB17186@megas.kitware.com> Message-ID: <20171214144547.GA27488@megas.kitware.com> On Thu, Dec 14, 2017 at 09:24:40 -0500, Alexis Girault wrote: > Since we're in XCode and not using CMake at that point, I don't think we > can grab anything from VTKConfig.cmake easily. > > I'll look into generating a header, I assume I should try to use > VTK_MODULES_ENABLED > and not VTK_MODULES_ALL ? It depends whether you're using an external VTK or not. The `find_package(VTK)` has `VTK_MODULES_ENABLED`, but it looks like it comes from `VTK_CONFIG_MODULES_ENABLED` which is `VTK_MODULES_ENABLED` without the test modules during the VTK build. Would it be easier just to have everything from VTK compiled into a single kit (a single library) or do you still need to know modules for features? --Ben From sean at rogue-research.com Thu Dec 14 11:02:44 2017 From: sean at rogue-research.com (Sean McBride) Date: Thu, 14 Dec 2017 11:02:44 -0500 Subject: [vtk-developers] List header changes? X-BeenThere & List-Id Message-ID: <20171214160244.1284534052@mail.rogue-research.com> Hi all, Looks like you updated mailman an your server... Two headers commonly used for filtering seem to have changed from: X-BeenThere: vtk-developers at vtk.org List-Id: to: X-BeenThere: vtk-developers at public.kitware.com List-Id: Was that deliberate? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From brad.king at kitware.com Thu Dec 14 11:16:35 2017 From: brad.king at kitware.com (Brad King) Date: Thu, 14 Dec 2017 11:16:35 -0500 Subject: [vtk-developers] List header changes? X-BeenThere & List-Id In-Reply-To: <20171214160244.1284534052@mail.rogue-research.com> References: <20171214160244.1284534052@mail.rogue-research.com> Message-ID: <41b835d6-20c2-02d8-cf10-fa0db6e5a8db@kitware.com> On 12/14/2017 11:02 AM, Sean McBride wrote: > Looks like you updated mailman an your server... > Two headers commonly used for filtering seem to have changed from: > > X-BeenThere: vtk-developers at vtk.org > List-Id: > > to: > > X-BeenThere: vtk-developers at public.kitware.com > List-Id: According to our admins this was fixed this morning so it was only a few messages that went wrong. Indeed the message to which I'm replying has the correct headers. -Brad From jchris.fillionr at kitware.com Fri Dec 15 00:04:52 2017 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 15 Dec 2017 00:04:52 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> Message-ID: Hi Utkarsh, I would prefer to have a more generic way of configuring the import behavior. The idea would be to have two top-level packages: vtk and vtkConfig To skip loading of all module, you would do: ------------------- import vtkConfig vtkConfig.VTK_MODULE_IMPORT = vtkConfig.EXPLICIT # Default would be vtkConfig.ALL. Later we could also have vtkConfig.LAZY import vtk ------------------- This would allow to keep things coherent for our user. Naming the package "vtkmodules" seem unconventional. It would also have the advantage of support addition of new option. For example: vtkConfig.RENDERING_METHOD = vtkConfig.OFFSCREEN # or vtkConfig.MESA, .... Jc On Tue, Dec 12, 2017 at 4:55 PM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > On Tue, Dec 12, 2017 at 3:18 PM, Ben Boeckel > wrote: > > On Tue, Dec 12, 2017 at 15:06:15 -0500, Prabhu Ramachandran wrote: > >> Would `vtkm` be a shorter name rather than `vtkmodules`? > > > > `vtkm` is a different project already (though I don't know of its status > > with Python wrapping outside of the VTK filters which use it). > > Yea, alas `vtkm` won't be a good option. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Fri Dec 15 08:55:08 2017 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Fri, 15 Dec 2017 08:55:08 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> Message-ID: JC, I am not a huge fan of this option since the `vtk`package will not provide a consistent interface based on how the package was imported. It will make it impossible to write scripts that use `import vtk` and work reliably. e..g say I have a module (outside VTK) that relies on `import vtk` to have all necessary symbols. Now my script will fail, if some other module that the user imported before importing my module changed the nature of the `vtk` package. Thus, the only way to write reliable scripts is to import internal modules as needed, and that defeats the purpose. The future config you envision could currently be easily provided by factory or other singletons in VTK library itself that control the default render window created, for example, and should indeed be supported there since it's useful for C++ users of VTK too. Utkarsh On Fri, Dec 15, 2017 at 12:04 AM, Jean-Christophe Fillion-Robin wrote: > Hi Utkarsh, > > I would prefer to have a more generic way of configuring the import > behavior. > > The idea would be to have two top-level packages: vtk and vtkConfig > > To skip loading of all module, you would do: > > ------------------- > import vtkConfig > vtkConfig.VTK_MODULE_IMPORT = vtkConfig.EXPLICIT # Default would be > vtkConfig.ALL. Later we could also have vtkConfig.LAZY > > import vtk > ------------------- > > This would allow to keep things coherent for our user. Naming the package > "vtkmodules" seem unconventional. > > It would also have the advantage of support addition of new option. > > For example: > > vtkConfig.RENDERING_METHOD = vtkConfig.OFFSCREEN # or vtkConfig.MESA, .... > > Jc > > > On Tue, Dec 12, 2017 at 4:55 PM, Utkarsh Ayachit > wrote: >> >> On Tue, Dec 12, 2017 at 3:18 PM, Ben Boeckel >> wrote: >> > On Tue, Dec 12, 2017 at 15:06:15 -0500, Prabhu Ramachandran wrote: >> >> Would `vtkm` be a shorter name rather than `vtkmodules`? >> > >> > `vtkm` is a different project already (though I don't know of its status >> > with Python wrapping outside of the VTK filters which use it). >> >> Yea, alas `vtkm` won't be a good option. >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> > > > > -- > +1 919 869 8849 From alexis.girault at kitware.com Fri Dec 15 10:19:25 2017 From: alexis.girault at kitware.com (Alexis Girault) Date: Fri, 15 Dec 2017 10:19:25 -0500 Subject: [vtk-developers] vtk header listing compiled modules In-Reply-To: <20171214144547.GA27488@megas.kitware.com> References: <20171212182740.GA17186@megas.kitware.com> <20171212182802.GB17186@megas.kitware.com> <20171214144547.GA27488@megas.kitware.com> Message-ID: when compiling VTK for iOS, it cross-compiles a vtk.framework with all the libraries from the selected modules in there. We need to know modules for features (example: can I include and create a vtkPLYReader in my reader manager). I'll be looking into generating that header file then. Thanks for the tips. Alexis Girault R&D Engineer in Medical Computing Kitware, Inc. http://www.kitware.com (919) 969-6990 x325 On Thu, Dec 14, 2017 at 9:45 AM, Ben Boeckel wrote: > On Thu, Dec 14, 2017 at 09:24:40 -0500, Alexis Girault wrote: > > Since we're in XCode and not using CMake at that point, I don't think we > > can grab anything from VTKConfig.cmake easily. > > > > I'll look into generating a header, I assume I should try to use > > VTK_MODULES_ENABLED > > and not VTK_MODULES_ALL ? > > It depends whether you're using an external VTK or not. The > `find_package(VTK)` has `VTK_MODULES_ENABLED`, but it looks like it > comes from `VTK_CONFIG_MODULES_ENABLED` which is `VTK_MODULES_ENABLED` > without the test modules during the VTK build. > > Would it be easier just to have everything from VTK compiled into a > single kit (a single library) or do you still need to know modules for > features? > > --Ben > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Dec 15 10:39:31 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Dec 2017 10:39:31 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl Message-ID: Folks, The VTK Book, Figure 10-14 page 403 references a script MorphComparison.tcl. Does anyone know where I can find it and the associated input image? It was never checked into the VTK repo. Thanks, Bill BTW: This is one of the last scripts we need to convert to C++ for the VTKBookFigures in the VTKExamples repo. We have already converted 100 figure examples. Take a look here: https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ From will.schroeder at kitware.com Fri Dec 15 11:12:44 2017 From: will.schroeder at kitware.com (Will Schroeder) Date: Fri, 15 Dec 2017 11:12:44 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl In-Reply-To: References: Message-ID: Got it! On Fri, Dec 15, 2017 at 10:39 AM, Bill Lorensen wrote: > Folks, > > The VTK Book, Figure 10-14 page 403 references a script > MorphComparison.tcl. > > Does anyone know where I can find it and the associated input image? > It was never checked into the VTK repo. > > Thanks, > > Bill > > BTW: This is one of the last scripts we need to convert to C++ for the > VTKBookFigures in the VTKExamples repo. We have already converted 100 > figure examples. Take a look here: > https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: MorphComparison.tcl Type: application/x-tcl Size: 894 bytes Desc: not available URL: From bill.lorensen at gmail.com Fri Dec 15 11:26:55 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Dec 2017 11:26:55 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl In-Reply-To: References: Message-ID: Great! Maybe the input file binary.pgm is in the same location? On Fri, Dec 15, 2017 at 11:12 AM, Will Schroeder wrote: > Got it! > > On Fri, Dec 15, 2017 at 10:39 AM, Bill Lorensen > wrote: >> >> Folks, >> >> The VTK Book, Figure 10-14 page 403 references a script >> MorphComparison.tcl. >> >> Does anyone know where I can find it and the associated input image? >> It was never checked into the VTK repo. >> >> Thanks, >> >> Bill >> >> BTW: This is one of the last scripts we need to convert to C++ for the >> VTKBookFigures in the VTKExamples repo. We have already converted 100 >> figure examples. Take a look here: >> https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 -- Unpaid intern in BillsBasement at noware dot com From jchris.fillionr at kitware.com Fri Dec 15 11:30:27 2017 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 15 Dec 2017 11:30:27 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> Message-ID: Hi Utkarsh, Good point. Disabling import using vtkConfig is not a good idea for the reason you mentioned. That said, I still like the idea of implementing lazy loading by default and having vtkConfig to disable it. > currently be easily provided by factory or other singletons in VTK library itself that control the default render window created Good point. Would it roughly work like this: from vtk import vtkSomeFactory vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") or like this: from vtkmodules import vtkSomeFactory vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") import vtk Based on the proposed implementation for vtk.py [1], looks like the second case is correct. [1] https://gitlab.kitware.com/vtk/vtk/merge_requests/3674/diffs#95bcbb4f764974495db2df50144d2e041a3373f3 On Fri, Dec 15, 2017 at 8:55 AM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > JC, > > I am not a huge fan of this option since the `vtk`package will not > provide a consistent interface based on how the package was imported. > It will make it impossible to write scripts that use `import vtk` and > work reliably. e..g say I have a module (outside VTK) that relies on > `import vtk` to have all necessary symbols. Now my script will fail, > if some other module that the user imported before importing my module > changed the nature of the `vtk` package. Thus, the only way to write > reliable scripts is to import internal modules as needed, and that > defeats the purpose. > > The future config you envision could currently be easily provided by > factory or other singletons in VTK library itself that control the > default render window created, for example, and should indeed be > supported there since it's useful for C++ users of VTK too. > > Utkarsh > > On Fri, Dec 15, 2017 at 12:04 AM, Jean-Christophe Fillion-Robin > wrote: > > Hi Utkarsh, > > > > I would prefer to have a more generic way of configuring the import > > behavior. > > > > The idea would be to have two top-level packages: vtk and vtkConfig > > > > To skip loading of all module, you would do: > > > > ------------------- > > import vtkConfig > > vtkConfig.VTK_MODULE_IMPORT = vtkConfig.EXPLICIT # Default would be > > vtkConfig.ALL. Later we could also have vtkConfig.LAZY > > > > import vtk > > ------------------- > > > > This would allow to keep things coherent for our user. Naming the package > > "vtkmodules" seem unconventional. > > > > It would also have the advantage of support addition of new option. > > > > For example: > > > > vtkConfig.RENDERING_METHOD = vtkConfig.OFFSCREEN # or vtkConfig.MESA, > .... > > > > Jc > > > > > > On Tue, Dec 12, 2017 at 4:55 PM, Utkarsh Ayachit > > wrote: > >> > >> On Tue, Dec 12, 2017 at 3:18 PM, Ben Boeckel > >> wrote: > >> > On Tue, Dec 12, 2017 at 15:06:15 -0500, Prabhu Ramachandran wrote: > >> >> Would `vtkm` be a shorter name rather than `vtkmodules`? > >> > > >> > `vtkm` is a different project already (though I don't know of its > status > >> > with Python wrapping outside of the VTK filters which use it). > >> > >> Yea, alas `vtkm` won't be a good option. > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: http://markmail.org/search/?q= > vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> > > > > > > > > -- > > +1 919 869 8849 > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Fri Dec 15 11:44:40 2017 From: will.schroeder at kitware.com (Will Schroeder) Date: Fri, 15 Dec 2017 11:44:40 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl In-Reply-To: References: Message-ID: got it also! On Fri, Dec 15, 2017 at 11:26 AM, Bill Lorensen wrote: > Great! Maybe the input file binary.pgm is in the same location? > > On Fri, Dec 15, 2017 at 11:12 AM, Will Schroeder > wrote: > > Got it! > > > > On Fri, Dec 15, 2017 at 10:39 AM, Bill Lorensen > > > wrote: > >> > >> Folks, > >> > >> The VTK Book, Figure 10-14 page 403 references a script > >> MorphComparison.tcl. > >> > >> Does anyone know where I can find it and the associated input image? > >> It was never checked into the VTK repo. > >> > >> Thanks, > >> > >> Bill > >> > >> BTW: This is one of the last scripts we need to convert to C++ for the > >> VTKBookFigures in the VTKExamples repo. We have already converted 100 > >> figure examples. Take a look here: > >> https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: http://markmail.org/search/?q= > vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> https://vtk.org/mailman/listinfo/vtk-developers > >> > > > > > > > > -- > > William J. Schroeder, PhD > > Kitware, Inc. - Building the World's Technical Computing Software > > 28 Corporate Drive > > Clifton Park, NY 12065 > > will.schroeder at kitware.com > > http://www.kitware.com > > (518) 881-4902 > > > > -- > Unpaid intern in BillsBasement at noware dot com > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: binary.pgm Type: image/x-portable-graymap Size: 254718 bytes Desc: not available URL: From ben.boeckel at kitware.com Fri Dec 15 11:55:47 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Fri, 15 Dec 2017 11:55:47 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> Message-ID: <20171215165547.GA19577@megas.kitware.com> On Fri, Dec 15, 2017 at 11:30:27 -0500, Jean-Christophe Fillion-Robin wrote: > That said, I still like the idea of implementing lazy loading by default > and having vtkConfig to disable it. That whole lazy loading thing looks finicky to me. Personally, I'd rather just deprecate the old behavior of bringing everything into scope on import, but `vtkmodules` is a good middleground. > from vtkmodules import vtkSomeFactory > vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") This would be `from vtkmodules.vtkSomeModule import vtkSomeFactory`. The point of vtkmodules is that the top-level package *doesn't* import everything. --Ben From utkarsh.ayachit at kitware.com Fri Dec 15 12:02:37 2017 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Fri, 15 Dec 2017 12:02:37 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: <20171215165547.GA19577@megas.kitware.com> References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> <20171215165547.GA19577@megas.kitware.com> Message-ID: >> from vtkmodules import vtkSomeFactory >> vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") > > This would be `from vtkmodules.vtkSomeModule import vtkSomeFactory`. The > point of vtkmodules is that the top-level package *doesn't* import > everything. You can also: > from vtk import vtkSomeFactory > vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") Utkarsh From bill.lorensen at gmail.com Fri Dec 15 14:41:33 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Dec 2017 14:41:33 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl In-Reply-To: References: Message-ID: Wow. Good detective work. On Dec 15, 2017 11:45 AM, "Will Schroeder" wrote: > got it also! > > On Fri, Dec 15, 2017 at 11:26 AM, Bill Lorensen > wrote: > >> Great! Maybe the input file binary.pgm is in the same location? >> >> On Fri, Dec 15, 2017 at 11:12 AM, Will Schroeder >> wrote: >> > Got it! >> > >> > On Fri, Dec 15, 2017 at 10:39 AM, Bill Lorensen < >> bill.lorensen at gmail.com> >> > wrote: >> >> >> >> Folks, >> >> >> >> The VTK Book, Figure 10-14 page 403 references a script >> >> MorphComparison.tcl. >> >> >> >> Does anyone know where I can find it and the associated input image? >> >> It was never checked into the VTK repo. >> >> >> >> Thanks, >> >> >> >> Bill >> >> >> >> BTW: This is one of the last scripts we need to convert to C++ for the >> >> VTKBookFigures in the VTKExamples repo. We have already converted 100 >> >> figure examples. Take a look here: >> >> https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: http://markmail.org/search/?q= >> vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> https://vtk.org/mailman/listinfo/vtk-developers >> >> >> > >> > >> > >> > -- >> > William J. Schroeder, PhD >> > Kitware, Inc. - Building the World's Technical Computing Software >> > 28 Corporate Drive >> >> > Clifton Park, NY 12065 >> >> > will.schroeder at kitware.com >> > http://www.kitware.com >> > (518) 881-4902 >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > > Clifton Park, NY 12065 > > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kevin.lee at emiservices.com Fri Dec 15 17:10:04 2017 From: kevin.lee at emiservices.com (Kevin Lee) Date: Fri, 15 Dec 2017 14:10:04 -0800 Subject: [vtk-developers] vtkOpenGLTextActor/vtkTextActor exception error Message-ID: <001001d375f1$76789b20$6369d160$@emiservices.com> I am using VTK 8.0. When I call the New member function of either vtkOpenGLTextActor or vtkTextActor, my program throws an exception. The exception occurs in: vtkCommonExecutionModel-8.0.dll!vtkAlgorithm::SetInputDataInternal(int port, vtkDataObject *input) Line 949 I have no problems instantiating a vtkOpenGLActor object. Are there special setup requirements that must be in place before creating a text actor? -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Dec 15 17:48:03 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Dec 2017 17:48:03 -0500 Subject: [vtk-developers] Seeking MorphComparison.tcl In-Reply-To: References: Message-ID: Will, Thanks. Here is the new example: https://lorensen.github.io/VTKExamples/site/Cxx/ImageProcessing/MorphologyComparison/ Bill On Fri, Dec 15, 2017 at 2:41 PM, Bill Lorensen wrote: > Wow. Good detective work. > > On Dec 15, 2017 11:45 AM, "Will Schroeder" > wrote: >> >> got it also! >> >> On Fri, Dec 15, 2017 at 11:26 AM, Bill Lorensen >> wrote: >>> >>> Great! Maybe the input file binary.pgm is in the same location? >>> >>> On Fri, Dec 15, 2017 at 11:12 AM, Will Schroeder >>> wrote: >>> > Got it! >>> > >>> > On Fri, Dec 15, 2017 at 10:39 AM, Bill Lorensen >>> > >>> > wrote: >>> >> >>> >> Folks, >>> >> >>> >> The VTK Book, Figure 10-14 page 403 references a script >>> >> MorphComparison.tcl. >>> >> >>> >> Does anyone know where I can find it and the associated input image? >>> >> It was never checked into the VTK repo. >>> >> >>> >> Thanks, >>> >> >>> >> Bill >>> >> >>> >> BTW: This is one of the last scripts we need to convert to C++ for the >>> >> VTKBookFigures in the VTKExamples repo. We have already converted 100 >>> >> figure examples. Take a look here: >>> >> https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Search the list archives at: >>> >> http://markmail.org/search/?q=vtk-developers >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> https://vtk.org/mailman/listinfo/vtk-developers >>> >> >>> > >>> > >>> > >>> > -- >>> > William J. Schroeder, PhD >>> > Kitware, Inc. - Building the World's Technical Computing Software >>> > 28 Corporate Drive >>> > Clifton Park, NY 12065 >>> > will.schroeder at kitware.com >>> > http://www.kitware.com >>> > (518) 881-4902 >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >> >> >> >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 -- Unpaid intern in BillsBasement at noware dot com From ken.martin at kitware.com Mon Dec 18 10:31:50 2017 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 18 Dec 2017 10:31:50 -0500 Subject: [vtk-developers] Python Changes Message-ID: Maybe someone changed something in the python wrapping/build resulting in these warnings? In file included from /Users/builder/external/VTK-clang-rel-x86_64/Wrapping/Python/vtkPOutlineFilterInternalsPython.cxx:12: [CTest: warning matched] /Users/builder/external/VTK/Filters/Parallel/vtkPOutlineFilterInternals.h:48:11: warning: definition of implicit copy constructor for 'vtkPOutlineFilterInternals' is deprecated because it has a user-declared destructor [-Wdeprecated] virtual ~vtkPOutlineFilterInternals(); ^ [CTest: warning matched] /Users/builder/external/VTK-clang-rel-x86_64/Wrapping/Python/vtkPOutlineFilterInternalsPython.cxx:139:42: note: implicit copy constructor for 'vtkPOutlineFilterInternals' first required here vtkPOutlineFilterInternals *op = new vtkPOutlineFilterInternals(*temp0); ^ [CTest: warning suppressed] 1 warning generated. In file included from /Users/builder/external/VTK-clang-rel-x86_64/Wrapping/Python/vtkOpenGLHelperPython.cxx:11: [CTest: warning matched] /Users/builder/external/VTK/Rendering/OpenGL2/vtkOpenGLHelper.h:43:3: warning: definition of implicit copy constructor for 'vtkOpenGLHelper' is deprecated because it has a user-declared destructor [-Wdeprecated] ~vtkOpenGLHelper(); ^ [CTest: warning matched] /Users/builder/external/VTK-clang-rel-x86_64/Wrapping/Python/vtkOpenGLHelperPython.cxx:82:31: note: implicit copy constructor for 'vtkOpenGLHelper' first required here vtkOpenGLHelper *op = new vtkOpenGLHelper(*temp0); ^ [CTest: warning suppressed] 1 warning generated. -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From allison.vacanti at kitware.com Mon Dec 18 10:35:33 2017 From: allison.vacanti at kitware.com (Allie Vacanti) Date: Mon, 18 Dec 2017 10:35:33 -0500 Subject: [vtk-developers] vtkOpenGLTextActor/vtkTextActor exception error In-Reply-To: <001001d375f1$76789b20$6369d160$@emiservices.com> References: <001001d375f1$76789b20$6369d160$@emiservices.com> Message-ID: The only bit of extra setup that vtkTextActor requires is that the vtkRenderingFreeType module needs to be linked, but it should print out something like "Failed getting the TextRenderer instance!" if that's not done, and vtkAlgorithm::SetInputDataInternal shouldn't be a part of the stack. What does the exception say? Can you provide a more detailed backtrace? On Fri, Dec 15, 2017 at 5:10 PM, Kevin Lee wrote: > I am using VTK 8.0. When I call the New member function of either > vtkOpenGLTextActor or vtkTextActor, my program throws an exception. The > exception occurs in: > > vtkCommonExecutionModel-8.0.dll!vtkAlgorithm::SetInputDataInternal(int > port, vtkDataObject *input) Line 949 > > > > I have no problems instantiating a vtkOpenGLActor object. Are there > special setup requirements that must be in place before creating a text > actor? > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Mon Dec 18 11:15:26 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Mon, 18 Dec 2017 11:15:26 -0500 Subject: [vtk-developers] Python Changes In-Reply-To: References: Message-ID: <20171218161526.GB27521@megas.kitware.com> On Mon, Dec 18, 2017 at 10:31:50 -0500, Ken Martin wrote: > Maybe someone changed something in the python wrapping/build resulting in > these warnings? Yeah, wrappers are now trying to wrap "everything". Though currently there is no real indication of what is public API and private API, so private APIs may get wrapped up unintentionally. When I removed EXCLUDE_WRAP, I hid the headers which the wrappers actively failed on. In order to hide these headers (which seem to be private), you can wrap them in: #ifndef __VTK_WRAP__ #endif If they also have headers which don't work from the wrappers (not true if they're working now, but for future cases), also add: #ifndef VTK_WRAPPING_CXX #endif to hide it from the "no-op" wrapper source as well. These will disappear with the new module system since these headers are private and shouldn't be looked at by wrapper tools at all. --Ben From allison.vacanti at kitware.com Mon Dec 18 12:21:12 2017 From: allison.vacanti at kitware.com (Allie Vacanti) Date: Mon, 18 Dec 2017 12:21:12 -0500 Subject: [vtk-developers] vtkOpenGLTextActor/vtkTextActor exception error In-Reply-To: <006901d3781c$6d20f450$4762dcf0$@emiservices.com> References: <001001d375f1$76789b20$6369d160$@emiservices.com> <006901d3781c$6d20f450$4762dcf0$@emiservices.com> Message-ID: Hi Kevin, I'm cc'ing the list with my reply in case anyone else is having this issue. It looks like the object factory is not being set up properly, since vtkRenderingOpenGL2 is linked (otherwise you wouldn't enter vtkOpenGLTextActor in the stack), but vtkTexture::New() is returning NULL instead of a new vtkOpenGLTexture pointer (which is triggering the crash inside vtkOpenGLTextActor::New(). Is this project using CMake? If so, the object factory stuff should be take care of by default. If not using CMake, you'll need to add a bit of code to your application to set things up. See the bottom of https://www.vtk.org/Wiki/VTK/Build_System_Migration, I suspect that adding: #include VTK_MODULE_INIT(vtkRenderingOpenGL2); VTK_MODULE_INIT(vtkRenderingFreeType); somewhere in your application will fix it. You'll need to add one of these VTK_MODULE_INIT calls for every linked VTK library. HTH, Allie On Mon, Dec 18, 2017 at 11:22 AM, Kevin Lee wrote: > I am linking vktRenderingFreeType-8.0.dll > > > > The exception dialog window that VS2015 display when the exception occurs > state: Exception thrown: read access violation. This was nullptr. > > > > The call stack shows the following trace: > > > > vtkCommonExecutionModel-8.0.dll!vtkAlgorithm::SetInputDataInternal(int > port, vtkDataObject * input) Line 949 > > vtkCommonExecutionModel-8.0.dll!vtkImageAlgorithm::SetInputData(int > index, vtkDataObject * input) Line 406 > > vtkCommonExecutionModel-8.0.dll!vtkImageAlgorithm::SetInputData(vtkDataObject > * input) Line 400 > > vtkRenderingCore-8.0.dll!vtkTextActor::vtkTextActor() Line 75 > > vtkRenderingOpenGL2-8.0.dll!vtkOpenGLTextActor::vtkOpenGLTextActor() Line > 56 > > vtkRenderingOpenGL2-8.0.dll!vtkOpenGLTextActor::New() Line 56 > > MultiPlotDisplay.exe!vtkSmartPointer::New() Line 137 > > MultiPlotDisplay.exe!CTextActor::CTextActor() Line 17 > > > > > > This is line 17 of my code that is failing. It?s the first line in my > class constructor: > > > > m_pTextActor = vtkSmartPointer::New(); > > > > > > This is how I declare the smart pointer in my class definition: > > > > vtkSmartPointer m_pTextActor; > > > > > > I appreciate the help. > > > > > > *From:* Allie Vacanti [mailto:allison.vacanti at kitware.com] > *Sent:* Monday, December 18, 2017 7:36 AM > *To:* Kevin Lee > *Cc:* VTK Developers > *Subject:* Re: [vtk-developers] vtkOpenGLTextActor/vtkTextActor exception > error > > > > The only bit of extra setup that vtkTextActor requires is that the > vtkRenderingFreeType module needs to be linked, but it should print out > something like "Failed getting the TextRenderer instance!" if that's not > done, and vtkAlgorithm::SetInputDataInternal shouldn't be a part of the > stack. > > What does the exception say? Can you provide a more detailed backtrace? > > > > On Fri, Dec 15, 2017 at 5:10 PM, Kevin Lee > wrote: > > I am using VTK 8.0. When I call the New member function of either > vtkOpenGLTextActor or vtkTextActor, my program throws an exception. The > exception occurs in: > > vtkCommonExecutionModel-8.0.dll!vtkAlgorithm::SetInputDataInternal(int > port, vtkDataObject *input) Line 949 > > > > I have no problems instantiating a vtkOpenGLActor object. Are there > special setup requirements that must be in place before creating a text > actor? > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Mon Dec 18 13:09:15 2017 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 18 Dec 2017 13:09:15 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> <20171215165547.GA19577@megas.kitware.com> Message-ID: Hi Ben, Here is an updated version of the comment I originally posted on MR 3674 . Short version: Having the dependency graph of VTK kits available in python is needed to generate cross platform distributable wheels. Long version: The introduction vtkmodules enables granular import. In a install or build tree where the PATH, LD_LIBRARY_PATH, ... are set or if RPATH is available, importing any specific module will work because the dynamic library loader will find the correct dependencies and load them. (e.g ParaView, Slicer, ...) To support generation of distributable python wheels and avoid user to compile VTK each time they want to use it, a given compiled python module can NOT depends on shared libraries and expect the library loader to find them unless: * the dependent libraries are system ones * the compiled python module explicitly loads them in order What does this mean ? * We need to support building any given kit as standalone kit without any dependencies beside of system libraries and symbols from other kit * We need to make sure dependent kit are explicitly imported within python in the right order Hence the need to have the dependency graph available from python. There is also other challenges like: * sharing symbol across python modules (e.g GlobalTimeStamp need to be the same for all modules). To address this, we use Python Capsule C/API in ITK. For these reasons, we need to have the dependency graph available. And once, we have the dependency graph ... supporting lazy loading wouldn't be too much work. In the future, support for Native libraries in wheels would alleviate some of these issues. In the mean time, it is a necessary evil: * https://github.com/jcfr/wheel-builders/blob/058287254a139908578501eb70b602e33202720a/pynativelib-proposal.rst * https://github.com/pypa/wheel-builders/pull/2 On Fri, Dec 15, 2017 at 12:02 PM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > >> from vtkmodules import vtkSomeFactory > >> vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") > > > > This would be `from vtkmodules.vtkSomeModule import vtkSomeFactory`. The > > point of vtkmodules is that the top-level package *doesn't* import > > everything. > > You can also: > > from vtk import vtkSomeFactory > > vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") > > Utkarsh > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Mon Dec 18 15:56:36 2017 From: berk.geveci at kitware.com (Berk Geveci) Date: Mon, 18 Dec 2017 15:56:36 -0500 Subject: [vtk-developers] Speeding up `import vtk` In-Reply-To: References: <20170919142943.GA28183@megas.kitware.com> <4d647cd6-d068-5a1c-fd92-90e96535fdbe@aero.iitb.ac.in> <20171212201809.GA20736@megas.kitware.com> <20171215165547.GA19577@megas.kitware.com> Message-ID: Are we talking about modules or kits? The two are not interchangeable in VTK. On Mon, Dec 18, 2017 at 1:09 PM, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Ben, > > Here is an updated version of the comment I originally posted on MR 3674 > . > > > Short version: > > Having the dependency graph of VTK kits available in python is needed to > generate cross platform distributable wheels. > > > Long version: > > The introduction vtkmodules enables granular import. > > In a install or build tree where the PATH, LD_LIBRARY_PATH, ... are set or > if RPATH is available, importing any specific module will work because the > dynamic library loader will find the correct dependencies and load them. > (e.g ParaView, Slicer, ...) > > To support generation of distributable python wheels and avoid user to > compile VTK each time they want to use it, a given compiled python module > can NOT depends on shared libraries and expect the library loader to find > them unless: > > * the dependent libraries are system ones > * the compiled python module explicitly loads them in order > > > What does this mean ? > > * We need to support building any given kit as standalone kit without any > dependencies beside of system libraries and symbols from other kit > * We need to make sure dependent kit are explicitly imported within python > in the right order > > > Hence the need to have the dependency graph available from python. > > There is also other challenges like: > > * sharing symbol across python modules (e.g GlobalTimeStamp need to be the > same for all modules). To address this, we use Python Capsule C/API in ITK. > > > For these reasons, we need to have the dependency graph available. > > And once, we have the dependency graph ... supporting lazy loading > wouldn't be too much work. > > > In the future, support for Native libraries in wheels would alleviate some > of these issues. In the mean time, it is a necessary evil: > > * https://github.com/jcfr/wheel-builders/blob/ > 058287254a139908578501eb70b602e33202720a/pynativelib-proposal.rst > * https://github.com/pypa/wheel-builders/pull/2 > > > > > On Fri, Dec 15, 2017 at 12:02 PM, Utkarsh Ayachit < > utkarsh.ayachit at kitware.com> wrote: > >> >> from vtkmodules import vtkSomeFactory >> >> vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") >> > >> > This would be `from vtkmodules.vtkSomeModule import vtkSomeFactory`. The >> > point of vtkmodules is that the top-level package *doesn't* import >> > everything. >> >> You can also: >> > from vtk import vtkSomeFactory >> > vtkSomeFactory.SetDefaultClass("vtkNameOfSomeClass") >> >> Utkarsh >> > > > > -- > +1 919 869 8849 <(919)%20869-8849> > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon Dec 18 17:40:56 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 18 Dec 2017 17:40:56 -0500 Subject: [vtk-developers] ANN: VTK Book Figures completed Message-ID: Folks, Andrew Maclean and I have successfully revived 112 examples from the VTK Book. This covers all figures that were generated by VTK code. A few figures were generated with "mystery" codes and are not included. Most of the figures were created by Tcl scripts and 30 C++ programs. Andrew also converted many of the figure examples to Python. All of the figure examples are part of the VTKExamples repo and can be viewed here: https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ Each Book example has an image that is regression tested every night. Also, a link to the original code is provided. Most of the scripts were deleted from the repo many years ago. The VTKExamples https://lorensen.github.io/VTKExamples/site/ now contains: C++ examples: 948 CSharp examples: 121 Python examples: 161 Java examples: 18 Total examples: 1248 This effort means that the "once lost" figure examples will live on. Old Guys Rule! Bill From pieper at isomics.com Mon Dec 18 17:42:38 2017 From: pieper at isomics.com (Steve Pieper) Date: Mon, 18 Dec 2017 17:42:38 -0500 Subject: [vtk-developers] ANN: VTK Book Figures completed In-Reply-To: References: Message-ID: Go Bill! On Mon, Dec 18, 2017 at 5:40 PM, Bill Lorensen wrote: > Folks, > > Andrew Maclean and I have successfully revived 112 examples from the > VTK Book. This covers all figures that were generated by VTK code. A > few figures were generated with "mystery" codes and are not included. > > Most of the figures were created by Tcl scripts and 30 C++ programs. > Andrew also converted many of the figure examples to Python. > > All of the figure examples are part of the VTKExamples repo and can be > viewed here: > https://lorensen.github.io/VTKExamples/site/VTKBookFigures/ > > Each Book example has an image that is regression tested every night. > Also, a link to the original code is provided. Most of the scripts > were deleted from the repo many years ago. > > The VTKExamples https://lorensen.github.io/VTKExamples/site/ now contains: > > C++ examples: 948 > CSharp examples: 121 > Python examples: 161 > Java examples: 18 > Total examples: 1248 > > This effort means that the "once lost" figure examples will live on. > > Old Guys Rule! > > Bill > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Mon Dec 18 18:47:03 2017 From: nztoddler at yahoo.com (Todd) Date: Tue, 19 Dec 2017 12:47:03 +1300 Subject: [vtk-developers] ANN: VTK Book Figures completed In-Reply-To: Message-ID: <3e6d7cb0-4eca-4dbf-9ee7-dc49e7f16c92@email.android.com> An HTML attachment was scrubbed... URL: From drouin.simon at gmail.com Tue Dec 19 23:32:58 2017 From: drouin.simon at gmail.com (Simon Drouin) Date: Tue, 19 Dec 2017 23:32:58 -0500 Subject: [vtk-developers] Multiple sets of texture coordinates with OpenGL2 backend Message-ID: Is there any way to have multiple sets of texture coordinates on a vtkPolyData with the OpenGL2 backend? In the legacy OpenGL backend, it used to be possible to have multiple sets of texture coordinates on a vtkPolyData by adding multiple arrays, each containing a set of texture coordinates, to the point data of the polydata, by doing something like this: polyData->GetPointData()->AddArray( tcoordArray ) And then associating the array to one of the textures with: polyDataMapper->MapDataArrayToMultiTextureAttribute( textureUnit, arrayName ); This behavior is not implemented in the OpenGL2 backend. The mapper considers only the array returned by polyData->GetPointData()->GetTCoord() as texture coordinates and uses it for all textures. Initially, I thought I could do the job by modifying the shader program used to render the polydata, but the mapper doesn't seem to pack the extra arrays from the point data into the VBO, so the data is not there for the shader. Any solution? Thanks in advance. s. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Wed Dec 20 01:45:51 2017 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 20 Dec 2017 17:45:51 +1100 Subject: [vtk-developers] Question regarding Python imports. Message-ID: What do people using Python mostly do/prefer? 1) import vtk 2) from vtk.xx import yy 3) from vtk import yy In 2) we are actually specifying the module where yy resides. In PyCharm: For the case of 1) when we declare something like z = vtk.yy we get a cannot find reference in __init__.py() warning For case of 2) or 3) we get an unresolved reference for yy in the from statement. I'm trying to speed up vtk in Windows! Regards Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From elvis.stansvik at orexplore.com Wed Dec 20 03:24:36 2017 From: elvis.stansvik at orexplore.com (Elvis Stansvik) Date: Wed, 20 Dec 2017 09:24:36 +0100 Subject: [vtk-developers] Question regarding Python imports. In-Reply-To: References: Message-ID: 2017-12-20 7:45 GMT+01:00 Andrew Maclean : > What do people using Python mostly do/prefer? > 1) import vtk > 2) from vtk.xx import yy > 3) from vtk import yy I generally use 3, but 1 for quick one-off scripts (for the convenience). I dislike 1 because of the resulting repetitive "vtk.vtk...." (e.g. vtk.vtkPolyDataMapper). I prefer 3 because explicitly importing the symbols I use somehow feels more cleanly (no real motivation for that though). I've never used 2. > > In 2) we are actually specifying the module where yy resides. > > In PyCharm: > For the case of 1) when we declare something like z = vtk.yy we get a > cannot find reference in __init__.py() warning > For case of 2) or 3) we get an unresolved reference for yy in the from > statement. It was some time since I used PyCharm for VTK stuff, but I seem to remember these problems. Would be great if what you guys come up with could work well in PyCharm of course, since it's my goto IDE when writing non-trivial things (for small stuff I use Vim). Elvis > > I'm trying to speed up vtk in Windows! > > Regards > Andrew > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > From ken.martin at kitware.com Wed Dec 20 08:53:56 2017 From: ken.martin at kitware.com (Ken Martin) Date: Wed, 20 Dec 2017 08:53:56 -0500 Subject: [vtk-developers] Multiple sets of texture coordinates with OpenGL2 backend In-Reply-To: References: Message-ID: Have you tried? /** * Select a data array from the point/cell data * and map it to a generic vertex attribute. * vertexAttributeName is the name of the vertex attribute. * dataArrayName is the name of the data array. * fieldAssociation indicates when the data array is a point data array or * cell data array (vtkDataObject::FIELD_ASSOCIATION_POINTS or * (vtkDataObject::FIELD_ASSOCIATION_CELLS). * componentno indicates which component from the data array must be passed as * the attribute. If -1, then all components are passed. */ virtual void MapDataArrayToVertexAttribute( const char* vertexAttributeName, const char* dataArrayName, int fieldAssociation, int componentno = -1); You will need to do something with that attribute in the shader code. I believe only point association is supported. All textures will automatically get bound in order with names starting with texture_0 and going up. On Tue, Dec 19, 2017 at 11:32 PM, Simon Drouin wrote: > Is there any way to have multiple sets of texture coordinates on a > vtkPolyData with the OpenGL2 backend? > > In the legacy OpenGL backend, it used to be possible to have multiple sets > of texture coordinates on a vtkPolyData by adding multiple arrays, each > containing a set of texture coordinates, to the point data of the polydata, > by doing something like this: > > polyData->GetPointData()->AddArray( tcoordArray ) > > And then associating the array to one of the textures with: > > polyDataMapper->MapDataArrayToMultiTextureAttribute( textureUnit, > arrayName ); > > This behavior is not implemented in the OpenGL2 backend. The mapper > considers only the array returned by polyData->GetPointData()->GetTCoord() > as texture coordinates and uses it for all textures. Initially, I thought I > could do the job by modifying the shader program used to render the > polydata, but the mapper doesn't seem to pack the extra arrays from the > point data into the VBO, so the data is not there for the shader. > > Any solution? > > Thanks in advance. > > s. > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Thu Dec 21 12:20:32 2017 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 21 Dec 2017 12:20:32 -0500 Subject: [vtk-developers] Build errors Message-ID: If either of these are yours please fix them as they are build errors (which is a bad thing) Thanks! In file included from /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.cxx:59:0: /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.h:118:10: error: 'std::string' has not been declared std::string nameOfPointData); VTK/Rendering/VolumeOpenGL2/vtkOpenGLGPUVolumeRayCastMapper.cxx:3621 :7: error: 'to_string' is not a member of 'std' -- Ken Martin PhD Distinguished Engineer Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From brad.king at kitware.com Thu Dec 21 14:10:06 2017 From: brad.king at kitware.com (Brad King) Date: Thu, 21 Dec 2017 14:10:06 -0500 Subject: [vtk-developers] Build errors In-Reply-To: References: Message-ID: On 12/21/2017 12:20 PM, Ken Martin wrote: > If either of these are yours please fix them as they are build errors > (which is a bad thing) > > In file included from /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.cxx:59:0: > /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.h:118:10: error: 'std::string' has not been declared > std::string nameOfPointData); These weren't mine but they occurred on a build I maintain so I fixed them this morning: https://gitlab.kitware.com/vtk/vtk/merge_requests/3729 I haven't touched the `to_string` errors though (which also aren't mine). -Brad From joachim.pouderoux at kitware.com Thu Dec 21 14:54:18 2017 From: joachim.pouderoux at kitware.com (Joachim Pouderoux) Date: Thu, 21 Dec 2017 15:54:18 -0400 Subject: [vtk-developers] Build errors In-Reply-To: References: Message-ID: Ken, Sorry about that. I will take care of the to_string issue. This function is c++11 and declared in which is included. So it looks like the android compiler used is not totally compliant. Anyway, I will replace that. Best, *Joachim Pouderoux*, PhD *Technical Expert - Scientific Computing Team* *Kitware SAS * 2017-12-21 13:20 GMT-04:00 Ken Martin : > > If either of these are yours please fix them as they are build errors > (which is a bad thing) > > Thanks! > > In file included from /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.cxx:59:0: > /home/kitware/Dashboards/My Tests/VTK/Filters/MomentInvariants/vtkMomentsHelper.h:118:10: error: 'std::string' has not been declared > std::string nameOfPointData); > > > > VTK/Rendering/VolumeOpenGL2/vtkOpenGLGPUVolumeRayCastMapper.cxx:3621 :7: error: 'to_string' is not a member of 'std' > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jhlegarreta at vicomtech.org Fri Dec 22 06:23:19 2017 From: jhlegarreta at vicomtech.org (Jon Haitz Legarreta) Date: Fri, 22 Dec 2017 12:23:19 +0100 Subject: [vtk-developers] ANN: VTK Book Figures completed In-Reply-To: <3e6d7cb0-4eca-4dbf-9ee7-dc49e7f16c92@email.android.com> References: <3e6d7cb0-4eca-4dbf-9ee7-dc49e7f16c92@email.android.com> Message-ID: Simply awesome. Priceless work. This is another one of the kinds of things that make VTK and its community great. Thanks Bill, JON HAITZ -- On 19 December 2017 at 00:47, Todd via vtk-developers < vtk-developers at vtk.org> wrote: > That's excellent! > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dave.demarle at kitware.com Fri Dec 22 11:56:51 2017 From: dave.demarle at kitware.com (David E DeMarle) Date: Fri, 22 Dec 2017 11:56:51 -0500 Subject: [vtk-developers] announce : VTK 8.1.0 Message-ID: Hi folks, VTK 8.1.0 is tagged and up on the download page. Read all about it here: https://blog.kitware.com/vtk-8-1-0/ happy holidays everyone! David E DeMarle Kitware, Inc. Principal Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Sat Dec 23 08:30:22 2017 From: will.schroeder at kitware.com (Will Schroeder) Date: Sat, 23 Dec 2017 08:30:22 -0500 Subject: [vtk-developers] Discrete contouring classes Message-ID: FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the vtkDiscreteMarchingCubes class. This is used to generate contours for label masks (as you would find in segmentation). The key here is that the labels are non-continuous (i.e., scalar field is not smooth) so the regular edge interpolation of something like marching cubes doesn't work. Long story short, this class interpolates on the mid-edge point between regions, and it generates different regions (i.e., meshes) for each label. This class and approach is woefully underappreciated and underused. I am just adding flying edges versions (2D and 3D) of this functionality (MR 3739). These are of course much faster and scalable across multiple cores. They also produce slightly different results. Principally they do not merge coincident points belonging to different regions (since flying edges does not use a point locator) -- this is both good and bad depending on the application. Also normals are generated by the flying edges algorithm, not by vtkDiscreteMarchingCubes. See the docs for more info. Best, W -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Sat Dec 23 08:35:24 2017 From: will.schroeder at kitware.com (Will Schroeder) Date: Sat, 23 Dec 2017 08:35:24 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: FYI here is an example of discrete marching cubes at work. From Bill: Here is the SPLBrainAtlas; > https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary > > The two-paned images show Discrete on left, Cube's Model (also > undersold) on right. STL files created using discrete followed by > non-manifold joint smoothing. > On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder wrote: > FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the > vtkDiscreteMarchingCubes class. This is used to generate contours for label > masks (as you would find in segmentation). The key here is that the labels > are non-continuous (i.e., scalar field is not smooth) so the regular edge > interpolation of something like marching cubes doesn't work. Long story > short, this class interpolates on the mid-edge point between regions, and > it generates different regions (i.e., meshes) for each label. > > This class and approach is woefully underappreciated and underused. > > I am just adding flying edges versions (2D and 3D) of this functionality > (MR 3739). These are of course much faster and scalable across multiple > cores. They also produce slightly different results. Principally they do > not merge coincident points belonging to different regions (since flying > edges does not use a point locator) -- this is both good and bad depending > on the application. Also normals are generated by the flying edges > algorithm, not by vtkDiscreteMarchingCubes. > > See the docs for more info. > > Best, > W > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Sat Dec 23 08:41:21 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 23 Dec 2017 08:41:21 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: Here are VTKExamples for discrete and cubes model generation: https://lorensen.github.io/VTKExamples/site/Cxx/Medical/GenerateModelsFromLabels/ https://lorensen.github.io/VTKExamples/site/Cxx/Medical/GenerateCubesFromLabels/ On Sat, Dec 23, 2017 at 8:35 AM, Will Schroeder wrote: > FYI here is an example of discrete marching cubes at work. From Bill: > >> Here is the SPLBrainAtlas; >> https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary >> >> The two-paned images show Discrete on left, Cube's Model (also >> undersold) on right. STL files created using discrete followed by >> non-manifold joint smoothing. > > > On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder > wrote: >> >> FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the >> vtkDiscreteMarchingCubes class. This is used to generate contours for label >> masks (as you would find in segmentation). The key here is that the labels >> are non-continuous (i.e., scalar field is not smooth) so the regular edge >> interpolation of something like marching cubes doesn't work. Long story >> short, this class interpolates on the mid-edge point between regions, and it >> generates different regions (i.e., meshes) for each label. >> >> This class and approach is woefully underappreciated and underused. >> >> I am just adding flying edges versions (2D and 3D) of this functionality >> (MR 3739). These are of course much faster and scalable across multiple >> cores. They also produce slightly different results. Principally they do not >> merge coincident points belonging to different regions (since flying edges >> does not use a point locator) -- this is both good and bad depending on the >> application. Also normals are generated by the flying edges algorithm, not >> by vtkDiscreteMarchingCubes. >> >> See the docs for more info. >> >> Best, >> W >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 > > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From lasso at queensu.ca Sat Dec 23 10:28:29 2017 From: lasso at queensu.ca (Andras Lasso) Date: Sat, 23 Dec 2017 15:28:29 +0000 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: Hi Will and Bill, Surface generation from binary labelmap is an important task for us in 3D Slicer, to display segmentation results in 3D while it is being edited in 2D, We are very interested in any potential improvements. Currently, we use discrete marching cubes and sinc smoothing, which gives good results, but sometimes it can be quite slow (especially the smoothing step). We tried cube models but surface normals always pointed to x/y/z direction instead of actual surface normal direction, so it was very hard to see 3D shapes. This flat look is visible in your examples, too: https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/white_matter_of_left_cerebral_hemisphere.png. We use discrete marching cubes, but as far as I remember, we did not see huge differences between regular and discrete marching cubes. Is there a study or examples that compares them (visual appearance, accuracy, computation time, etc.)? Is there a solution that provides smooth surfaces (that would not require further smoothing step to remove staircase artifacts)? We also plan to evaluate how well we can visualize binary labelmaps in 3D using the new multi-volume-rendering feature that is being integrated into VTK now. Andras From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of Will Schroeder Sent: Saturday, December 23, 2017 8:35 AM To: vtk-developers Subject: Re: [vtk-developers] Discrete contouring classes FYI here is an example of discrete marching cubes at work. From Bill: Here is the SPLBrainAtlas; https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary The two-paned images show Discrete on left, Cube's Model (also undersold) on right. STL files created using discrete followed by non-manifold joint smoothing. On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder > wrote: FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the vtkDiscreteMarchingCubes class. This is used to generate contours for label masks (as you would find in segmentation). The key here is that the labels are non-continuous (i.e., scalar field is not smooth) so the regular edge interpolation of something like marching cubes doesn't work. Long story short, this class interpolates on the mid-edge point between regions, and it generates different regions (i.e., meshes) for each label. This class and approach is woefully underappreciated and underused. I am just adding flying edges versions (2D and 3D) of this functionality (MR 3739). These are of course much faster and scalable across multiple cores. They also produce slightly different results. Principally they do not merge coincident points belonging to different regions (since flying edges does not use a point locator) -- this is both good and bad depending on the application. Also normals are generated by the flying edges algorithm, not by vtkDiscreteMarchingCubes. See the docs for more info. Best, W -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Sat Dec 23 10:45:08 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 23 Dec 2017 10:45:08 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: I'll take a look to fix normals on cube models. On Sat, Dec 23, 2017 at 10:28 AM, Andras Lasso wrote: > Hi Will and Bill, > > > > Surface generation from binary labelmap is an important task for us in 3D > Slicer, to display segmentation results in 3D while it is being edited in > 2D, We are very interested in any potential improvements. > > > > Currently, we use discrete marching cubes and sinc smoothing, which gives > good results, but sometimes it can be quite slow (especially the smoothing > step). > > > > We tried cube models but surface normals always pointed to x/y/z direction > instead of actual surface normal direction, so it was very hard to see 3D > shapes. This flat look is visible in your examples, too: > https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/white_matter_of_left_cerebral_hemisphere.png. > > > > We use discrete marching cubes, but as far as I remember, we did not see > huge differences between regular and discrete marching cubes. Is there a > study or examples that compares them (visual appearance, accuracy, > computation time, etc.)? Is there a solution that provides smooth surfaces > (that would not require further smoothing step to remove staircase > artifacts)? > > > > We also plan to evaluate how well we can visualize binary labelmaps in 3D > using the new multi-volume-rendering feature that is being integrated into > VTK now. > > > > Andras > > > > From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of > Will Schroeder > Sent: Saturday, December 23, 2017 8:35 AM > To: vtk-developers > Subject: Re: [vtk-developers] Discrete contouring classes > > > > FYI here is an example of discrete marching cubes at work. From Bill: > > > > Here is the SPLBrainAtlas; > https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary > > The two-paned images show Discrete on left, Cube's Model (also > undersold) on right. STL files created using discrete followed by > non-manifold joint smoothing. > > > > On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder > wrote: > > FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the > vtkDiscreteMarchingCubes class. This is used to generate contours for label > masks (as you would find in segmentation). The key here is that the labels > are non-continuous (i.e., scalar field is not smooth) so the regular edge > interpolation of something like marching cubes doesn't work. Long story > short, this class interpolates on the mid-edge point between regions, and it > generates different regions (i.e., meshes) for each label. > > > > This class and approach is woefully underappreciated and underused. > > > > I am just adding flying edges versions (2D and 3D) of this functionality (MR > 3739). These are of course much faster and scalable across multiple cores. > They also produce slightly different results. Principally they do not merge > coincident points belonging to different regions (since flying edges does > not use a point locator) -- this is both good and bad depending on the > application. Also normals are generated by the flying edges algorithm, not > by vtkDiscreteMarchingCubes. > > > > See the docs for more info. > > > > Best, > > W > > > > -- > > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > > > > > -- > > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://vtk.org/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Sat Dec 23 11:53:47 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 23 Dec 2017 11:53:47 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: There are no normals in the cube files I generate. I do color the edges, so on large poly models, the dark edges may be causing the problem. For example, see this lower poly count model: https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/right_putamen.png On Sat, Dec 23, 2017 at 10:45 AM, Bill Lorensen wrote: > I'll take a look to fix normals on cube models. > > On Sat, Dec 23, 2017 at 10:28 AM, Andras Lasso wrote: >> Hi Will and Bill, >> >> >> >> Surface generation from binary labelmap is an important task for us in 3D >> Slicer, to display segmentation results in 3D while it is being edited in >> 2D, We are very interested in any potential improvements. >> >> >> >> Currently, we use discrete marching cubes and sinc smoothing, which gives >> good results, but sometimes it can be quite slow (especially the smoothing >> step). >> >> >> >> We tried cube models but surface normals always pointed to x/y/z direction >> instead of actual surface normal direction, so it was very hard to see 3D >> shapes. This flat look is visible in your examples, too: >> https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/white_matter_of_left_cerebral_hemisphere.png. >> >> >> >> We use discrete marching cubes, but as far as I remember, we did not see >> huge differences between regular and discrete marching cubes. Is there a >> study or examples that compares them (visual appearance, accuracy, >> computation time, etc.)? Is there a solution that provides smooth surfaces >> (that would not require further smoothing step to remove staircase >> artifacts)? >> >> >> >> We also plan to evaluate how well we can visualize binary labelmaps in 3D >> using the new multi-volume-rendering feature that is being integrated into >> VTK now. >> >> >> >> Andras >> >> >> >> From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of >> Will Schroeder >> Sent: Saturday, December 23, 2017 8:35 AM >> To: vtk-developers >> Subject: Re: [vtk-developers] Discrete contouring classes >> >> >> >> FYI here is an example of discrete marching cubes at work. From Bill: >> >> >> >> Here is the SPLBrainAtlas; >> https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary >> >> The two-paned images show Discrete on left, Cube's Model (also >> undersold) on right. STL files created using discrete followed by >> non-manifold joint smoothing. >> >> >> >> On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder >> wrote: >> >> FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the >> vtkDiscreteMarchingCubes class. This is used to generate contours for label >> masks (as you would find in segmentation). The key here is that the labels >> are non-continuous (i.e., scalar field is not smooth) so the regular edge >> interpolation of something like marching cubes doesn't work. Long story >> short, this class interpolates on the mid-edge point between regions, and it >> generates different regions (i.e., meshes) for each label. >> >> >> >> This class and approach is woefully underappreciated and underused. >> >> >> >> I am just adding flying edges versions (2D and 3D) of this functionality (MR >> 3739). These are of course much faster and scalable across multiple cores. >> They also produce slightly different results. Principally they do not merge >> coincident points belonging to different regions (since flying edges does >> not use a point locator) -- this is both good and bad depending on the >> application. Also normals are generated by the flying edges algorithm, not >> by vtkDiscreteMarchingCubes. >> >> >> >> See the docs for more info. >> >> >> >> Best, >> >> W >> >> >> >> -- >> >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> >> >> >> >> -- >> >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://vtk.org/mailman/listinfo/vtk-developers >> >> > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Sat Dec 23 19:17:40 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 23 Dec 2017 19:17:40 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: I brightened the edges rather than darkening them. See https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/white_matter_of_left_cerebral_hemisphere.png On Sat, Dec 23, 2017 at 11:53 AM, Bill Lorensen wrote: > There are no normals in the cube files I generate. I do color the > edges, so on large poly models, the dark edges may be causing the > problem. > > For example, see this lower poly count model: > https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/right_putamen.png > > On Sat, Dec 23, 2017 at 10:45 AM, Bill Lorensen wrote: >> I'll take a look to fix normals on cube models. >> >> On Sat, Dec 23, 2017 at 10:28 AM, Andras Lasso wrote: >>> Hi Will and Bill, >>> >>> >>> >>> Surface generation from binary labelmap is an important task for us in 3D >>> Slicer, to display segmentation results in 3D while it is being edited in >>> 2D, We are very interested in any potential improvements. >>> >>> >>> >>> Currently, we use discrete marching cubes and sinc smoothing, which gives >>> good results, but sometimes it can be quite slow (especially the smoothing >>> step). >>> >>> >>> >>> We tried cube models but surface normals always pointed to x/y/z direction >>> instead of actual surface normal direction, so it was very hard to see 3D >>> shapes. This flat look is visible in your examples, too: >>> https://raw.githubusercontent.com/lorensen/SPLBrainAtlas/master/Models/Screenshot/white_matter_of_left_cerebral_hemisphere.png. >>> >>> >>> >>> We use discrete marching cubes, but as far as I remember, we did not see >>> huge differences between regular and discrete marching cubes. Is there a >>> study or examples that compares them (visual appearance, accuracy, >>> computation time, etc.)? Is there a solution that provides smooth surfaces >>> (that would not require further smoothing step to remove staircase >>> artifacts)? >>> >>> >>> >>> We also plan to evaluate how well we can visualize binary labelmaps in 3D >>> using the new multi-volume-rendering feature that is being integrated into >>> VTK now. >>> >>> >>> >>> Andras >>> >>> >>> >>> From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of >>> Will Schroeder >>> Sent: Saturday, December 23, 2017 8:35 AM >>> To: vtk-developers >>> Subject: Re: [vtk-developers] Discrete contouring classes >>> >>> >>> >>> FYI here is an example of discrete marching cubes at work. From Bill: >>> >>> >>> >>> Here is the SPLBrainAtlas; >>> https://github.com/lorensen/SPLBrainAtlas/wiki/Atlas-Summary >>> >>> The two-paned images show Discrete on left, Cube's Model (also >>> undersold) on right. STL files created using discrete followed by >>> non-manifold joint smoothing. >>> >>> >>> >>> On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder >>> wrote: >>> >>> FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the >>> vtkDiscreteMarchingCubes class. This is used to generate contours for label >>> masks (as you would find in segmentation). The key here is that the labels >>> are non-continuous (i.e., scalar field is not smooth) so the regular edge >>> interpolation of something like marching cubes doesn't work. Long story >>> short, this class interpolates on the mid-edge point between regions, and it >>> generates different regions (i.e., meshes) for each label. >>> >>> >>> >>> This class and approach is woefully underappreciated and underused. >>> >>> >>> >>> I am just adding flying edges versions (2D and 3D) of this functionality (MR >>> 3739). These are of course much faster and scalable across multiple cores. >>> They also produce slightly different results. Principally they do not merge >>> coincident points belonging to different regions (since flying edges does >>> not use a point locator) -- this is both good and bad depending on the >>> application. Also normals are generated by the flying edges algorithm, not >>> by vtkDiscreteMarchingCubes. >>> >>> >>> >>> See the docs for more info. >>> >>> >>> >>> Best, >>> >>> W >>> >>> >>> >>> -- >>> >>> William J. Schroeder, PhD >>> Kitware, Inc. - Building the World's Technical Computing Software >>> 28 Corporate Drive >>> Clifton Park, NY 12065 >>> will.schroeder at kitware.com >>> http://www.kitware.com >>> (518) 881-4902 >>> >>> >>> >>> >>> >>> -- >>> >>> William J. Schroeder, PhD >>> Kitware, Inc. - Building the World's Technical Computing Software >>> 28 Corporate Drive >>> Clifton Park, NY 12065 >>> will.schroeder at kitware.com >>> http://www.kitware.com >>> (518) 881-4902 >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://vtk.org/mailman/listinfo/vtk-developers >>> >>> >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From lasso at queensu.ca Sat Dec 23 19:31:36 2017 From: lasso at queensu.ca (Andras Lasso) Date: Sun, 24 Dec 2017 00:31:36 +0000 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: The image on the right has some texture but looks mostly flat (as if there was no shading at all). In contrast, in the left image shapes are nicely visible. Can you remove edges completely and estimate surface normals from voxel values in a small neighborhood? Andras -----Original Message----- From: Bill Lorensen [mailto:bill.lorensen at gmail.com] Sent: Saturday, December 23, 2017 7:18 PM To: Andras Lasso Cc: Will Schroeder ; vtk-developers Subject: Re: [vtk-developers] Discrete contouring classes I brightened the edges rather than darkening them. See https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels%2FScreenshot%2Fwhite_matter_of_left_cerebral_hemisphere.png&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata=JsXf9yOP6WQu7xa82bU%2FS64iwyJIGcIW9Vs1v0pg76I%3D&reserved=0 On Sat, Dec 23, 2017 at 11:53 AM, Bill Lorensen wrote: > There are no normals in the cube files I generate. I do color the > edges, so on large poly models, the dark edges may be causing the > problem. > > For example, see this lower poly count model: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.g > ithubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels%2FSc > reenshot%2Fright_putamen.png&data=02%7C01%7Classo%40queensu.ca%7C6e05c > 878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0 > %7C636496714637148564&sdata=jeeJF3UcOimQ3qesRBVqMVNd%2Bq%2F9OR4Tsr1u1Q > xKJ%2FQ%3D&reserved=0 > > On Sat, Dec 23, 2017 at 10:45 AM, Bill Lorensen wrote: >> I'll take a look to fix normals on cube models. >> >> On Sat, Dec 23, 2017 at 10:28 AM, Andras Lasso wrote: >>> Hi Will and Bill, >>> >>> >>> >>> Surface generation from binary labelmap is an important task for us >>> in 3D Slicer, to display segmentation results in 3D while it is >>> being edited in 2D, We are very interested in any potential improvements. >>> >>> >>> >>> Currently, we use discrete marching cubes and sinc smoothing, which >>> gives good results, but sometimes it can be quite slow (especially >>> the smoothing step). >>> >>> >>> >>> We tried cube models but surface normals always pointed to x/y/z >>> direction instead of actual surface normal direction, so it was very >>> hard to see 3D shapes. This flat look is visible in your examples, too: >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels%2FScreenshot%2Fwhite_matter_of_left_cerebral_hemisphere.png&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata=JsXf9yOP6WQu7xa82bU%2FS64iwyJIGcIW9Vs1v0pg76I%3D&reserved=0. >>> >>> >>> >>> We use discrete marching cubes, but as far as I remember, we did not >>> see huge differences between regular and discrete marching cubes. Is >>> there a study or examples that compares them (visual appearance, >>> accuracy, computation time, etc.)? Is there a solution that provides >>> smooth surfaces (that would not require further smoothing step to >>> remove staircase artifacts)? >>> >>> >>> >>> We also plan to evaluate how well we can visualize binary labelmaps >>> in 3D using the new multi-volume-rendering feature that is being >>> integrated into VTK now. >>> >>> >>> >>> Andras >>> >>> >>> >>> From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On >>> Behalf Of Will Schroeder >>> Sent: Saturday, December 23, 2017 8:35 AM >>> To: vtk-developers >>> Subject: Re: [vtk-developers] Discrete contouring classes >>> >>> >>> >>> FYI here is an example of discrete marching cubes at work. From Bill: >>> >>> >>> >>> Here is the SPLBrainAtlas; >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >>> hub.com%2Florensen%2FSPLBrainAtlas%2Fwiki%2FAtlas-Summary&data=02%7C >>> 01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3 >>> b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata=SflCrfK >>> aKUbhYoX2DkqCbM4a8V6UAiUNF08%2F9BYjb5Q%3D&reserved=0 >>> >>> The two-paned images show Discrete on left, Cube's Model (also >>> undersold) on right. STL files created using discrete followed by >>> non-manifold joint smoothing. >>> >>> >>> >>> On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder >>> >>> wrote: >>> >>> FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the >>> vtkDiscreteMarchingCubes class. This is used to generate contours >>> for label masks (as you would find in segmentation). The key here is >>> that the labels are non-continuous (i.e., scalar field is not >>> smooth) so the regular edge interpolation of something like marching >>> cubes doesn't work. Long story short, this class interpolates on the >>> mid-edge point between regions, and it generates different regions (i.e., meshes) for each label. >>> >>> >>> >>> This class and approach is woefully underappreciated and underused. >>> >>> >>> >>> I am just adding flying edges versions (2D and 3D) of this >>> functionality (MR 3739). These are of course much faster and scalable across multiple cores. >>> They also produce slightly different results. Principally they do >>> not merge coincident points belonging to different regions (since >>> flying edges does not use a point locator) -- this is both good and >>> bad depending on the application. Also normals are generated by the >>> flying edges algorithm, not by vtkDiscreteMarchingCubes. >>> >>> >>> >>> See the docs for more info. >>> >>> >>> >>> Best, >>> >>> W >>> >>> >>> >>> -- >>> >>> William J. Schroeder, PhD >>> Kitware, Inc. - Building the World's Technical Computing Software >>> 28 Corporate Drive >>> Clifton Park, NY 12065 >>> will.schroeder at kitware.com >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. >>> kitware.com&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a >>> 08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C6364967146 >>> 37148564&sdata=oBrbE83YzEguIiDvdkZehoJcszF%2B%2FlFD26LQEPLLJxo%3D&re >>> served=0 >>> (518) 881-4902 >>> >>> >>> >>> >>> >>> -- >>> >>> William J. Schroeder, PhD >>> Kitware, Inc. - Building the World's Technical Computing Software >>> 28 Corporate Drive >>> Clifton Park, NY 12065 >>> will.schroeder at kitware.com >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. >>> kitware.com&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a >>> 08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C6364967146 >>> 37148564&sdata=oBrbE83YzEguIiDvdkZehoJcszF%2B%2FlFD26LQEPLLJxo%3D&re >>> served=0 >>> (518) 881-4902 >>> >>> >>> _______________________________________________ >>> Powered by >>> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&d >>> ata=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5% >>> 7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdat >>> a=24cgYdCFRcpCMK6OcYpMW4rFbRmPxLI6MVABGAB6DQ8%3D&reserved=0 >>> >>> Visit other Kitware open-source projects at >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. >>> kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40qu >>> eensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4ef >>> b2838b925c%7C1%7C0%7C636496714637148564&sdata=x5%2FLmD5SSk1lfz1C2lnz >>> 7RRGxUBtqHk9B3x0zEhe%2B68%3D&reserved=0 >>> >>> Search the list archives at: >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmark >>> mail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40que >>> ensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb >>> 2838b925c%7C1%7C0%7C636496714637148564&sdata=bbfUgoGzThOELIFSbPChQLB >>> qZM%2BpeFv7i9OoSR%2BcN9I%3D&reserved=0 >>> >>> Follow this link to subscribe/unsubscribe: >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk >>> .org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40qu >>> eensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4ef >>> b2838b925c%7C1%7C0%7C636496714637148564&sdata=1DH%2F2a%2B2QMlatxhC1W >>> %2Br9ALy654zrar2tBdEzzhimVI%3D&reserved=0 >>> >>> >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Sat Dec 23 20:27:31 2017 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Sat, 23 Dec 2017 20:27:31 -0500 Subject: [vtk-developers] Discrete contouring classes In-Reply-To: References: Message-ID: It is meant to show the voxels. If you zoom the models the current representation is good. On Dec 23, 2017 7:31 PM, "Andras Lasso" wrote: > The image on the right has some texture but looks mostly flat (as if there > was no shading at all). In contrast, in the left image shapes are nicely > visible. Can you remove edges completely and estimate surface normals from > voxel values in a small neighborhood? > > Andras > > -----Original Message----- > From: Bill Lorensen [mailto:bill.lorensen at gmail.com] > Sent: Saturday, December 23, 2017 7:18 PM > To: Andras Lasso > Cc: Will Schroeder ; vtk-developers < > vtk-developers at vtk.org> > Subject: Re: [vtk-developers] Discrete contouring classes > > I brightened the edges rather than darkening them. > See > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw. > githubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels% > 2FScreenshot%2Fwhite_matter_of_left_cerebral_hemisphere. > png&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5% > 7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata= > JsXf9yOP6WQu7xa82bU%2FS64iwyJIGcIW9Vs1v0pg76I%3D&reserved=0 > > > On Sat, Dec 23, 2017 at 11:53 AM, Bill Lorensen > wrote: > > There are no normals in the cube files I generate. I do color the > > edges, so on large poly models, the dark edges may be causing the > > problem. > > > > For example, see this lower poly count model: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.g > > ithubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels%2FSc > > reenshot%2Fright_putamen.png&data=02%7C01%7Classo%40queensu.ca%7C6e05c > > 878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0 > > %7C636496714637148564&sdata=jeeJF3UcOimQ3qesRBVqMVNd%2Bq%2F9OR4Tsr1u1Q > > xKJ%2FQ%3D&reserved=0 > > > > On Sat, Dec 23, 2017 at 10:45 AM, Bill Lorensen > wrote: > >> I'll take a look to fix normals on cube models. > >> > >> On Sat, Dec 23, 2017 at 10:28 AM, Andras Lasso > wrote: > >>> Hi Will and Bill, > >>> > >>> > >>> > >>> Surface generation from binary labelmap is an important task for us > >>> in 3D Slicer, to display segmentation results in 3D while it is > >>> being edited in 2D, We are very interested in any potential > improvements. > >>> > >>> > >>> > >>> Currently, we use discrete marching cubes and sinc smoothing, which > >>> gives good results, but sometimes it can be quite slow (especially > >>> the smoothing step). > >>> > >>> > >>> > >>> We tried cube models but surface normals always pointed to x/y/z > >>> direction instead of actual surface normal direction, so it was very > >>> hard to see 3D shapes. This flat look is visible in your examples, too: > >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw. > githubusercontent.com%2Florensen%2FSPLBrainAtlas%2Fmaster%2FModels% > 2FScreenshot%2Fwhite_matter_of_left_cerebral_hemisphere. > png&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5% > 7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata= > JsXf9yOP6WQu7xa82bU%2FS64iwyJIGcIW9Vs1v0pg76I%3D&reserved=0. > >>> > >>> > >>> > >>> We use discrete marching cubes, but as far as I remember, we did not > >>> see huge differences between regular and discrete marching cubes. Is > >>> there a study or examples that compares them (visual appearance, > >>> accuracy, computation time, etc.)? Is there a solution that provides > >>> smooth surfaces (that would not require further smoothing step to > >>> remove staircase artifacts)? > >>> > >>> > >>> > >>> We also plan to evaluate how well we can visualize binary labelmaps > >>> in 3D using the new multi-volume-rendering feature that is being > >>> integrated into VTK now. > >>> > >>> > >>> > >>> Andras > >>> > >>> > >>> > >>> From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On > >>> Behalf Of Will Schroeder > >>> Sent: Saturday, December 23, 2017 8:35 AM > >>> To: vtk-developers > >>> Subject: Re: [vtk-developers] Discrete contouring classes > >>> > >>> > >>> > >>> FYI here is an example of discrete marching cubes at work. From Bill: > >>> > >>> > >>> > >>> Here is the SPLBrainAtlas; > >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > >>> hub.com%2Florensen%2FSPLBrainAtlas%2Fwiki%2FAtlas-Summary&data=02%7C > >>> 01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3 > >>> b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdata=SflCrfK > >>> aKUbhYoX2DkqCbM4a8V6UAiUNF08%2F9BYjb5Q%3D&reserved=0 > >>> > >>> The two-paned images show Discrete on left, Cube's Model (also > >>> undersold) on right. STL files created using discrete followed by > >>> non-manifold joint smoothing. > >>> > >>> > >>> > >>> On Sat, Dec 23, 2017 at 8:30 AM, Will Schroeder > >>> > >>> wrote: > >>> > >>> FYI- Back in the day (2004) Jim Miller and Bill Lorensen added the > >>> vtkDiscreteMarchingCubes class. This is used to generate contours > >>> for label masks (as you would find in segmentation). The key here is > >>> that the labels are non-continuous (i.e., scalar field is not > >>> smooth) so the regular edge interpolation of something like marching > >>> cubes doesn't work. Long story short, this class interpolates on the > >>> mid-edge point between regions, and it generates different regions > (i.e., meshes) for each label. > >>> > >>> > >>> > >>> This class and approach is woefully underappreciated and underused. > >>> > >>> > >>> > >>> I am just adding flying edges versions (2D and 3D) of this > >>> functionality (MR 3739). These are of course much faster and scalable > across multiple cores. > >>> They also produce slightly different results. Principally they do > >>> not merge coincident points belonging to different regions (since > >>> flying edges does not use a point locator) -- this is both good and > >>> bad depending on the application. Also normals are generated by the > >>> flying edges algorithm, not by vtkDiscreteMarchingCubes. > >>> > >>> > >>> > >>> See the docs for more info. > >>> > >>> > >>> > >>> Best, > >>> > >>> W > >>> > >>> > >>> > >>> -- > >>> > >>> William J. Schroeder, PhD > >>> Kitware, Inc. - Building the World's Technical Computing Software > >>> 28 Corporate Drive > >>> Clifton Park, NY 12065 > >>> will.schroeder at kitware.com > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > >>> kitware.com&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a > >>> 08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C6364967146 > >>> 37148564&sdata=oBrbE83YzEguIiDvdkZehoJcszF%2B%2FlFD26LQEPLLJxo%3D&re > >>> served=0 > >>> (518) 881-4902 > >>> > >>> > >>> > >>> > >>> > >>> -- > >>> > >>> William J. Schroeder, PhD > >>> Kitware, Inc. - Building the World's Technical Computing Software > >>> 28 Corporate Drive > >>> Clifton Park, NY 12065 > >>> will.schroeder at kitware.com > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > >>> kitware.com&data=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a > >>> 08d54a63bfb5%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C6364967146 > >>> 37148564&sdata=oBrbE83YzEguIiDvdkZehoJcszF%2B%2FlFD26LQEPLLJxo%3D&re > >>> served=0 > >>> (518) 881-4902 > >>> > >>> > >>> _______________________________________________ > >>> Powered by > >>> https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&d > >>> ata=02%7C01%7Classo%40queensu.ca%7C6e05c878eb634666e41a08d54a63bfb5% > >>> 7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636496714637148564&sdat > >>> a=24cgYdCFRcpCMK6OcYpMW4rFbRmPxLI6MVABGAB6DQ8%3D&reserved=0 > >>> > >>> Visit other Kitware open-source projects at > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > >>> kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40qu > >>> eensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4ef > >>> b2838b925c%7C1%7C0%7C636496714637148564&sdata=x5%2FLmD5SSk1lfz1C2lnz > >>> 7RRGxUBtqHk9B3x0zEhe%2B68%3D&reserved=0 > >>> > >>> Search the list archives at: > >>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmark > >>> mail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40que > >>> ensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4efb > >>> 2838b925c%7C1%7C0%7C636496714637148564&sdata=bbfUgoGzThOELIFSbPChQLB > >>> qZM%2BpeFv7i9OoSR%2BcN9I%3D&reserved=0 > >>> > >>> Follow this link to subscribe/unsubscribe: > >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvtk > >>> .org%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40qu > >>> eensu.ca%7C6e05c878eb634666e41a08d54a63bfb5%7Cd61ecb3b38b142d582c4ef > >>> b2838b925c%7C1%7C0%7C636496714637148564&sdata=1DH%2F2a%2B2QMlatxhC1W > >>> %2Br9ALy654zrar2tBdEzzhimVI%3D&reserved=0 > >>> > >>> > >> > >> > >> > >> -- > >> Unpaid intern in BillsBasement at noware dot com > > > > > > > > -- > > Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com > -------------- next part -------------- An HTML attachment was scrubbed... URL: From isaiah.norton at gmail.com Thu Dec 28 10:01:21 2017 From: isaiah.norton at gmail.com (Isaiah Norton) Date: Thu, 28 Dec 2017 10:01:21 -0500 Subject: [vtk-developers] module system / cmake changes? Message-ID: I've seen several comments recently about upcoming changes to VTK's modules and/or cmake system [1]. But I'm having trouble finding an issue/wiki/thread about these plans. Any suggestions? (or perhaps it's only a shared-intention for revamps made possible by CMake+compiler minimum-version bumps...) Thanks, Isaiah [1] - https://discourse.slicer.org/t/long-path-using-ninja/1702/10 - https://blog.kitware.com/vtk-8-1-0/ - https://gitlab.kitware.com/vtk/vtk/merge_requests/3725 -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Thu Dec 28 11:25:18 2017 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Thu, 28 Dec 2017 11:25:18 -0500 Subject: [vtk-developers] module system / cmake changes? In-Reply-To: References: Message-ID: <20171228162518.GA14715@megas.kitware.com> On Thu, Dec 28, 2017 at 10:01:21 -0500, Isaiah Norton wrote: > I've seen several comments recently about upcoming changes to VTK's modules > and/or cmake system [1]. But I'm having trouble finding an > issue/wiki/thread about these plans. > > Any suggestions? (or perhaps it's only a shared-intention for revamps made > possible by CMake+compiler minimum-version bumps...) The plans have mostly been internal discussions, sorry. The branch is currently a work-in-progress. The commit history is a mess on the current branch, but I'm working on making proper commits for it (I'm in the middle of third-party stuff right now). Basically the idea is to make VTK leverage the new features in CMake since 3.0 with target-based logic rather than the old system's variable slinging and such. The core of it is here: https://gitlab.kitware.com/ben.boeckel/vtk/blob/new-cmake-module/CMake/vtkModule.cmake A simple(ish) module: https://gitlab.kitware.com/ben.boeckel/vtk/blob/new-cmake-module/Common/DataModel/CMakeLists.txt The new module file format (it is treated as a CMake argument block; no logic allowed): https://gitlab.kitware.com/ben.boeckel/vtk/blob/new-cmake-module/Common/DataModel/vtk.module Language wrapping is also now done explicitly rather than implicitly based on global variables. This means that VTK uses the wrapping logic just as any other VTK-using library would: https://gitlab.kitware.com/ben.boeckel/vtk/blob/new-cmake-module/CMakeLists.txt#L126 Documentation needs improvement, but it will get there before merging. The plan is to extract it from the CMake files and dump it out for Doxygen to put into the official docs. Thanks, --Ben From isaiah.norton at gmail.com Fri Dec 29 21:54:04 2017 From: isaiah.norton at gmail.com (Isaiah Norton) Date: Fri, 29 Dec 2017 21:54:04 -0500 Subject: [vtk-developers] module system / cmake changes? In-Reply-To: <20171228162518.GA14715@megas.kitware.com> References: <20171228162518.GA14715@megas.kitware.com> Message-ID: Thanks for the detailed response! On Thu, Dec 28, 2017 at 11:25 AM, Ben Boeckel wrote: > On Thu, Dec 28, 2017 at 10:01:21 -0500, Isaiah Norton wrote: > > I've seen several comments recently about upcoming changes to VTK's > modules > > and/or cmake system [1]. But I'm having trouble finding an > > issue/wiki/thread about these plans. > > > > Any suggestions? (or perhaps it's only a shared-intention for revamps > made > > possible by CMake+compiler minimum-version bumps...) > > The plans have mostly been internal discussions, sorry. The branch is > currently a work-in-progress. The commit history is a mess on the > current branch, but I'm working on making proper commits for it (I'm in > the middle of third-party stuff right now). > > Basically the idea is to make VTK leverage the new features in CMake > since 3.0 with target-based logic rather than the old system's variable > slinging and such. > > The core of it is here: > > https://gitlab.kitware.com/ben.boeckel/vtk/blob/new- > cmake-module/CMake/vtkModule.cmake > > A simple(ish) module: > > https://gitlab.kitware.com/ben.boeckel/vtk/blob/new- > cmake-module/Common/DataModel/CMakeLists.txt > > The new module file format (it is treated as a CMake argument block; no > logic allowed): > > https://gitlab.kitware.com/ben.boeckel/vtk/blob/new- > cmake-module/Common/DataModel/vtk.module > > Language wrapping is also now done explicitly rather than implicitly > based on global variables. This means that VTK uses the wrapping logic > just as any other VTK-using library would: > > https://gitlab.kitware.com/ben.boeckel/vtk/blob/new- > cmake-module/CMakeLists.txt#L126 > > Documentation needs improvement, but it will get there before merging. > The plan is to extract it from the CMake files and dump it out for > Doxygen to put into the official docs. > > Thanks, > > --Ben > -------------- next part -------------- An HTML attachment was scrubbed... URL: