[vtk-developers] MR to reindent VTK's braces

Fri Sep 9 07:05:34 EDT 2016

So as long as this approach checks out alright:
https://gitlab.kitware.com/vtk/vtk/merge_requests/1932

Then I'm fine with merging both things in the next couple of days and
branching for 7.1 afterward.

My misgivings about whether these sweeping format changes belong be in a
minor release are moot because of the mtime,  VTK_OVERRIDE and
VTK_DELETE_FUNCTION changes will already be present.

Merging before the branch will certainly make patches to both 7.1 and 8.0
easier to boot.

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909

On Thu, Sep 8, 2016 at 12:10 PM, David E DeMarle <dave.demarle at kitware.com>
wrote:

> To first approximation this doesn't appear hard to do:
>
> perl Utilities/Doxygen/doc_header2doxygen.pl  --to ~/tmp $VTKSRC
> cp -r ~/tmp $VTKSRC
>
> There is probably more to it than that. I'll poke around now.
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
> On Thu, Sep 8, 2016 at 11:04 AM, David Gobbi <david.gobbi at gmail.com>
> wrote:
>
>> Is anyone working on the Doxygen changes, though?  Unless we have some
>> idea of when it's going to be done, it shouldn't be influencing decisions
>> about other merges.
>>
>> On Thu, Sep 8, 2016 at 8:49 AM, Berk Geveci <berk.geveci at kitware.com>
>> wrote:
>>
>>> I agree with Dave's (DeMarle) argument that we should do this at the
>>> same time as the Doxygen changes. It would be annoying to have two merge
>>> barriers in a manner of a few months.
>>>
>>> -berk
>>>
>>> On Thu, Sep 8, 2016 at 10:42 AM, David Cole <DLRdave at aol.com> wrote:
>>>
>>>> +1
>>>>
>>>> Automatic even. ;-)
>>>>
>>>> Daves on the VTK lists unite!
>>>>
>>>>
>>>>
>>>> On Thu, Sep 8, 2016 at 10:00 AM, David Gobbi <david.gobbi at gmail.com>
>>>> wrote:
>>>> > In general, I'd love to see VTK move to regularly-scheduled minor
>>>> releases
>>>> > with firm dates set months in advance :)
>>>> >
>>>> > On Thu, Sep 8, 2016 at 7:34 AM, Berk Geveci <berk.geveci at kitware.com>
>>>> wrote:
>>>> >>
>>>> >> One way or another it would be great to choose & announce a date for
>>>> >> merging this. That way, people with existing work will know when
>>>> potential
>>>> >> conflicts are coming.
>>>> >>
>>>> >> On Thu, Sep 8, 2016 at 9:29 AM, David E DeMarle <
>>>> dave.demarle at kitware.com>
>>>> >> wrote:
>>>> >>>
>>>> >>> I want to do a release soonish only because:
>>>> >>> * 7.0.0 is getting long in the tooth and I've not found any time to
>>>> do
>>>> >>> 7.0.1
>>>> >>> * It is helpful for ParaView releases if VTK has a recent release
>>>> to work
>>>> >>> from, and PV 5.2 is expected month or so from now.
>>>> >>>
>>>> >>> Why shouldn't we do this now?
>>>> >>> * the doxygen update will also be a disruption, so we should
>>>> combine so
>>>> >>> people only go through the pain once
>>>> >>> * my vague feelings about whether this should be in a minor release
>>>> or a
>>>> >>> major release, and we know we want a major release very soon.
>>>> >>>
>>>> >>>
>>>> >>> David E DeMarle
>>>> >>> Kitware, Inc.
>>>> >>> R&D Engineer
>>>> >>> 21 Corporate Drive
>>>> >>> Clifton Park, NY 12065-8662
>>>> >>> Phone: 518-881-4909
>>>> >>>
>>>> >>> On Thu, Sep 8, 2016 at 9:10 AM, David Cole <DLRdave at aol.com> wrote:
>>>> >>>>
>>>> >>>> It would seem better to bite the bullet and do it now unless there
>>>> is
>>>> >>>> an extremely urgent deadline for 7.1......
>>>> >>>>
>>>> >>>> D
>>>> >>>>
>>>> >>>>
>>>> >>>> On Thu, Sep 8, 2016 at 9:06 AM, Ben Boeckel <
>>>> ben.boeckel at kitware.com>
>>>> >>>> wrote:
>>>> >>>> > On Thu, Sep 08, 2016 at 09:02:09 -0400, David E DeMarle wrote:
>>>> >>>> >> How about after 7.1 final then.
>>>> >>>> >>
>>>> >>>> >> That and the reworking of doxygen will disrupt pretty much
>>>> everyone's
>>>> >>>> >> existing branches, so better to come out first as part of 8.0.
>>>> >>>> >
>>>> >>>> > No, because any branch which is meant for 7.1 then needs two
>>>> versions:
>>>> >>>> > one for master (post-cleanup) and another for 7.1 itself
>>>> >>>> > (pre-cleanup).
>>>> >>>> >
>>>> >>>> > --Ben
>>>> >>>> > _______________________________________________
>>>> >>>> > Powered by www.kitware.com
>>>> >>>> >
>>>> >>>> > Visit other Kitware open-source projects at
>>>> >>>> > http://www.kitware.com/opensource/opensource.html
>>>> >>>> >
>>>> >>>> > Search the list archives at:
>>>> >>>> > http://markmail.org/search/?q=vtk-developers
>>>> >>>> >
>>>> >>>> > Follow this link to subscribe/unsubscribe:
>>>> >>>> > http://public.kitware.com/mailman/listinfo/vtk-developers
>>>> >>>> >
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> _______________________________________________
>>>> >>> Powered by www.kitware.com
>>>> >>>
>>>> >>> Visit other Kitware open-source projects at
>>>> >>> http://www.kitware.com/opensource/opensource.html
>>>> >>>
>>>> >>> Search the list archives at: http://markmail.org/search/?q=
>>>> vtk-developers
>>>> >>>
>>>> >>> Follow this link to subscribe/unsubscribe:
>>>> >>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>> >>>
>>>> >>>
>>>> >>
>>>> >
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20160909/cbd29fe1/attachment.html>