[vtk-developers] Fwd: [VTK] Build shared libs overlapping with Verdict's flag?

[Jon Haitz Legarreta]

Hi there,
here is the MR for a possible fix to the issue:
https://gitlab.kitware.com/vtk/vtk/merge_requests/2160

JON HAITZ


---------- Forwarded message ----------
From: Jon Haitz Legarreta <jhlegarreta at vicomtech.org>
Date: 9 November 2016 at 12:24
Subject: [VTK] Build shared libs overlapping with Verdict's flag?
To: "vtk-developers at vtk.org" <vtk-developers at vtk.org>


Hi there,
I'd dare to say that there is some kind of overlap/confusion in the
BUILD_SHARED_LIBS flag used by VTK and vtkverdict in master. Please,
correct me if I'm wrong, but both the flag belonging to the whole VTK
(CMakeLists.txt:180) and that one corresponding to verdict
(ThirdParty/verdict/vtkverdict/CMakeLists.txt:18) have the same name.

In fact, the tooltip shown by CMake over BUILD_SHARED_LIBS in the general
BUILD group reads "Build Verdict with shared libraries.", which I guess
should refer to VTK instead.

On the other hand, the VTK_BUILD_SHARED_LIBS variable is set to the
BUILD_SHARED_LIBS value.

Now, if this is a bug, I'd be willing to submit a patch. The thing is that
I ignore whether Verdict being built with shared libraries should directly
inherit from VTK's BUILD_SHARED_LIBS or whether they should be two distinct
options.

Any suggestion would be highly appreciated.

Thanks,
JON HAITZ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20161114/f186caf7/attachment.html>