[vtk-developers] About the vtkDataArray::InsertTuple() method

[David Gobbi]

On Thu, Mar 24, 2016 at 8:03 AM, Sean McBride <sean at rogue-research.com>
wrote:

> On Wed, 23 Mar 2016 22:09:55 -0600, David Gobbi said:
>
> >Also related to data arrays: I'd love to see the deprecation of
> >InsertValue() and InsertTuple().  The problems with them are:
> >
> >1) They are redundant.  As far as I'm concerned, their usage can
> >always be replaced with SetTuple() or InsertNextTuple() and the
> >resulting code will become easier to read.
> >
> >2) They don't actually "insert" tuples except at the end of the
> >array, and we have InsertNextTuple() or that purpose.  Anywhere
> >else in the array, they perform a replacement operation.
> >
> >Any thoughts?  Are these methods widely used anywhere except
> >for VTK's own source tree?
>
> No opinion per se, but as to your last question: it's impossible for us to
> know, and polling this list is too small a sample size.  I just grepped our
> codebase and found 2 uses of InsertValue().
>

Yes, I prefer to get the opinions of other developers before opening it up
to everyone :)

But since you took the time to answer: for those two uses you found, was
the usage of InsertValue() easy to understand, and was it a good match for
the intent of the code?

 - David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20160324/6e9ae116/attachment.html>