[vtk-developers] Changes to the way the pipeline is updated

[Sean McBride]

I guess that obsoletes this:
<https://gitlab.kitware.com/vtk/vtk/merge_requests/1292>

Maybe you could fix that up at the same time David?

Sean


On Wed, 2 Mar 2016 13:12:44 -0700, David Gobbi said:

>Will do.
>
>On Wed, Mar 2, 2016 at 1:08 PM, Berk Geveci <berk.geveci at kitware.com> wrote:
>
>> Ugh. That's a typo (probably copy & paste error). If you look at the
>> implementation, it actually doesn't check for NULL pointer. I am swamped
>> now. Do you have a few cycles to push a fix?
>>
>> On Wed, Mar 2, 2016 at 2:12 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>>
>>> Hi Berk,
>>>
>>> One of the things that I'm not quite sure about is, why is it permitted
>>> to call algorithm->UpdateExtent() with no arguments?
>>>
>>>   int UpdateExtent(const int extents[6]=0)
>>>
>>> If I understand the code, UpdateExtent() with no args is the same as
>>> Update().  It seems dangerous to allow this, because a programmer could
>>> easily type UpdateExtent() by accident instead of UpdateWholeExtent(),
>>> especially if they have autocompletion turned on in their code editor (and
>>> especially because Update() and UpdateWholeExtent() give the same result
>>> most of the time).